Re: [blink-dev] Re: Intent to Ship: Add containerName and containerQuery, update conditionText

2023-01-24 Thread Rick Byers
Thanks Danil. Great, that means you can mark 'Firefox' as 'shipping' in chromestatus. For Safari ideally you'd link to a WebKit bug tracking this, but regardless (even if they say something positive) the signal stays

Re: [blink-dev] Re: Intent to Ship: Add containerName and containerQuery, update conditionText

2023-01-24 Thread 'Daniil Sakhapov' via blink-dev
Now I see, thanks! Firefox has updated their implementation and is up-to-date. Safari hasn't done anything yet from what I can tell. I will ping them. Long live the web platform! On Tue, Jan 24, 2023 at 7:00 PM Rick Byers wrote: > Sorry I wasn't clear. I mean that WebKit and Gecko have

Re: [blink-dev] Re: Intent to Ship: Add containerName and containerQuery, update conditionText

2023-01-24 Thread Rick Byers
Sorry I wasn't clear. I mean that WebKit and Gecko have implementations of container queries, do they already support these properties? If not, we want to ensure they're aware of the spec change and have open bugs tracking making updates to their engines to reduce the likely time period for

Re: [blink-dev] Re: Intent to Ship: Add containerName and containerQuery, update conditionText

2023-01-24 Thread 'Daniil Sakhapov' via blink-dev
Hi, Rick! Thanks! Not sure I understand what you mean. On Tue, Jan 24, 2023 at 6:21 PM Rick Byers wrote: > Looks to be a very low risk update to a brand new feature, LGTM3 > > But what do we know about the other implementations with respect to this > change? For any which haven't yet updated,

Re: [blink-dev] Re: Intent to Ship: Add containerName and containerQuery, update conditionText

2023-01-24 Thread Rick Byers
Looks to be a very low risk update to a brand new feature, LGTM3 But what do we know about the other implementations with respect to this change? For any which haven't yet updated, are there bugs tracking it? On Tue, Jan 24, 2023 at 10:27 AM Mike Taylor wrote: > LGTM2 > > On 1/24/23 9:19 AM,

Re: [blink-dev] Re: Intent to Ship: Add containerName and containerQuery, update conditionText

2023-01-24 Thread Mike Taylor
LGTM2 On 1/24/23 9:19 AM, Philip Jägenstedt wrote: LGTM1 Thanks Daniil for that httparchive analysis. The second one looking for use of the @container rule should include all cases that could matter. 56 unique matches is a very small number when it comes to httparchive compat analysis. I

Re: [blink-dev] Re: Intent to Ship: Add containerName and containerQuery, update conditionText

2023-01-24 Thread Philip Jägenstedt
LGTM1 Thanks Daniil for that httparchive analysis. The second one looking for use of the @container rule should include all cases that could matter. 56 unique matches is a very small number when it comes to httparchive compat analysis. I double checked just one of them (botaniska.se, a nice park

[blink-dev] Re: Intent to Ship: Add containerName and containerQuery, update conditionText

2023-01-24 Thread Daniil Sakhapov
And another query for @container + conditionText. There are no things that can be broken. https://docs.google.com/spreadsheets/d/1ILyBkGLud7fy4kXjlLURELhcMRAPqdEWz8X8J25SfDY/edit?usp=sharing On Mon, Jan 23, 2023 at 11:35 AM Daniil Sakhapov wrote: > Hi! > > So, I haven't found any usage on the

[blink-dev] Re: Intent to Ship: Add containerName and containerQuery, update conditionText

2023-01-23 Thread Daniil Sakhapov
Hi! So, I haven't found any usage on the websites chromestatus gave me. But looking at WebArchive results I can see that the usage is very small and the update won't change

[blink-dev] Re: Intent to Ship: Add containerName and containerQuery, update conditionText

2023-01-18 Thread Alex Russell
Hey Daniil: Thanks for filing for this change while the feature is still low-use; it'll be much more challenging to make this switch later. Something that wasn't clear from the use counters you linked was the use of the IDL properties vs. the CSS names. Given that it seems like we have