[blink-dev] Re: Intent to Ship: Standard-compliant pseudo-element argument for getComputedStyle & KeyframeEffect

2024-03-08 Thread 'Dan Clark' via blink-dev
Am I correct in understanding that Gecko already mostly matches the behavior in the spec? I see that Firefox also fails most of the WPTs at https://wpt.fyi/results/css/cssom/getComputedStyle-pseudo-with-argument.html?label=master&label=experimental&aligned, but I guess that's because they have

Re: [blink-dev] Re: Intent to Ship: Standard-compliant pseudo-element argument for getComputedStyle & KeyframeEffect

2024-03-10 Thread Noam Rosenthal
On Fri, Mar 8, 2024 at 11:56 PM 'Dan Clark' via blink-dev < blink-dev@chromium.org> wrote: > Am I correct in understanding that Gecko already mostly matches the > behavior in the spec? I see that Firefox also fails most of the WPTs at > https://wpt.fyi/results/css/cssom/getComputedStyle-pseudo-wit

Re: [blink-dev] Re: Intent to Ship: Standard-compliant pseudo-element argument for getComputedStyle & KeyframeEffect

2024-03-10 Thread Domenic Denicola
Thanks Dan for raising the compat concerns here. It seems like a mistake that the original Intent says "None" for that, and I think we need to get that section of the Chrome Status entry fleshed out before considering approvals here. What I'm hearing so far is that we think the compat risks might

Re: [blink-dev] Re: Intent to Ship: Standard-compliant pseudo-element argument for getComputedStyle & KeyframeEffect

2024-03-11 Thread Noam Rosenthal
On Mon, Mar 11, 2024 at 5:57 AM Domenic Denicola wrote: > Thanks Dan for raising the compat concerns here. It seems like a mistake > that the original Intent says "None" for that, > Good point, I updated it. > and I think we need to get that section of the Chrome Status entry fleshed > out bef

Re: [blink-dev] Re: Intent to Ship: Standard-compliant pseudo-element argument for getComputedStyle & KeyframeEffect

2024-03-11 Thread Noam Rosenthal
I've run a rough HTTP archive query on it, testing all HTTP responses last month (666 million): getComputedStyle with an argument that doesn't begin with "::" is called in 0.45% of pages, out of which 55% is ":before", 28% is after, and the vast majority of the rest are invalid pseudo-element names

Re: [blink-dev] Re: Intent to Ship: Standard-compliant pseudo-element argument for getComputedStyle & KeyframeEffect

2024-03-11 Thread Domenic Denicola
Awesome, thanks so much for the quick investigation! That indeed sounds pretty low risk to me. LGTM1. On Mon, Mar 11, 2024 at 7:36 PM Noam Rosenthal wrote: > I've run a rough HTTP archive query on it, testing all HTTP responses last > month (666 million): > getComputedStyle with an argument that

Re: [blink-dev] Re: Intent to Ship: Standard-compliant pseudo-element argument for getComputedStyle & KeyframeEffect

2024-03-13 Thread Yoav Weiss (@Shopify)
On Monday, March 11, 2024 at 6:36:07 AM UTC-4 Noam Rosenthal wrote: I've run a rough HTTP archive query on it, testing all HTTP responses last month (666 million): getComputedStyle with an argument that doesn't begin with "::" is called in 0.45% of pages, out of which 55% is ":before", 28% is

Re: [blink-dev] Re: Intent to Ship: Standard-compliant pseudo-element argument for getComputedStyle & KeyframeEffect

2024-03-13 Thread Noam Rosenthal
On Wed, Mar 13, 2024 at 12:36 PM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > > > On Monday, March 11, 2024 at 6:36:07 AM UTC-4 Noam Rosenthal wrote: > > I've run a rough HTTP archive query on it, testing all HTTP responses last > month (666 million): > getComputedStyle with an argumen

Re: [blink-dev] Re: Intent to Ship: Standard-compliant pseudo-element argument for getComputedStyle & KeyframeEffect

2024-03-13 Thread Yoav Weiss (@Shopify)
LGTM2 On Wed, Mar 13, 2024 at 10:59 AM Noam Rosenthal wrote: > > > On Wed, Mar 13, 2024 at 12:36 PM Yoav Weiss (@Shopify) < > yoavwe...@chromium.org> wrote: > >> >> >> On Monday, March 11, 2024 at 6:36:07 AM UTC-4 Noam Rosenthal wrote: >> >> I've run a rough HTTP archive query on it, testing all

Re: [blink-dev] Re: Intent to Ship: Standard-compliant pseudo-element argument for getComputedStyle & KeyframeEffect

2024-03-13 Thread Daniel Bratell
LGTM3 /Daniel On 2024-03-13 16:19, Yoav Weiss (@Shopify) wrote: LGTM2 On Wed, Mar 13, 2024 at 10:59 AM Noam Rosenthal wrote: On Wed, Mar 13, 2024 at 12:36 PM Yoav Weiss (@Shopify) wrote: On Monday, March 11, 2024 at 6:36:07 AM UTC-4 Noam Rosenthal wrote: