[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650490#comment-13650490
]
Hudson commented on BOOKKEEPER-564:
---
Integrated in bookkeeper-trunk #195 (See
[http
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649075#comment-13649075
]
Hadoop QA commented on BOOKKEEPER-564:
--
Testing JIRA BOOKKEEPER-564
Patch
[000
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13648588#comment-13648588
]
Rakesh R commented on BOOKKEEPER-564:
-
+1 ready to go in. pls trigger build...
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13648261#comment-13648261
]
Ivan Kelly commented on BOOKKEEPER-564:
---
when a FileInfo is created fc is null.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13648194#comment-13648194
]
Rakesh R commented on BOOKKEEPER-564:
-
[~ikelly] good catch. As per the logic, mov
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647566#comment-13647566
]
Rakesh R commented on BOOKKEEPER-564:
-
Thanks [~iv...@yahoo-inc.com] and [~hustlms
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647386#comment-13647386
]
Hadoop QA commented on BOOKKEEPER-564:
--
Testing JIRA BOOKKEEPER-564
Patch
[000
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646729#comment-13646729
]
Rakesh R commented on BOOKKEEPER-564:
-
{code}
public static final Checkpoint MIN
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645493#comment-13645493
]
Hadoop QA commented on BOOKKEEPER-564:
--
Testing JIRA BOOKKEEPER-564
Patch
[000
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645463#comment-13645463
]
Ivan Kelly commented on BOOKKEEPER-564:
---
[~rakeshr] new patch addresses some of
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645249#comment-13645249
]
Sijie Guo commented on BOOKKEEPER-564:
--
+1 for the patch.
> Bett
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645193#comment-13645193
]
Rakesh R commented on BOOKKEEPER-564:
-
Thanks [~iv...@yahoo-inc.com], [~hustlmsp]
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644609#comment-13644609
]
Hadoop QA commented on BOOKKEEPER-564:
--
Testing JIRA BOOKKEEPER-564
Patch
[000
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644575#comment-13644575
]
Hadoop QA commented on BOOKKEEPER-564:
--
Testing JIRA BOOKKEEPER-564
Patch
[000
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644080#comment-13644080
]
Sijie Guo commented on BOOKKEEPER-564:
--
{quote}
This can be achieved by breaking
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644077#comment-13644077
]
Sijie Guo commented on BOOKKEEPER-564:
--
{code}
This patch doesn't explicitly do t
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642961#comment-13642961
]
Ivan Kelly commented on BOOKKEEPER-564:
---
{quote}
a new patch to remove circular
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642518#comment-13642518
]
Hadoop QA commented on BOOKKEEPER-564:
--
Testing JIRA BOOKKEEPER-564
Patch
[BOO
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642477#comment-13642477
]
Sijie Guo commented on BOOKKEEPER-564:
--
{quote}
This should be better. The journa
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642467#comment-13642467
]
Sijie Guo commented on BOOKKEEPER-564:
--
{quote}
Journal implements CheckpointLis
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641837#comment-13641837
]
Rakesh R commented on BOOKKEEPER-564:
-
I feel its good idea and +1 for this approa
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641784#comment-13641784
]
Ivan Kelly commented on BOOKKEEPER-564:
---
{quote}
InterLeavedStorage implements E
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641414#comment-13641414
]
Rakesh R commented on BOOKKEEPER-564:
-
[~iv...@yahoo-inc.com], thanks for pointing
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640224#comment-13640224
]
Ivan Kelly commented on BOOKKEEPER-564:
---
I was thinking about this some more las
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638896#comment-13638896
]
Ivan Kelly commented on BOOKKEEPER-564:
---
{quote}
In this case, when a new Ledger
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638789#comment-13638789
]
Sijie Guo commented on BOOKKEEPER-564:
--
[~ikelly]
I already commented on your p
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638775#comment-13638775
]
Rakesh R commented on BOOKKEEPER-564:
-
Thanks Ivan and Sijie for the great effort
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637845#comment-13637845
]
Ivan Kelly commented on BOOKKEEPER-564:
---
{quote}
if you could do the optimizatio
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637332#comment-13637332
]
Sijie Guo commented on BOOKKEEPER-564:
--
{quote}
My point was that there's nothing
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637149#comment-13637149
]
Ivan Kelly commented on BOOKKEEPER-564:
---
{quote}
I don't see how we need to reim
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637079#comment-13637079
]
Sijie Guo commented on BOOKKEEPER-564:
--
{quote}
We're going to be introducing a n
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636202#comment-13636202
]
Ivan Kelly commented on BOOKKEEPER-564:
---
Also, the fact that SyncThread needs to
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636201#comment-13636201
]
Ivan Kelly commented on BOOKKEEPER-564:
---
{quote}
bq. We don't. We always constru
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636063#comment-13636063
]
Sijie Guo commented on BOOKKEEPER-564:
--
one more point that using the CheckPointe
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635940#comment-13635940
]
Sijie Guo commented on BOOKKEEPER-564:
--
{quote}
We don't. We always construct a f
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634026#comment-13634026
]
Ivan Kelly commented on BOOKKEEPER-564:
---
{quote}
How it worked in previous flow
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633678#comment-13633678
]
Sijie Guo commented on BOOKKEEPER-564:
--
{quote}
This is control coupling. It make
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628777#comment-13628777
]
Ivan Kelly commented on BOOKKEEPER-564:
---
{quote}
1) SyncThread ask ledger storag
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628499#comment-13628499
]
Sijie Guo commented on BOOKKEEPER-564:
--
I don't see how coupling as you said. a c
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628195#comment-13628195
]
Ivan Kelly commented on BOOKKEEPER-564:
---
But actually, to clarify because I thin
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628141#comment-13628141
]
Ivan Kelly commented on BOOKKEEPER-564:
---
{quote}the integration is easy due to s
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628016#comment-13628016
]
Sijie Guo commented on BOOKKEEPER-564:
--
the integration is easy due to skiplist e
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627716#comment-13627716
]
Ivan Kelly commented on BOOKKEEPER-564:
---
If you're concerned that not having che
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627577#comment-13627577
]
Ivan Kelly commented on BOOKKEEPER-564:
---
{quote}
you didn't answer the question
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627138#comment-13627138
]
Sijie Guo commented on BOOKKEEPER-564:
--
you didn't answer the question for skipli
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627016#comment-13627016
]
Ivan Kelly commented on BOOKKEEPER-564:
---
The bridge between journal and ledger s
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626971#comment-13626971
]
Sijie Guo commented on BOOKKEEPER-564:
--
I don't like putting SyncThread in ledger
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626830#comment-13626830
]
Hadoop QA commented on BOOKKEEPER-564:
--
Testing JIRA BOOKKEEPER-564
Patch
[000
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626822#comment-13626822
]
Sijie Guo commented on BOOKKEEPER-564:
--
{quote}
The more I look at it, the less I
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626708#comment-13626708
]
Hadoop QA commented on BOOKKEEPER-564:
--
Testing JIRA BOOKKEEPER-564
Patch
[000
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626410#comment-13626410
]
Ivan Kelly commented on BOOKKEEPER-564:
---
The more I look at it, the less I like
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626364#comment-13626364
]
Hadoop QA commented on BOOKKEEPER-564:
--
Testing JIRA BOOKKEEPER-564
Patch
[BOO
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626331#comment-13626331
]
Sijie Guo commented on BOOKKEEPER-564:
--
{quote}
So we should give the ledger stor
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626287#comment-13626287
]
Sijie Guo commented on BOOKKEEPER-564:
--
{quote}
In fact, I think you should get r
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624370#comment-13624370
]
Ivan Kelly commented on BOOKKEEPER-564:
---
{quote}
but since checkpointing is a b
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624238#comment-13624238
]
Sijie Guo commented on BOOKKEEPER-564:
--
the patch here already covered the most p
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623992#comment-13623992
]
Ivan Kelly commented on BOOKKEEPER-564:
---
With BOOKKEEPER-572 the way we checkpoi
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623832#comment-13623832
]
Sijie Guo commented on BOOKKEEPER-564:
--
the jira is to separate checkpoint with f
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623779#comment-13623779
]
Ivan Kelly commented on BOOKKEEPER-564:
---
This is just a preliminary patch btw, i
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615435#comment-13615435
]
Ivan Kelly commented on BOOKKEEPER-564:
---
The patch seems to mix a couple of chan
[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604920#comment-13604920
]
Hadoop QA commented on BOOKKEEPER-564:
--
Testing JIRA BOOKKEEPER-564
Patch
[BOO
61 matches
Mail list logo
