[bug #34490] -[NSWorkspace open*] native system integration

Update of bug #34490 (project gnustep): Item Group:None => Change Request Summary: -[NSWorkspace open*] implemented uselessly => -[NSWorkspace open*] native system integration ___

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #3, bug #34490 (project gnustep): >GWorkspace i don't think these APIs should depend on GWorkspace (i don't have it) and the idea of having to wrap any linux app in existence ... sounds not so bright. >a. not work on any system without xdg-open AFAIK all linux distributions

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #4, bug #34490 (project gnustep): new patch with experimental native code path for win32 which uses ShellExecuteW(). can't verify the win32 path, may also need an include of (file #24109) ___ Additional Item Attachment:

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #5, bug #34490 (project gnustep): the new patch may not apply cleanly since i don't have access to the linux machine ATM i just added the new lines to the old patch. i think you will be able to sort it out. ___ Reply to th

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #6, bug #34490 (project gnustep): now without memleak (file #24110) ___ Additional Item Attachment: File name: open_exp2.diff Size:1 KB ___ Reply

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #7, bug #34490 (project gnustep): attached a version that should apply cleanly, win32 codepath still untested. (file #24111) ___ Additional Item Attachment: File name: open_exp3.diff Size:1 KB __

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #8, bug #34490 (project gnustep): since this is the only patch i depend on, i'd really like to see (something like) this upstream. what would still be necessary to get this comitted? ___ Reply to this item at:

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #9, bug #34490 (project gnustep): I am willing to add a patch similar to this one. But like Richard I would prefer a solution that uses NSTask to start and external process. On Windows we could use the command "Explorer.exe /e, " followed by the file name to start the correspondi

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #10, bug #34490 (project gnustep): I wrote some code in gui for launching ghostscript using NSTask which could be borrowed for this (it handles searching through the PATH variable to find the requested executable, and handles the different PATH separators on win32 vs posix. Perha

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #11, bug #34490 (project gnustep): hmmm. i think the ShellExectureW() call is the *right* way to open a document/URL on windows, so it should work better than NSTask'ing "Explorer.exe /e" ... so porting the stuff to use NSTask would actually make it worse. (aren't there stripped

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #12, bug #34490 (project gnustep): ShellExecuteW() sounds like the right choice on win32 to me. regarding system(), I think the main problem is format string vulnerability… i.e. a malicious user sends you a file with a specially-consturcted filename and tells you to open it, and

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #13, bug #34490 (project gnustep): >regarding system(), I think the main problem is format string vulnerability well i am not sure this is a real problem, also validating the string shouldn't be hard but i've updated the patch to use NSTask btw. if the code you talked about i

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #14, bug #34490 (project gnustep): should have clarified, new patch still uses ShellExectureW() on WIN32 and NSTask/xdg-open elsewhere ___ Reply to this item at: __

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #15, bug #34490 (project gnustep): well i updated it to use NSTask, what else is needed to get it in? ;) ___ Reply to this item at: ___

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #16, bug #34490 (project gnustep): sorry the NSTask version is bugged, additionally i'd like more graceful recovery if xdg-open doesn't exist, including fallback to gnome-open and kde-open. will work on this next week. ___

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #17, bug #34490 (project gnustep): ok i have reworked the patch. * still uses NSTask on unix and native API ShellExecute on win32. * actually works now * as suggested is user configurable, the user defaults keys GSOpenFileTools and GSOpenURLTools should contain arrays of strings

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #18, bug #34490 (project gnustep): could this patch please make it into the upcoming release? i'd rather not have to depend on a patched gnustep version just because of this one issue... ___ Reply to this item at:

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #20, bug #34490 (project gnustep): i am a bit puzzled about the resistance since any changes in my patch are only for a fallback where the current code path doesn't work at all. please keep in mind that *anything* that calls "xdg-open" is a infinite improvement over what you have

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #21, bug #34490 (project gnustep): 6 months later the patch is still not in ;-( ___ Reply to this item at: ___ Nachricht gesendet von/

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #22, bug #34490 (project gnustep): Did you implement a change which addresses Fred's concerns in his last message? If so, I would really love to get this in. One thing which has always bugged me is the idea that we need to wrap external applications in order to have them be use

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #23, bug #34490 (project gnustep): i did incorporate a lot of feedback, thats why the patch is at revision 5. i did not specifically address something in fred's last post as it didn't make sense to me at all. the patch as-is only changes behavior as a last fallback anyway, only

[bug #34490] -[NSWorkspace open*] native system integration

Update of bug #34490 (project gnustep): Status:None => Ready For Test Assigned to:None => FredKiefer Open/Closed:Open => In Test __

[bug #34490] -[NSWorkspace open*] native system integration

Follow-up Comment #25, bug #34490 (project gnustep): thanks very much for getting the patch in. to get everything perfect the talked-about changes to NSPerformService() still should be done, because it opens a dialogue if it doesn't succeed. __

[bug #34490] -[NSWorkspace open*] native system integration

Update of bug #34490 (project gnustep): Open/Closed: In Test => Closed ___ Reply to this item at: ___ Mes