Re: patch locale settings

2019-09-16 Thread Andreas Schwab
On Sep 14 2019, Paul Smith wrote: > On Sat, 2019-09-14 at 16:19 -0400, Dmitry Goncharov wrote: >> $ LC_MESSAGES=ru_RU ./run_make_tests -make_path ../l32/make > > I'm surprised that even works; on my system if I use a shorthand like > "de_DE" instead of the full "de_DE.UTF-8", then it isn't

Re: patch locale settings

2019-09-15 Thread Paul Smith
On Sun, 2019-09-15 at 13:01 -0400, Dmitry Goncharov wrote: > perl will tell you that it does not know what POSIX::LC_MESSAGES is. > > This patch initializes has_posix right here in test_driver.pl and pulls in > locale_h. > This patch sets LC_ALL because we saw that LANG has an affect. > This

Re: patch locale settings

2019-09-15 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
On Sun, Sep 15, 2019 at 10:14:07AM -0400, Paul Smith wrote: > I see. I wonder why it works for me. i was thinking your system couldn't do anything other than the default, but your german test demonstrates it can. > > > Let me come up with a fix for 'perl run_make_tests.pl'. if you set use

Re: patch locale settings

2019-09-15 Thread Paul Smith
On Sun, 2019-09-15 at 09:44 -0400, Dmitry Goncharov wrote: > > So, the question is why does your Perl still provide language-specific > > messages? > has_POSIX is uninitialized at the time test_driver.pl reads it, because > (atleast in my testing) the code which initializes has_POSIX hasn't run

Re: patch locale settings

2019-09-15 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
On Sun, Sep 15, 2019 at 08:31:39AM -0400, Paul Smith wrote: > That's because before we try to detect these messages we explicitly set > the locale in Perl; see test_driver.pl: > > my $loc = undef; > if ($has_POSIX) { > $loc = POSIX::setlocale(POSIX::LC_MESSAGES); >

Re: patch locale settings

2019-09-15 Thread Paul Smith
On Sat, 2019-09-14 at 22:31 -0400, Dmitry Goncharov wrote: > On Sat, Sep 14, 2019 at 6:27 PM Paul Smith wrote: > > Your setting of LANG or LC_MESSAGES > > cannot make any difference to the test suite because the test suite > > does not pass those values to the make that it invokes. > > Paul,

Re: patch locale settings

2019-09-14 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
On Sat, Sep 14, 2019 at 6:27 PM Paul Smith wrote: > Your setting of LANG or LC_MESSAGES > cannot make any difference to the test suite because the test suite > does not pass those values to the make that it invokes. Paul, that's the output from the perl program (called base) that is affected by

Re: patch locale settings

2019-09-14 Thread Paul Smith
On Sat, 2019-09-14 at 18:27 -0400, Paul Smith wrote: Can you apply the attached patch Oops ignore/delete the diff of m4/.gitignore :( ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make

Re: patch locale settings

2019-09-14 Thread Paul Smith
On Sat, 2019-09-14 at 16:19 -0400, Dmitry Goncharov wrote: > On Sat, Sep 14, 2019 at 10:22 AM Paul Smith wrote: > > and, I've checked with a makefile invoked by the test suite and > > this setting is in effect, even if the shell invoking > > run_make_tests.pl has a different setting for LC_ALL. >

Re: patch locale settings

2019-09-14 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
On Sat, Sep 14, 2019 at 10:22 AM Paul Smith wrote: > and, I've checked with a makefile invoked by the test suite and this > setting is in effect, even if the shell invoking run_make_tests.pl has > a different setting for LC_ALL. This should be sufficient. > Furthermore, we clear out the

Re: patch locale settings

2019-09-14 Thread Paul Smith
On Fri, 2019-09-13 at 21:43 -0400, Dmitry Goncharov via Bug reports and discussion for GNU make wrote: > Multiple tests fail when locale related env variables (such as LANG or > LC_MESSAGES) are set to some regional setting. This should not be necessary because we already do this, in

patch locale settings

2019-09-13 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
Multiple tests fail when locale related env variables (such as LANG or LC_MESSAGES) are set to some regional setting. regards, Dmitry diff --git a/tests/run_make_tests b/tests/run_make_tests index b68b784..7b3719e 100755 --- a/tests/run_make_tests +++ b/tests/run_make_tests @@ -1,2 +1,3 @@