[bug #48643] Irrelevant targets can confuse make on which pattern rule to select.

2022-01-19 Thread Dmitry Goncharov
Follow-up Comment #31, bug #48643 (project make): Paul, in update 27 i added 2 patches. sv48643_exp_preqreq_is_not_interm.diff has a fix for example 6. sv48643_exp_preqreq_is_not_interm_tests.diff has related tests. Not sure, if you decided not to apply these 2 patches or they fell through the cr

[bug #48643] Irrelevant targets can confuse make on which pattern rule to select.

2022-01-20 Thread Dmitry Goncharov
Follow-up Comment #33, bug #48643 (project make): This fix turned out to be difficult. i'll be surprised if we don't miss anything. i wanted to bring to your attention a couple of leftovers. One is that pat->is_explicit that is described in update 31. For the other let's consider example 8. +++

[bug #48643] Irrelevant targets can confuse make on which pattern rule to select.

2022-01-20 Thread Dmitry Goncharov
Follow-up Comment #35, bug #48643 (project make): > Do you mean that if I apply the test patch mentioned there, some of those tests would fail? All tests should pass. in the case of example 6 make fails to set pat->is_explicit for 'hello.x'. This used to fail example 6 until commit 6682fb. My con

Re: $(info xxx) output interleaved with other $(info) output

2022-01-20 Thread Dmitry Goncharov
On Thu, Jan 20, 2022 at 5:41 PM Paul Eggert wrote: > I suggested working around the problem in the GNU Emacs Makefiles by > installing the attached patch. It's a bit of a hack but I couldn't think > of anything better, other than outputting the information with the shell > rather than with $(info)

[bug #48643] Irrelevant targets can confuse make on which pattern rule to select.

2022-01-27 Thread Dmitry Goncharov
Follow-up Comment #37, bug #48643 (project make): > The first one is that the output appears even if make ultimately decides that there is no way to build the target. i think, this is good. Hopefully, this will prevent users from writing makefiles that depend on compat search. > When I put my e

[bug #61955] Remade Makefiles & Phony Targets

2022-01-28 Thread Dmitry Goncharov
Follow-up Comment #2, bug #61955 (project make): > I see that this is not documented in the manual so that should be fixed; > I will convert this into a documentation bug. Đ•here is https://savannah.gnu.org/bugs/?61623 with a patch that documents phony makefile targets. _

[bug #61957] Document the side effect of mentioning a file explicitly.

2022-01-28 Thread Dmitry Goncharov
URL: Summary: Document the side effect of mentioning a file explicitly. Project: make Submitted by: dgoncharov Submitted on: Sat 29 Jan 2022 01:32:57 AM UTC Severity: 3 - Normal

[bug #61957] Document the side effect of mentioning a file explicitly.

2022-01-28 Thread Dmitry Goncharov
Additional Item Attachment, bug #61957 (project make): File name: sv61957_side_effect_doc.diff Size:1 KB ___ Reply to this item at:

Re: Bug in $(shell ...) I can't understand

2022-02-06 Thread Dmitry Goncharov
On Sun, Feb 6, 2022 at 3:28 PM Paul Smith wrote: > Oh. I see the problem. If the shell exits with an exit code of 127 > then make's shell function assumes that it failed because the sub- > process was not found, and it actually writes its output to stderr!! This behavior is correct, is not it?

[bug #62088] Avoid re-exec due to stdin

2022-02-20 Thread Dmitry Goncharov
URL: Summary: Avoid re-exec due to stdin Project: make Submitted by: dgoncharov Submitted on: Sun 20 Feb 2022 01:26:47 PM UTC Severity: 3 - Normal Item Group: Bug

[bug #62088] Avoid re-exec due to stdin

2022-02-20 Thread Dmitry Goncharov
Additional Item Attachment, bug #62088 (project make): File name: sv62088_fix.diff Size:0 KB ___ Reply to this item at:

Re: make re-exec regression in 'make -sf -' mode

2022-02-20 Thread Dmitry Goncharov
On Sat, Feb 19, 2022 at 4:12 AM Sergei Trofimovich wrote: > Noticed the regression on lowdown-0.10.0 upstream package. ... > Bitsect points at commit 7c4e6b0299 "[SV 60595] Restart > whenever any makefile is rebuilt". Thanks for your report. I opened https://savannah.gnu.org/bugs/index.php?62088

[bug #62088] Avoid re-exec due to stdin

2022-02-20 Thread Dmitry Goncharov
Follow-up Comment #1, bug #62088 (project make): Indeed, the fix for SV 60595 introduced an undesired change, specifically, causes make to re-execute when make code is read from the standard input. This is not related to lowdown. No need for any package or makefile to reproduce. In fact, the follo

[bug #62118] Fix parsing of command line options -f, --file, --makefile.

2022-02-26 Thread Dmitry Goncharov
URL: Summary: Fix parsing of command line options -f, --file, --makefile. Project: make Submitted by: dgoncharov Submitted on: Sat 26 Feb 2022 04:52:59 PM UTC Severity: 3 - Normal

[bug #62118] Fix parsing of command line options -f, --file, --makefile.

2022-02-26 Thread Dmitry Goncharov
Additional Item Attachment, bug #62118 (project make): File name: sv62118_test.diff Size:4 KB File name: sv62118_fix.diff Size:4 KB

[bug #62145] Unlink the stdin temporary file on failure to re-execute.

2022-03-06 Thread Dmitry Goncharov
URL: Summary: Unlink the stdin temporary file on failure to re-execute. Project: make Submitted by: dgoncharov Submitted on: Sun 06 Mar 2022 07:36:16 PM UTC Severity: 3 - Normal

[bug #62145] Unlink the stdin temporary file on failure to re-execute.

2022-03-06 Thread Dmitry Goncharov
Additional Item Attachment, bug #62145 (project make): File name: sv62145_test.diff Size:4 KB File name: sv62145_fix.diff Size:2 KB

Re: [bug #62118] Fix parsing of command line options -f, --file, --makefile.

2022-03-06 Thread Dmitry Goncharov
On Sun, Feb 27, 2022 at 6:11 PM Paul D. Smith wrote: > > Update of bug #62118 (project make): ... > When looking at the test results I noticed that we were leaving the temporary > files behind if we had to re-exec, because the re-exec'd version of make > didn't realize they were temporary. > > I d

[bug #62162] patsubst not working in prerequisites under .SECONDEXPANSION

2022-03-10 Thread Dmitry Goncharov
Follow-up Comment #2, bug #62162 (project make): You can store % in a variable percent:=% $(files) : %.ext : $$(patsubst r$(percent),$(percent),$$(lastword $$(subst .stem., ,$$*)))-prereq ___ Reply to this item at:

[bug #62162] patsubst not working in prerequisites under .SECONDEXPANSION

2022-03-10 Thread Dmitry Goncharov
Follow-up Comment #3, bug #62162 (project make): A typo, ofcourse should be $$(percent) percent:=% $(files) : %.ext : $$(patsubst r$$(percent),$$(percent),$$(lastword $$(subst .stem., ,$$*)))-prereq ___ Reply to this item at:

[bug #62171] ARFLAGS violate posix on aix.

2022-03-12 Thread Dmitry Goncharov
URL: Summary: ARFLAGS violate posix on aix. Project: make Submitted by: dgoncharov Submitted on: Sat 12 Mar 2022 11:03:51 PM UTC Severity: 3 - Normal Item Group: Bug

[bug #62171] ARFLAGS violate posix on aix.

2022-03-12 Thread Dmitry Goncharov
Additional Item Attachment, bug #62171 (project make): File name: arflags_violate_posix_on_aix_fix.diff Size:0 KB ___ Reply to this item at: <

[bug #62172] Haver options/dash-l test exit greacefully, when getloadavg is not available

2022-03-12 Thread Dmitry Goncharov
URL: Summary: Haver options/dash-l test exit greacefully, when getloadavg is not available Project: make Submitted by: dgoncharov Submitted on: Sat 12 Mar 2022 11:07:05 PM UTC Severit

[bug #62172] Haver options/dash-l test exit greacefully, when getloadavg is not available

2022-03-12 Thread Dmitry Goncharov
Additional Item Attachment, bug #62172 (project make): File name: exit_grecefully_when_load_not_supported_fix.diff Size:0 KB ___ Reply

[bug #62173] Fix test features/archives.

2022-03-12 Thread Dmitry Goncharov
URL: Summary: Fix test features/archives. Project: make Submitted by: dgoncharov Submitted on: Sat 12 Mar 2022 11:11:39 PM UTC Severity: 3 - Normal Item Group: Bug

[bug #62173] Fix test features/archives.

2022-03-12 Thread Dmitry Goncharov
Additional Item Attachment, bug #62173 (project make): File name: test_features_archive_fix.diff Size:0 KB ___ Reply to this item at:

[bug #62174] fix test functions/shell on aix.

2022-03-12 Thread Dmitry Goncharov
URL: Summary: fix test functions/shell on aix. Project: make Submitted by: dgoncharov Submitted on: Sat 12 Mar 2022 11:14:40 PM UTC Severity: 3 - Normal Item Group: Bug

[bug #62174] fix test functions/shell on aix.

2022-03-12 Thread Dmitry Goncharov
Additional Item Attachment, bug #62174 (project make): File name: test_functions_shell_fix_on_aix.diff Size:0 KB ___ Reply to this item at:

[bug #62175] Port tests to big endian.

2022-03-12 Thread Dmitry Goncharov
URL: Summary: Port tests to big endian. Project: make Submitted by: dgoncharov Submitted on: Sat 12 Mar 2022 11:21:32 PM UTC Severity: 3 - Normal Item Group: Bug

[bug #62175] Port tests to big endian.

2022-03-12 Thread Dmitry Goncharov
Additional Item Attachment, bug #62175 (project make): File name: port_tests_to_big_endian.diff Size:5 KB ___ Reply to this item at:

[bug #62173] Fix test features/archives.

2022-03-13 Thread Dmitry Goncharov
Follow-up Comment #2, bug #62173 (project make): The patch contains the following changes -my $arflags = 'rv'; +my $arflags = '-rv'; +if ($^O eq 'aix') { +$arflags = "-Xany -rv"; +} That reason for the first part of the patch, specifically -my $arflags = 'rv'; +my $arflags = '-

[bug #62206] Fix % substitution in pattern rules.

2022-03-20 Thread Dmitry Goncharov
URL: Summary: Fix % substitution in pattern rules. Project: make Submitted by: dgoncharov Submitted on: Mon 21 Mar 2022 01:04:05 AM UTC Severity: 3 - Normal Item Group:

[bug #62206] Fix % substitution in pattern rules.

2022-03-20 Thread Dmitry Goncharov
Additional Item Attachment, bug #62206 (project make): File name: sv62206_stem_substitution_in_pattern_rules_fix.diff Size:6 KB File name: sv62206_stem_substitution_in_pattern_rules_test.dif

[bug #62206] Fix % substitution in pattern rules.

2022-03-20 Thread Dmitry Goncharov
Follow-up Comment #1, bug #62206 (project make): Tested on linux, sun and aix, 64 and 32 bits. ___ Reply to this item at: ___ Message sent via Savanna

[bug #62206] Fix % substitution in pattern rules.

2022-03-21 Thread Dmitry Goncharov
Follow-up Comment #3, bug #62206 (project make): > What I usually do is recommend people use $$* instead of % in secondary expansion expressions like this as it's more clear and less confusing, and ends up being the same result. There are situations where the difference between % and $$* matters.

[bug #62206] Fix % substitution in pattern rules.

2022-03-21 Thread Dmitry Goncharov
Follow-up Comment #4, bug #62206 (project make): Such a workaround with 2 rules could be something like .SECONDEXPANSION: all: lib/hello.o hello.o %.o: 3$$*.c; $(info $@ from $<) lib/%.o: lib/3$$*.c; $(info $@ from $<) ___ Reply

[bug #62278] Fix % substitution in static pattern rules.

2022-04-09 Thread Dmitry Goncharov
URL: Summary: Fix % substitution in static pattern rules. Project: make Submitted by: dgoncharov Submitted on: Sat 09 Apr 2022 03:30:51 PM UTC Severity: 3 - Normal Item

[bug #62278] Fix % substitution in static pattern rules.

2022-04-09 Thread Dmitry Goncharov
Additional Item Attachment, bug #62278 (project make): File name: sv62278_test.diff Size:5 KB File name: sv62278_fix.diff Size:2 KB

[bug #62278] Fix % substitution in static pattern rules.

2022-04-09 Thread Dmitry Goncharov
Follow-up Comment #1, bug #62278 (project make): Tested on 64 and 32 bit linux. ___ Reply to this item at: ___ Message sent via Savannah https://sav

[bug #62324] Fix cache integrity check

2022-04-16 Thread Dmitry Goncharov
URL: Summary: Fix cache integrity check Project: make Submitted by: dgoncharov Submitted on: Sat 16 Apr 2022 05:59:23 PM UTC Severity: 3 - Normal Item Group: Bug

[bug #62324] Fix cache integrity check

2022-04-16 Thread Dmitry Goncharov
Additional Item Attachment, bug #62324 (project make): File name: sv62324_test.diff Size:2 KB File name: sv62324_fix.diff Size:4 KB

[bug #62356] Setting -R through MAKEFLAGS should set -r.

2022-04-23 Thread Dmitry Goncharov
URL: Summary: Setting -R through MAKEFLAGS should set -r. Project: make Submitted by: dgoncharov Submitted on: Sat 23 Apr 2022 02:11:17 PM UTC Severity: 3 - Normal Item

[bug #62356] Setting -R through MAKEFLAGS should set -r.

2022-04-23 Thread Dmitry Goncharov
Additional Item Attachment, bug #62356 (project make): File name: sv62356_test.diff Size:0 KB File name: sv62356_fix.diff Size:0 KB

[bug #60736] Introduce "Circular <- dependency dropped." for .EXTRA_PREREQS deps.

2022-04-23 Thread Dmitry Goncharov
Additional Item Attachment, bug #60736 (project make): File name: sv_60736_add_avoid_circular_dep_msg_tests.diff Size:2 KB ___ Reply to

[bug #60736] Introduce "Circular <- dependency dropped." for .EXTRA_PREREQS deps.

2022-04-23 Thread Dmitry Goncharov
Follow-up Comment #3, bug #60736 (project make): > For one thing it causes a number of tests to fail. Fixed. > For another thing the docs explicitly say: > Note 'make' is smart enough not to add a prerequisite listed in '.EXTRA_PREREQS' as a prerequisite to itself. Does this behavior have t

[bug #62173] Fix test features/archives.

2022-04-27 Thread Dmitry Goncharov
Additional Item Attachment, bug #62173 (project make): File name: sv62173_fix_typo.diff Size:0 KB ___ Reply to this item at:

[bug #62173] Fix test features/archives.

2022-04-27 Thread Dmitry Goncharov
Follow-up Comment #4, bug #62173 (project make): Paul, a typo was introduced, which causes multiple tests to fail. Please have a look at sv62173_fix_typo.diff. ___ Reply to this item at: _

[bug #62174] fix test functions/shell on aix.

2022-04-27 Thread Dmitry Goncharov
Additional Item Attachment, bug #62174 (project make): File name: sv62174_fix2.diff Size:0 KB ___ Reply to this item at:

[bug #62174] fix test functions/shell on aix.

2022-04-27 Thread Dmitry Goncharov
Follow-up Comment #2, bug #62174 (project make): Paul, the changes that were introduced in toplevel to set LANG=C do not have desired effect, because run_make_tests.pl sets $ERR_command_not_found before &toplevel is called. Since you didn't like removing LANG from environment, i attached another

Re: [bug #62173] Fix test features/archives.

2022-04-27 Thread Dmitry Goncharov
On Sun, Apr 24, 2022 at 2:48 PM Jeffrey Walton wrote: > Be sure to test the change on OpenBSD. In the past OpenBSD needed the > dash for options. I'm not sure if it is needed nowadays. The change that was mentioned added the dash. The current default ARFLAGS=-rv, which is also required by posix.

[bug #62397] jobserver unavailable from $(shell $(MAKE)...)

2022-05-03 Thread Dmitry Goncharov
Follow-up Comment #3, bug #62397 (project make): For explanation of the warning see https://lists.gnu.org/archive/html/bug-make/2021-02/msg5.html. MAKEFLAGS= removes all flags. i'd rather use something like filter-out (or some other tool) to remove just the jobserver related flags.

Re: Archive Members as Targets

2022-05-10 Thread Dmitry Goncharov
On Tue, May 10, 2022 at 5:12 PM Michael Lehn wrote: > But not on the Linux boxes there make always rebuild everything. On all > machines I am using GNU Make. ... > Can anyone confirm that? i can confirm that for me on linux the latest make from git as well as make-4.3 correctly detect that libfo

[bug #62469] Make honors MAKEFLAGS= definition on the command line.

2022-05-16 Thread Dmitry Goncharov
URL: Summary: Make honors MAKEFLAGS= definition on the command line. Project: make Submitted by: dgoncharov Submitted on: Mon 16 May 2022 02:12:20 AM UTC Severity: 3 - Normal

[bug #62469] Make honors MAKEFLAGS= definition on the command line.

2022-05-16 Thread Dmitry Goncharov
Additional Item Attachment, bug #62469 (project make): File name: sv62469_doc.diff Size:1 KB File name: sv62469_test.diff Size:2 KB

Re: Potential Bug: `.PHONY` targets and order-only prerequisites

2022-05-18 Thread Dmitry Goncharov
On Wed, May 18, 2022 at 5:37 PM Jacob Kopczynski wrote: >> - it might make sense to state explicitly that order-only prereqs >> which are phony behave in all ways like standard prerequisites. This statement is simply incorrect. Order-only prerequisites which are phony do not behave like reg

[bug #62496] Fix "7.3 Conditionals that Test Flags" in the manual,

2022-05-20 Thread Dmitry Goncharov
Triage Status: None ___ Follow-up Comments: --- Date: Sat 21 May 2022 01:21:51 AM UTC By: Dmitry Goncharov In paragraph "7.3 Conditionals that Test Flags" the man

[bug #62496] Fix "7.3 Conditionals that Test Flags" in the manual,

2022-05-20 Thread Dmitry Goncharov
Additional Item Attachment, bug #62496 (project make): File name: sv62496_doc.diff Size:1 KB ___ Reply to this item at:

[bug #62496] Fix "7.3 Conditionals that Test Flags" in the manual,

2022-05-20 Thread Dmitry Goncharov
Additional Item Attachment, bug #62496 (project make): File name: sv62496_test.diff Size:1 KB ___ Reply to this item at:

Re: Potential Bug: `.PHONY` targets and order-only prerequisites

2022-05-21 Thread Dmitry Goncharov
On Sat, May 21, 2022 at 12:25 PM Paul Smith wrote: > Maybe what you're saying is that make should throw an error or warning > if you try to add an order-only prerequisite to a phony target, telling > you that it will have no effect on your makefile? Having a phony target depend (usually indirectl

[bug #62514] Regression. make ignores cli flags.

2022-05-23 Thread Dmitry Goncharov
: None ___ Follow-up Comments: --- Date: Tue 24 May 2022 12:16:45 AM UTC By: Dmitry Goncharov Commit f2771aa614d3a826b70973217c33f605fb4cd0c2 introduced function reset_switches. reset_switches wipes out c

[bug #62514] Regression. make ignores cli flags.

2022-05-23 Thread Dmitry Goncharov
Additional Item Attachment, bug #62514 (project make): File name: sv62514_fix.diff Size:4 KB File name: sv62514_test.diff Size:3 KB

[bug #62469] Make honors MAKEFLAGS= definition on the command line.

2022-05-25 Thread Dmitry Goncharov
Follow-up Comment #2, bug #62469 (project make): > I'm confident a lot of makefiles do do this, and although it's not a good idea I don't know that we want to break them. i agree, that we don't want to break existing makefiles. i also think, that a build system which relies on a MAKEFLAGS= cli de

[bug #62615] Fix the leaks of file->cmds and file->cmds->commands

2022-06-11 Thread Dmitry Goncharov
ge Status: None ___ Follow-up Comments: --- Date: Sat 11 Jun 2022 01:52:52 PM UTC By: Dmitry Goncharov Makefile like the following causes make to leak file->cmds along with file->cmd

[bug #62615] Fix the leaks of file->cmds and file->cmds->commands

2022-06-11 Thread Dmitry Goncharov
Additional Item Attachment, bug #62615 (project make): File name: sv62615_fix.diff Size:1 KB File name: sv62615_test.diff Size:1 KB

[bug #62615] Fix the leaks of file->cmds and file->cmds->commands

2022-06-15 Thread Dmitry Goncharov
Follow-up Comment #1, bug #62615 (project make): Paul, can you please ignore this patch? This bug report is correct, there is a memory leak. But the patch is not correct. The patch fails to take into account a case when multiple targets are defined on the same rule. Correctly taking care of freein

[bug #62650] Fix an incorrect user message.

2022-06-18 Thread Dmitry Goncharov
: None ___ Follow-up Comments: --- Date: Sat 18 Jun 2022 10:13:59 PM UTC By: Dmitry Goncharov Make reports an incorrect message when a file found through directory search is preferred over the explicitly men

[bug #62650] Fix an incorrect user message.

2022-06-18 Thread Dmitry Goncharov
Additional Item Attachment, bug #62650 (project make): File name: sv62650_fix.diff Size:1 KB File name: sv62650_test.diff Size:2 KB

Re: Goodbye to GNU make's "build.sh" ... ?

2022-06-26 Thread Dmitry Goncharov
On Sun, Jun 26, 2022 at 10:11 AM Paul Smith wrote: > This really came up because I was trying to find a way to include the > latest gnulib globbing library. Adding "glob" to this pulls in a HUGE > number of prerequisites. Have you considered to to avoid glob from gnulib? Make has its one impl of

Re: Goodbye to GNU make's "build.sh" ... ?

2022-06-26 Thread Dmitry Goncharov
On Sunday, June 26, 2022, Paul Smith wrote > > > I would prefer to have that fixed in gnulib, than continue to maintain > a local copy just to avoid this issue. Then there is no choice to drop gnulib and build.sh should go. Since you asked for opinions, my opinion is that maintaining a mini make

Re: Goodbye to GNU make's "build.sh" ... ?

2022-06-26 Thread Dmitry Goncharov
On Sun, Jun 26, 2022 at 5:48 PM Paul Smith wrote: > Seems like it's not so much that the patch was rejected; indeed they > seem to agree there's a bug. But they wanted more work on it and it > sort of fell apart. I have no idea how much effort it would be to push > hard enough to get a change me

[bug #62706] Restrict second expansion to targets which are being built.

2022-07-04 Thread Dmitry Goncharov
Triage Status: None ___ Follow-up Comments: --- Date: Mon 04 Jul 2022 11:19:17 PM UTC By: Dmitry Goncharov . ___ Reply t

[bug #62706] Restrict second expansion to targets which are being built.

2022-07-04 Thread Dmitry Goncharov
Additional Item Attachment, bug #62706 (project make): File name: sv62706_doc.diff Size:4 KB File name: sv62706_test.diff Size:14 KB

[bug #62706] Restrict second expansion to targets which are being built.

2022-07-04 Thread Dmitry Goncharov
Follow-up Comment #1, bug #62706 (project make): Second expand only the prerequisites of the targets being built. Avoid second expanding the prerequisites of targets which are not being built. There are multiple benefits. 1. Avoids redundant work of second expanding prerequisites of the targets

Re: [bug #62706] Restrict second expansion to targets which are being built.

2022-07-05 Thread Dmitry Goncharov
On Tue, Jul 5, 2022 at 5:19 AM Edward Welbourne wrote: > I would have expected the order to be the exact reverse of the > order of building: i guess, an example will make it more clear. $ cat makefile .SECONDEXPANSION: all: hello.tsk bye.tsk hello.tsk: $$(info 2nd expansion of prereqs of $$@);

Re: [bug #62706] Restrict second expansion to targets which are being built.

2022-07-05 Thread Dmitry Goncharov
On Tue, Jul 5, 2022 at 12:34 PM Edward Welbourne wrote: > was thinking of the fact that, if you'd started with > > all: $$(info 2nd expansion for all) hello.tsk bye.tsk; echo built both > > then its info would appear first, although its rule would be run last. That's correct. $$(info 2nd expansio

[bug #62706] Restrict second expansion to targets which are being built.

2022-07-05 Thread Dmitry Goncharov
Follow-up Comment #2, bug #62706 (project make): This is a more detailed description of point 2 above (2. Causes all prerequisites to be second expanded in the same order they are being built.) $ cat makefile .SECONDEXPANSION: all: hello.tsk bye.tsk hello.tsk: $$(info 2nd expansion of prereq

[bug #62734] Have the test suite set ASAN env to ignore leaks.

2022-07-09 Thread Dmitry Goncharov
Status: None ___ Follow-up Comments: --- Date: Sat 09 Jul 2022 06:57:40 PM UTC By: Dmitry Goncharov There are known memory leaks in make. When make is build with ASAN checks enabled, those

[bug #62734] Have the test suite set ASAN env to ignore leaks.

2022-07-09 Thread Dmitry Goncharov
Additional Item Attachment, bug #62734 (project make): File name: sv62734.diff Size:0 KB ___ Reply to this item at:

[bug #62706] Restrict second expansion to targets which are being built.

2022-07-09 Thread Dmitry Goncharov
Follow-up Comment #3, bug #62706 (project make): Another thought on point 2 above. Posix contains the following requirement. "The make utility shall treat all prerequisites as targets themselves and recursively ensure that they are up-to-date, processing them in the order in which they appear in

Re: Some "fun" last weekend

2022-07-19 Thread Dmitry Goncharov
On Tue, Jul 19, 2022 at 6:13 PM Paul Smith wrote: > There are at least two Savannah bugs about this very subtle and > annoying issue. Do you mean that jobserver-auth is present in the child env, even though the fds are closed? > So the first thing I tried to do was to add another setting of the

Re: Some "fun" last weekend

2022-07-20 Thread Dmitry Goncharov
On Wed, Jul 20, 2022 at 9:33 AM Paul Smith wrote: > There are so many ways this can bite people. The last thing > GNU make needs IMO is more obscure subtleties. For example if someone > writes this: > > NRMAKE = $(MAKE) > > recurse: > MAKEFLAGS=$(MAKEFLAGS) $(NRMAKE) > > it will br

Re: New feature: Post-requisites

2022-07-22 Thread Dmitry Goncharov
On Fri, Jul 22, 2022 at 9:34 AM wrote: > In your example, wouldn't the following accomplish the same thing? > > > update-mandb: $(DESTDIR)$(man3dir)/foo.3 $(DESTDIR)$(man3dir)/bar.3 i'd also be interested in the answer. Either this traditional syntax specified above, or $(DESTDIR)$(man3dir)/bar

[bug #62706] Restrict second expansion to targets which are being built.

2022-07-23 Thread Dmitry Goncharov
Additional Item Attachment, bug #62706 (project make): File name: sv62706_fix2.diff Size:5 KB File name: sv62706_test2.diff Size:15 KB

[bug #62706] Restrict second expansion to targets which are being built.

2022-07-23 Thread Dmitry Goncharov
Follow-up Comment #5, bug #62706 (project make): sv62706_fix2.diff takes care of secondary expanding a prerequisite marked as intermediate by .SECONDARY or .INTERMEDIATE when an explicit or static pattern rule builds the prerequisite. sv62706_test2.diff adds related tests. __

[bug #62881] parentheses confuse make parser

2022-08-09 Thread Dmitry Goncharov
: None ___ Follow-up Comments: --- Date: Tue 09 Aug 2022 07:02:50 PM UTC By: Dmitry Goncharov . ___ Reply to this item at:

[bug #62881] parentheses confuse make parser

2022-08-09 Thread Dmitry Goncharov
Follow-up Comment #1, bug #62881 (project make): A user reported the following here https://lists.gnu.org/archive/html/bug-make/2022-08/msg00017.html in GNU-make macros. Like in: msg = @echo "$(1)" ptest_1: $(call msg, foo (arg1, arg2, arg3)) ... A 'ma

Re: Macro arguments

2022-08-09 Thread Dmitry Goncharov
On Tue, Aug 9, 2022 at 10:48 AM Gisle Vanem wrote: Thanks for your report. See here https://savannah.gnu.org/bugs/index.php?62881 regards, Dmitry

[bug #62881] parentheses confuse make parser

2022-08-09 Thread Dmitry Goncharov
Additional Item Attachment, bug #62881 (project make): File name: sv62881_test.diff Size:1 KB File name: sv62881_fix.diff Size:0 KB

Re: Macro arguments

2022-08-13 Thread Dmitry Goncharov
On Tue, Aug 9, 2022 at 11:56 PM Paul Smith wrote: > ...modifying the way all function arguments > are parsed is something that needs to be carefully considered, if > nothing else from a backward-compatibility standpoint. agree. i added an example to the manual of how to use variable to hide spec

Re: Some "fun" last weekend

2022-08-15 Thread Dmitry Goncharov
On Thu, Jul 21, 2022 at 10:23 AM Paul Smith wrote: > Instead, any sub-process can look at MAKEFLAGS, see the value of jobserver-auth, find the name of the pipe, open it, and start to use it. If the sub-process doesn't know anything about MAKEFLAGS, it will never know that the jobserver is relevan

[bug #62908] Regression. Double free if jobserver is enabled, but cannot open fifo.

2022-08-17 Thread Dmitry Goncharov
: None Triage Status: None ___ Follow-up Comments: --- Date: Wed 17 Aug 2022 11:45:30 PM UTC By: Dmitry Goncharov Failure to open a fifo causes make to double free fif

[bug #62908] Regression. Double free if jobserver is enabled, but cannot open fifo.

2022-08-17 Thread Dmitry Goncharov
Additional Item Attachment, bug #62908 (project make): File name: sv62908_fix.diff Size:0 KB File name: sv62908_test.diff Size:1 KB

Re: False positive "doesn't match the target pattern" error

2022-08-20 Thread Dmitry Goncharov
On Sat, Aug 20, 2022 at 5:52 AM Masahiro Yamada wrote: > I appreciate GNU Make normalize the path > by removing "./" > > This is helpful in some cases, but I think it is a bad side-effect > in this case. Is there a reason to treat './foo.x' as different from 'foo.x'? > If this is a bug, I can f

Re: False positive "doesn't match the target pattern" error

2022-08-20 Thread Dmitry Goncharov
On Sat, Aug 20, 2022 at 11:36 AM Alejandro Colomar wrote: > Why does make(1) need to special-case a leading ./ ? If your makefile has a rule like foo.x: foo.z; cp $< $@ then make foo.x and make ./foo.x both produce the same file. regards, Dmitry

[bug #62929] Normalize foo/./bar

2022-08-20 Thread Dmitry Goncharov
: None ___ Follow-up Comments: --- Date: Sun 21 Aug 2022 03:38:36 AM UTC By: Dmitry Goncharov . ___ Reply to this item at: <https://savannah.gnu

[bug #62929] Normalize foo/./bar

2022-08-20 Thread Dmitry Goncharov
Follow-up Comment #1, bug #62929 (project make): Make fails to normalize foo/./bar as foo/bar. The original bug report is here https://lists.gnu.org/archive/html/bug-make/2022-08/msg00064.html ___ Reply to this item at:

[bug #62929] Normalize foo/./bar

2022-08-20 Thread Dmitry Goncharov
Additional Item Attachment, bug #62929 (project make): File name: sv62929_fix.diff Size:3 KB File name: sv62929_test.diff Size:1 KB

Re: False positive "doesn't match the target pattern" error

2022-08-20 Thread Dmitry Goncharov
On Sat, Aug 20, 2022 at 8:28 PM Masahiro Yamada wrote: > build-dirs := . drivers sound net virt arch/x86/pci arch/x86/power lib > arch/x86/lib > subdir-modorder := $(addsuffix /.modules.order, $(build-dirs)) > $(sort $(subdir-modorder)): %/.modules.order: % Can you remove . from build-dirs and ad

[bug #62929] Normalize foo/./bar

2022-08-22 Thread Dmitry Goncharov
Follow-up Comment #2, bug #62929 (project make): i compared gmake, bmake, sun make, sun dmake, sun make in svr4 mode, aix make. Given makefile hello: @echo $@ gmake treats ./hello, ././hello, ././/hello or .//hello, as hello. $@ has value hello. sun make, sun dmake, sun svr4 make treat ./hel

[bug #62929] Normalize foo/./bar

2022-08-22 Thread Dmitry Goncharov
Follow-up Comment #3, bug #62929 (project make): pmake behaves the same as bmake. ___ Reply to this item at: ___ Message sent via Savannah https://savan

<    1   2   3   4   5   6   7   >