I have updated webrevs:
http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.top/
http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.jdk/
I've addressed the minor suggestions that have been given by Kelly and
Erik eg:
- better comment on the jarreorder change (and a CR to follow up)
-
Adding a configure parameter --with-user-release-suffix which acts as
the USER_RELEASE_SUFFIX variable used to do. If build number isn't set
or is set to b00, this gets added to the full version string, overriding
the default value username_timestamp. It's also possible to override
this
The open part of this review. Move handling of --enable-openjdk-only to
before the first custom hook call.
http://cr.openjdk.java.net/~erikj/8005850/webrev.root.01/
Five classes which in jigsaw will be located in the base module
currently have their native headers generated in a special way
(explicitly with javah). This was because the base module could not be
made dependent on the compiler module where the annotation
On 08/01/2013 14:07, Erik Joelsson wrote:
Five classes which in jigsaw will be located in the base module
currently have their native headers generated in a special way
(explicitly with javah). This was because the base module could not be
made dependent on the compiler module where the
When submitting JDK-8005723 to jdk8/build, I missed adding the
comparisons of these files to compare.sh. The implementation was already
done in build-infra.
http://cr.openjdk.java.net/~erikj/8005858/webrev.root.01/
/Erik
Hi Erik Joelsson:
Adding a configure parameter --with-user-release-suffix which acts as
the USER_RELEASE_SUFFIX variable used to do. If build number isn't set
or is set to b00, this gets added to the full version string,
overriding the default value username_timestamp. It's also
possible to
Erik:
The open part of this review. Move handling of --enable-openjdk-only
to before the first custom hook call.
http://cr.openjdk.java.net/~erikj/8005850/webrev.root.01/
Looks good.
Tim
Hi Erik:
Filter away -R flags from X_LIBS variable in configure.
http://cr.openjdk.java.net/~erikj/8005855/webrev.root.01/
common/autoconf/libraries.m4:
143 X_LIBS=`$ECHO $X_LIBS | $SED 's/-R.*//g'`
If I am reading this correctly, sed will delete everything from -R to
end of line. Is
On 01/08/13 06:17, Alan Bateman wrote:
On 08/01/2013 14:07, Erik Joelsson wrote:
Five classes which in jigsaw will be located in the base module
currently have their native headers generated in a special way
(explicitly with javah). This was because the base module could not
be made dependent
Erik:
When submitting JDK-8005723 to jdk8/build, I missed adding the
comparisons of these files to compare.sh. The implementation was
already done in build-infra.
http://cr.openjdk.java.net/~erikj/8005858/webrev.root.01/
Looks good.
Tim
Looks fine.
-kto
On Jan 8, 2013, at 3:03 AM, Erik Joelsson wrote:
Adding a configure parameter --with-user-release-suffix which acts as the
USER_RELEASE_SUFFIX variable used to do. If build number isn't set or is set
to b00, this gets added to the full version string, overriding the
I need more info on this, what is X_LIBS for, and why remove ALL -R options.
I always considered the -R options to be LD options, not library specifications
really.
The -L and -l options are library specifications, but -R is just a path that
gets baked into the .so
for runtime access to the
Looks good.
-kto
On Jan 8, 2013, at 6:07 AM, Erik Joelsson wrote:
Five classes which in jigsaw will be located in the base module currently
have their native headers generated in a special way (explicitly with javah).
This was because the base module could not be made dependent on the
Changeset: 8171d23e914d
Author:katleman
Date: 2012-12-27 12:14 -0800
URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/8171d23e914d
Added tag jdk8-b70 for changeset 603cceb495c8
! .hgtags
Changeset: cb40427f4714
Author:katleman
Date: 2013-01-03 12:44 -0800
URL:
Changeset: 3fb32a5a2388
Author:katleman
Date: 2012-12-27 12:14 -0800
URL: http://hg.openjdk.java.net/jdk8/build/rev/3fb32a5a2388
Added tag jdk8-b70 for changeset 105a25ffa4a4
! .hgtags
Changeset: 2ed5be3dd506
Author:lana
Date: 2012-12-16 22:02 -0800
URL:
Changeset: 63815efd132f
Author:katleman
Date: 2012-12-27 12:15 -0800
URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/63815efd132f
Added tag jdk8-b70 for changeset 6ec9edffc286
! .hgtags
Changeset: b1fdb101c82e
Author:joehw
Date: 2012-12-14 13:24 -0800
URL:
Changeset: 0847210f8548
Author:katleman
Date: 2012-12-27 12:14 -0800
URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0847210f8548
Added tag jdk8-b70 for changeset e94068d4ff52
! .hgtags
Changeset: d5cb5830f570
Author:katleman
Date: 2013-01-03 12:44 -0800
URL:
Changeset: f577a39c9fb3
Author:katleman
Date: 2012-12-27 12:15 -0800
URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/f577a39c9fb3
Added tag jdk8-b70 for changeset 3b1c2733d47e
! .hgtags
Changeset: d9707230294d
Author:katleman
Date: 2013-01-03 12:44 -0800
URL:
Changeset: 8d7651351cfe
Author:katleman
Date: 2012-12-27 12:15 -0800
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8d7651351cfe
Added tag jdk8-b70 for changeset a996b57e5541
! .hgtags
Changeset: a988c23b8553
Author:jgodinez
Date: 2012-12-20 14:43 -0800
URL:
Changeset: 7d5032c2d747
Author:katleman
Date: 2012-12-27 12:15 -0800
URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/7d5032c2d747
Added tag jdk8-b70 for changeset 47f71d7c124f
! .hgtags
Changeset: 37a5d7eccb87
Author:vromero
Date: 2012-12-14 11:16 +
URL:
On Jan 8, 2013, at 12:02 AM, David Holmes wrote:
I have updated webrevs:
http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.top/
http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.jdk/
They look ok to me.
I've addressed the minor suggestions that have been given by Kelly and
Changeset: b284980b7d9a
Author:tbell
Date: 2013-01-08 16:23 -0800
URL: http://hg.openjdk.java.net/jdk8/build/rev/b284980b7d9a
8005794: in new infra, how do we change java -version?
Summary: Added configure parameter --with-user-release-suffix
Reviewed-by: ohair, tbell
!
On 8/01/2013 10:56 PM, Erik Joelsson wrote:
The open part of this review. Move handling of --enable-openjdk-only to
before the first custom hook call.
http://cr.openjdk.java.net/~erikj/8005850/webrev.root.01/
Minor nit: SUPPRESS has two P's :)
One concern I have with this is that we keep
On 9/01/2013 5:56 AM, Kelly O'Hair wrote:
I need more info on this, what is X_LIBS for, and why remove ALL -R options.
IIRC Fredrik added this to deal with some binary difference detected on
OSX. I don't know what these variables actually contain
I always considered the -R options to be LD
On 9/01/2013 8:23 AM, Kelly O'Hair wrote:
On Jan 8, 2013, at 12:02 AM, David Holmes wrote:
I have updated webrevs:
http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.top/
http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.jdk/
They look ok to me.
Thanks.
I've addressed the
I had a failure building on a Mac (Mountain Lion, 10.8.2), both new build and
old build, at this step:
/Library/Java/JavaVirtualMachines/1.7.0.jdk/Contents/Home/bin/java
-XX:-PrintVMOptions -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput
-Djava.awt.headless=true -Xmx512m -Xms512m
27 matches
Mail list logo
