On 01/22/13 20:14, Tim Bell wrote:
> On 01/22/13 16:02, David Holmes wrote:
>> Hi Eric,
>>
>> On 23/01/2013 4:47 AM, Eric McCorkle wrote:
>>> Hello,
>>>
>>> Please review and approve the makefile changes for JDK-8004729.
>>>
>>> This patch add a native method (getParameters0) to the Executable clas
On 01/22/13 16:02, David Holmes wrote:
Hi Eric,
On 23/01/2013 4:47 AM, Eric McCorkle wrote:
Hello,
Please review and approve the makefile changes for JDK-8004729.
This patch add a native method (getParameters0) to the Executable class,
and uses the JVM_GetMethodParameters function exported fr
On 23/01/2013 9:08 AM, Xueming Shen wrote:
On 01/22/2013 02:58 PM, Alan Bateman wrote:
On 22/01/2013 22:19, David Holmes wrote:
All of the jar building was modified so that jars go into images/lib
not jdk/lib. So it should not be necessary (or desirable) to build
into jdk/lib and then copy over
Hi Eric,
On 23/01/2013 4:47 AM, Eric McCorkle wrote:
Hello,
Please review and approve the makefile changes for JDK-8004729.
This patch add a native method (getParameters0) to the Executable class,
and uses the JVM_GetMethodParameters function exported from the JVM.
http://cr.openjdk.java.net/
On 22/01/2013 22:19, David Holmes wrote:
All of the jar building was modified so that jars go into images/lib
not jdk/lib. So it should not be necessary (or desirable) to build
into jdk/lib and then copy over.
Sherman can confirm, but I believe the TzdbZoneRulesProvider requires it
in the lib d
On 23/01/2013 5:52 AM, Alan Bateman wrote:
On 22/01/2013 19:09, Xueming Shen wrote:
Hi,
Webrev has been updated to address the build issue in the
new build infra. M
(1) added the java.time packages into
common/makefiles.javadoc/CORE_PKGS.gmk
to be included into ct.sym
http://cr.openjdk.java.n
Hello all;
This is a patch that has been lingering around in the lambda/lambda repo for a
long time. It adds minimal support for the MacOSX platform to the JDK NetBeans
projects. It could also be used as the basis for similar support for the
langtools NetBeans projects.
The patch also adjust t
Hello all;
This is a two piece patch.
8006594: Add jdk_core target to jdk/test/Makefile
8006595: Use jdk/test/Makefile targets in preference to local definitions
I chose to do it as two patches because the changes are in different repos and
the changes in 8006594 could be committed without the
On 22/01/2013 19:09, Xueming Shen wrote:
Hi,
Webrev has been updated to address the build issue in the
new build infra. M
(1) added the java.time packages into
common/makefiles.javadoc/CORE_PKGS.gmk
to be included into ct.sym
http://cr.openjdk.java.net/~sherman/8003680/webrev_ctrl/
(2) not
Hello,
Please review and approve the makefile changes for JDK-8004729.
This patch add a native method (getParameters0) to the Executable class,
and uses the JVM_GetMethodParameters function exported from the JVM.
http://cr.openjdk.java.net/~emc/8004729/webrev.00/
For more discussion of the feat
Hi Erik
Looks good to me as well.
Tim
On 01/22/13 01:38, Fredrik Öhrström wrote:
Ok!
2013/1/22 Erik Joelsson :
In JDK-8001895, MILESTONE and JDK_BUILD_NUMBER were made customizable. But
by mistake, JDK_BUILD_NUMBER could get picked up from the environment while
MILESTONE couldn't. They shoul
Erik:
Adding functionality to compare.sh to take two zip/jar files as
arguments and just compare those.
http://cr.openjdk.java.net/~erikj/8006663/webrev.root.01/
Looks good.
Tim
Hi Erik:
New webrev for this:
http://cr.openjdk.java.net/~erikj/8005855/webrev.root.02/
I changed the sed to only remove the -R argument and made it
conditional on cross compilation.
Looks good. Thanks for the background!
Tim
A bit of background on this. The X_LIBS variable is created b
Erik,
Thank you for explanation!
-Dmitry
On 2013-01-22 19:05, Erik Joelsson wrote:
> Hello,
>
> The purpose of compare.sh is to compare build output between builds to
> check that nothing changed that shouldn't have. It has been developed
> and used in the build-infra project. Several file typ
Hello,
The purpose of compare.sh is to compare build output between builds to
check that nothing changed that shouldn't have. It has been developed
and used in the build-infra project. Several file types need extra care
when comparing and various exceptions to be made. For example zip and
jar
Erik,
What is the purpose of this comparison. Is it time critical?
On a brief look
unzip -v > /tmp/1
unzip -v > /tmp/2
diff /tmp/1 /tmp/2
do exactly the same but much much faster.
Maybe I missed something.
-Dmitry
On 2013-01-22 14:03, Erik Joelsson wrote:
> Adding functionality to compare.s
Okay. I can't attest to the accuracy of the sed command but I agree with
the intent :) Though I'm not sure there still exists any place where we
use X_LIBS if cross-compiling.
Thanks,
David
On 22/01/2013 8:18 PM, Erik Joelsson wrote:
New webrev for this:
http://cr.openjdk.java.net/~erikj/800
Looks good to me.
Thanks,
David
On 22/01/2013 7:13 PM, Erik Joelsson wrote:
In JDK-8001895, MILESTONE and JDK_BUILD_NUMBER were made customizable.
But by mistake, JDK_BUILD_NUMBER could get picked up from the
environment while MILESTONE couldn't. They should behave the same and at
this time, li
New webrev for this:
http://cr.openjdk.java.net/~erikj/8005855/webrev.root.02/
I changed the sed to only remove the -R argument and made it conditional
on cross compilation.
A bit of background on this. The X_LIBS variable is created by autoconf
by calling some special macros to locate libra
Ok!
2013/1/22 Erik Joelsson :
> Adding functionality to compare.sh to take two zip/jar files as arguments
> and just compare those.
>
> http://cr.openjdk.java.net/~erikj/8006663/webrev.root.01/
>
> /Erik
Adding functionality to compare.sh to take two zip/jar files as
arguments and just compare those.
http://cr.openjdk.java.net/~erikj/8006663/webrev.root.01/
/Erik
Use LC_ALL=C instead of LANG=C because the latter does not change LC_MESSAGES,
which is necessary if we are grepping for english words in the output from diff.
Contributed by ohrstrom
http://cr.openjdk.java.net/~erikj/8006661/webrev.root.01/
/Erik
Ok!
2013/1/22 Erik Joelsson :
> In JDK-8001895, MILESTONE and JDK_BUILD_NUMBER were made customizable. But
> by mistake, JDK_BUILD_NUMBER could get picked up from the environment while
> MILESTONE couldn't. They should behave the same and at this time, listening
> to the environment is needed.
>
>
In JDK-8001895, MILESTONE and JDK_BUILD_NUMBER were made customizable.
But by mistake, JDK_BUILD_NUMBER could get picked up from the
environment while MILESTONE couldn't. They should behave the same and at
this time, listening to the environment is needed.
http://cr.openjdk.java.net/~erikj/800
Changeset: 57d5d9544628
Author:erikj
Date: 2013-01-22 09:01 +0100
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/57d5d9544628
8004151: build-infra: Generating X11 wrapper offset file is not cross compilable
Reviewed-by: dholmes, ohrstrom
! makefiles/GensrcX11Wrappers.gmk
+ src/
25 matches
Mail list logo
