- Original Message -
> On 15/03/2013 12:55 PM, Andrew Hughes wrote:
> > - Original Message -
> >> On 15/03/2013 5:37 AM, Omair Majid wrote:
> >>> Hi,
> >>>
> >>> Updated webrev at:
> >>> http://cr.openjdk.java.net/~omajid/webrevs/intree-ec/01/
> >>>
> >>> I switched from DISABLE_INT
On 15/03/2013 12:55 PM, Andrew Hughes wrote:
- Original Message -
On 15/03/2013 5:37 AM, Omair Majid wrote:
Hi,
Updated webrev at:
http://cr.openjdk.java.net/~omajid/webrevs/intree-ec/01/
I switched from DISABLE_INTREE_EC to ENABLE_INTREE_EC to avoid the
confusion with double negative
- Original Message -
> Hi,
>
> Updated webrev at:
> http://cr.openjdk.java.net/~omajid/webrevs/system-giflib/01/
>
> The webrev borrows some idioms that Andrew Hughes pointed out, and
> uses
> system headers for giflib too.
>
> I checked this by building --with-libgif=system and also by
- Original Message -
> Hi Andrew,
>
> On 03/13/2013 05:08 AM, Andrew Hughes wrote:
> > Given this is essentially a binary option (system giflib or bundled
> > giflib),
> > why is AC_ARG_ENABLE not being used instead of AC_ARG_WITH? It
> > would simplify
> > the logic here and is what we u
- Original Message -
> On 15/03/2013 5:37 AM, Omair Majid wrote:
> > Hi,
> >
> > Updated webrev at:
> > http://cr.openjdk.java.net/~omajid/webrevs/intree-ec/01/
> >
> > I switched from DISABLE_INTREE_EC to ENABLE_INTREE_EC to avoid the
> > confusion with double negatives.
>
> Looking just
On 15/03/2013 5:37 AM, Omair Majid wrote:
Hi,
Updated webrev at:
http://cr.openjdk.java.net/~omajid/webrevs/intree-ec/01/
I switched from DISABLE_INTREE_EC to ENABLE_INTREE_EC to avoid the
confusion with double negatives.
Looking just at the mechanics of this it looks fine to me. This needs t
On 03/14/2013 07:39 PM, Omair Majid wrote:
> I checked this by building --with-libgif=system
Typo. I meant '--with-giflib=bundled' (I had also removed the system
giflib headers at that point to ensure the bundled copy was used).
Thanks,
Omair
--
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerpri
Hi,
Updated webrev at:
http://cr.openjdk.java.net/~omajid/webrevs/system-giflib/01/
The webrev borrows some idioms that Andrew Hughes pointed out, and uses
system headers for giflib too.
I checked this by building --with-libgif=system and also by removing the
src/share/native/sun/awt/giflib dir
Hi Andrew,
On 03/13/2013 05:08 AM, Andrew Hughes wrote:
> Given this is essentially a binary option (system giflib or bundled giflib),
> why is AC_ARG_ENABLE not being used instead of AC_ARG_WITH? It would simplify
> the logic here and is what we use in the equivalent IcedTea check which has
> be
On 03/14/2013 03:14 PM, Vincent Ryan wrote:
> The DISABLE_INTREE_EC flag is designed to control whether the Elliptic Curve
> support in the
> JDK source tree is skipped during a build. It is used to avoid the
> duplication of EC libraries on
> platforms where an EC library is already present.
>
Hi,
Updated webrev at:
http://cr.openjdk.java.net/~omajid/webrevs/intree-ec/01/
I switched from DISABLE_INTREE_EC to ENABLE_INTREE_EC to avoid the
confusion with double negatives.
Note that because of the ifeq comparison, if you use the new build
system and just update the jdk tree, the ifeq ($E
The DISABLE_INTREE_EC flag is designed to control whether the Elliptic Curve
support in the
JDK source tree is skipped during a build. It is used to avoid the duplication
of EC libraries on
platforms where an EC library is already present.
In the old build it was a build option. In the new build
- Original Message -
> On 14/03/2013 6:09 AM, Omair Majid wrote:
> > Hi,
> >
> > jdk/makefiles/CompileNativeLibraries.gmk has a little note:
> >
> > TODO Set DISABLE_INTREE_EC in configure if
> > src/share/native/sun/security/ec/impl is not present
> >
> > The webrev at
> > http://cr.openjd
- Original Message -
> On 03/14/2013 08:58 AM, Alan Bateman wrote:
> > On 14/03/2013 01:26, David Holmes wrote:
> >> :
> >>
> >>> 3. -Werror is set for the SCTP native code causing the build to
> >>> fail:
> >>>
> >>> Lots of stuff like:
> >>>
> >>> /home/andrew/projects/openjdk/upstream
- Original Message -
> On 14/03/2013 01:26, David Holmes wrote:
> > :
> >
> >> 3. -Werror is set for the SCTP native code causing the build to
> >> fail:
> >>
> >> Lots of stuff like:
> >>
> >> /home/andrew/projects/openjdk/upstream/jdk8/jdk/src/solaris/native/sun/nio/ch/sctp/SctpChannel
On 03/14/2013 08:58 AM, Alan Bateman wrote:
On 14/03/2013 01:26, David Holmes wrote:
:
3. -Werror is set for the SCTP native code causing the build to fail:
Lots of stuff like:
/home/andrew/projects/openjdk/upstream/jdk8/jdk/src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c:88:24:
error:
On 14/03/2013 3:12 PM, David Holmes wrote:
Note that this isn't changing any functionality simply exposing an
existing make variable at configure time.
Correction. I misunderstood what was being done here. This forcibly
set/clears the make variable based solely on the existence of a directory:
Hello Andrew,
Thanks for the feedback! Adding in my view of things below.
On 2013-03-13 17:16, Andrew Hughes wrote:
I've just got my first build out of the new system using the main jdk8/jdk8
tree (b80) and
so thought it was worth giving some feedback on the problems encountered and
issues
wi
On 14/03/2013 01:26, David Holmes wrote:
:
3. -Werror is set for the SCTP native code causing the build to fail:
Lots of stuff like:
/home/andrew/projects/openjdk/upstream/jdk8/jdk/src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c:88:24:
error: unused parameter 'klass' [-Werror=unused-pa
19 matches
Mail list logo
