Re: [OpenJDK 2D-Dev] Add optional support for using the system libicu

Omair, I'm sorry I did not see this before. I probably would not have noticed it except I happened to notice this reply. I'm responsible for maintaining the version of ICU in JDK, and also (read: main day job) IBM's lead for ICU for C/C++. ( But I speak for myself here, of course. ) I t

Re: Add optional support for using the system libicu

Hi Phil, Updated webrev: http://cr.openjdk.java.net/~omajid/webrevs/system-icu/01/ It's still against jdk8/build and missing support for the old build system. On 06/05/2013 02:02 PM, Phil Race wrote: > Since this entirely affects a 2D component, please include 2d-dev in > this discussion. > I wo

Re: Add optional support for using the system libicu

Hi Erik, Thanks for your comments. Sorry I couldn't get back to you earlier, I was busy with a conference. Here's an updated webrev: http://cr.openjdk.java.net/~omajid/webrevs/system-icu/01/ On 06/05/2013 05:21 AM, Erik Joelsson wrote: > Is it required to remove the font/layout dir to use the sy

Re: RFR: 8012564: The SOURCE value in release file of JDK 8 doesn't contain valid changesets for some OS since b74

Erik: Simple patch removing unnecessary check for existence of mercurial for getting the hgtips for the release file. This check prevented the backup solution of using the .hgtip files from working when building from source bundles. http://cr.openjdk.java.net/~erikj/8012564/webrev.root.01

Re: RFR: 8017480: Move copying of jfr files to closed makefile

Looks good to me as well. Tim On 06/24/13 05:08 AM, Staffan Larsen wrote: Looks good. /Staffan On 24 jun 2013, at 13:57, Erik Joelsson wrote: Please review this simple patch, removing copying of jfr files from CopyFiles.gmk and adding an optional include of a custom CopyFiles.gmk. http:/

Re: RFR: 8017047: Can't use --with-java-devtools and --with-devkit at the same time

Erik: Open part of this review: There is an artificial limitation put into configure that prevents usage of options --with-devkit and --with-tools-dir at the same time. The reason was probably because they could potentially be conflicting. This patch removes this check and makes them work to

RFR (XS): Enable new build on Linux/PPC64 (jdk part)

Hi, could somebody please review the following change and create an appropriate Bug ID for it: http://cr.openjdk.java.net/~simonis/webrevs/linux_ppc_build_jdk/ The patch contains two little changes which are required to build the class library part of the OpenJDK on Linux/PPC64. Most of the buil

RFR (S): Enable new build on Linux/PPC64 (top-level part)

Hi, could somebody please review the following change and create an appropriate Bug ID for it: http://cr.openjdk.java.net/~simonis/webrevs/linux_ppc_build_top/ The change will enable to build the PowerPC/AIX port on Linux/PPC64 with the new build system using an interpreter only VM using the C++

Re: HSX-24: Code Review (round 0) request for MacOS X exported symbols fix (8014326)

Added back build-dev. On 6/19/2013 3:58 PM, Coleen Phillimore wrote: Dan, This looks good! Coleen On 6/18/2013 4:50 PM, Daniel D. Daugherty wrote: Greetings, I have picked up David Holmes' work on the following bug: 8014326 [OSX] All libjvm symbols are exported http://bugs.sun.com/

Re: RFR: 8017480: Move copying of jfr files to closed makefile

Looks good. /Staffan On 24 jun 2013, at 13:57, Erik Joelsson wrote: > Please review this simple patch, removing copying of jfr files from > CopyFiles.gmk and adding an optional include of a custom CopyFiles.gmk. > > http://cr.openjdk.java.net/~erikj/8017114/webrev.jdk.01/ > > /Erik

RFR: 8017480: Move copying of jfr files to closed makefile

Please review this simple patch, removing copying of jfr files from CopyFiles.gmk and adding an optional include of a custom CopyFiles.gmk. http://cr.openjdk.java.net/~erikj/8017114/webrev.jdk.01/ /Erik