Build Configure Fail In Windows Platform

2013-06-26 Thread Dan Xu
Hi All, I updated my cygwin in my windows 7 yesterday. And since then, the build configuration failed to work. After investigating the build issue, I find the problem is related with the sed package updated in the cygwin. The latest sed package in cygwin is version 4.2.2-1. If I downgrade my

Re: RFR: 8017047: Can't use --with-java-devtools and --with-devkit at the same time

2013-06-26 Thread Tim Bell
Hi Erik: In the new basics.m4: 362 TOOLS_DIR=$TOOLS_DIR:$with_devkit/bin If TOOLS_DIR was empty, this will add an extra : Probably harmless, but I'd prefer not to see it happen. If you feel it is harmless, go ahead. Code deletion looks good. Yes, there would be an extra :, but it did

hg: jdk8/build/jdk: 8016684: JDK8 b94 source with GPL header errors

2013-06-26 Thread david . katleman
Changeset: 4a5d3cf2b3af Author:katleman Date: 2013-06-26 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4a5d3cf2b3af 8016684: JDK8 b94 source with GPL header errors Reviewed-by: tbell, darcy ! src/share/classes/java/nio/CharBufferSpliterator.java ! src/share/native/

hg: jdk8/build/hotspot: 8017323: JDK8 b95 source with GPL header errors

2013-06-26 Thread david . katleman
Changeset: e6a4b8c71fa6 Author:katleman Date: 2013-06-26 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e6a4b8c71fa6 8017323: JDK8 b95 source with GPL header errors Reviewed-by: tbell, darcy ! src/share/vm/memory/referenceProcessorStats.hpp

hg: jdk8/build/langtools: 8016684: JDK8 b94 source with GPL header errors

2013-06-26 Thread david . katleman
Changeset: 988aef3a8c3a Author:katleman Date: 2013-06-26 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/988aef3a8c3a 8016684: JDK8 b94 source with GPL header errors Reviewed-by: tbell, darcy ! test/tools/javac/6567415/T6567415.java

Re: RFR (XS): Enable new build on Linux/PPC64 (jdk part)

2013-06-26 Thread Vladimir Kozlov
Erik, We have special staging forest for PPC64/AIX port: http://hg.openjdk.java.net/ppc-aix-port/stage We collect Hotspot and JDK changes there for testing before pushing into main sources in a future. But some general fixes we push directly into our main sources. If you think these build cha

Re: RFR (XS): 8019155 Update makefiles with correct jfr packages

2013-06-26 Thread Tim Bell
Looks good to me as well. Tim On 06/26/13 05:32 AM, David Holmes wrote: +1 from me. David On 26/06/2013 6:08 PM, Staffan Larsen wrote: Thanks Erik and Markus. Widening the audience to get the required number of reviewers. Thanks, /Staffan On 26 jun 2013, at 10:02, Erik Joelsson wrote:

Re: RFR (S): Enable new build on Linux/PPC64 (top-level part)

2013-06-26 Thread Volker Simonis
Hi Erik, thanks for the BugID! Here's the new webrev: http://cr.openjdk.java.net/~simonis/webrevs/8017568_toplevel I've added a detection for buggy linkers on older SuSE distros (e.g. on SLES 10) which complains with: "Invalid version tag `SUNWprivate_1.1'. Only anonymous version tag is allowed

Re: RFR (XS): Enable new build on Linux/PPC64 (jdk part)

2013-06-26 Thread Volker Simonis
Hi Erik, thank you for looking at this. I've prepared a new webrev at: http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ What do you think, do you want to push this directly into the build repositories or should I push it into the staging repository first? Please see my further comments

Re: RFR (XS): 8019155 Update makefiles with correct jfr packages

2013-06-26 Thread David Holmes
+1 from me. David On 26/06/2013 6:08 PM, Staffan Larsen wrote: Thanks Erik and Markus. Widening the audience to get the required number of reviewers. Thanks, /Staffan On 26 jun 2013, at 10:02, Erik Joelsson wrote: Looks good to me, but I'm not a jdk7 reviewer. /Erik On 2013-06-26 09:42,

Re: RFR: 8017047: Can't use --with-java-devtools and --with-devkit at the same time

2013-06-26 Thread Erik Joelsson
On 2013-06-24 20:45, Tim Bell wrote: Erik: Open part of this review: There is an artificial limitation put into configure that prevents usage of options --with-devkit and --with-tools-dir at the same time. The reason was probably because they could potentially be conflicting. This patch r

Re: RFR (XS): 8019155 Update makefiles with correct jfr packages

2013-06-26 Thread Staffan Larsen
Thanks Erik and Markus. Widening the audience to get the required number of reviewers. Thanks, /Staffan On 26 jun 2013, at 10:02, Erik Joelsson wrote: > Looks good to me, but I'm not a jdk7 reviewer. > > /Erik > > On 2013-06-26 09:42, Staffan Larsen wrote: >> Please review this small fix for

Re: RFR (XS): 8019155 Update makefiles with correct jfr packages

2013-06-26 Thread Erik Joelsson
Looks good to me, but I'm not a jdk7 reviewer. /Erik On 2013-06-26 09:42, Staffan Larsen wrote: Please review this small fix for the 7u40 makefiles to include the correct packages in jfr.jar. webrev: http://cr.openjdk.java.net/~sla/8019155/webrev.00/ Thanks, /Staffan

RE: RFR (XS): 8019155 Update makefiles with correct jfr packages

2013-06-26 Thread Markus Grönlund
Looks good. /Markus -Original Message- From: Staffan Larsen Sent: den 26 juni 2013 09:42 To: build-dev@openjdk.java.net build-dev; serviceability-...@openjdk.java.net serviceability-...@openjdk.java.net Subject: RFR (XS): 8019155 Update makefiles with correct jfr packages Please review

RFR (XS): 8019155 Update makefiles with correct jfr packages

2013-06-26 Thread Staffan Larsen
Please review this small fix for the 7u40 makefiles to include the correct packages in jfr.jar. webrev: http://cr.openjdk.java.net/~sla/8019155/webrev.00/ Thanks, /Staffan