Re: Problem related to building JDK in Windows

2014-04-07 Thread Volker Simonis
This is a known problem with VS2010 after installing VS2012 or .NET 4.5.1. There exist various workarounds - just google for "LINK : fatal error LNK1123: failure during conversion to COFF: file invalid". The easiest and fastes solution is to remove the bad version of "cvtres.exe" which is causing

gcc can target wrong instruction set when building JDK native code

2014-04-07 Thread David Holmes
I just filed this as: https://bugs.openjdk.java.net/browse/JDK-8039426 Our JDK build does not specify -march/-mtune (whereas hotspot specifies -march=i586) so JDK gets gcc's default behaviour. The default is -mtune=generic and 'generic', at least back to 4.2, means i686 - this means that the

RFR: 8039411 : Add environment variable support to fixpath

2014-04-07 Thread Mike Duigou
Hello all; Currently the fixpath utility used in windows builds expects that the first parameter it is passed will be the path of the executable. In some cases it's desirable to define environment variables which will apply during the execution of that executable. This change adds support for d

Re: RFR [9] 8039362: Read content-types.properties as a resource

2014-04-07 Thread Mandy Chung
On 4/7/14 11:54 AM, Chris Hegarty wrote: Updated webrev: http://cr.openjdk.java.net/~chegar/8039362/01/webrev/ Thanks for doing this. Some minor comments: line 225: since content-types.properties is moved to the same package as MimeType class, you can simply use the relative path "conte

Re: RFR [9] 8039362: Read content-types.properties as a resource

2014-04-07 Thread Chris Hegarty
[ Including Alex; there is a question/confirmation related to a change he pushed, that needs his input ] Hi Erik, thanks for your feedback, comments inline… Updated webrev: http://cr.openjdk.java.net/~chegar/8039362/01/webrev/ On 7 Apr 2014, at 16:00, Erik Joelsson wrote: > Hello Chris, >

Re: Problem related to building JDK in Windows

2014-04-07 Thread pooja chopra
Hi Magnus, After doing " make clean " and then doing " make " I am getting same error:- jvm.obj : warning LNK4197: export 'JVM_GetThreadStateNames' specified multiple times; using first specification Creating library jvm.lib and object jvm.exp LINK : fatal error LNK1123: failure during convers

Re: Fwd: RFR [9] 8039362: Read content-types.properties as a resource

2014-04-07 Thread Erik Joelsson
Hello Chris, The changes seem to do what you intend, but I have a couple of questions. If this is a standard properties file, wouldn't it make sense to either "clean" or "compile" it like other properties files? I note that there is a macosx version of this file but from what I can see of bo

Fwd: RFR [9] 8039362: Read content-types.properties as a resource

2014-04-07 Thread Chris Hegarty
Adding build-dev ( for the makefile changes ). -Chris. Original Message Subject: RFR [9] 8039362: Read content-types.properties as a resource Date: Mon, 07 Apr 2014 15:27:43 +0100 From: Chris Hegarty To: OpenJDK Network Dev list Following JDK-8004963: "URLConnection, downgra

Re: RFR: JDK-8035134: JDK9 unix debug bundle manifest file list issue

2014-04-07 Thread Magnus Ihse Bursie
Looks good to me. /Magnus > On 3 apr 2014, at 10:08, Erik Joelsson wrote: > > Hello, > > Please review this small fix, correcting the contents of the zipped debuginfo > files. They are currently adding the full absolute path name of the debuginfo > files to the zip instead of just the filen

Re: Problem related to building JDK in Windows

2014-04-07 Thread Magnus Ihse Bursie
I recommend you try "make clean" first. /Magnus > On 7 apr 2014, at 07:44, pooja chopra wrote: > > Hi Ludovic , > > Thanks for your help . I followed your steps mentioned in the blog and was > able to configure. After giving make command I am getting this error as > below :- > > jvm.obj : wa