Looks good to me Sean.
-Chris.
P.S. don’t forget to push the closed version of gen-conf too.
On 12 May 2014, at 23:22, Seán Coffey wrote:
> While adding some lambda code to a CORBA class, I got a build time error
> indicating that the build was running with -source 7.
>
> Given that JDK 8 is
I tried the NO_DEMOS flag as in
https://bugs.openjdk.java.net/browse/JDK-7143162 "Allow disabling of jdk
demos and samples build", but this seems to be in "old build" only, and
doesn't affect the new build system.
Is there an equivalent for the new build?
Thanks
- Ioi
Hello all;
I have updated the webrev after additional testing and cleanup. I found a
couple of additional minor problems and added a feature that had been
requested. Some of the default behaviour can now be controlled using
environment variables. It had been pointed out that being able to run c
On May 9 2014, at 01:54 , pointo1d wrote:
> Hi Mike ,
>
> On 09/05/14 08:25, Mike Duigou wrote:
>> On May 8 2014, at 22:35 , Chris Hegarty wrote:
>>
>>> Looks fine to me Mike.
>>>
>>> Trivially while you are there (not related to your changes), or i can do it
>>> separately, --sequentially
While adding some lambda code to a CORBA class, I got a build time error
indicating that the build was running with -source 7.
Given that JDK 8 is now the official bootstrap JDK for JDK 9 building, I
think we can bump the -source and -target properties up to 8 (from 7)
bug ID : https://bugs.o
Looks good to me.
A very useful addition that I plan to port to the jdk repo.
Mike
On May 12 2014, at 11:16 , Dan Smith wrote:
> A patch to enhance langtools/test/Makefile is inline, below.
>
> This addresses JDK-8042882, adding a variable to control verbosity. I've
> also slipped in a fi
On May 9 2014, at 03:54 , pointo1d wrote:
> Hi Mike ,
>
> On 09/05/14 03:19, Mike Duigou wrote:
>> Hello all;
>>
>> This issue is a follow-on bug fix to JDK-8041151 (Improve hgforest.sh
>> concurrency). That changeset introduced use of fifos for monitoring
>> sub-shell completion and include
A patch to enhance langtools/test/Makefile is inline, below.
This addresses JDK-8042882, adding a variable to control verbosity. I've also
slipped in a fix for JDK-8032441, eliminating the use of the MaxPermSize JVM
option (deprecated in 8, gone in 9) when running JCK tests.
—Dan
# HG changes
Staffan, Erik - thanks for the reviews!
Cheers,
Mikael
On 2014-05-12 01:38, Erik Joelsson wrote:
Looks good to me.
/Erik
On 2014-05-09 23:32, Mikael Vidstedt wrote:
All,
Can I please get a review or two of the below change, which makes it
possible to invoke/run the hotspot tests from the
Hi ,
Further to previous e-mails on the above subject, an update to the
simple patch incorporates Magnus' clarification comment (or a variant
thereof) ...
diff -r 9263073b1d95 configure
--- a/configureFri May 09 16:24:59 2014 +0100
+++ b/configureMon May 12 13:03:17 2014 +0100
@@ -26,
This looks good to me.
/Erik
On 2014-05-12 12:13, pointo1d wrote:
Thanx all ,
Pls be advised that the comments have been incorporated and the webrev
updated - at http://cr.openjdk.java.net/~ngmr/8037953/webrev.01.
Rgds ,
--
Dave Pointon FIAP MBCS
Now I saw, tho' too late, the folly of be
On 12/05/14 10:50, David Holmes wrote:
Also this appears to need the x to be quoted "x"
+ if test "x$with_import_hotspot" != x; then
at least that is the normal pattern (it may not be strictly necessary).
Hmm, I was following, or attempting to follow, the 'convention' as
illustrated elsew
Thanx all ,
Pls be advised that the comments have been incorporated and the webrev
updated - at http://cr.openjdk.java.net/~ngmr/8037953/webrev.01.
Rgds ,
--
Dave Pointon FIAP MBCS
Now I saw, tho' too late, the folly of beginning a work before we count the
cost and before we we judge righ
Also this appears to need the x to be quoted "x"
+ if test "x$with_import_hotspot" != x; then
at least that is the normal pattern (it may not be strictly necessary).
David H.
On 12/05/2014 7:40 PM, pointo1d wrote:
Hi Erik ,
On 12/05/14 09:35, Erik Joelsson wrote:
Hello Dave,
This looks b
Hi Erik ,
On 12/05/14 09:35, Erik Joelsson wrote:
Hello Dave,
This looks better. However, the test for cross compilation is bit too
restrictive. We have a variable called COMPILE_TYPE which can have the
values "native", "reduced" and "cross". Reduced means that we compile
for 32bit on an arc
Looks good to me.
/Erik
On 2014-05-09 23:32, Mikael Vidstedt wrote:
All,
Can I please get a review or two of the below change, which makes it
possible to invoke/run the hotspot tests from the top level
test/Makefile too - much like the jdk, langtools etc. tests. The
implementation does thi
Hello Dave,
This looks better. However, the test for cross compilation is bit too
restrictive. We have a variable called COMPILE_TYPE which can have the
values "native", "reduced" and "cross". Reduced means that we compile
for 32bit on an architecture that normally supports 64bit, and achieved
Looks good!
Thanks,
/Staffan
On 9 maj 2014, at 23:32, Mikael Vidstedt wrote:
>
> All,
>
> Can I please get a review or two of the below change, which makes it possible
> to invoke/run the hotspot tests from the top level test/Makefile too - much
> like the jdk, langtools etc. tests. The imp
For the Open record, the hotspot fix has an issue because
FASTDEBUG_CFLAGS is unused on linux/bsd.
David
On 9/05/2014 2:07 PM, David Holmes wrote:
Hi Mike,
This looks okay to me, but of course the proof is in the building and
testing.
David
On 4/05/2014 1:24 PM, Mike Duigou wrote:
Hello;
On 9/05/2014 10:32 PM, pointo1d wrote:
Hi all ,
By way of a heads-up, I deem that the nature and relative size of the
change (incorporating the comments from both Erik & David) now requires
a webrev, so one has been generated and is awaiting hosting up on
openjdk - of which further news as and w
20 matches
Mail list logo
