Re: RFR: JDK-8065215 Print warning summary at end of configure

2014-11-20 Thread Erik Joelsson
Looks good to me. /Erik On 2014-11-18 15:14, Magnus Ihse Bursie wrote: On 2014-11-18 15:00, Magnus Ihse Bursie wrote: Warnings in configure tends to just fly by quickly and be buried in the verbose autoconf output. We could with a simple trick repeat all those warnings (if any) at the end

Re: RFR: 8065138 - Encodings.isRecognizedEnconding sometimes fails to recognize 'UTF8'

2014-11-20 Thread Erik Joelsson
Hello, On 2014-11-20 02:20, Martin Buchholz wrote: Amusingly, the $(SORT) has an LC_ALL=C carefully placed before it, but the $(SED)s need it too! Yes, I think that's the correct fix in this case. On Wed, Nov 19, 2014 at 5:18 PM, Martin Buchholz marti...@google.com wrote: [+ build-dev] I

Re: RFR: 8065138 - Encodings.isRecognizedEnconding sometimes fails to recognize 'UTF8'

2014-11-20 Thread Daniel Fuchs
On 11/20/14 10:26 AM, Erik Joelsson wrote: Hello, On 2014-11-20 02:20, Martin Buchholz wrote: Amusingly, the $(SORT) has an LC_ALL=C carefully placed before it, but the $(SED)s need it too! Yes, I think that's the correct fix in this case. On Wed, Nov 19, 2014 at 5:18 PM, Martin Buchholz

unlink problem on OSX with unzipped debuginfo

2014-11-20 Thread David Holmes
Building 8u on OSX with --disable-zip-debug-info I see in the log: make[2]: unlink: /Users/jprtadm/davidh-test/build/b01/se-macosx-x86_64-ea/jdk/lib/libjsig.dylib.dSYM: Operation not permitted Can anyone shed any light on this? I'm not clear on what is being attempted nor the affects on the

Re: unlink problem on OSX with unzipped debuginfo

2014-11-20 Thread Erik Joelsson
I think it's Import.gmk that isn't working well with non zipped debug symbols on mac. The .dSYM file is actually a directory and the logic in Import.gmk probably hasn't been exercised with that much. /Erik On 2014-11-20 11:00, David Holmes wrote: Building 8u on OSX with

RFR: JDK-8065412: generated source to compile .properties file incorreectly includes the module name in the package name

2014-11-20 Thread Erik Joelsson
Hello, Please review this small fix, correcting the source generation from properties when the properties files are in platform specific source directories. The bug was introduced by me in JDK-8055191. Bug: https://bugs.openjdk.java.net/browse/JDK-8065412 Patch inline: diff --git

Re: RFR: 8065138 - Encodings.isRecognizedEnconding sometimes fails to recognize 'UTF8'

2014-11-20 Thread Erik Joelsson
Here is my proposal for fixing the particular issue of generating the correct properties files. I'm simply adding LC_ALL=C to the whole command line instead of just the sort at the end. It seems to require using export to get picked up. Bug: https://bugs.openjdk.java.net/browse/JDK-8065138

Re: RFR: JDK-8065412: generated source to compile .properties file incorreectly includes the module name in the package name

2014-11-20 Thread Tim Bell
Erik: Please review this small fix, correcting the source generation from properties when the properties files are in platform specific source directories. The bug was introduced by me in JDK-8055191. Bug: https://bugs.openjdk.java.net/browse/JDK-8065412 Patch inline: diff --git

Re: RFR: 8065138 - Encodings.isRecognizedEnconding sometimes fails to recognize 'UTF8'

2014-11-20 Thread Daniel Fuchs
On 20/11/14 14:36, Erik Joelsson wrote: Here is my proposal for fixing the particular issue of generating the correct properties files. I'm simply adding LC_ALL=C to the whole command line instead of just the sort at the end. It seems to require using export to get picked up. Hi Erik, Looks

Re: RFR: JDK-8065412: generated source to compile .properties file incorreectly includes the module name in the package name

2014-11-20 Thread Mandy Chung
On 11/20/14 3:19 AM, Erik Joelsson wrote: Hello, Please review this small fix, correcting the source generation from properties when the properties files are in platform specific source directories. The bug was introduced by me in JDK-8055191. Bug:

RFR [JEP 220] Modular Run-Time Images

2014-11-20 Thread Chris Hegarty
From: Chris Hegarty chris.hega...@oracle.com Subject: RFR [JEP 220] Modular Run-Time Images Date: 20 November 2014 21:39:14 GMT To: jigsaw-dev jigsaw-...@openjdk.java.net, jdk9-dev jdk9-...@openjdk.java.net, build-dev build-dev@openjdk.java.net, Alan Bateman alan.bate...@oracle.com, Alex

Re: RFR: AARCH64: Top-level JDK changes

2014-11-20 Thread David M. Lloyd
On 11/07/2014 12:19 PM, Andrew Haley wrote: On 11/07/2014 06:10 PM, Christian Thalinger wrote: On Nov 7, 2014, at 9:55 AM, Andrew Haley a...@redhat.com wrote: On 11/07/2014 05:42 PM, Christian Thalinger wrote: On Nov 7, 2014, at 9:21 AM, Andrew Haley a...@redhat.com wrote: The first