Re: An issue of building openjre on CentOS 5.9

On 11/05/2016 11:56 AM, 31731705 wrote: Can anybody help me to check this compile error? OS is CentOS 5.9 [root@localhost openjdk]# uname -a Linux localhost.localdomain

Re: RFR: JDK-8155587: Cross compilation may cause compiler warnings for "build" compiler

Hi Erik, I can confirm the changes resolve the issues I was having. I looked at the changes, but don't really have the background to comment on them. thanks, Chris On 5/10/16 9:41 AM, Erik Joelsson wrote: Hello, When cross compiling, we compile a subset of the jdk for the build host to

RFR: JDK-8155587: Cross compilation may cause compiler warnings for "build" compiler

Hello, When cross compiling, we compile a subset of the jdk for the build host to be able to run jmod and jlink. Configure sets up a toolchain for this through variables prefixed "BUILD_" (BUILD_CC etc). The new nifty macro we have for conditionally setting compiler flags depending on the

Re: RFR: JDK-8156658 Common way to run jtreg tests

Staffan, Looks good for me. -Dmitry On 2016-05-10 17:22, Staffan Larsen wrote: > Updated webrev with those changes to the hotspot > makefile: http://cr.openjdk.java.net/~sla/8156658/webrev.04/ > > Thanks, > /Staffan > >> On 10 maj 2016, at 15:50, Dmitry Samersoff >>

Re: RFR: JDK-8156658 Common way to run jtreg tests

There are several issues that I would like to bring up after this, but I really don't want to open that can of worms since the goal here is not to do a full cleanup. I'm ok with this. /Erik On 2016-05-10 16:22, Staffan Larsen wrote: Updated webrev with those changes to the hotspot makefile:

Re: RFR: JDK-8156658 Common way to run jtreg tests

Updated webrev with those changes to the hotspot makefile: http://cr.openjdk.java.net/~sla/8156658/webrev.04/ Thanks, /Staffan > On 10 maj 2016, at 15:50, Dmitry Samersoff > wrote: > > Staffan, > >> Maybe. I

Re: RFR: JDK-8156658 Common way to run jtreg tests

Staffan, > Maybe. I didn’t want to change existing behavior in this patch. Which > one do you prefer? The code from jdk/test/Makefile (jaxp uses the same code). -Dmitry On 2016-05-10 16:06, Staffan Larsen wrote: > >> On 10 maj 2016, at 14:46, Dmitry Samersoff

Re: RFR: JDK-8156658 Common way to run jtreg tests

> On 10 maj 2016, at 14:46, Dmitry Samersoff > wrote: > > Staffan, > > Long awaited changes, thank you for doing it. > > Is it possible to use the same code for hotspot/test/Makefile:128 and > jdk/test/Makefile:84 Maybe. I didn’t want to change existing behavior

Re: RFR: JDK-8156658 Common way to run jtreg tests

Staffan, Long awaited changes, thank you for doing it. Is it possible to use the same code for hotspot/test/Makefile:128 and jdk/test/Makefile:84 84 ifdef ALT_OUTPUTDIR 85 ABS_OUTPUTDIR = $(shell $(CD) $(ALT_OUTPUTDIR) && $(PWD)) 86 else 87 ABS_OUTPUTDIR = $(shell $(CD)

Re: RFR: JDK-8156658 Common way to run jtreg tests

Thanks Erik! > On 10 maj 2016, at 14:39, Erik Joelsson wrote: > > Looks good to me. > > /Erik > > On 2016-05-10 14:21, Staffan Larsen wrote: >> For test automation purposes we want a way to run jtreg tests for the >> different components (jdk, langtools, jaxp,

Re: RFR: JDK-8156658 Common way to run jtreg tests

Looks good to me. /Erik On 2016-05-10 14:21, Staffan Larsen wrote: For test automation purposes we want a way to run jtreg tests for the different components (jdk, langtools, jaxp, hotspot, nashorn) in a unified way from the command line. We also want each component to be able to define how

RFR: JDK-8156658 Common way to run jtreg tests

For test automation purposes we want a way to run jtreg tests for the different components (jdk, langtools, jaxp, hotspot, nashorn) in a unified way from the command line. We also want each component to be able to define how jtreg is invoked (problemlists, concurrency, agentvm, ...). There is

Re: RFR: 8156561: Remove makeClasslist.js

Thanks for the quick reviews! /Claes On 2016-05-10 13:50, Chris Hegarty wrote: On 10 May 2016, at 12:42, Claes Redestad wrote: Hi, the tool makeClasslist.js lost it's purpose after JDK-8150044, so should be removed. Bug:

Re: RFR: 8156561: Remove makeClasslist.js

Looks good. /Erik On 2016-05-10 13:42, Claes Redestad wrote: Hi, the tool makeClasslist.js lost it's purpose after JDK-8150044, so should be removed. Bug: https://bugs.openjdk.java.net/browse/JDK-8156561 jdk repo$ hg rm make/non-build-utils/src/build/tools/makeclasslist Thanks! /Claes

RFR: 8156561: Remove makeClasslist.js

Hi, the tool makeClasslist.js lost it's purpose after JDK-8150044, so should be removed. Bug: https://bugs.openjdk.java.net/browse/JDK-8156561 jdk repo$ hg rm make/non-build-utils/src/build/tools/makeclasslist Thanks! /Claes