Re: RFR 8173715: Remove Flat Profiler

+1 Thanks, David On 21/08/2017 11:01 PM, Erik Joelsson wrote: Build changes look good. Don't forget to regenerate configure and push both the closed and open generated-configure script with this change. /Erik On 2017-08-18 23:09, Gerard Ziemski wrote: hi all, The FlatProfiler (i.e. -Xpr

Re: [RFR]: 8186433: Compiler flag -arch=sparc should not be passed on linux-sparc

On 21/08/2017 7:23 PM, John Paul Adrian Glaubitz wrote: On 08/18/2017 01:37 PM, John Paul Adrian Glaubitz wrote: This is my very first issue opened in the Java Bug System, so please bear with me if there are any issues with my report. FWIW, I still need to understand how to push the patch to the

Re: [RFR]: 8186313: Additional platform definitions to support Zero builds

Looks good to me. Thanks, David On 21/08/2017 10:23 PM, John Paul Adrian Glaubitz wrote: Hi! Here's the webrev for 8186313 (see [1,2,3,4]) which adds additional architectures to platform.m4 to enable Zero builds on. These are: - Alpha - M68K - MIPSEL, MIPS, MIPS64EL, MIPS64 - SH*EB, SH* All

Re: RFR: JDK-8186115 - libelf still referenced after 8172670

On 8/21/17 7:05 AM, Bob Vandette wrote: No, I have not pushed this fix yet. I was waiting for you to look into the CodeSectionProcessor issue. Leave CodeSectionProcessor.java as it is - don't even change comment. I will update it if needed. No updated webrev needed. Do you want me to just

Re: RFR: JDK-8186115 - libelf still referenced after 8172670

No, I have not pushed this fix yet. I was waiting for you to look into the CodeSectionProcessor issue. Do you want me to just push it? Can you send me a diff of the change you want me to add? Bob. > On Aug 19, 2017, at 3:46 PM, Vladimir Kozlov > wrote: > > Bob, did you pushed it? > > If n

Re: [RFR]: 8186433: Compiler flag -arch=sparc should not be passed on linux-sparc

On 08/21/2017 03:11 PM, Erik Joelsson wrote: I will do it, for both of your changes. Ok. And I was told to remind my sponsor to regenerate the generated_configure.sh after pushing the changes to platform.m4. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debia

Re: [RFR]: 8186433: Compiler flag -arch=sparc should not be passed on linux-sparc

Ah, I was just about to push to jdk10/jdk10, thanks! /Erik On 2017-08-21 15:12, David Holmes wrote: Hi Erik, Also note that these changes should go to jdk10/hs forest so that they will be in the safe place as Adrian's other hotspot patches as they come in. David On 21/08/2017 11:09 PM, J

Re: [RFR]: 8186433: Compiler flag -arch=sparc should not be passed on linux-sparc

Hi Erik, Also note that these changes should go to jdk10/hs forest so that they will be in the safe place as Adrian's other hotspot patches as they come in. David On 21/08/2017 11:09 PM, John Paul Adrian Glaubitz wrote: Hi Eric! On 08/21/2017 03:08 PM, Erik Joelsson wrote: Your change look

Re: [RFR]: 8186433: Compiler flag -arch=sparc should not be passed on linux-sparc

I will do it, for both of your changes. /Erik On 2017-08-21 15:09, John Paul Adrian Glaubitz wrote: Hi Eric! On 08/21/2017 03:08 PM, Erik Joelsson wrote: Your change looks ok. I assume you will also need a sponsor? Yes, I think so. I assume I don't any push rights ;). Adrian

Re: [RFR]: 8186313: Additional platform definitions to support Zero builds

On 08/21/2017 03:09 PM, Erik Joelsson wrote: This looks ok to me. I assume you also need a sponsor? Yes, that would be great :-). Thanks a lot! -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de

Re: [RFR]: 8186433: Compiler flag -arch=sparc should not be passed on linux-sparc

Hi Eric! On 08/21/2017 03:08 PM, Erik Joelsson wrote: Your change looks ok. I assume you will also need a sponsor? Yes, I think so. I assume I don't any push rights ;). Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berli

Re: [RFR]: 8186313: Additional platform definitions to support Zero builds

This looks ok to me. I assume you also need a sponsor? /Erik On 2017-08-21 14:23, John Paul Adrian Glaubitz wrote: Hi! Here's the webrev for 8186313 (see [1,2,3,4]) which adds additional architectures to platform.m4 to enable Zero builds on. These are: - Alpha - M68K - MIPSEL, MIPS, MIPS64E

Re: [RFR]: 8186433: Compiler flag -arch=sparc should not be passed on linux-sparc

Your change looks ok. I assume you will also need a sponsor? /Erik On 2017-08-21 11:23, John Paul Adrian Glaubitz wrote: On 08/18/2017 01:37 PM, John Paul Adrian Glaubitz wrote: This is my very first issue opened in the Java Bug System, so please bear with me if there are any issues with my r

Re: RFR(S): 8186438: 'configure' fails to find installed libfreetype on Ubuntu AArch64

Thank you Erik! -Dmitry On 08/21/2017 03:54 PM, Erik Joelsson wrote: Hello Dmitry Chuyko, The change looks reasonable to me and seems to still work on my x86_64 Ubuntu. I can sponsor this. /Erik On 2017-08-18 15:57, Dmitry Chuyko wrote: Please review the fix to let 'configure' proceed t

Re: RFR: JDK-8186115 - libelf still referenced after 8172670

Build changes look ok. /Erik On 2017-08-15 20:55, Bob Vandette wrote: Please review these changes for JDK 10 that remove all dependencies on libelf from the JDK build system. Bug: https://bugs.openjdk.java.net/browse/JDK-8186115 Webrev: http://cr.openjdk.java.net/~bobv/8186115/

Re: windows: sporadic configure errors in cygwin

Hi Eric, On Mon, Aug 21, 2017 at 2:27 PM, Erik Joelsson wrote: > Hello Thomas, > > I have seen the error before, but I do not recognize it as intermittent. > If you find any more information, we will be interested. > > It went away as mysteriously as it came... I'll come back to you if it return

Re: RFR 8173715: Remove Flat Profiler

Build changes look good. Don't forget to regenerate configure and push both the closed and open generated-configure script with this change. /Erik On 2017-08-18 23:09, Gerard Ziemski wrote: hi all, The FlatProfiler (i.e. -Xprof) has been deprecated in jdk9, and now it’s the time to remove

Re: RFR(S): 8186438: 'configure' fails to find installed libfreetype on Ubuntu AArch64

Hello Dmitry Chuyko, The change looks reasonable to me and seems to still work on my x86_64 Ubuntu. I can sponsor this. /Erik On 2017-08-18 15:57, Dmitry Chuyko wrote: Please review the fix to let 'configure' proceed to success after dependencies installation on clean Ubuntu-aarch64. bug

Re: [RFR]: Add alpha detection to platform.m4

Thanks David. John, your collected changes for adding all of these VAR_CPU* definitions look ok to me. /Erik On 2017-08-16 21:45, David Holmes wrote: Okay I have filed: https://bugs.openjdk.java.net/browse/JDK-8186313 to cover the addition of alpha, mips*, m68k and sh* platforms. Build f

Re: hotspot atom editor integration

For each generated object file, there is a corresponding .cmdline file which contains the full compile command line. That file can be parsed to extract the relevant flags that were used, and is probably easier to work with than parsing a debug build log. /Erik On 2017-08-11 15:37, Maurizio C

Re: windows: sporadic configure errors in cygwin

Hello Thomas, I have seen the error before, but I do not recognize it as intermittent. If you find any more information, we will be interested. I usually run 64bit cygwin and find that to be slightly faster in general, but 32bit should work fine. The date you installed (as in exactly which v

[RFR]: 8186313: Additional platform definitions to support Zero builds

Hi! Here's the webrev for 8186313 (see [1,2,3,4]) which adds additional architectures to platform.m4 to enable Zero builds on. These are: - Alpha - M68K - MIPSEL, MIPS, MIPS64EL, MIPS64 - SH*EB, SH* All these are known to work in Debian , some require additional minor patches though which I wi

Re: [RFR]: 8186433: Compiler flag -arch=sparc should not be passed on linux-sparc

On 08/18/2017 01:37 PM, John Paul Adrian Glaubitz wrote: This is my very first issue opened in the Java Bug System, so please bear with me if there are any issues with my report. FWIW, I still need to understand how to push the patch to the webreview system. Here's the webrev for this one [1].