Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

On 26/04/2018 2:34 PM, Jiangli Zhou wrote: Here is the incremental webrev with updates that incorporate all feedbacks: http://cr.openjdk.java.net/~jiangli/8193213_8182731/webrev_inc.02/ Looks good. One additional comment on test/hotspot/jtreg/runtime/appcds/SharedArchiveFile.java - it seems

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

Here is the incremental webrev with updates that incorporate all feedbacks: http://cr.openjdk.java.net/~jiangli/8193213_8182731/webrev_inc.02/ - Filed JDK-8202282 (https://bugs.openjdk.java.net/browse/JDK-8202282) for TestCommon.makeCommandLineForAppCDS() cleanup. - Removed case 2, 3 and 4 in

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

Hi David, > On Apr 25, 2018, at 3:12 PM, David Holmes wrote: > > Hi Jiangli, > > On 26/04/2018 3:39 AM, Jiangli Zhou wrote: >> Hi David, >> Thanks a lot for the review! >>> On Apr 24, 2018, at 11:17 PM, David Holmes wrote: >>> >>> cc'ing

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

Hi Jiangli, On 26/04/2018 3:39 AM, Jiangli Zhou wrote: Hi David, Thanks a lot for the review! On Apr 24, 2018, at 11:17 PM, David Holmes wrote: cc'ing build-dev for the makefile change Hi Jiangli, On 25/04/2018 10:53 AM, Jiangli Zhou wrote: Please review the

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

Hi Erik, > On Apr 25, 2018, at 8:30 AM, Erik Joelsson wrote: > > Hello, > > I would prefer if the .tmp file was not deleted. That will make it easier to > debug problems in the future. We have recently had reason to look at the > contents of the files here to figure

Re: RFR: 8201274: Launch Single-File Source-Code Programs

Kumar, Thank you for your feedback; I will incorporate it in the next webrev. -- Jon On 04/25/2018 09:38 AM, Kumar Srinivasan wrote: Hi John, I focused mainly on the native side, looks ok, except for a couple of minor issues. java.c 1320 const char *prop =

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

Hi Magnus, Thanks a lot for the review! Jiangli > On Apr 25, 2018, at 2:17 AM, Magnus Ihse Bursie > wrote: > > > > On 2018-04-25 08:17, David Holmes wrote: >> cc'ing build-dev for the makefile change >> >> Hi Jiangli, >> >> On 25/04/2018 10:53 AM, Jiangli

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

Hi David, Thanks a lot for the review! > On Apr 24, 2018, at 11:17 PM, David Holmes wrote: > > cc'ing build-dev for the makefile change > > Hi Jiangli, > > On 25/04/2018 10:53 AM, Jiangli Zhou wrote: >> Please review the following changes that streamline the support

Re: RFR: 8201274: Launch Single-File Source-Code Programs

Hi John, I focused mainly on the native side, looks ok, except for a couple of minor issues. java.c 1320 const char *prop = "-Djdk.internal.javac.source="; 1321 size_t size = JLI_StrLen(prop) + JLI_StrLen(value) + 1; 1322 char *propValue = (char

Re: [10] RFR: 8202262: libjsig.so not linked with extra linker flags from configure

On Wed, 2018-04-25 at 08:48 -0700, Erik Joelsson wrote: > The change looks good. You will need to also get approval for pushing to > 10u. Right. Thanks for the review, Erik! Cheers, Severin > /Erik > > > On 2018-04-25 08:44, Severin Gehwolf wrote: > > Hi, > > > > Can I please get a review

Re: [10] RFR: 8202262: libjsig.so not linked with extra linker flags from configure

The change looks good. You will need to also get approval for pushing to 10u. /Erik On 2018-04-25 08:44, Severin Gehwolf wrote: Hi, Can I please get a review for this JDK 10 only fix, which prevents some extra link flags getting injected to the build of libjsig.so. JDK 11 is not affected.

[10] RFR: 8202262: libjsig.so not linked with extra linker flags from configure

Hi, Can I please get a review for this JDK 10 only fix, which prevents some extra link flags getting injected to the build of libjsig.so. JDK 11 is not affected. It appears to be a typo. It should be a rather low risk change and helps us reduce downstream carried patches. Bug:

Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

Hi All, Does anyone have an objection to pushing this tiny change in? It doesn't break anything, it fixes a build break on two supported platforms, and it seems like we never refresh the code from upstream. - Adam > I also advocate the source code fix, as Make isn't meant to use the sort of

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

Hi Jiangli, The code changes look good to me. I agree with David's comments about the test cases. Thanks - Ioi On 4/24/18 11:17 PM, David Holmes wrote: cc'ing build-dev for the makefile change Hi Jiangli, On 25/04/2018 10:53 AM, Jiangli Zhou wrote: Please review the following changes

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

Hello, I would prefer if the .tmp file was not deleted. That will make it easier to debug problems in the future. We have recently had reason to look at the contents of the files here to figure out if the generator ran properly. If leaving it around, then perhaps call it .raw or something

Re: RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated

On 24 April 2018 at 20:17, Kim Barrett wrote: >> On Apr 23, 2018, at 3:51 AM, Michal Vala wrote: >> >> Hi, >> >> following discussion "RFR: build pragma error with gcc 4.4.7"[1], I'm >> posting updated patch replacing deprecated readdir_r with readdir.

Re: RFR 8202210: jlink uses little-endian for big-endian cross-compilation targets

On 04/25/2018 12:08 PM, Alan Bateman wrote: > On 25/04/2018 10:06, Aleksey Shipilev wrote: >> I was doing the exercise of cross-compiling from x86_64 to most OpenJDK >> arches, and we have >> discovered the bug with endianness. Right now, compiling big-endian s390x >> target on little-endian >>

Re: RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated

On 04/24/2018 09:17 PM, Kim Barrett wrote: On Apr 23, 2018, at 3:51 AM, Michal Vala wrote: Hi, following discussion "RFR: build pragma error with gcc 4.4.7"[1], I'm posting updated patch replacing deprecated readdir_r with readdir. Bug ID is JDK-8179887 [2]. webrev:

Re: RFR 8202210: jlink uses little-endian for big-endian cross-compilation targets

Hi Aleksey, the fix looks good. Best Regards, Thomas On Wed, Apr 25, 2018 at 11:29 AM, Aleksey Shipilev wrote: > On 04/25/2018 11:14 AM, Magnus Ihse Bursie wrote: >>> diff -r 5d2da44780ac make/Images.gmk >>> --- a/make/Images.gmkWed Apr 25 10:38:07 2018 +0200 >>> +++

Re: strange configure error on Linux Mint 18.3

Sorry, that was wrong... here you go: Runnable configure script is not present Generating runnable configure script at /shared/projects/openjdk/jdk-jdk/output-fastdebug/configure-support/generated-configure.sh Using autoconf at /usr/bin/autoconf [autoconf (GNU Autoconf) 2.69] configure:

Re: RFR 8202210: jlink uses little-endian for big-endian cross-compilation targets

On 25/04/2018 10:06, Aleksey Shipilev wrote: Hi, I was doing the exercise of cross-compiling from x86_64 to most OpenJDK arches, and we have discovered the bug with endianness. Right now, compiling big-endian s390x target on little-endian x86_64 host produces the modules blob that cannot be

Re: strange configure error on Linux Mint 18.3

Hi Magnus, Ok I reverted the VM to the point before installing the dependencies. Here you go:Runnable configure script is not present Generating runnable configure script at /shared/projects/openjdk/jdk-jdk/output-fastdebug/configure-support/generated-configure.sh Using autoconf at

Re: RFR 8202210: jlink uses little-endian for big-endian cross-compilation targets

On 04/25/2018 11:14 AM, Magnus Ihse Bursie wrote: >> diff -r 5d2da44780ac make/Images.gmk >> --- a/make/Images.gmk    Wed Apr 25 10:38:07 2018 +0200 >> +++ b/make/Images.gmk    Wed Apr 25 10:55:04 2018 +0200 >> @@ -117,7 +117,7 @@ >> >>   JLINK_TOOL := $(JLINK) -J-Djlink.debug=true \ >>  

Re: strange configure error on Linux Mint 18.3

On 2018-04-24 14:50, Thomas Stüfe wrote: Hi all, Hi Thomas, What does the output from configure look like? The config.log file does not really help tell us how far into our configure script we've come. As John pointed out, the problem here was (likely) that you were missing the needed C

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

On 2018-04-25 08:17, David Holmes wrote: cc'ing build-dev for the makefile change Hi Jiangli, On 25/04/2018 10:53 AM, Jiangli Zhou wrote: Please review the following changes that streamline the support for application class data sharing by eliminating the requirement of using

Re: RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent - support on s390x

On 2018-04-25 10:14, Baesken, Matthias wrote: Hi Erik, thanks ! Can I consider this as a review ? In the meantime I created a webrev + bug : webrev for review  : http://cr.openjdk.java.net/~mbaesken/webrevs/8202200/ Looks good

Re: RFR 8202210: jlink uses little-endian for big-endian cross-compilation targets

On 2018-04-25 11:06, Aleksey Shipilev wrote: Hi, I was doing the exercise of cross-compiling from x86_64 to most OpenJDK arches, and we have discovered the bug with endianness. Right now, compiling big-endian s390x target on little-endian x86_64 host produces the modules blob that cannot be

RFR 8202210: jlink uses little-endian for big-endian cross-compilation targets

Hi, I was doing the exercise of cross-compiling from x86_64 to most OpenJDK arches, and we have discovered the bug with endianness. Right now, compiling big-endian s390x target on little-endian x86_64 host produces the modules blob that cannot be read on real s390x. It seems to be a simple

RE: RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent - support on s390x

Hi Erik, thanks ! Can I consider this as a review ? In the meantime I created a webrev + bug : webrev for review : http://cr.openjdk.java.net/~mbaesken/webrevs/8202200/ bug : https://bugs.openjdk.java.net/browse/JDK-8202200 Regards, Matthias From: Erik Joelsson

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

cc'ing build-dev for the makefile change Hi Jiangli, On 25/04/2018 10:53 AM, Jiangli Zhou wrote: Please review the following changes that streamline the support for application class data sharing by eliminating the requirement of using -XX:+UseAppCDS to enable the feature. The support for