Re: RFR(S) : 8219395 : integrate gcov w/ run-test

2019-02-20 Thread Erik Joelsson
Looks good. /Erik On 2019-02-20 10:27, Igor Ignatyev wrote: Hi Erik, thanks for your review, I've removed the commented lines and changed default_make_targets, http://cr.openjdk.java.net/~iignatyev//8219395/webrev.0-1/index.html is incremental webrev. Thanks, -- Igor On Feb 20, 2019, at

Re: RFR(S) : 8219395 : integrate gcov w/ run-test

2019-02-20 Thread Igor Ignatyev
Hi Erik, thanks for your review, I've removed the commented lines and changed default_make_targets, http://cr.openjdk.java.net/~iignatyev//8219395/webrev.0-1/index.html is incremental webrev. Thanks, -- Igor > On Feb 20,

Re: RFR: JDK-8212091 : Move native code under platform specific folders and files

2019-02-20 Thread Roger Riggs
Hi Alexander, Ok, thanks Note: code reviews of code going into the sandbox is not a substitute for code review when it is to be pushed to jdk/jdk. (The sandbox has much more informal rules for commits that are branch specific.) Roger On 02/19/2019 10:44 PM, Alexander Matveev wrote: Hi

Re: RFR(S) : 8219395 : integrate gcov w/ run-test

2019-02-20 Thread Erik Joelsson
Hello Igor, This looks pretty good. Just a few comments. In jib-profiles.js, the linux-x64 profile also builds docs-bundles, so if you base linux-x64-gcov on a clone of that there is some extra build work being done unnecessarily. I would recommend explicitly setting the default_make_targets

Re: Faster rebuild with GNU gold linker

2019-02-20 Thread Andrew Haley
On 2/20/19 7:54 AM, Ioi Lam wrote: > Ahh, I was using a debug build of lld. After making a release build, the > link time drops to 1.1 seconds! It's definitely better than gold. Right, exactly. And when you're working on just one file in HotSpot, this can make a very significant difference to

Re: Faster rebuild with GNU gold linker

2019-02-20 Thread Andrew Haley
On 2/20/19 6:35 AM, Ioi Lam wrote: > Thanks for the info. I didn't know that this has been discussed so > recently. Should have checked befor I posted. > > Anyway, I built the latest lld from GIT, but it's slower than gold on my > machine. Just linking libjvm.so is 5.8s vs 3.8s. This is

Re: RFR(T) : 8219132 : switch to jtreg4.2-b14

2019-02-20 Thread David Holmes
Hi Alan, On 20/02/2019 5:08 pm, Alan Bateman wrote: On 20/02/2019 00:34, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8219132/webrev.00/index.html 1 line changed: 0 ins; 0 del; 1 mod; Hi all, could you please review this one-liner which switch jtreg version to