On Wed, 13 Apr 2022 20:36:48 GMT, Andrey Turbanov wrote:
> Found various typos of expected: `exepected`, `exept`, `epectedly`,
> `expeced`, `Unexpeted`, etc.
test/jdk/java/lang/StackWalker/StackStreamTest.java line 218:
> 216: private static void equalsOrThrow(String label, List list,
>
On Mon, 4 Oct 2021 13:44:44 GMT, Richard Reingruber wrote:
> The following sentence in the JDWP Specification describing the Dispose
> command confuses resume with suspend [1]:
>
> All threads suspended by the thread-level **resume** command or the VM-level
> **resume** command are resumed
On Wed, 3 Feb 2021 20:17:03 GMT, Phil Race wrote:
>> This removes the JNF dependency from the jdk.hotspot.agent module.
>> The macro expansions are the same as already used in the Java desktop module
>> - which actually uses a macro
>> still but there there are hundreds of uses.
>> The function
On Thu, 28 Jan 2021 22:40:57 GMT, Phil Race wrote:
> This removes the JNF dependency from the jdk.hotspot.agent module.
> The macro expansions are the same as already used in the Java desktop module
> - which actually uses a macro
> still but there there are hundreds of uses.
> The function of t
On Fri, 29 Jan 2021 00:15:56 GMT, Chris Plummer wrote:
>> This removes the JNF dependency from the jdk.hotspot.agent module.
>> The macro expansions are the same as already used in the Java desktop module
>> - which actually uses a macro
>> still but there there are
On Thu, 28 Jan 2021 22:40:57 GMT, Phil Race wrote:
> This removes the JNF dependency from the jdk.hotspot.agent module.
> The macro expansions are the same as already used in the Java desktop module
> - which actually uses a macro
> still but there there are hundreds of uses.
> The function of t
On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Mon, 4 Jan 2021 09:25:55 GMT, Yasumasa Suenaga wrote:
> I got garbled exception message as following when I run `livenmethods` CLHSDB
> command:
>
> sun.jvm.hotspot.debugger.DebuggerException : ?w???W
>
> My Windows laptop is set Japanese Locale, garbled message was written in
> Japane
On Tue, 5 Jan 2021 02:40:29 GMT, Yasumasa Suenaga wrote:
>> Marked as reviewed by iklam (Reviewer).
>
> @iklam Thanks for your review!
>
>> I looked at a cases in the JDK code where
>> `Java_sun_security_pkcs11_wrapper_PKCS11_connect()` calls `FormatMessage()`.
>> It eventually passes the `cha
On Tue, 5 Jan 2021 00:41:11 GMT, Yasumasa Suenaga wrote:
> jdk.hotspot.agent do not have `FormatMessage()` call in other place.
> Did you say about whole JDK code? I haven't checked all of them, but some
> code (e.g. net_util_md.c) uses `JNU_ThrowByName()` which is provided by
> java.dll.
Yes,
On Mon, 4 Jan 2021 09:25:55 GMT, Yasumasa Suenaga wrote:
> I got garbled exception message as following when I run `livenmethods` CLHSDB
> command:
>
> sun.jvm.hotspot.debugger.DebuggerException : ?w???W
>
> My Windows laptop is set Japanese Locale, garbled message was written in
> Japane
On Wed, 9 Dec 2020 07:11:53 GMT, Hao Sun
wrote:
> Flag '-Wmisleading-indentation' was introduced since clang-10 [1] and
> gcc-6 [2]. Putting the code with proper indentations would suppress this
> warning.
>
> The main reason why test image build with gcc succeeds is that, clang
> and gcc might
On Tue, 29 Sep 2020 14:08:49 GMT, Monica Beckwith wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around R18
On Tue, 29 Sep 2020 14:03:57 GMT, Bernhard Urban-Forster
wrote:
>> Marked as reviewed by aph (Reviewer).
>
> @theRealAph okay, I've changed the string representation of `r18` to
> `"r18_tls"` on every platform.
> @plummercj thank you for your feedback. I've updated the copyright in
> mentione
On Thu, 24 Sep 2020 14:04:22 GMT, Monica Beckwith wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around R18
Hi Magnus,
Some minor mistakes below, but otherwise looks good. Also copyrights
need updating. I don't need to see another webrev.
thanks,
Chris
---
old/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/MethodHandlesAdapterBlob.java
2020-04-14 12:47:05.098156117 +0200
+++
new/src/j
Hi Magus,
I haven't looked at the changes yet, other to see that there are many
files touched, but after reading below (and only partly understanding
since I don't know this area well), I was wondering if this issue
wouldn't be better served with multiple passes made to fix the warnings.
Star
:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8208091/after_patch.txt
Thanks,
Severin
[1] http://mail.openjdk.java.net/pipermail/build-dev/2018-August/022819.html
-Original Message-
From: Chris Plummer
Sent: Monday, July 30, 2018 10:03 PM
To: Severin Gehwolf; Sharath Ballal; serviceab
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8196992
diff --git a/make/lib/Lib-jdk.jdwp.agent.gmk
b/make/lib/Lib-jdk.jdwp.agent.gmk
--- a/make/lib/Lib-jdk.jdwp.agent.gmk
+++ b/make/lib/Lib-jdk.jdwp.agent.gmk
@@ -43,7 +43,6 @@
OPTIMIZATION := LOW, \
CF
On 11/21/16 4:27 PM, Gustavo Romero wrote:
Hi Joe,
On 17-11-2016 19:33, joe darcy wrote:
Currently, optimization for building fdlibm is disabled, except for the
"solaris" OS target [1].
The reason for that is because historically the Solaris compilers have had
sufficient discipline and contro
On 11/17/16 1:33 PM, joe darcy wrote:
Hi Gustavo,
On 11/17/2016 10:31 AM, Gustavo Romero wrote:
Hi Joe,
Thanks a lot for your valuable comments.
On 17-11-2016 15:35, joe darcy wrote:
Currently, optimization for building fdlibm is disabled, except for
the
"solaris" OS target [1].
The reason
Hi Erik,
I can confirm the changes resolve the issues I was having. I looked at
the changes, but don't really have the background to comment on them.
thanks,
Chris
On 5/10/16 9:41 AM, Erik Joelsson wrote:
Hello,
When cross compiling, we compile a subset of the jdk for the build
host to be
Hi Erik,
I can confirm that this fixes the issue I was seeing.
thanks,
Chris
On 3/29/16 6:14 AM, Erik Joelsson wrote:
Hello,
The VarHandles change introduced a new gensrc step that crashes when
using gnumake 3.81. Newer versions of make seem to handle the
construct in that file. I have fou
Thanks Mikael!
Chris
On 12/7/15 3:22 PM, Mikael Vidstedt wrote:
Thumbs up!
Cheers,
Mikael
On 2015-12-07 14:27, Chris Plummer wrote:
Thanks David!
Can I get a second reviewer please?
thanks,
Chris
On 12/6/15 3:52 PM, David Holmes wrote:
Hi Chris,
On 5/12/2015 7:00 AM, Chris Plummer
Thanks David!
Can I get a second reviewer please?
thanks,
Chris
On 12/6/15 3:52 PM, David Holmes wrote:
Hi Chris,
On 5/12/2015 7:00 AM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8144677
http://cr.openjdk.java.net/~cjplummer/8144677
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8144677
http://cr.openjdk.java.net/~cjplummer/8144677/webrev.01/webrev/
Tested with JPRT with:
• "-testset hotspot"
• "-testset svc"
• "-testset chris" from the example custom testset provided in the CR.
• no t
ear before you push.
Dan
On 12/4/14 4:52 PM, David Holmes wrote:
Hi Chris,
Sorry I mis-directed you to send this one to build-dev, as it is a
hotspot test/Makefile fix it should be reviewed by hotspot-dev now cc'd.
Fix looks good to me.
Thanks,
David
On 5/12/2014 6:37 AM, Chris Plumm
test/Makefile fix it should be reviewed by hotspot-dev now
cc'd.
Fix looks good to me.
Thanks,
David
On 5/12/2014 6:37 AM, Chris Plummer wrote:
Please review the following fix to address JPRT timeout issues when
using -rtests to run hotspot JTReg tests on slow devices. The same
logic
has
Please review the following fix to address JPRT timeout issues when
using -rtests to run hotspot JTReg tests on slow devices. The same logic
has been in place for jdk/test/Makefile for a while now, so I just
copied from there to hotspot/test/Makefile.
https://bugs.openjdk.java.net/browse/JDK-8
Please review the following fix to allow running jdk jtreg tests using
JPRT -rtests. This is the same fix that his been in place in
hotspot/test/Makefile for a while now, so I just copied from there to
jdk/test/Makefile.
https://bugs.openjdk.java.net/browse/JDK-8066507
http://cr.openjdk.java.n
31 matches
Mail list logo
