If I only want jar.exe

2016-12-19 Thread Wang Weijun
Which target should I build with? Seems jdk.jartool is not enough. VM not complete. Also, I feel that jdk.jartool includes jdk.jartool-launchers, but java.base does not include java.base-launchers. Thanks Max

Re: On 8171135: Include javadoc on JarSigner API in security doc

2016-12-13 Thread Wang Weijun
quot;official" place > for exported, non-SE javadocs; otherwise it seems ok to me. > > --Sean > > On 12/12/16 9:50 PM, Wang Weijun wrote: >> Hi All >> >> I've create a new bug to include the javadoc of the non-Java SE JarSigner >> API into securit

Re: Official JDK used to build JDK9

2016-09-26 Thread Wang Weijun
My recent JPRT (an Oracle internal build tool) job shows checking Boot JDK version... java version "1.8.0" Java(TM) SE Runtime Environment (build 1.8.0-b132) Java HotSpot(TM) 64-Bit Server VM (build 25.0-b70, mixed mode) This is not OpenJDK. --Max > On Sep 26, 2016, at 6:22 PM, Andrew Haley

Re: conf vs. lib

2016-07-27 Thread Wang Weijun
> On Jul 27, 2016, at 7:13 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > > > On 27/07/2016 10:45, Wang Weijun wrote: >> : >> I suggest we create a new special -keystore value "<>" which acts >> like an alias of the cacerts file.

Re: conf vs. lib

2016-07-27 Thread Wang Weijun
> 在 2016年7月27日,17:15,Alan Bateman 写道: > > So have you decided one way or the other to have keytool support updating > caceerts without needing to specify the file path? That would be consistent > with leaving it in lib. If there are existing scripts that are

Re: RFR (L) JEP 280: Indify String Concatenation (integration)

2016-01-27 Thread Wang Weijun
> > Just out of curiosity, what does "indy" mean in this context? I have not > heard this expression and googling fails to bring up anything relevant. > At first I thought it's Russian, but then -- invokedynamic. --Max

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2016-01-14 Thread Wang Weijun
> On Jan 14, 2016, at 11:00 PM, Magnus Ihse Bursie > <magnus.ihse.bur...@oracle.com> wrote: > > On 2015-12-18 15:11, Wang Weijun wrote: >> Hi Vinnie >> >> I take a look and it includes a change for >> src/jdk.crypto.mscap

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2015-12-18 Thread Wang Weijun
Hi Vinnie I take a look and it includes a change for src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp in the Java_sun_security_mscapi_KeyStore_getKeyLength() function. It seems there is no sun.security.mscapi.KeyStore#getKeyLength on the java side. Is the function useless now?

Re: RFR 8141690: JDK-8133151 change to MakeJavaSecurity.java is not complete

2015-11-26 Thread Wang Weijun
> On Nov 25, 2015, at 11:04 PM, Sean Mullan wrote: > > The fix looks fine to me. For testing, can you create a test that uses a > custom java.security file with "#ifndef solaris-sparc" in it, and check > whether the property is used or not depending on what system is

Re: RFR 8141690: JDK-8133151 change to MakeJavaSecurity.java is not complete

2015-11-19 Thread Wang Weijun
Ding dong. > On Nov 9, 2015, at 3:35 PM, Wang Weijun <weijun.w...@oracle.com> wrote: > > Hi All > > Please review the code change at > > http://cr.openjdk.java.net/~weijun/8141690/webrev.00/ > > JDK-8133151 added support for "#ifdef solaris-sp

RFR 8141690: JDK-8133151 change to MakeJavaSecurity.java is not complete

2015-11-08 Thread Wang Weijun
Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8141690/webrev.00/ JDK-8133151 added support for "#ifdef solaris-sparc" but not "#ifndef solaris-spare". This is fixed and I also added "#else". How do I test the change? Thanks Max

Re: RFR 8074835/8074836: Resolve disabled warnings for libj2gss/libosxkrb5

2015-03-16 Thread Wang Weijun
On Mar 16, 2015, at 22:04, Magnus Ihse Bursie magnus.ihse.bur...@oracle.com wrote: On 2015-03-16 04:12, Wang Weijun wrote: Hi All Please review the change at http://cr.openjdk.java.net/~weijun/8074836/webrev.00/ Thanks Max Looks good to me. Thanks for fixing this. I'm

RFR 8074835/8074836: Resolve disabled warnings for libj2gss/libosxkrb5

2015-03-15 Thread Wang Weijun
Hi All Please review the change at http://cr.openjdk.java.net/~weijun/8074836/webrev.00/ Thanks Max

Re: Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

2015-03-05 Thread Wang Weijun
On Mar 6, 2015, at 01:55, Mandy Chung mandy.ch...@oracle.com wrote: For this review request, are you okay with this patch moving policytool and jarsigner tools to the new home? Yes. --Max

Re: Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

2015-03-04 Thread Wang Weijun
I am about to introduce 2 APIs into jdk.dev so that people can call functions of keytool and jarsigner directly. So what I am suggesting is - Create jdk.security.util - Move jarsigner, policytool to jdk.security.util - Create the new APIs in this module - Move keytool to jdk.security.util, it's

Re: Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

2015-03-04 Thread Wang Weijun
On Mar 5, 2015, at 11:25, Mandy Chung mandy.ch...@oracle.com wrote: On 3/4/2015 6:55 PM, Wang Weijun wrote: I am about to introduce 2 APIs into jdk.dev so that people can call functions of keytool and jarsigner directly. Are you referring to these 2 RFEs? https

Re: Building openjdk 8 on Mac OS X

2015-01-06 Thread Wang Weijun
Advices from Denis and Na (were in this thread, quoted at the end), and 1. MACOSX_DEPLOYMENT_TARGET is also necessary for make 2. I need an extra configure argument --with-tools-dir=/Applications/Xcode4.app/Contents/Developer/usr/bin 3. When applying Na's patch, make sure to use Xcode4.app

Re: visual-studio-community?

2014-11-14 Thread Wang Weijun
On Nov 13, 2014, at 21:48, Magnus Ihse Bursie magnus.ihse.bur...@oracle.com wrote: My guess is that the Visual Studio detection code in common/autoconf needs updating to locate the tools. Looks like vs2013 is not supported yet. If as Microsoft described the community version is

visual-studio-community?

2014-11-12 Thread Wang Weijun
I just read http://www.visualstudio.com/products/visual-studio-community-vs, which has Here’s how Visual Studio Community can be used in organizations: • An unlimited number of users within an organization can use Visual Studio Community for the following scenarios: in a classroom

Re: Building openjdk 8 on Mac OS X

2014-11-11 Thread Wang Weijun
No, I am able to build jdk9, but NOT jdk8. It seems the SDK (those .h files) no longer works with gcc in xcode4. --Max On Nov 12, 2014, at 12:13, Manas Thakur manasthaku...@gmail.com wrote: Hi Wang You were able to compile openjdk8 on Yosemite!! Can you please look into the error faced

Re: Building openjdk 8 on Mac OS X

2014-11-10 Thread Wang Weijun
On Nov 6, 2014, at 17:13, Magnus Ihse Bursie magnus.ihse.bur...@oracle.com wrote: A longer answer is that we're currently working on getting jdk9 to compile on Yosemite. Isn't it already compiling? I am on Yosemite and I can compile both openjdk and closedjdk successfully. Of course, I

Re: RFR (XS) 8061346: Source changes needed to build JDK 9 with Mac OS 9 'Maverics' and clang/Xcode 5.1.1

2014-10-23 Thread Wang Weijun
On Oct 24, 2014, at 02:12, Tim Bell tim.b...@oracle.com wrote: -macosx_x64_10.7-{product|fastdebug},\ +macosx_x64_10.9-{product|fastdebug},\ You have to remove the old line. Does this mean we cannot setup some clients with 10.7 and some 10.9? --Max

Re: incremental builds in the new JDK9 modular build

2014-08-20 Thread Wang Weijun
On Aug 21, 2014, at 5:37, Mandy Chung mandy.ch...@oracle.com wrote: On 8/20/2014 1:26 PM, Phil Race wrote: I understood we now build individual modules so when I touched one java source file in the desktop module I expected to see only that one module rebuilt but I see this :-

Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-07-28 Thread Wang Weijun
On 2014-07-28 03:44, Wang Weijun wrote: Webrev updated at http://cr.openjdk.java.net/~weijun/6997010/webrev.01/ New test CheckSecurityProvider.java, and updates to MakeJavaSecurity.addPackages(). Thanks Max On Jul 25, 2014, at 22:44, Wang Weijun weijun.w...@oracle.com

Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-07-27 Thread Wang Weijun
Webrev updated at http://cr.openjdk.java.net/~weijun/6997010/webrev.01/ New test CheckSecurityProvider.java, and updates to MakeJavaSecurity.addPackages(). Thanks Max On Jul 25, 2014, at 22:44, Wang Weijun weijun.w...@oracle.com wrote: On Jul 25, 2014, at 22:30, Sean Mullan sean.mul

Re: RFR 8047765: Generate blacklist.certs in build

2014-07-04 Thread Wang Weijun
On Jul 2, 2014, at 15:02, Alan Bateman alan.bate...@oracle.com wrote: Should blacklisted.certs.pem also move into the make tree? I think there has been an effort to put data files that are used for generating something in the build into the make tree. Someone from the build will probably

Re: RFR 8047765: Generate blacklist.certs in build

2014-07-02 Thread Wang Weijun
On Jul 2, 2014, at 15:02, Alan Bateman alan.bate...@oracle.com wrote: On touch the tool then does this happen for other tools too? I assume it does, in which case you could submit a build bug to improve this. Yes, it does. https://bugs.openjdk.java.net/browse/JDK-8049024 filed. --Max

Re: RFR 8047765: Generate blacklist.certs in build

2014-07-02 Thread Wang Weijun
On Jul 2, 2014, at 20:50, Sean Mullan sean.mul...@oracle.com wrote: On 07/02/2014 01:02 AM, Wang Weijun wrote: On Jul 2, 2014, at 12:48, David Holmes david.hol...@oracle.com wrote: 73 // Output sorted for eye pleasure. ?? eye pleasure Well, it's easy for a human to locate

RFR 8047765: Generate blacklist.certs in build

2014-07-01 Thread Wang Weijun
Hi All Please review the fix at http://cr.openjdk.java.net/~weijun/8047765/webrev.00/ where the generation of blacklisted.certs is moved from developer-manual to build-auto. I copied the mechanisms from GENDATA_HTML32DTD. One thing I am not sure about is that if I update the tool a little,

Re: RFR 8047765: Generate blacklist.certs in build

2014-07-01 Thread Wang Weijun
On Jul 2, 2014, at 12:48, David Holmes david.hol...@oracle.com wrote: 73 // Output sorted for eye pleasure. ?? eye pleasure Well, it's easy for a human to locate one from a sorted output. Or maybe it's because the old one is sorted and I don't want the new one looks ugly. --Max

xcodebuild necessary on Mac?

2014-05-28 Thread Wang Weijun
I just installed a brand new Mavericks and go straight to 'bash configure' for jdk9/dev. A dialog pops out asking me to choose between installing Xcode and downloading command line tools. I choose the latter and after they are installed I run configure again, and it shows Failed to determine

Re: xcodebuild necessary on Mac?

2014-05-28 Thread Wang Weijun
On May 28, 2014, at 23:43, David DeHaven david.deha...@oracle.com wrote: I just installed a brand new Mavericks and go straight to 'bash configure' for jdk9/dev. A dialog pops out asking me to choose between installing Xcode and downloading command line tools. I choose the latter and

make reconfigure?

2014-04-03 Thread Wang Weijun
Every now and then, running make asks me to reconfigure so I call configure again. Recently it is showing ERROR: /space/repos/jdk9/dev/build/macosx-x86_64-normal-server-fastdebug/spec.gmk is not up to date. Please rerun configure! Easiest way to do this is by running 'make reconfigure'.

Re: get_source.sh from ssh://host//path

2014-04-03 Thread Wang Weijun
It looks like the problem is at common/bin/hgforest.sh: 222pull_newrepo=`echo ${pull_base}/${i} | sed -e 's@\([^:]/\)//*@\1@g'` It tries to substitute all repeated slashes into one unless it's after a colon. *Mike*: Is that line really useful or just a beautifier? --Max On Apr

Re: [PATCH] Handle alternative Kerberos credential cache locations

2014-01-14 Thread Wang Weijun
Hi Elliott Great to see this again. I’ll come back to this later. There are some urgent issues I have to deal with at this moment. I’ll also need to get those legal advices regarding pkg.m4 etc. Thanks Max On Jan 15, 2014, at 7:01, Elliott Baron eba...@redhat.com wrote: Hi Max, I have

Re: J2SE est mort, vive Java SE!

2013-11-27 Thread Wang Weijun
What security libs have j2 in their names? libj2gss.so etc. --Max