Integrated: 8286562: GCC 12 reports some compiler warnings

2022-05-27 Thread Yasumasa Suenaga
On Wed, 11 May 2022 05:58:31 GMT, Yasumasa Suenaga wrote: > I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on > Fedora 36. > As you can see, the warnings spreads several areas. Let me know if I should > separate them by area. > > * -Wstringop-ov

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v10]

2022-05-26 Thread Yasumasa Suenaga
Thread*) const' at > /home/ysuenaga/github-forked/jdk/src/hotspot/share/classfile/bytecodeAssembler.cpp:85:26: Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision: Fix comments - Changes: - all: ht

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v9]

2022-05-26 Thread Yasumasa Suenaga
On Thu, 26 May 2022 03:48:31 GMT, Kim Barrett wrote: >> Yasumasa Suenaga has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Change Array::data() implementation >> - Avoid stringop-overflow warning in jfr

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v8]

2022-05-25 Thread Yasumasa Suenaga
On Wed, 25 May 2022 01:50:57 GMT, Kim Barrett wrote: >> Yasumasa Suenaga has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 11 commits: >> >> - Merge remote-tracking branch 'upstream/master' into gcc12-w

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v9]

2022-05-25 Thread Yasumasa Suenaga
Thread*) const' at > /home/ysuenaga/github-forked/jdk/src/hotspot/share/classfile/bytecodeAssembler.cpp:85:26: Yasumasa Suenaga has updated the pull request incrementally with two additional commits since the last revision: - Change Array::data() implementation - Avoid stringop-overflow

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v5]

2022-05-22 Thread Yasumasa Suenaga
On Sun, 22 May 2022 05:00:21 GMT, Kim Barrett wrote: >> I guess GCC cannot understand `assert(dest != NULL` immediately preceding it. >> >> >> In file included from >> /home/ysuenaga/github-forked/jdk/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdLoadBarrier.inline.hpp:33,

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v5]

2022-05-22 Thread Yasumasa Suenaga
On Sun, 22 May 2022 03:15:20 GMT, Kim Barrett wrote: >> Like the others, it is caused by `Array::at_put()`. >> >> >> In file included from >> /home/ysuenaga/github-forked/jdk/src/hotspot/share/oops/annotations.hpp:28, >> from >>

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v8]

2022-05-22 Thread Yasumasa Suenaga
Thread*) const' at > /home/ysuenaga/github-forked/jdk/src/hotspot/share/classfile/bytecodeAssembler.cpp:85:26: Yasumasa Suenaga has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - Merge remote-tracking branch 'upstream

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v7]

2022-05-21 Thread Yasumasa Suenaga
On Tue, 17 May 2022 13:32:42 GMT, Yasumasa Suenaga wrote: >> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 >> on Fedora 36. >> As you can see, the warnings spreads several areas. Let me know if I should >> separate them by area. >

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v5]

2022-05-17 Thread Yasumasa Suenaga
On Tue, 17 May 2022 04:52:44 GMT, Kim Barrett wrote: >> src/hotspot/share/opto/memnode.cpp line 1413: >> >>> 1411:bt == T_BYTE|| bt == T_SHORT || >>> 1412:bt == T_INT || bt == T_LONG, "wrong type = >>> %s", type2name(bt)); >>> 1413:

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v5]

2022-05-17 Thread Yasumasa Suenaga
On Tue, 17 May 2022 03:06:49 GMT, Kim Barrett wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert change for java.c , parse_manifest.c , LinuxPackage.c > > src/hotspot

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v7]

2022-05-17 Thread Yasumasa Suenaga
Thread*) const' at > /home/ysuenaga/github-forked/jdk/src/hotspot/share/classfile/bytecodeAssembler.cpp:85:26: Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision: revert changes for memnode.cpp and type.cpp - Chang

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v5]

2022-05-17 Thread Yasumasa Suenaga
On Tue, 17 May 2022 03:14:05 GMT, Kim Barrett wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert change for java.c , parse_manifest.c , LinuxPackage.c > > src/hotspot/share/c

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v6]

2022-05-17 Thread Yasumasa Suenaga
Thread*) const' at > /home/ysuenaga/github-forked/jdk/src/hotspot/share/classfile/bytecodeAssembler.cpp:85:26: Yasumasa Suenaga has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Add assert to check the range

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v5]

2022-05-17 Thread Yasumasa Suenaga
On Tue, 17 May 2022 03:02:55 GMT, Kim Barrett wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert change for java.c , parse_manifest.c , LinuxPackage.c > > src/hotspot/share

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v5]

2022-05-17 Thread Yasumasa Suenaga
On Tue, 17 May 2022 01:43:25 GMT, Kim Barrett wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert change for java.c , parse_manifest.c , LinuxPackage.c > > src/hotspot/share

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v4]

2022-05-16 Thread Yasumasa Suenaga
On Thu, 12 May 2022 11:02:02 GMT, Magnus Ihse Bursie wrote: >> Thanks for all to review this PR! I think we should separate this issue as >> following: >> >> * Suppress warnings >> * make/modules/java.desktop/lib/Awt2dLibraries.gmk >> * src/hotspot/share/classfile/bytecodeAssembler.cpp

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v5]

2022-05-13 Thread Yasumasa Suenaga
On Fri, 13 May 2022 10:02:30 GMT, Yasumasa Suenaga wrote: >> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 >> on Fedora 36. >> As you can see, the warnings spreads several areas. Let me know if I should >> separate them by area. >

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v5]

2022-05-13 Thread Yasumasa Suenaga
Thread*) const' at > /home/ysuenaga/github-forked/jdk/src/hotspot/share/classfile/bytecodeAssembler.cpp:85:26: Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision: Revert change for java.c , parse_manifest.c , LinuxPackage.c

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v4]

2022-05-11 Thread Yasumasa Suenaga
On Thu, 12 May 2022 01:27:30 GMT, Yasumasa Suenaga wrote: >> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 >> on Fedora 36. >> As you can see, the warnings spreads several areas. Let me know if I should >> separate them by area. >

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v2]

2022-05-11 Thread Yasumasa Suenaga
On Wed, 11 May 2022 13:47:43 GMT, Kim Barrett wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Avoid pragma error in before GCC 12 > > src/jdk.jpackage/linux/native/appla

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v4]

2022-05-11 Thread Yasumasa Suenaga
Thread*) const' at > /home/ysuenaga/github-forked/jdk/src/hotspot/share/classfile/bytecodeAssembler.cpp:85:26: Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision: Calculate char offset before realloc() - Changes: -

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v2]

2022-05-11 Thread Yasumasa Suenaga
On Wed, 11 May 2022 13:43:55 GMT, Kim Barrett wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Avoid pragma error in before GCC 12 > > src/java.base/unix/native/libjli/java_m

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v3]

2022-05-11 Thread Yasumasa Suenaga
Thread*) const' at > /home/ysuenaga/github-forked/jdk/src/hotspot/share/classfile/bytecodeAssembler.cpp:85:26: Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision: Use return value from JLI_Snprintf - Changes: -

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v2]

2022-05-11 Thread Yasumasa Suenaga
On Wed, 11 May 2022 14:27:27 GMT, Kim Barrett wrote: >> src/java.base/share/native/libjli/java.c line 1629: >> >>> 1627: const char *arg = jargv[i]; >>> 1628: if (arg[0] == '-' && arg[1] == 'J') { >>> 1629: *nargv++ = (arg[2] == '\0') ? NULL : JLI_StringDup(arg +

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v2]

2022-05-11 Thread Yasumasa Suenaga
On Wed, 11 May 2022 13:35:43 GMT, Kim Barrett wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Avoid pragma error in before GCC 12 > > src/hotspot/share/utilities/compilerWarn

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v2]

2022-05-11 Thread Yasumasa Suenaga
On Wed, 11 May 2022 19:11:16 GMT, Phil Race wrote: >> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 462: >> >>> 460:HARFBUZZ_DISABLED_WARNINGS_gcc := type-limits >>> missing-field-initializers strict-aliasing >>> 461:HARFBUZZ_DISABLED_WARNINGS_CXX_gcc := reorder >>>

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v2]

2022-05-11 Thread Yasumasa Suenaga
On Wed, 11 May 2022 12:48:38 GMT, Alan Bateman wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Avoid pragma error in before GCC 12 > > src/java.base/unix/native/libjli/java_m

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v2]

2022-05-11 Thread Yasumasa Suenaga
On Wed, 11 May 2022 08:40:21 GMT, Yasumasa Suenaga wrote: >> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 >> on Fedora 36. >> As you can see, the warnings spreads several areas. Let me know if I should >> separate them by area. >

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v2]

2022-05-11 Thread Yasumasa Suenaga
On Wed, 11 May 2022 11:48:00 GMT, Magnus Ihse Bursie wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Avoid pragma error in before GCC 12 > > The harfbuzz disabled warnin

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v2]

2022-05-11 Thread Yasumasa Suenaga
Thread*) const' at > /home/ysuenaga/github-forked/jdk/src/hotspot/share/classfile/bytecodeAssembler.cpp:85:26: Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision: Avoid pragma error in before GCC 12 - Changes: -

RFR: 8286562: GCC 12 reports some compiler warnings

2022-05-11 Thread Yasumasa Suenaga
I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on Fedora 36. As you can see, the warnings spreads several areas. Let me know if I should separate them by area. * -Wstringop-overflow * src/hotspot/share/oops/array.hpp *

Integrated: 8286105: SourceRevision.gmk should respect GIT variable

2022-05-04 Thread Yasumasa Suenaga
On Wed, 4 May 2022 03:06:44 GMT, Yasumasa Suenaga wrote: > We can specify `git` binary via `GIT` in configure script, but it does not > affect in SourceRevision.gmk . This pull request has now been integrated. Changeset: d43ae723 Author:Yasumasa Suenaga URL:

RFR: 8286105: SourceRevision.gmk should respect GIT variable

2022-05-03 Thread Yasumasa Suenaga
We can specify `git` binary via `GIT` in configure script, but it does not affect in SourceRevision.gmk . - Commit messages: - 8286105: SourceRevision.gmk should respect GIT variable Changes: https://git.openjdk.java.net/jdk/pull/8526/files Webrev:

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v5]

2022-03-28 Thread Yasumasa Suenaga
On Mon, 28 Feb 2022 16:22:25 GMT, Christian Hagedorn wrote: >> When printing the native stack trace on Linux (mostly done for hs_err >> files), it only prints the method with its parameters and a relative offset >> in the method: >> >> Stack: [0x7f6e01739000,0x7f6e0183a000],

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-27 Thread Yasumasa Suenaga
On Tue, 25 Jan 2022 15:10:11 GMT, Christian Hagedorn wrote: >> When printing the native stack trace on Linux (mostly done for hs_err >> files), it only prints the method with its parameters and a relative offset >> in the method: >> >> Stack: [0x7f6e01739000,0x7f6e0183a000],

Integrated: 8279644: hsdis may not work when it was built with --with-binutils=system

2022-01-10 Thread Yasumasa Suenaga
On Sat, 8 Jan 2022 02:00:27 GMT, Yasumasa Suenaga wrote: > [JDK-8277089](https://bugs.openjdk.java.net/browse/JDK-8277089) (PR #6378 ) > introduced the feature to build hsdis with binutils which is provided by the > system, however it may not work when it was build with --with-binuti

RFR: 8279644: hsdis may not work when it was built with --with-binutils=system

2022-01-07 Thread Yasumasa Suenaga
[JDK-8277089](https://bugs.openjdk.java.net/browse/JDK-8277089) (PR #6378 ) introduced the feature to build hsdis with binutils which is provided by the system, however it may not work when it was build with --with-binutils=system. We can see the following message when the problem happens. I

Internal Error in build process on Windows

2021-12-18 Thread Yasumasa Suenaga
Hi all, I use Visual Studio 2022 (17.0.4) on WSL 1 Ubuntu to build OpenJDK for Windows on Windows 11. I sometimes saw Internal Error in masm as following: ``` Assembling: c:\github-forked\jdk\src\jdk.incubator.vector\windows\native\libjsvml\jsvml_d_cos_windows_x86.S MASM : fatal error

Integrated: 8277370: configure script cannot distinguish WSL version

2021-11-19 Thread Yasumasa Suenaga
On Thu, 18 Nov 2021 07:17:07 GMT, Yasumasa Suenaga wrote: > configure script distinguish WSL version if it is run on WSL. It is assumed > WSL 2 if `/run/WSL` exists. > However it exists in spite of WSL 1 on Windows 11 at least. We need to check > it with other method. >

Re: RFR: 8277370: configure script cannot distinguish WSL version [v2]

2021-11-18 Thread Yasumasa Suenaga
On Thu, 18 Nov 2021 14:03:33 GMT, Erik Joelsson wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use $GREP to check /proc/interrupts > > make/autoconf/basic_windows.m4 line 39: &g

Re: RFR: 8277370: configure script cannot distinguish WSL version [v2]

2021-11-18 Thread Yasumasa Suenaga
ws/wsl/faq#does-wsl-2-use-hyper-v--will-it-be-available-on-windows-10-home- Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision: Use $GREP to check /proc/interrupts - Changes: - all: https://git.openjdk.java.net/j

RFR: 8277370: configure script cannot distinguish WSL version

2021-11-18 Thread Yasumasa Suenaga
configure script distinguish WSL version if it is run on WSL. It is assumed WSL 2 if `/run/WSL` exists. However it exists in spite of WSL 1 on Windows 11 at least. We need to check it with other method. The method to distinguish WSL version has been discussed on

Integrated: 8277089: Use system binutils to build hsdis

2021-11-16 Thread Yasumasa Suenaga
On Sat, 13 Nov 2021 08:08:53 GMT, Yasumasa Suenaga wrote: > hsdis requires binutils source tree for building. Most of Linux distros > provide binutils package. (e.g. binutils-devel from Fedora, binutils-dev from > Ubuntu) > It would be nice to be able to use them like z

Re: RFR: 8277089: Use system binutils to build hsdis

2021-11-15 Thread Yasumasa Suenaga
On Mon, 15 Nov 2021 10:23:48 GMT, Magnus Ihse Bursie wrote: >> hsdis requires binutils source tree for building. Most of Linux distros >> provide binutils package. (e.g. binutils-devel from Fedora, binutils-dev >> from Ubuntu) >> It would be nice to be able to use them like zlib and lcms. >>

Re: RFR: 8277089: Use system binutils to build hsdis [v2]

2021-11-15 Thread Yasumasa Suenaga
db.git;a=commit;f=bfd/bfd-in2.h;h=618265039f697eab9e72bb58b95fc2d32925df58 > > Please see [JDK-8244819](https://bugs.openjdk.java.net/browse/JDK-8244819) > why we need version check. Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision: Refactori

RFR: 8277089: Use system binutils to build hsdis

2021-11-13 Thread Yasumasa Suenaga
hsdis requires binutils source tree for building. Most of Linux distros provide binutils package. (e.g. binutils-devel from Fedora, binutils-dev from Ubuntu) It would be nice to be able to use them like zlib and lcms. Unfortunately bfdver.h would not be provided because it is not included

Integrated: 8276672: Cannot build hsdis on WSL

2021-11-10 Thread Yasumasa Suenaga
On Fri, 5 Nov 2021 03:03:55 GMT, Yasumasa Suenaga wrote: > JDK-8275128 introduced new Makefile for hsdis to integrate it to normal build > system, however it does not work on WSL 1 Ubuntu 20.04 and MinGW from Ubuntu. > > Hsdis.gmk has two problems: > > 1. MinGW version is fi

Re: RFR: 8276672: Cannot build hsdis on WSL [v2]

2021-11-09 Thread Yasumasa Suenaga
On Wed, 10 Nov 2021 00:55:13 GMT, Yasumasa Suenaga wrote: >> JDK-8275128 introduced new Makefile for hsdis to integrate it to normal >> build system, however it does not work on WSL 1 Ubuntu 20.04 and MinGW from >> Ubuntu. >> >> Hsdis.gmk has two problems: &g

Re: RFR: 8276672: Cannot build hsdis on WSL [v3]

2021-11-09 Thread Yasumasa Suenaga
is located at /usr/$MINGW_BASE/sys-root > > I tested this change on WSL only, so it is appreciate to review on Cygwin. Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision: Remove SYSROOT_FLAGS - Changes: - all:

Re: RFR: 8276672: Cannot build hsdis on WSL [v2]

2021-11-09 Thread Yasumasa Suenaga
is located at /usr/$MINGW_BASE/sys-root > > I tested this change on WSL only, so it is appreciate to review on Cygwin. Yasumasa Suenaga has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the me

Re: RFR: 8276672: Cannot build hsdis on WSL

2021-11-09 Thread Yasumasa Suenaga
On Tue, 9 Nov 2021 15:06:05 GMT, Magnus Ihse Bursie wrote: >> JDK-8275128 introduced new Makefile for hsdis to integrate it to normal >> build system, however it does not work on WSL 1 Ubuntu 20.04 and MinGW from >> Ubuntu. >> >> Hsdis.gmk has two problems: >> >> 1. MinGW version is fixed to

Integrated: 8276841: Add support for Visual Studio 2022

2021-11-09 Thread Yasumasa Suenaga
On Tue, 9 Nov 2021 06:36:53 GMT, Yasumasa Suenaga wrote: > Now OpenJDK supports VS 2017 and 2019 for building. > VS 2022 has been released in Nov. 2021, so I want to add VS 2022 to build > system for Windows. This pull request has now been integrated. Changeset: f65db88b Author:

RFR: 8276841: Add support for Visual Studio 2022

2021-11-09 Thread Yasumasa Suenaga
Now OpenJDK supports VS 2017 and 2019 for building. VS 2022 has been released in Nov. 2021, so I want to add VS 2022 to build system for Windows. - Commit messages: - 8276841: Add support for Visual Studio 2022 Changes: https://git.openjdk.java.net/jdk/pull/6304/files Webrev:

RFR: 8276672: Cannot build hsdis on WSL

2021-11-04 Thread Yasumasa Suenaga
JDK-8275128 introduced new Makefile for hsdis to integrate it to normal build system, however it does not work on WSL 1 Ubuntu 20.04 and MinGW from Ubuntu. Hsdis.gmk has two problems: 1. MinGW version is fixed to "9.2.0" 2. Assumes sysroot for MinGW is located at /usr/$MINGW_BASE/sys-root I

Integrated: 8270083: -Wnonnull errors happen with GCC 11.1.1

2021-07-09 Thread Yasumasa Suenaga
On Thu, 8 Jul 2021 09:42:43 GMT, Yasumasa Suenaga wrote: > I attempted to build OpenJDK on Fedora 34 with gcc-11.1.1-3.fc34.x86_64, but > I saw following errors: > > > In file included from > /home/ysuenaga/github-forked/jdk/src/hotspot/share/runtime/f

Re: RFR: 8270083: -Wnonnull errors happen with GCC 11.1.1

2021-07-09 Thread Yasumasa Suenaga
On Thu, 8 Jul 2021 18:02:55 GMT, Erik Joelsson wrote: >> I attempted to build OpenJDK on Fedora 34 with gcc-11.1.1-3.fc34.x86_64, but >> I saw following errors: >> >> >> In file included from >> /home/ysuenaga/github-forked/jdk/src/hotspot/share/runtime/frame.inline.hpp:42, >>

Re: RFR: 8270083: -Wnonnull errors happen with GCC 11.1.1

2021-07-08 Thread Yasumasa Suenaga
On Thu, 8 Jul 2021 09:42:43 GMT, Yasumasa Suenaga wrote: > I attempted to build OpenJDK on Fedora 34 with gcc-11.1.1-3.fc34.x86_64, but > I saw following errors: > > > In file included from > /home/ysuenaga/github-forked/jdk/src/hotspot/share/runtime/f

RFR: 8270083: -Wnonnull errors happen with GCC 11.1.1

2021-07-08 Thread Yasumasa Suenaga
I attempted to build OpenJDK on Fedora 34 with gcc-11.1.1-3.fc34.x86_64, but I saw following errors: In file included from /home/ysuenaga/github-forked/jdk/src/hotspot/share/runtime/frame.inline.hpp:42, from

Re: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)

2021-06-16 Thread Yasumasa Suenaga
On 2021/06/17 10:31, David Holmes wrote: Hi Yasumasa, On 17/06/2021 11:28 am, Yasumasa Suenaga wrote: Hi, I can build current HEAD of upstream (02c9bf087e5) successfully both fastdebug and release build. I use VS 2019 (16.10.1) on WSL 1 Ubuntu 20.04 . We use 16.9.3 with no problem

Re: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)

2021-06-16 Thread Yasumasa Suenaga
Hi, I can build current HEAD of upstream (02c9bf087e5) successfully both fastdebug and release build. I use VS 2019 (16.10.1) on WSL 1 Ubuntu 20.04 . Thanks, Yasumasa On 2021/06/17 10:04, David Holmes wrote: Hi Vitaly, On 17/06/2021 9:47 am, Vitaly Provodin wrote: Hi all, Building

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-08 Thread Yasumasa Suenaga
On Mon, 8 Mar 2021 19:30:17 GMT, Sergey Bylokhov wrote: >> It seems to be fine not to use UNIX epoch at first glance as long as we can >> know the timing of events, but I'm not sure (Thus I rewrote to comply with >> the original code). So I want to hear from the others. > > Did you check via

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-07 Thread Yasumasa Suenaga
On Mon, 8 Mar 2021 06:37:07 GMT, Thomas Stuefe wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactoring > > src/jdk.accessibility/windows/native/common/AccessBridgeDebug.c

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-07 Thread Yasumasa Suenaga
On Mon, 8 Mar 2021 06:34:26 GMT, Thomas Stuefe wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactoring > > src/jdk.accessibility/windows/native/common/AccessBri

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge

2021-03-07 Thread Yasumasa Suenaga
On Sun, 7 Mar 2021 22:00:41 GMT, Sergey Bylokhov wrote: >> Yes, including c++ standard library headers like means you need to >> deal with C++ exceptions thrown from library functions, and the code needs >> to be compiled with unwind capabilities. If its not switched on, and a C++ >>

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-07 Thread Yasumasa Suenaga
2\2019\commun~1\vc\tools\msvc\1428~1.299\include\string > > `/EHsc` has been already passed in other makefiles, and also > AccessBridgeDebug.cpp uses some STL classes (e.g. `chrono` namespace). So > `/EHsc` is a solution for this problem. Yasumasa Suenaga has updated the pull request incre

RFR: 8263136: C4530 was reported from VS 2019 at access bridge

2021-03-06 Thread Yasumasa Suenaga
I saw C4530 with VS 2019 (16.9.0) as following (on Japanese locale): AccessBridgeDebug.cpp メモ: インクルード ファイル: d:\github-forked\jdk\src\jdk.accessibility\windows\native\common\AccessBridgeDebug.h : c:\progra~2\micros~2\2019\commun~1\vc\tools\msvc\1428~1.299\include\ostream(611): error C2220:

Integrated: 8258925: configure script failed on WSL

2021-01-11 Thread Yasumasa Suenaga
On Thu, 24 Dec 2020 08:04:34 GMT, Yasumasa Suenaga wrote: > I ran configure script on WSL 1, but it failed as below: > > $ bash configure --enable-debug --with-boot-jdk=/mnt/d/Java/jdk-15.0.1 > > : > > configure: Found potential Boot JDK using configure arguments >

Re: RFR: 8258925: configure script failed on WSL [v4]

2021-01-09 Thread Yasumasa Suenaga
On Sat, 9 Jan 2021 09:22:40 GMT, David Holmes wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactoring > > I _think_ this is right but to be honest the multitude of variables a

Re: RFR: 8258925: configure script failed on WSL [v5]

2021-01-09 Thread Yasumasa Suenaga
s as > "/mnt/d/Java/jdk-15.0.1/bin/java", can not be found. > configure: error: Cannot locate /mnt/d/Java/jdk-15.0.1/bin/java > configure exiting with result code 1 > > `fixpath.sh` attempts to run `$PATHTOOL` with `.exe` if it fails with > original path, but `.exe` woul

Re: RFR: 8258925: configure script failed on WSL [v4]

2021-01-09 Thread Yasumasa Suenaga
On Sat, 9 Jan 2021 09:21:20 GMT, David Holmes wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactoring > > make/scripts/fixpath.sh line 155: > >> 153: if [[ $

Re: RFR: 8258925: configure script failed on WSL [v3]

2021-01-08 Thread Yasumasa Suenaga
On Fri, 8 Jan 2021 14:57:16 GMT, Erik Joelsson wrote: > In this case, I think introducing a variable is well worth it as it means we > can eliminate a very common and unnecessary call to $PATHTOOL. Ok, I pushed new commit to use `$unixpath` instead of calling `$PATHTOOL`. Could you review

Re: RFR: 8258925: configure script failed on WSL [v4]

2021-01-08 Thread Yasumasa Suenaga
s as > "/mnt/d/Java/jdk-15.0.1/bin/java", can not be found. > configure: error: Cannot locate /mnt/d/Java/jdk-15.0.1/bin/java > configure exiting with result code 1 > > `fixpath.sh` attempts to run `$PATHTOOL` with `.exe` if it fails with > original path, but `.exe` woul

Re: RFR: 8258925: configure script failed on WSL [v3]

2021-01-08 Thread Yasumasa Suenaga
On Fri, 8 Jan 2021 14:15:08 GMT, Erik Joelsson wrote: >> Hi Yasumasa, >> >> Okay I see the problem case now, and the latest fix seems to fix things in a >> way that makes sense to me now. We still need to wait to see what Magnus or >> Erik think though. >> >> Thanks, >> David > > I initially

Re: RFR: 8258925: configure script failed on WSL

2021-01-08 Thread Yasumasa Suenaga
On Fri, 8 Jan 2021 07:34:03 GMT, Yasumasa Suenaga wrote: >> I ran configure script on WSL 1, but it failed as below: >> >> $ bash configure --enable-debug --with-boot-jdk=/mnt/d/Java/jdk-15.0.1 >> >> : >> >> configure: Found potential Boot

Re: RFR: 8258925: configure script failed on WSL [v3]

2021-01-08 Thread Yasumasa Suenaga
s as > "/mnt/d/Java/jdk-15.0.1/bin/java", can not be found. > configure: error: Cannot locate /mnt/d/Java/jdk-15.0.1/bin/java > configure exiting with result code 1 > > `fixpath.sh` attempts to run `$PATHTOOL` with `.exe` if it fails with > original path, but `.exe` woul

Re: RFR: 8258925: configure script failed on WSL

2021-01-07 Thread Yasumasa Suenaga
On Thu, 24 Dec 2020 08:04:34 GMT, Yasumasa Suenaga wrote: > I ran configure script on WSL 1, but it failed as below: > > $ bash configure --enable-debug --with-boot-jdk=/mnt/d/Java/jdk-15.0.1 > > : > > configure: Found potential Boot JDK using configure arguments >

Re: RFR: 8258925: configure script failed on WSL [v2]

2021-01-07 Thread Yasumasa Suenaga
On Fri, 8 Jan 2021 06:23:35 GMT, David Holmes wrote: >> I pushed to new commit to save original `$path` and restore it later if the >> path not found. >> Could you review again? > > Sorry but I'm really not following exactly what the problem is and thus the > solution. How does setting path

Re: RFR: 8258925: configure script failed on WSL [v2]

2021-01-07 Thread Yasumasa Suenaga
On Fri, 8 Jan 2021 04:27:16 GMT, David Holmes wrote: >> Yasumasa Suenaga has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contain

Re: RFR: 8258925: configure script failed on WSL [v2]

2021-01-07 Thread Yasumasa Suenaga
s as > "/mnt/d/Java/jdk-15.0.1/bin/java", can not be found. > configure: error: Cannot locate /mnt/d/Java/jdk-15.0.1/bin/java > configure exiting with result code 1 > > `fixpath.sh` attempts to run `$PATHTOOL` with `.exe` if it fails with > original path, but `.exe` woul

Re: Cannot build new jdk on Windows after commit d29c78d

2021-01-07 Thread Yasumasa Suenaga
Hi, I use WSL 1 to build OpenJDK on Windows 10. However, it has a problem in fixpath.sh, so I've posted PR for it. https://github.com/openjdk/jdk/pull/1889 You can build OpenJDK if you apply it. Thanks, Yasumasa On 2021/01/08 0:20, Anirvan Sarkar wrote: ++ build-dev On Thu, 7 Jan 2021

Integrated: 8259045: Exception message from saproc.dll is garbled on Windows with Japanese locale

2021-01-06 Thread Yasumasa Suenaga
On Mon, 4 Jan 2021 09:25:55 GMT, Yasumasa Suenaga wrote: > I got garbled exception message as following when I run `livenmethods` CLHSDB > command: > > sun.jvm.hotspot.debugger.DebuggerException : ?w???W > > My Windows laptop is set Japanese Locale, garbled m

Re: RFR: 8259045: Exception message from saproc.dll is garbled on Windows with Japanese locale

2021-01-04 Thread Yasumasa Suenaga
On Tue, 5 Jan 2021 03:19:51 GMT, Ioi Lam wrote: > > Given that this seems to be a common problem in our code, and likely a very > > very old problem at that, why has it never been reported before? I'm not > > questioning the fix except to the extent that I'm questioning our > > understanding

Re: RFR: 8259045: Exception message from saproc.dll is garbled on Windows with Japanese locale

2021-01-04 Thread Yasumasa Suenaga
On Tue, 5 Jan 2021 02:19:37 GMT, Ioi Lam wrote: >> I got garbled exception message as following when I run `livenmethods` >> CLHSDB command: >> >> sun.jvm.hotspot.debugger.DebuggerException : ?w???W >> >> My Windows laptop is set Japanese Locale, garbled message was written in >>

Re: RFR: 8259045: Exception message from saproc.dll is garbled on Windows with Japanese locale

2021-01-04 Thread Yasumasa Suenaga
On Tue, 5 Jan 2021 01:30:07 GMT, Ioi Lam wrote: > Now the saproc DLL has an external reference to getLastErrorString, > JNU_NewStringPlatform and JNU_NewObjectByName on all platforms. Do we need to > modify the makefiles for platforms other than Windows? @iklam Agree, so I added `LIBS_unix :=

Re: RFR: 8259045: Exception message from saproc.dll is garbled on Windows with Japanese locale

2021-01-04 Thread Yasumasa Suenaga
On Mon, 4 Jan 2021 21:06:46 GMT, Chris Plummer wrote: > There are probably 25 or so places in our code where we use FormatMessage to > get the error message. Are these all going to run into the same > FormateMessage bug? jdk.hotspot.agent do not have `FormatMessage()` call in other place. Did

Re: RFR: 8259045: Exception message from saproc.dll is garbled on Windows with Japanese locale

2021-01-04 Thread Yasumasa Suenaga
On Mon, 4 Jan 2021 20:58:59 GMT, Chris Plummer wrote: >> I got garbled exception message as following when I run `livenmethods` >> CLHSDB command: >> >> sun.jvm.hotspot.debugger.DebuggerException : ?w???W >> >> My Windows laptop is set Japanese Locale, garbled message was written in >>

RFR: 8259045: Exception message from saproc.dll is garbled on Windows with Japanese locale

2021-01-04 Thread Yasumasa Suenaga
I got garbled exception message as following when I run `livenmethods` CLHSDB command: sun.jvm.hotspot.debugger.DebuggerException : ?w???W My Windows laptop is set Japanese Locale, garbled message was written in Japanese. saproc.dll would throw exception via

RFR: 8258925: configure script failed on WSL

2020-12-24 Thread Yasumasa Suenaga
I ran configure script on WSL 1, but it failed as below: $ bash configure --enable-debug --with-boot-jdk=/mnt/d/Java/jdk-15.0.1 : configure: Found potential Boot JDK using configure arguments configure: The command for java_to_test, which resolves as "/mnt/d/Java/jdk-15.0.1/bin/java", can

Re: RFR: 8253757: Add LLVM-based backend for hsdis

2020-10-06 Thread Yasumasa Suenaga
On Fri, 2 Oct 2020 11:44:51 GMT, Magnus Ihse Bursie wrote: >> @navyxliu I've merged the sources into `src/utils/hsdis` and added support >> to build it in the Makefile. > > This is an interesting suggestion. There is a similar attempt at replacing > binutils with capstone in >

Re: PING: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-17 Thread Yasumasa Suenaga
On 2020/08/18 10:42, David Holmes wrote: Hi Yasumasa, On 14/08/2020 12:36 pm, Yasumasa Suenaga wrote: Hi David, Matthias, Martin, I uploaded new webrev. Could you review again?    http://cr.openjdk.java.net/~ysuenaga/JDK-8250598/webrev.02/ It generates runtime stub for hypervisor detection

Re: PING: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-13 Thread Yasumasa Suenaga
) Thanks, Yasumasa On 2020/08/13 20:39, David Holmes wrote: On 13/08/2020 5:39 pm, Yasumasa Suenaga wrote: Hi Matthias, David, On 2020/08/13 15:52, Baesken, Matthias wrote: Should we make the change to determine just before it is needed (e.g. VM.info or hs_err log) at first? It is out

Re: PING: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-13 Thread Yasumasa Suenaga
nctional%20Specification%20v6.0b.pdf Best regards, Matthias -Original Message- From: Yasumasa Suenaga Sent: Donnerstag, 13. August 2020 06:15 To: David Holmes ; Baesken, Matthias ; hotspot-runtime-...@openjdk.java.net; build-dev@openjdk.java.net Cc: Doerr, Martin Subject: Re: PIN

Re: PING: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-12 Thread Yasumasa Suenaga
Hi Matthias, David, I measured startup benchmarks with `Measure-Command {.\jdk\build\windows-x86_64-server-release\images\jdk\bin\java.exe --version}` on PowerShell. * PC: Ryzen 3 3300X, 16GB memory * OS: Windows 10 x64 (May 2020 Update) * Java: jdk/jdk revision 60537 (Compiled by VS 2019

Re: PING: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-12 Thread Yasumasa Suenaga
Hi Matthias, David, On 2020/08/12 21:12, David Holmes wrote: On 12/08/2020 8:51 pm, Baesken, Matthias wrote: Hi Yasumasa ,  I'm more or less fine with the change . But still not fully convinced  that removing  the iteration is a good thing .

PING: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-11 Thread Yasumasa Suenaga
PING: Could you review this change? JBS: https://bugs.openjdk.java.net/browse/JDK-8250598 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8250598/webrev.01/ Build change has been reviewed by Erik. Thanks, Yasumasa On 2020/08/05 18:30, Yasumasa Suenaga wrote: Hi Matthias, (CC'ed build

Re: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-05 Thread Yasumasa Suenaga
Thanks Erik! Yasumasa On 2020/08/05 21:30, Erik Joelsson wrote: Build change is ok. /Erik On 2020-08-05 02:36, Yasumasa Suenaga wrote: CC'ing build-dev On 2020/08/05 18:30, Yasumasa Suenaga wrote: Hi Matthias, (CC'ed build-dev due to makefile change) I uploaded new webrev. Could you

Re: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-05 Thread Yasumasa Suenaga
CC'ing build-dev On 2020/08/05 18:30, Yasumasa Suenaga wrote: Hi Matthias, (CC'ed build-dev due to makefile change) I uploaded new webrev. Could you review it?   http://cr.openjdk.java.net/~ysuenaga/JDK-8250598/webrev.01/ On 2020/08/05 16:26, Baesken, Matthias wrote: Hello, I also

Re: Preliminary review for new WINENV support

2020-07-08 Thread Yasumasa Suenaga
On 2020/07/09 12:12, Derek Keeler wrote: After applying Suenaga's patch, I see this error: checking wsl distribution... /home/dekeeler/dev/openjdk.net/sandbox/build/.configure-support/generated-configure.sh: line 32952: -d: command not found I'm running Debian 10 in my WSL2 instance and it

Re: Preliminary review for new WINENV support

2020-07-05 Thread Yasumasa Suenaga
Hi Magnus, It's awesome work! I tested your patch, but I saw some errors (configure --enable-debug --with-boot-jdk=/path/to/jdk14): 1) script error checking for gdiff... /mnt/d/test/jdk-master/build/.configure-support/generated-configure.sh: line 9989: test: /mnt/c/Program: binary operator

  1   2   >