Re: RFR: 8248526: configure script failed on WSL in May 2020 update

2020-06-30 Thread Yasumasa Suenaga
:47, Yasumasa Suenaga wrote: Hi all, Please review this change. This change is happen on discussion for WSL 2 support [1], but I tested this change on WSL 1 (Ubuntu 20.04).   JBS: https://bugs.openjdk.java.net/browse/JDK-8248526   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8248526/webrev.00

Re: RFR: 8248526: configure script failed on WSL in May 2020 update

2020-06-30 Thread Yasumasa Suenaga
On 2020/06/30 22:50, Magnus Ihse Bursie wrote: On 2020-06-30 14:11, Yasumasa Suenaga wrote: Thanks Magnus! We cannot build OpenJDK on Windows 10 May 2020 update even if we use WSL 1. So I will push this change when I got second reviewer. The two-reviewer rule is only for hotspot code. Build

RFR: 8248526: configure script failed on WSL in May 2020 update

2020-06-30 Thread Yasumasa Suenaga
Hi all, Please review this change. This change is happen on discussion for WSL 2 support [1], but I tested this change on WSL 1 (Ubuntu 20.04). JBS: https://bugs.openjdk.java.net/browse/JDK-8248526 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8248526/webrev.00/ I saw two configure

Re: configure error on WSL 2

2020-06-02 Thread Yasumasa Suenaga
e would be occur on Windows 10 20H1 even if the build is happen on WSL1. I strace'ed `wslpath -m`, it attempt to open the file at first. I guess it relates to the #4078 fix. Thanks, Yasumasa [1] https://docs.microsoft.com/windows/wsl/release-notes [2] https://github.com/microsoft/WSL/issues/4

Re: configure error on WSL 2

2020-06-01 Thread Yasumasa Suenaga
Hi Magnus, On 2020/06/01 20:06, Magnus Ihse Bursie wrote: On 2020-05-31 14:39, Yasumasa Suenaga wrote: Hi all, I tried to build jdk/jdk on WSL 2 with VS2019, but I saw three errors as below. 1) Could not detect VC (cl.exe) version. So configure reports that it could not find valid

Re: configure error on WSL 2

2020-05-31 Thread Yasumasa Suenaga
The fix is here: http://cr.openjdk.java.net/~ysuenaga/wsl2/ Yasumasa On 2020/05/31 21:39, Yasumasa Suenaga wrote: Hi all, I tried to build jdk/jdk on WSL 2 with VS2019, but I saw three errors as below. 1) Could not detect VC (cl.exe) version. So configure reports that it could not find

configure error on WSL 2

2020-05-31 Thread Yasumasa Suenaga
Hi all, I tried to build jdk/jdk on WSL 2 with VS2019, but I saw three errors as below. 1) Could not detect VC (cl.exe) version. So configure reports that it could not find valid Microsoft C++ compiler. 2) Could not generate fixpath.exe because $CONFIGURESUPPORT_OUTPUTDIR/bin did not exist.

Re: [OpenJDK 2D-Dev] PING: RFR: 8220074: Clean up GCC 8.3 errors in LittleCMS

2019-11-18 Thread Yasumasa Suenaga
Thanks Phil! Yasumasa On 2019/11/19 11:43, Philip Race wrote: OK -phil. On 11/18/19, 5:34 PM, Yasumasa Suenaga wrote: PING: Could you review it?   JBS: https://bugs.openjdk.java.net/browse/JDK-8220074   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8220074/webrev.01/ I think

PING: RFR: 8220074: Clean up GCC 8.3 errors in LittleCMS

2019-11-18 Thread Yasumasa Suenaga
PING: Could you review it? JBS: https://bugs.openjdk.java.net/browse/JDK-8220074 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8220074/webrev.01/ I think it is a trivial change. Yasumasa On 2019/11/13 11:42, Yasumasa Suenaga wrote: Thanks Erik! I uploaded new webrev, and it passed

Re: RFR: 8220074: Clean up GCC 8.3 errors in LittleCMS

2019-11-12 Thread Yasumasa Suenaga
version checks like this. We just add all the necessary warning disabling for all versions. GCC will not fail or warn for invalid -W-no... flags and we use this feature for this very reason. We don't think it's feasible to track warnings per compiler versions.. /Erik On 2019-11-12 06:48, Yasumasa

Re: RFR: 8220074: Clean up GCC 8.3 errors in LittleCMS

2019-11-12 Thread Yasumasa Suenaga
10450 Thanks, Yasumasa -phil. On 11/12/19 6:48 AM, Yasumasa Suenaga wrote: Hi all, Please review this change:   JBS: https://bugs.openjdk.java.net/browse/JDK-8220074   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8220074/webrev.00/ I saw some -Wstringop-truncation warnings in LCMS when I

RFR: 8220074: Clean up GCC 8.3 errors in LittleCMS

2019-11-12 Thread Yasumasa Suenaga
Hi all, Please review this change: JBS: https://bugs.openjdk.java.net/browse/JDK-8220074 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8220074/webrev.00/ I saw some -Wstringop-truncation warnings in LCMS when I build OpenJDK with GCC 9.2.1 on Fedora 31. They are LCMS problems, thus we

Re: RFR: 8233285: Demangling C++ symbols in jhsdb jstack --mixed

2019-11-06 Thread Yasumasa Suenaga
gherty wrote: Since this review contains build changes, I've added build-dev@... Thanks Dan for noticing this and cc:ing us. Yasumasa: build changes look fine. Thanks. This change broke all cross-compilation. David /Magnus Dan On 11/1/19 4:56 AM, Yasumasa Suenaga wrote: (Changed subje

Re: RFR: 8233285: Demangling C++ symbols in jhsdb jstack --mixed

2019-11-04 Thread Yasumasa Suenaga
. Thanks. /Magnus Dan On 11/1/19 4:56 AM, Yasumasa Suenaga wrote: (Changed subject to review request) Hi, I converted LinuxDebuggerLocal.c to C++ code, and it works fine on submit repo. (mach5-one-ysuenaga-JDK-8233285-1-20191101-0746-6336009)   http://cr.openjdk.java.net/~ysuenaga/JDK-8233285

Re: RFR: JDK-8221988: add possibility to build with Visual Studio 2019

2019-04-18 Thread Yasumasa Suenaga
brev: http://cr.openjdk.java.net/~avoitylov/webrev.8221988.01/ issue: https://bugs.openjdk.java.net/browse/JDK-8221988 Build testing: Windows x86_64 product and fastdebug build on Windows 2012R2. Yasumasa Suenaga also reported successfully building on WSL. Testing: Windows 7, 10, 2012R2, 2016, 2

Re: Build with VS 2019

2019-04-17 Thread Yasumasa Suenaga
as the second item in the list of valid versions as it's most likely preferable to all the older versions currently listed after 2017. /Erik On 2019-04-17 07:18, Yasumasa Suenaga wrote: Hi all, I tried to build jdk/jdk on WSL with VS 2019. Someone work for VS 2019? If not, I want to file

Build with VS 2019

2019-04-17 Thread Yasumasa Suenaga
Hi all, I tried to build jdk/jdk on WSL with VS 2019. Someone work for VS 2019? If not, I want to file it to JBS and contribute patch as below. It works fine on my environment. -- diff -r 4224f26b2e7f make/autoconf/toolchain_windows.m4 --- a/make/autoconf/toolchain_windows.m4

Re: bash configure: result from running a microsoft compiler was empty string

2019-04-10 Thread Yasumasa Suenaga
Hi Vitaly, I can build jdk/jdk on my WSL as following: - A new configuration has been successfully created in /mnt/c/OpenJDK/jdk/build/windows-x86_64-server-fastdebug using configure arguments '--enable-debug --disable-hotspot-gtest --with-boot-jdk=/mnt/c/jdk-12'. Configuration

Re: RFR: JDK-8221851: Use of THIS_FILE in hotspot invalidates precompiled header on Linux/GCC

2019-04-10 Thread Yasumasa Suenaga
2019年4月10日(水) 13:55 David Holmes : > > Hi Erik, > > On 9/04/2019 11:55 pm, Erik Joelsson wrote: > > Hello, > > > > Here is a new webrev with an even simpler change: > > > > http://cr.openjdk.java.net/~erikj/8221851/webrev.06/ > > > > I decided to just remove the usage of THIS_FILE from

Re: RFR: 8220784: hsdis cannot be built with MinGW64

2019-03-20 Thread Yasumasa Suenaga
> Since this is a rarely touched Makefile, I think what you're doing in > > webrev.02 is fine. We can refactor it later if it becomes more unwieldy. > > Okay I can live with webrev.02 as well. > > Thanks, > David > - > > > Thanks > > - Ioi > > > >

Re: RFR: 8220784: hsdis cannot be built with MinGW64

2019-03-20 Thread Yasumasa Suenaga
not unclear why it is failed. But order of libraries seems to be important. Yasumasa 2019年3月20日(水) 15:18 David Holmes : > > On 20/03/2019 4:03 pm, Yasumasa Suenaga wrote: > > Hi David, > > > > 2019年3月20日(水) 14:25 David Holmes : > >> > >> Hi Yas

Re: RFR: 8220784: hsdis cannot be built with MinGW64

2019-03-20 Thread Yasumasa Suenaga
Hi David, 2019年3月20日(水) 14:25 David Holmes : > > Hi Yasumasa, > > On 20/03/2019 3:01 pm, Yasumasa Suenaga wrote: > > Thanks David! > > > > I uploaded new webrev. > > This change affects Windows only, and I confirmed it works fine for > > Linux x64 and

Re: RFR: 8220784: hsdis cannot be built with MinGW64

2019-03-19 Thread Yasumasa Suenaga
Thanks David! I uploaded new webrev. This change affects Windows only, and I confirmed it works fine for Linux x64 and MinGW64. http://cr.openjdk.java.net/~ysuenaga/JDK-8220784/webrev.01/ Thanks, Yasumasa 2019年3月20日(水) 11:25 David Holmes : > > On 20/03/2019 11:54 am, Yasumasa Suenaga

Re: RFR: 8220784: hsdis cannot be built with MinGW64

2019-03-19 Thread Yasumasa Suenaga
> > with this change (which would be at least Macos, AIX and Windows in a > > normal Cygwin VS env)? > > > > /Erik > > > > On 2019-03-18 17:56, Yasumasa Suenaga wrote: > >> Hi all, > >> > >> Please review this change: > >> > >

RFR: 8220784: hsdis cannot be built with MinGW64

2019-03-18 Thread Yasumasa Suenaga
Hi all, Please review this change: JBS: https://bugs.openjdk.java.net/browse/JDK-8220784 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8220784/webrev.00/ I attempt to build hsdis for Windows on WSL Ubuntu 18.04 with gcc-mingw-w64-x86-64, but I saw error messages that some functions which

Re: C4819 warnings on Windows

2019-01-04 Thread Yasumasa Suenaga
to launch the build process now? That's unbelievable. Thanks, Max On Jan 4, 2019, at 3:22 PM, Yasumasa Suenaga wrote: Hi all, I tried to build OpenJDK on WSL (Windows 10 1809 + VS2017 (15.9.4) + Ubuntu 18.04 LTS). However, I saw some C4819 warnings as below: ``` c:/OpenJDK/jdk/src/hotspot

Re: C4819 warnings on Windows

2019-01-04 Thread Yasumasa Suenaga
. Consider JDK-8216155 reviewed. /Erik On 2019-01-04 09:47, Yasumasa Suenaga wrote: Thanks David! I filed two issues to JBS:   https://bugs.openjdk.java.net/browse/JDK-8216154   https://bugs.openjdk.java.net/browse/JDK-8216155 Patches have been pushed to submit repo. I will send RFR when I receive

Re: C4819 warnings on Windows

2019-01-04 Thread Yasumasa Suenaga
: Hi Yasumasa, The two hotspot issues can be filed in one bug under hotspot->compiler and reviewed on hotspot-compiler-dev as they are source code changes not build changes. The other one is a build change but probably also needs reviewing by awt-dev. Cheers, David On 4/01/2019 5:22 pm, Yasum

C4819 warnings on Windows

2019-01-03 Thread Yasumasa Suenaga
Hi all, I tried to build OpenJDK on WSL (Windows 10 1809 + VS2017 (15.9.4) + Ubuntu 18.04 LTS). However, I saw some C4819 warnings as below: ``` c:/OpenJDK/jdk/src/hotspot/share/compiler/methodMatcher.cpp(258): warning C4819: ファイルは、現在のコード ページ (0) で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを Unicode

Re: Build failure on Fedora 28

2018-05-15 Thread Yasumasa Suenaga
Yasumasa 2018-05-16 0:09 GMT+09:00 Severin Gehwolf <sgehw...@redhat.com>: > Hi Yasumasa, > > On Tue, 2018-05-15 at 23:56 +0900, Yasumasa Suenaga wrote: >> Hi Severin, >> >> > Looks like another case of UB in the JDK. This time libjimage.so with a >>

Re: Build failure on Fedora 28

2018-05-15 Thread Yasumasa Suenaga
: Hi, On Fri, 2018-05-11 at 12:55 +0900, Yasumasa Suenaga wrote: Hi, I found 1 GCC optimization issue, but it is not enough. http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/gcc8-opt/gdb-before.txt I traced class loading from `modules`. Above log is copy of GDB console in ImageFileReader

Re: Build failure on Fedora 28

2018-05-10 Thread Yasumasa Suenaga
10.0.1 builds fine with GCC 8. > > So far showing all symptoms of either a GCC bug or some UB in recent > OpenJDK code which breaks with new optimizations done in GCC 8. > > I'll continue to investigate what it is... > > Cheers, > Severin > > On Wed, 2018-05-0

Re: Build failure on Fedora 28

2018-05-09 Thread Yasumasa Suenaga
the source you build - I usually > use a clean current release build. > > This excludes build errors which may be caused by the JDK you are > building being faulty (the build uses itself in places). > > ..Thomas > > On Wed, May 9, 2018 at 5:46 AM, Yasumasa Suenaga <yasue...

Re: Build failure on Fedora 28

2018-05-09 Thread Yasumasa Suenaga
Hi David, 2018-05-09 16:26 GMT+09:00 David Holmes <david.hol...@oracle.com>: > On 9/05/2018 5:19 PM, Yasumasa Suenaga wrote: >> >> Hi David, >> >> I uploaded trace log: >>http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/trace-all.log >> &

Re: Build failure on Fedora 28

2018-05-09 Thread Yasumasa Suenaga
t; Thanks, > David > > >> >> Thanks, >> >> Yasumasa >> >> >> >> 2018-05-09 11:17 GMT+09:00 David Holmes <david.hol...@oracle.com>: >>> >>> On 9/05/2018 12:09 PM, Yasumasa Suenaga wrote: >>>> >>>>

Re: Build failure on Fedora 28

2018-05-08 Thread Yasumasa Suenaga
Hi David, I uploaded build.log: http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/build.log Is it enough? Thanks, Yasumasa 2018-05-09 11:17 GMT+09:00 David Holmes <david.hol...@oracle.com>: > On 9/05/2018 12:09 PM, Yasumasa Suenaga wrote: >> >> Hi David, >> &g

Re: Build failure on Fedora 28

2018-05-08 Thread Yasumasa Suenaga
avid > > > On 9/05/2018 11:39 AM, Yasumasa Suenaga wrote: >> >> Hi, >> >> 2018-05-09 0:27 GMT+09:00 Erik Joelsson <erik.joels...@oracle.com>: >>> >>> Hello, >>> >>> Your assessment is looks correct so far. At this point, o

Re: Build failure on Fedora 28

2018-05-08 Thread Yasumasa Suenaga
OpenJDK 64-Bit Server VM (fastdebug build 11-internal+0-adhoc.ysuenaga.jdk, mixed mode) ``` I'm waiting for Severin's evaluation :-) Thanks, Yasumasa > Has anyone at Redhat built successfully on Fedora 28 yet? > > /Erik > > > > On 2018-05-08 06:42, Yasumasa Suenaga wrote: >>

Build failure on Fedora 28

2018-05-08 Thread Yasumasa Suenaga
Hi all, I tried to build OpenJDK (jdk/jdk) on Fedora 28 x64, but it failed as following: ``` [ysuenaga@fc28 jdk]$ make images Building target 'images' in configuration 'linux-x86_64-normal-server-fastdebug' gmake[3]: *** [GenerateLinkOptData.gmk:64:

Build OpenJDK for Windows x64 w/ VS 2017 on WSL

2018-01-23 Thread Yasumasa Suenaga
Hi all, I'm trying to build OpenJDK for Windows x64 with VS 2017 on WSL. I've modified some build scripts [1], but I cannot build yet. So I have some questions: - Do build-dev team have any plan to support VS 2017 ? - Do build-dev team have any plan to support WSL as build platform?

Re: [OpenJDK 2D-Dev] [REGRESSION?] Build warnings at jdhuff.c with GCC 6

2016-08-24 Thread Yasumasa Suenaga
/jdk9/client/jdk/rev/d4f7412a51d2 I don't think we want to add it back unless the *official* compilers object .. I am sure that official list is documented somewhere. -phil. On 8/23/16, 6:10 AM, Yasumasa Suenaga wrote: Hi all, I've fixed several warnings when we build OpenJDK with GCC 6 in JDK

[REGRESSION?] Build warnings at jdhuff.c with GCC 6

2016-08-23 Thread Yasumasa Suenaga
Hi all, I've fixed several warnings when we build OpenJDK with GCC 6 in JDK-8160294. However, I encountered shift-negative-value warnings at jdhuff.c on my Fedora 24 (GCC 6.1.1): -- /home/ysuenaga/OpenJDK/hs/jdk/src/java.desktop/share/native/libjavajpeg/jdhuff.c:458:13: warning:

Re: RFR: JDK-8160354: uninitialized value warning and VM crash are occurred with GCC 6

2016-08-23 Thread Yasumasa Suenaga
Hi Kim, and all, Sorry for my late reply. I've fixed them in new webrev. Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8160354/webrev.01/ Also I need a sponsor. Thanks, Yasumasa On 2016/06/28 12:43, Yasumasa Suenaga wrote: Hi Kim, On 2016/06/28 7:12, Kim Barrett wrote

Re: RFR: 8151351: HotSpot build process should regard --with-native-debug-symbols.

2016-03-07 Thread Yasumasa Suenaga
On 2016-03-07 15:29, Yasumasa Suenaga wrote: Hi Erik, If you like, you can take it for a spin yourself by cloning http://hg.openjdk.java.net/build-infra/jdk9. It should be in a pretty good shape right now on Linux. Thanks! It looks good to me. BTW, Does build-infra use hotspot/make/linux

Re: RFR: 8151351: HotSpot build process should regard --with-native-debug-symbols.

2016-03-07 Thread Yasumasa Suenaga
build there works as expected with the "internal" setting. If you like, you can take it for a spin yourself by cloning http://hg.openjdk.java.net/build-infra/jdk9. It should be in a pretty good shape right now on Linux. /Erik On 2016-03-07 10:34, Yasumasa Suenaga wrote: Hi David,

Re: RFR: 8151351: HotSpot build process should regard --with-native-debug-symbols.

2016-03-07 Thread Yasumasa Suenaga
Hi David, Does "new hotspot build" mean JEP 284? If it so and this issue does not occur on JEP 284, I will close this issue. Thanks, Yasumasa 2016/03/07 16:57 "David Holmes" <david.hol...@oracle.com>: > Hi Yasumasa, > > On 7/03/2016 1:38 PM, Yasumasa Suenag

RFR: 8151351: HotSpot build process should regard --with-native-debug-symbols.

2016-03-06 Thread Yasumasa Suenaga
Hi all, When I build fastdebug JDK (--enable-debug) with --with-native-debug-symbols=internal, build process generated *.debuginfo for libjsig and libjvm. I think that build process should regard --with-native-debug-symbols. I've uploaded webrev. Could you review it?

Re: RFR: JDK-8150723: HSDB toolbar icons are missing.

2016-02-29 Thread Yasumasa Suenaga
orkaround. > > Could you move gif files to correct location and remove custom makefile > logic? > > I'll sponsor the push then. > > -Dmitry > > On 2016-02-27 06:44, Yasumasa Suenaga wrote: >> Hi Erik, >> >> Thanks! >> I've uploaded new webrev. Cou

Re: RFR: JDK-8150723: HSDB toolbar icons are missing.

2016-02-26 Thread Yasumasa Suenaga
e output. Then we can remove this whole SetupCopyFiles > construct and just add .gif to jdk.hotspot.agent_COPY. > > /Erik > > On 2016-02-26 04:28, Yasumasa Suenaga wrote: >> Hi all, >> >> HSDB toolbar icons >> (hotspot/src/jdk.hotspot.agent/share/classes/images/toolbarB

RFR: JDK-8150723: HSDB toolbar icons are missing.

2016-02-26 Thread Yasumasa Suenaga
Hi all, HSDB toolbar icons (hotspot/src/jdk.hotspot.agent/share/classes/images/toolbarButtonGraphics) are missing in appmodules.jimage . They should be contained to appmodules.jimage . I've uploaded a webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8150723/webrev.00/ Could you review it?

Re: RFR: JDK-8149466: configure failed after JDK-8148351

2016-02-09 Thread Yasumasa Suenaga
Hi Magnus, Thanks, I've understood. I closed JDK-8149466 as "Not an issue" . Yasumasa On 2016/02/09 23:33, Magnus Ihse Bursie wrote: > On 2016-02-09 15:29, Yasumasa Suenaga wrote: >> Hi Magnus, >> >>> If this is not possible, then you can specify your compile

Re: RFR: JDK-8149466: configure failed after JDK-8148351

2016-02-09 Thread Yasumasa Suenaga
could not avoid with it. Thus I think that we should fix to affect --enable-cache to these logic. Thanks, Yasumasa On 2016/02/09 23:14, Magnus Ihse Bursie wrote: > On 2016-02-09 14:43, Yasumasa Suenaga wrote: >> Hi all, >> >> After JDK-8148351, configure script failed as below: >

RFR: JDK-8149466: configure failed after JDK-8148351

2016-02-09 Thread Yasumasa Suenaga
Hi all, After JDK-8148351, configure script failed as below: configure: Using default toolchain gcc (GNU Compiler Collection) checking for gcc... /usr/lib64/ccache/gcc checking resolved symbolic links for CC... /usr/bin/ccache configure: Please use --enable-ccache instead of

Re: [urgent] RFR: JDK-8145206: Configure broken on Macosx

2015-12-12 Thread Yasumasa Suenaga
I agree to David. If your environment does not have objcopy, you should set --with-native-debug-symbols to internal or none. Thanks, Yasumasa On 2015/12/12 21:40, David Holmes wrote: On 12/12/2015 1:52 AM, Erik Joelsson wrote: JDK-8036003 broke configure on Macosx: checking what type of

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-12-11 Thread Yasumasa Suenaga
s, no need to upload a new webrev. Sorry, I've fixed it and pushed. Thank you so much! Yasumasa On 2015/12/11 20:52, Magnus Ihse Bursie wrote: On 2015-12-11 00:47, Yasumasa Suenaga wrote: Hi build folks, Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8036003/webrev.06/

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-12-10 Thread Yasumasa Suenaga
Hi build folks, Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8036003/webrev.06/ Thanks, Yasumasa On 2015/12/09 13:12, David Holmes wrote: Hi, On 9/12/2015 10:31 AM, Yasumasa Suenaga wrote: Hi, I've uploaded a new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-12-08 Thread Yasumasa Suenaga
On 2015/12/03 15:51, David Holmes wrote: On 1/12/2015 12:34 AM, Yasumasa Suenaga wrote: Hi Magnus, I've uploaded new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8036003/webrev.05/ common/autoconf/jdk-options.m4 Can you reinstate the comment: 581 # This must be done after

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-12-03 Thread Yasumasa Suenaga
. Should I file it as another issue? I'm assuming there is no change to the default behaviour if none of these options are specified. Yes. Default behavior is zipped. Thanks, Yasumasa On 2015/12/03 15:51, David Holmes wrote: On 1/12/2015 12:34 AM, Yasumasa Suenaga wrote: Hi Magnus, I've

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-30 Thread Yasumasa Suenaga
reasonably be no_strip. I've fixed in this webrev. Thanks, Yasumasa On 2015/11/30 21:26, Magnus Ihse Bursie wrote: On 2015-11-26 15:19, Yasumasa Suenaga wrote: I uploaded a new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8036003/webrev.04/ I implemented --with-native-debug-symbols and --e

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-26 Thread Yasumasa Suenaga
agnus Ihse Bursie wrote: On 2015-11-21 14:12, Yasumasa Suenaga wrote: My point with current proposal is that either it doesn't touch the zipping because we already have an option for that; or it should deprecate the existing option (now Erik has pointed out that capability).

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-25 Thread Yasumasa Suenaga
rsie wrote: On 2015-11-21 14:12, Yasumasa Suenaga wrote: My point with current proposal is that either it doesn't touch the zipping because we already have an option for that; or it should deprecate the existing option (now Erik has pointed out that capability). I'm using BASIC_DEPRECATED_

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-21 Thread Yasumasa Suenaga
My point with current proposal is that either it doesn't touch the zipping because we already have an option for that; or it should deprecate the existing option (now Erik has pointed out that capability). I'm using BASIC_DEPRECATED_ARG_ENABLE for debug-symbols and zip-debug-info in new

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-19 Thread Yasumasa Suenaga
on that part. (I don't think we have a deprecation policy for configure args.) I also don't like that stripping is only considered for the "internal" case. I think all of the aspects should be handled together. On 17/11/2015 1:32 PM, Yasumasa Suenaga wrote: Thank you for your comm

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-19 Thread Yasumasa Suenaga
Hi all, (I removed distro-pkg-dev from this email) I've uploaded new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8036003/webrev.02/ * No logic in spec.gmk. That should be done in the m4 files. Ideally, spec.gmk is just a listing of variables and their contents. I've fixed it in new

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-16 Thread Yasumasa Suenaga
Magnus will want to comment. I'm afraid he likely won't be able to until next week however. One thing, could you name the variable DEBUG_SYMBOLS, with the S at the end so that it matches the configure option? /Erik On 2015-11-16 10:38, Yasumasa Suenaga wrote: Hi all, I would like to propose

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-16 Thread Yasumasa Suenaga
th the S at the > end so that it matches the configure option? > > /Erik > > On 2015-11-16 10:38, Yasumasa Suenaga wrote: >> Hi all, >> >> I would like to propose JDK-8036003: Add >> --with-debug-symbols=[none|internal|external|zipped] . >>

RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-16 Thread Yasumasa Suenaga
Hi all, I would like to propose JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped] . I had posted this enhancement which provides new make variable [1]. But it does not fit current jdk 9. So I propose it again as new configure option. I'm sure that this enhancement helps

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-03 Thread Yasumasa Suenaga
Hi Andrew, Separating debuginfo is not something that we want the OpenJDK build to do, and the most useful thing that we could have is a switch to turn all of OpenJDK's stripping and separate debuginfo off. I expect the same applies to all distros. My patch provides

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-03 Thread Yasumasa Suenaga
STRIP_POLICY to none, and set POST_STRIP_CMD to empty. I tried: $ make images STRIP_POLICY=no_strip POST_STRIP_CMD= I was able to get binaries which is included debug information. Thanks, Yasumasa On 2014/03/03 13:39, David Holmes wrote: Hi, On 2/03/2014 12:07 AM, Yasumasa Suenaga wrote: Hi

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-02 Thread Yasumasa Suenaga
HI Mike, - I would expect that the flow is something like an extended version of https://blogs.oracle.com/dbx/entry/creating_separate_debug_info : 1. Compile source files with some form of -g 2. Create separate debug files for object files. 3. Strip object files. 4. Add

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-01 Thread Yasumasa Suenaga
it before JDK8 GA is released. Thanks, Yasumasa On 2014/03/01 8:47, David Holmes wrote: On 1/03/2014 1:38 AM, Yasumasa Suenaga wrote: The proper way to fix this is to disable FDS. Does this mean I have to pass --disable-debug-symbols to configure ? I've added comment to JDK-8036003, I

JDK-8036003: Add variable not to separate debug information.

2014-02-28 Thread Yasumasa Suenaga
Hi all, Currently, configure script can accept --disable-debug-symbols and --disable-zip-debug-info as controlling to generate debug information. However, current makefiles cannot build ELF binaries which is contained debug information with images target. Some Linux distros use RPM as package

Re: JDK-8036003: Add variable not to separate debug information.

2014-02-28 Thread Yasumasa Suenaga
need to do to get what you want is not use FDS and not strip the symbols from the binary. The former is trivial. The latter is more awkward as the strip policy stuff does not work as I would want it to work, but still doable. David On 28/02/2014 7:18 PM, Yasumasa Suenaga wrote: Hi all

JDK-8035944: Build failed wilth configure option --disable-debuginfo-files

2014-02-27 Thread Yasumasa Suenaga
Hi all, I tried to build JDK8 with configure option: --disable-debuginfo-files, however I got error mesasges as following: - ## Starting hotspot Generating source files Building adlc Building libjvm.so Building libjsig.so Building libsaproc.so gmake[2]: *** No rule to make

Re: JDK-8035944: Build failed wilth configure option --disable-debuginfo-files

2014-02-27 Thread Yasumasa Suenaga
Sorry, I forgot to upload webrev. http://cr.openjdk.java.net/~ysuenaga/JDK-8035944/webrev.00/ Please review and sponsoring! Yasumasa On 02/27/2014 09:40 PM, Yasumasa Suenaga wrote: Hi all, I tried to build JDK8 with configure option: --disable-debuginfo-files, however I got error

Re: JDK-8035944: Build failed wilth configure option --disable-debuginfo-files

2014-02-27 Thread Yasumasa Suenaga
another mail list ? Thanks, Yasumasa On 02/27/2014 10:10 PM, Erik Joelsson wrote: Adding hotspot-dev as this is a hotspot fix /Erik On 2014-02-27 13:48, Yasumasa Suenaga wrote: Sorry, I forgot to upload webrev. http://cr.openjdk.java.net/~ysuenaga/JDK-8035944/webrev.00/ Please review

<    1   2