Re: Allow using a system-installed giflib

2013-04-10 Thread Brad Wetmore
On 4/10/2013 1:19 AM, Alan Bateman wrote: On 09/04/2013 23:11, Omair Majid wrote: : I would like to avoid this in the future; any tips on how to run the old build? I couldn't get it to work last I tried (the error messages were redirecting me to the new build). I see Brad's reply but I think

Re: Allow using a system-installed giflib

2013-04-09 Thread Omair Majid
On 04/09/2013 06:01 PM, Brad Wetmore wrote: Mike/Omair/Eric, This putback has likely broken the old JDK build (i.e. in jdk/make) JDK-8011812: JDK-8011278 breaks the old build Sorry for this. At least deploy and JCE are still stuck on the old build. I would like to avoid this in the

Re: Allow using a system-installed giflib

2013-04-09 Thread Brad Wetmore
Thanks Omair, Not sure how much I'll be able to help here since I use much of the internal /java mount point. But essentially as long as you have your tools in the right places (or specify them through the ALT_* variables), I just do: % cd jdk/make % make381 all (or images) Some

hg: jdk8/build/jdk: 8011278: Allow using a system-installed giflib

2013-04-02 Thread omajid
Changeset: 9c76ea43d491 Author:omajid Date: 2013-04-02 14:13 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9c76ea43d491 8011278: Allow using a system-installed giflib Reviewed-by: andrew, prr ! makefiles/CompileNativeLibraries.gmk ! src/share/native/sun/awt/splashscreen

Re: Allow using a system-installed giflib

2013-03-15 Thread Erik Joelsson
On 2013-03-15 04:10, Andrew Hughes wrote: - Original Message - Hi, Updated webrev at: http://cr.openjdk.java.net/~omajid/webrevs/system-giflib/01/ The webrev borrows some idioms that Andrew Hughes pointed out, and uses system headers for giflib too. I checked this by building

Re: Allow using a system-installed giflib

2013-03-08 Thread Erik Joelsson
On 2013-03-08 03:59, Omair Majid wrote: Hi, I have a webrev at: http://cr.openjdk.java.net/~omajid/webrevs/system-giflib/00/ It introduces a configure option --with-giflib that (similar to the existing --with-zlib) allows specifying whether the build should use the system installed giflib or

Re: Allow using a system-installed giflib

2013-03-08 Thread Phil Race
If I understand correctly, this removes the directory containing the JDK's copy of giflib sources from the set of locations to be compiled etc, and replaces it with just a link line pointer to use libgif which is then expected to be on the default linker path, ie in /usr/lib. I think this is

Re: Allow using a system-installed giflib

2013-03-08 Thread Omair Majid
On 03/08/2013 12:26 PM, Phil Race wrote: If I understand correctly, this removes the directory containing the JDK's copy of giflib sources from the set of locations to be compiled etc, and replaces it with just a link line pointer to use libgif which is then expected to be on the default

Allow using a system-installed giflib

2013-03-07 Thread Omair Majid
Hi, I have a webrev at: http://cr.openjdk.java.net/~omajid/webrevs/system-giflib/00/ It introduces a configure option --with-giflib that (similar to the existing --with-zlib) allows specifying whether the build should use the system installed giflib or the one bundled with OpenJDK. I have not