Integrated: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target

2022-03-04 Thread Julian Waters
On Wed, 2 Mar 2022 08:11:51 GMT, Julian Waters wrote: > Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead.

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v11]

2022-03-04 Thread Magnus Ihse Bursie
On Fri, 4 Mar 2022 11:48:14 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v11]

2022-03-04 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v10]

2022-03-04 Thread Julian Waters
On Fri, 4 Mar 2022 07:51:36 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v10]

2022-03-04 Thread Magnus Ihse Bursie
On Fri, 4 Mar 2022 07:51:36 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v10]

2022-03-03 Thread Julian Waters
On Fri, 4 Mar 2022 07:51:36 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v10]

2022-03-03 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v9]

2022-03-03 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v8]

2022-03-03 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v7]

2022-03-03 Thread Julian Waters
On Thu, 3 Mar 2022 16:48:40 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v7]

2022-03-03 Thread David Holmes
On Thu, 3 Mar 2022 16:48:40 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v7]

2022-03-03 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v6]

2022-03-03 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v4]

2022-03-03 Thread Julian Waters
On Thu, 3 Mar 2022 15:54:44 GMT, Magnus Ihse Bursie wrote: >> Would it be better if I changed that to say the flags are misleading, or if >> I reverted it back to legacy in that case? (Since that seems to be the >> primary concern with using them) > > As the build documentation says, the standa

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v5]

2022-03-03 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v4]

2022-03-03 Thread Julian Waters
On Thu, 3 Mar 2022 08:12:37 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v4]

2022-03-03 Thread Magnus Ihse Bursie
On Thu, 3 Mar 2022 13:32:33 GMT, Julian Waters wrote: >> make/autoconf/configure line 298: >> >>> 296: exit 1 >>> 297: else >>> 298: echo "Warning: You are using unsafe autoconf cross-compilation >>> flags." >> >> The autoconf flags are not really unsafe, they are just misleadingly n

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v4]

2022-03-03 Thread Julian Waters
On Thu, 3 Mar 2022 13:16:08 GMT, Magnus Ihse Bursie wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Syntax > > make/autoconf/configure line 298: > >> 296: exit 1 >> 297: else >> 298: echo "Warning: You

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v4]

2022-03-03 Thread Magnus Ihse Bursie
On Thu, 3 Mar 2022 08:12:37 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags [v4]

2022-03-03 Thread Julian Waters
On Thu, 3 Mar 2022 08:12:37 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags [v4]

2022-03-03 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags [v3]

2022-03-02 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags [v2]

2022-03-02 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: JDK-8282532

2022-03-02 Thread Magnus Ihse Bursie
Hi Julian, Thanks for bringing this back in a discussion format. If I understand your problem correctly, it is that the --openjdk-target fully replaces the autoconf --build/--host/--target triplet, and assumes that it can autodetect the build platform. And if that autodetect fails, the only r

Re: JDK-8282532

2022-03-02 Thread Jules W.
Hi Thomas, I was referring to Magnus' issue with the markdown docs I edited when I submitted the PR. Thank you for the encouragement, it means a lot to me :) best regards, Julian On Wed, Mar 2, 2022 at 8:42 PM Thomas Stüfe wrote: > Hi Jules, > > On Wed, Mar 2, 2022 at 1:29 PM Jules W. wrote:

Re: JDK-8282532

2022-03-02 Thread Thomas Stüfe
Hi Jules, On Wed, Mar 2, 2022 at 1:29 PM Jules W. wrote: > Apologies for not creating a thread consulting the mailing list before > submitting the PR, I'm still getting used to the process (And also thought > this would create unnecessary noise for people within this list). > On the contrary, t

JDK-8282532

2022-03-02 Thread Jules W.
Apologies for not creating a thread consulting the mailing list before submitting the PR, I'm still getting used to the process (And also thought this would create unnecessary noise for people within this list). I initially believed that given how the legacy options had warnings when they were set

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags

2022-03-02 Thread TheShermanTanker
On Wed, 2 Mar 2022 08:11:51 GMT, TheShermanTanker wrote: > Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instea

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags

2022-03-02 Thread Magnus Ihse Bursie
On Wed, 2 Mar 2022 08:11:51 GMT, TheShermanTanker wrote: > Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instea

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags

2022-03-02 Thread Thomas Stuefe
On Wed, 2 Mar 2022 08:33:58 GMT, TheShermanTanker wrote: > > > This also removes support for the legacy cross compilation flags as well. > > > > > > Hi, > > without reading through building.md and your patch, which legacy flags are > > would be removed by this? > > Thanks, Thomas > > Specific

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags

2022-03-02 Thread TheShermanTanker
On Wed, 2 Mar 2022 08:27:19 GMT, Thomas Stuefe wrote: > > This also removes support for the legacy cross compilation flags as well. > > Hi, > > without reading through building.md and your patch, which legacy flags are > would be removed by this? > > Thanks, Thomas Specifically the flags tha

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags

2022-03-02 Thread Thomas Stuefe
On Wed, 2 Mar 2022 08:11:51 GMT, TheShermanTanker wrote: >This also removes support for the legacy cross compilation flags as well. Hi, without reading through building.md and your patch, which legacy flags are would be removed by this? Thanks, Thomas Oh, and please describe whatever you do

RFR: JDK-8282532 Add option to explicitly set build platform and remove support for legacy cross compilation flags

2022-03-02 Thread TheShermanTanker
Issue: https://bugs.openjdk.java.net/browse/JDK-8282532 Stats: 40 lines in 2 files changed: 21 ins; 3 del; 16 mod Patch: https://git.openjdk.java.net/jdk/pull/7656.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7656/head:pull/7656 PR: https://git.openjdk.java.net/jdk/pull/7656