Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-27 Thread joe darcy
Hi Jon, On 6/27/2018 12:50 PM, Jonathan Gibbons wrote: Joe, javac Source.java   83   84 /** 1.11 covers the to be determined language features that will be added in JDK 11. */   85 JDK11("11"),   86   87 /** 12 covers the to be determined language features that will be added in

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-27 Thread Jonathan Gibbons
Joe, javac Source.java 83 84 /** 1.11 covers the to be determined language features that will be added in JDK 11. */ 85 JDK11("11"), 86 87 /** 12 covers the to be determined language features that will be added in JDK 12. */ 88 JDK12("12"); It would be nice if the

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-26 Thread joe darcy
On 6/26/2018 10:11 AM, Paul Sandoz wrote: This generally looks good. Having it all consolidated helps a lot, and we are slowly chipping away at reducing this for each release. src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassFile.java — 118 V55(55, 0), // JDK 11: constan

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-26 Thread Paul Sandoz
This generally looks good. Having it all consolidated helps a lot, and we are slowly chipping away at reducing this for each release. src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassFile.java — 118 V55(55, 0), // JDK 11: constant dynamic 119 V56(56, 0); // JDK 1

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-26 Thread Erik Joelsson
Build changes look good. I'm happy at least those are very few at this point. To make the updating of "-source 12 -target 12" easier in the future, we could introduce another variable in version-numbers that is used for these flags in SetupJavaCompilers.gmk so we get the build changes down to

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-26 Thread joe darcy
Hi Alan, On 6/26/2018 2:23 AM, Alan Bateman wrote: On 25/06/2018 19:10, joe darcy wrote: Hello, With the JDK 11 and 12 split fast approaching [1], it is time to work on the various start of release update tasks for JDK 12. Those tasks are being tracked under the umbrella bug JDK-8205615: "S

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-26 Thread Alan Bateman
On 25/06/2018 19:10, joe darcy wrote: Hello, With the JDK 11 and 12 split fast approaching [1], it is time to work on the various start of release update tasks for JDK 12. Those tasks are being tracked under the umbrella bug JDK-8205615: "Start of release updates for JDK 12". This thread is

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-25 Thread joe darcy
Hi David, On 6/25/2018 4:59 PM, David Holmes wrote: Hi Joe, Okay - no problem. Just looking for opportunities to streamline the process. Cheers, David I agree with the goal of striving for the a more streamlined process, but don't want to have to use it just yet ;-) -Joe

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-25 Thread David Holmes
Hi Joe, Okay - no problem. Just looking for opportunities to streamline the process. Cheers, David On 26/06/2018 9:42 AM, joe darcy wrote: Hi David, On 6/25/2018 4:13 PM, David Holmes wrote: Hi Joe, On 26/06/2018 4:10 AM, joe darcy wrote: Hello, With the JDK 11 and 12 split fast approach

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-25 Thread joe darcy
Hi David, On 6/25/2018 4:13 PM, David Holmes wrote: Hi Joe, On 26/06/2018 4:10 AM, joe darcy wrote: Hello, With the JDK 11 and 12 split fast approaching [1], it is time to work on the various start of release update tasks for JDK 12. Those tasks are being tracked under the umbrella bug JDK

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-25 Thread Jonathan Gibbons
On 6/25/18 4:13 PM, David Holmes wrote: And should these be using --release instead of -source + -target? There might be a chicken-and-egg problem here, since --release needs to be appropriately updated as well.  -source and -target are simpler and more likely to be easy to update. -- Jo

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-25 Thread David Holmes
Hi Joe, On 26/06/2018 4:10 AM, joe darcy wrote: Hello, With the JDK 11 and 12 split fast approaching [1], it is time to work on the various start of release update tasks for JDK 12. Those tasks are being tracked under the umbrella bug JDK-8205615: "Start of release updates for JDK 12". Thi

JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-25 Thread joe darcy
Hello, With the JDK 11 and 12 split fast approaching [1], it is time to work on the various start of release update tasks for JDK 12. Those tasks are being tracked under the umbrella bug JDK-8205615: "Start of release updates for JDK 12". This thread is to review the build-related portions o