Re: JI-9008287 - configure should provide better error reports about bootjvm binaries

2013-11-25 Thread David Holmes
Hi Dave, common/autoconf/generated-configure.sh stills contains an IBM copyright notice. Was it regenerated? Thanks, David On 26/11/2013 12:46 AM, Dave Pointon wrote: Hi David , On Thu, 2013-11-21 at 16:34 +, Dave Pointon wrote: Hi David , On Fri, 2013-11-22 at 01:45 +1000, David

Re: JI-9008287 - configure should provide better error reports about bootjvm binaries

2013-11-21 Thread Dave Pointon
Hi David , On Fri, 2013-11-22 at 01:45 +1000, David Holmes wrote: snip Please do. I moved the JI issue to JDK: https://bugs.openjdk.java.net/browse/JDK-8028794 Not sure what your plans was for getting this pushed but we are in a phase were an approval process has to be followed to make

Re: JI-9008287 - configure should provide better error reports about bootjvm binaries

2013-11-21 Thread Dave Pointon
Hi again, Magnus , On Fri, 2013-11-22 at 00:35 +1000, David Holmes wrote: On 21/11/2013 11:05 PM, Magnus Ihse Bursie wrote: On 2013-11-19 13:47, Dave Pointon wrote: The updated webrev can be found at http://cr.openjdk.java.net/~ngmr/JI-9008287/webrev.02/ The actual code looks better,

Re: JI-9008287 - configure should provide better error reports about bootjvm binaries

2013-11-21 Thread David Holmes
On 21/11/2013 11:05 PM, Magnus Ihse Bursie wrote: On 2013-11-19 13:47, Dave Pointon wrote: The updated webrev can be found at http://cr.openjdk.java.net/~ngmr/JI-9008287/webrev.02/ The actual code looks better, but I'm not so sure about the copyright header. The actual change was indeed very

Re: JI-9008287 - configure should provide better error reports about bootjvm binaries

2013-11-21 Thread David Holmes
On 22/11/2013 1:02 AM, Dave Pointon wrote: Hi again, Magnus , On Fri, 2013-11-22 at 00:35 +1000, David Holmes wrote: On 21/11/2013 11:05 PM, Magnus Ihse Bursie wrote: On 2013-11-19 13:47, Dave Pointon wrote: The updated webrev can be found at

Re: JI-9008287 - configure should provide better error reports about bootjvm binaries

2013-11-19 Thread Dave Pointon
Hi David , On Tue, 2013-11-19 at 06:28 +1000, David Holmes wrote: Hi Dave, On 19/11/2013 1:34 AM, Dave Pointon wrote: snip Minor style nit but note that the pattern used everywhere is x$FOO = x. So changing to use j or r is undesirable. OK, TFT. It was merely an obviously misguided

Re: JI-9008287 - configure should provide better error reports about bootjvm binaries

2013-11-19 Thread Magnus Ihse Bursie
On 2013-11-18 21:28, David Holmes wrote: MOre generally this seems solvable simply by changing the existing error message to an executable binary file for could not be found - and the user could see if it was missing or just not marked executable. :) I agree with David. The solution

Re: JI-9008287 - configure should provide better error reports about bootjvm binaries

2013-11-19 Thread Dave Pointon
Hi Magnus , On Tue, 2013-11-19 at 12:15 +0100, Magnus Ihse Bursie wrote: snip I have a hard time believing it is a common problem that a JDK installation exists, where the executable permission is missing. So it's reasonable to have this as a last time check, and not as part of the

Re: JI-9008287 - configure should provide better error reports about bootjvm binaries

2013-11-19 Thread Dave Pointon
On Tue, 2013-11-19 at 12:03 +, Dave Pointon wrote: Hi Magnus , snip I don't disagree - with the benefit of hindsight + invaluable insight provided by the group, I think that I am reading far too much into the problem I encountered whilst building, or attempting to build, the IBM

JI-9008287 - configure should provide better error reports about bootjvm binaries

2013-11-18 Thread Dave Pointon
Hi again all , Having encountered the above defect and implemented a/the solution, I would appreciate your feedback /or comment. Thanks to Neil Richards, the exploded webrev can be found at http://cr.openjdk.java.net/~ngmr/JI-9008287/webrev.01/ Note that, if it isn't already obvious, the defect

Re: JI-9008287 - configure should provide better error reports about bootjvm binaries

2013-11-18 Thread David Holmes
Hi Dave, On 19/11/2013 1:34 AM, Dave Pointon wrote: Hi again all , Having encountered the above defect and implemented a/the solution, I would appreciate your feedback /or comment. Thanks to Neil Richards, the exploded webrev can be found at