Re: Need reviewer for fix to Mac jdk partial builds

Should be integrated now in the jdk8/build/jdk repository. -kto On Sep 21, 2012, at 4:38 AM, Anthony Petrov wrote: > Hi Kelly, > > The JDK 8 partial repository (only the jdk itself) builds fine on my Mac with > your changes. The fix looks good to me, although I don't have deep knowledge > of

Re: Need reviewer for fix to Mac jdk partial builds

Hi Kelly, The JDK 8 partial repository (only the jdk itself) builds fine on my Mac with your changes. The fix looks good to me, although I don't have deep knowledge of the components being modified. Thanks for fixing this issue! -- best regards, Anthony On 9/20/2012 5:19 AM, Kelly O'Hair wr

Need reviewer for fix to Mac jdk partial builds

7191703: jprt cannot build jdk on MacOSX. http://cr.openjdk.java.net/~ohair/openjdk8/jobjc-fix/webrev/ Fixes a partial build issue with the jdk repo on the Mac. If LANGTOOLS_DIST is defined, nothing changes and the ant script should find langtools/dist/classes.jar. Otherwise, by running ant with

Re: Need reviewer

On Jul 16, 2012, at 1:07 PM, David Katleman wrote: > > > On 7/16/2012 10:52 AM, Kelly O'Hair wrote: >> Minor change to the get_source/hgforest scripts to allow for trailing // >> Plus adding the whitespace normalizer perl script to the openjdk7updates >> forest. >> >> 7184406: Adjust get_sour

Re: Need reviewer

On 7/16/2012 10:52 AM, Kelly O'Hair wrote: Minor change to the get_source/hgforest scripts to allow for trailing // Plus adding the whitespace normalizer perl script to the openjdk7updates forest. 7184406: Adjust get_source/hgforest script to allow for trailing // characters http://cr.openjdk.

Re: Need reviewer

On 07/16/12 10:52, Kelly O'Hair wrote: Minor change to the get_source/hgforest scripts to allow for trailing // Plus adding the whitespace normalizer perl script to the openjdk7updates forest. 7184406: Adjust get_source/hgforest script to allow for trailing // characters http://cr.openjdk.java.n

Need reviewer

Minor change to the get_source/hgforest scripts to allow for trailing // Plus adding the whitespace normalizer perl script to the openjdk7updates forest. 7184406: Adjust get_source/hgforest script to allow for trailing // characters http://cr.openjdk.java.net/~ohair/openjdk8/get_source_double_sla

Re: Need reviewer - @GenerateNativeHeader

so bottom line ... if you can determine that the GenerateNativeHeader is not needed you can delete it but please be sure Sent from my iPhone On Jun 28, 2012, at 15:35, Erik Joelsson wrote: > Hello, > > It's quite possible that the constants aren't needed. However, those files > are currentl

Re: Need reviewer - @GenerateNativeHeader

Hello, It's quite possible that the constants aren't needed. However, those files are currently on the list of files in the old build system that gets headers generated for them, and those headers are in turn included by native source files. The new annotation for automatically generating nat

Re: Need reviewer - @GenerateNativeHeader

Hi, Kelly. Because there is no constants that "are needed in the supporting JNI code". For example in *LWLabelPeer.java:* private static final int TEXT_XPAD = 5; private static final int TEXT_YPAD = 1; These constants are really used in a nativ? code? 29.06.2012 01:38, Kelly O'Hair wrote

Re: Need reviewer - @GenerateNativeHeader

Why do you say they are unnecessary? -kto On Jun 28, 2012, at 7:03 AM, Sergey Bylokhov wrote: > Hi, Kelly. > Looks like changes in these files are unnecessary. > Cdiffs Udiffs Sdiffs Frames Old New Patch Raw > src/macosx/classes/sun/lwawt/LWLabelPeer.java > > 4 lines changed: 4 ins; 0 del; 0 m

Re: Need reviewer - @GenerateNativeHeader

Hi, Kelly. Looks like changes in these files are unnecessary. |Cdiffs Udiffs

Re: Need reviewer: build-infra makefile changes

On 2012-06-11 14:57, Erik Joelsson wrote: And I've found two issues in the windows build that I would like to correct. http://cr.openjdk.java.net/~erikj/build-infra-m1.1/webrev-jdk-windowsfix/ Looks fine to me! /Magnus

Re: Need reviewer: build-infra makefile changes

I just pushed this change in. -kto On Jun 11, 2012, at 5:57 AM, Erik Joelsson wrote: > And I've found two issues in the windows build that I would like to correct. > > http://cr.openjdk.java.net/~erikj/build-infra-m1.1/webrev-jdk-windowsfix/ > > makefiles/java/redist/sajdi/Makefile > The windo

Re: Need reviewer: build-infra makefile changes

And I've found two issues in the windows build that I would like to correct. http://cr.openjdk.java.net/~erikj/build-infra-m1.1/webrev-jdk-windowsfix/ makefiles/java/redist/sajdi/Makefile The windows build broke when the full debug symbols were introduced.

Re: Need reviewer: build-infra makefile changes

Technically, I had plenty of reviewers via the build-infra team, my wording was a bit off on this email. Sorry. These new build-infra changes have now been pushed into the jdk8/build forest. I have NOT verified the build-infra builds, only verified that the existing old makefiles are not impact

Need reviewer: build-infra makefile changes

No impact to the current makefiles. This is changes for the new build-infra makefiles. I'm sure there is more to come. Thanks to Erik, Magnus, Fredrik, and Jonas. If I missed anyone else that has contributed on this, my apologies. 7170079: Adjustments to build-infra makefiles http://cr.openj

Re: Need reviewer - @GenerateNativeHeader

On 2012-05-23 09:51, Fredrik Öhrström wrote: There is no point holding off this push since GenerateNativeHeader annotation and uses of it were already pushed long time ago. These are just the finishing touches to cater for the conversion of the remaining makefiles. I think Fredrik has a point her

Re: Need reviewer - @GenerateNativeHeader

There is no point holding off this push since GenerateNativeHeader annotation and uses of it were already pushed long time ago. These are just the finishing touches to cater for the conversion of the remaining makefiles. If you want another location for the annotation then we can easily search and

Re: Need reviewer - @GenerateNativeHeader

Kelly, Can you hold off pushing this for a few days? While this is compile-time only dependency I think the impact needs further study. -Alan. On 23/05/2012 02:14, Kelly O'Hair wrote: 7170969: Add @GenerateNativeHeader to classes whose fields need to be exported for JNI http://cr.openjdk.j

Re: Need reviewer - @GenerateNativeHeader

Looks good. Since the annotation is a compile time only annotation, it should not affect any future modularization efforts. Right Alan? //Fredrik 2012/5/23 Kelly O'Hair : > > 7170969: Add @GenerateNativeHeader to classes whose fields need to be > exported for JNI > http://cr.openjdk.java.net/~

Need reviewer - @GenerateNativeHeader

7170969: Add @GenerateNativeHeader to classes whose fields need to be exported for JNI http://cr.openjdk.java.net/~ohair/openjdk8/generateHeaders1/webrev/ The new build infrastructure wants to fully automate the generation of the JNI header files (running javah). On classes that have "native" m

Re: Need reviewer - get_source.sh changes

I messed up somehow, the sed command is misbehaving on me constructing the extra repo path. I have changed the logic to sed out the tail of the default path, then just glue that to the extra path. Unfortunately, I pushed the first set of changes (could have sworn it worked on the Mac) so I ne

Re: Need reviewer - get_source.sh changes

Looks good! /Staffan On 9 maj 2012, at 20:13, Kelly O'Hair wrote: > > This change does not impact any openjdk use, but helps the Oracle engineers > get off the > forest extension (fclone command) if they want to. > > Changes the get_source.sh script so that you can provide an optional server

Re: Need reviewer - get_source.sh changes

On 10/05/2012 08:36, Erik Joelsson wrote: That will certainly be convenient. I've tried it and it works for me. Code looks good. +1, thanks Kelly. Anything that aids the migration off the forest extension can only be a good thing. The changes look fine to me. -Chris. /Erik On 2012-05-09

Re: Need reviewer - get_source.sh changes

That will certainly be convenient. I've tried it and it works for me. Code looks good. /Erik On 2012-05-09 20:13, Kelly O'Hair wrote: This change does not impact any openjdk use, but helps the Oracle engineers get off the forest extension (fclone command) if they want to. Changes the get_sou

Need reviewer - get_source.sh changes

This change does not impact any openjdk use, but helps the Oracle engineers get off the forest extension (fclone command) if they want to. Changes the get_source.sh script so that you can provide an optional server replacement path for http://hg.openjdk.java.net and fetching the so called "clos

Re: Need reviewer: corba changes for build infra

> This is all as expected, although perhaps questionable style. > > Given Fredrik's comments too, are you ok with the changes? Thanks for the back-story on this corner of the build. I am fine with the changes. Tim

Re: Need reviewer: corba changes for build infra

On Mar 12, 2012, at 10:14 PM, Tim Bell wrote: > Hi Kelly > >> Need a reviewer for these build-infra changes to the strip properties >> utility in the corba repository. >> >> 7153266: Adjustments to corba strip property utility (neutral to builds) >> http://cr.openjdk.java.net/~ohair/openjdk8/i

Re: Need reviewer: corba changes for build infra

The way properties files are handled in the jdk builds is inconsistent and this should be considered a bandaid until we get the common makefile logic up into the top repository and used by all lower level repositories. I recall making a change a long time ago to StripProperties.java to allow for

Re: Need reviewer: corba changes for build infra

Frederik, > In the new build system, the StripProperties and CompileProperties > will be annotation processors inside the smart javac wrapper inside > langtools. Neat and clean. OK. Thank you! It probably much better than sed script with conditional changes. -Dmitry On 2012-03-13 13:47, Fredrik

Re: Need reviewer: corba changes for build infra

2012-03-13 10:24, Dmitry Samersoff skrev: > Frederik, > > Just a curious - why we need a Java program here? > Could sed do the same with less efforts? In the old build system, there are two StripProperties.java in corba and in the jdk with slightly different implementations and command line option

Re: Need reviewer: corba changes for build infra

Frederik, Just a curious - why we need a Java program here? Could sed do the same with less efforts? -Dmitry On 2012-03-13 13:08, Fredrik Öhrström wrote: > 2012-03-13 06:30, Tim Bell skrev: >> >> Sorry, I meant to pick on these lines, and also mention that >> args.length should be an even numbe

Re: Need reviewer: corba changes for build infra

2012-03-13 06:30, Tim Bell skrev: > > Sorry, I meant to pick on these lines, and also mention that > args.length should be an even number at line 64... > > 107 infiles.add(args[i]); > 108 outfiles.add(args[i]); > > Otherwise, my remarks apply, FWIW. You are right,

Re: Need reviewer: corba changes for build infra

I wrote: > I find this is a bit alarming - won't it overwrite the input file with > the output file? > >  120             String infile = inIter.next(); >  121             String outfile = outIter.next(); Sorry, I meant to pick on these lines, and also mention that args.length should be an even n

Re: Need reviewer: corba changes for build infra

Hi Kelly > Need a reviewer for these build-infra changes to the strip properties utility > in the corba repository. > > 7153266: Adjustments to corba strip property utility (neutral to builds) > http://cr.openjdk.java.net/~ohair/openjdk8/infra-corba/webrev/ Looks good overall. I find this is a

Need reviewer: corba changes for build infra

Need a reviewer for these build-infra changes to the strip properties utility in the corba repository. 7153266: Adjustments to corba strip property utility (neutral to builds) http://cr.openjdk.java.net/~ohair/openjdk8/infra-corba/webrev/ -kto

Re: Fwd: Need reviewer, 7150322: Stop using drop source bundles in jaxws

Looks fine to me too! //Fredrik 2012/3/6 Joe Darcy : > Looks fine, > > -Joe > > > On 3/6/2012 9:24 AM, Kelly O'Hair wrote: > > Still need a reviewer or 2 on this. > > -kto > > > Begin forwarded message: > > From: "Kelly O'Hair"

Re: Fwd: Need reviewer, 7150322: Stop using drop source bundles in jaxws

Looks fine, -Joe On 3/6/2012 9:24 AM, Kelly O'Hair wrote: Still need a reviewer or 2 on this. -kto Begin forwarded message: *From: *"Kelly O'Hair" <mailto:kelly.oh...@oracle.com>> *Subject: **Need reviewer, 7150322: Stop using drop source bundles in jaxws * *

Fwd: Need reviewer, 7150322: Stop using drop source bundles in jaxws

Still need a reviewer or 2 on this. -kto Begin forwarded message: > From: "Kelly O'Hair" > Subject: Need reviewer, 7150322: Stop using drop source bundles in jaxws > Date: March 2, 2012 15:49:28 PM PST > To: build-dev build-dev > > Similar to jaxp change,

Re: Need reviewer on addition of whitespace normalizer script

Thanks for explaining, John. This should work fine regardless of indentation size as long as the tab stops in your editor are 8 wide (which may or may not be global truth). Kelly: Looks good! /Staffan On 3 mar 2012, at 14:55, John Rose wrote: > Lest Kelly have all the fun, I'll jump in. > >

Re: Fwd: Need reviewer, 7150324: Stop using drop bundles in jaxp

n we worked to remove the drop bundle process for JAXP. The change looks good to me. Thanks, Joe -kto Begin forwarded message: *From: *"Kelly O'Hair" <mailto:kelly.oh...@oracle.com>> *Subject: **Need reviewer, 7150324: Stop using drop bundles in jaxp * *Date: *Ma

Re: Need reviewer on addition of whitespace normalizer script

John, Wrote extendable nit hunting framework ;-) (attached) Fill free to add/change rules. This script doesn't change a source file but complains about found formatting errors. It should save a bit of time during code review. -Dmitry On 2012-03-03 23:55, John Rose wrote: > Lest Kelly have al

Re: Need reviewer on addition of whitespace normalizer script

Lest Kelly have all the fun, I'll jump in. On Mar 3, 2012, at 3:36 AM, David Holmes wrote: > So the question is: what does the script think a TAB represents? The same thing that /usr/bin/expand does, as noted earlier. Or read the perl code. When was the last time anybody on the hotspot team u

Re: Need reviewer on addition of whitespace normalizer script

does it replace a TAB with? 4 spaces for JDK or 2 spaces for Hotspot? David -kto On Mar 2, 2012, at 1:00 AM, Staffan Larsen wrote: Does this handle the difference between indents in HotSpot (indent 2) vs the JDK (indent 4)? /Staffan On 1 mar 2012, at 22:32, Kelly O'Hair wrote: Need

Re: Need reviewer on addition of whitespace normalizer script

at 1:00 AM, Staffan Larsen wrote: Does this handle the difference between indents in HotSpot (indent 2) vs the JDK (indent 4)? /Staffan On 1 mar 2012, at 22:32, Kelly O'Hair wrote: Need reviewer. Adding the whitespace normalizer script as a convenience to the jdk developers. 6625113: Add

Need reviewer, 7150322: Stop using drop source bundles in jaxws

Similar to jaxp change, but the source normalization was not needed. 7150322: Stop using drop source bundles in jaxws http://cr.openjdk.java.net/~ohair/openjdk8/infra-jaxws/webrev/ I'm working on helping to get the jdk8 build-infra changes integrated, this is for jaxws. This is just the changes

Re: Need reviewer on addition of whitespace normalizer script

es it replace a TAB with? 4 spaces for JDK or 2 > spaces for Hotspot? > > David > >> -kto >> >> On Mar 2, 2012, at 1:00 AM, Staffan Larsen wrote: >> >>> Does this handle the difference between indents in HotSpot (indent 2) vs >>> the JDK (i

Re: Need reviewer on addition of whitespace normalizer script

On 03/02/2012 03:04 PM, David Holmes wrote: On 3/03/2012 3:12 AM, Kelly O'Hair wrote: I don't understand the question. It only changes TAB characters, removes trailing whitespace on lines, and duplicate blank lines at the end of the file. I think the issue is what does it replace a TAB with? 4

Re: Need reviewer on addition of whitespace normalizer script

or Hotspot? David -kto On Mar 2, 2012, at 1:00 AM, Staffan Larsen wrote: Does this handle the difference between indents in HotSpot (indent 2) vs the JDK (indent 4)? /Staffan On 1 mar 2012, at 22:32, Kelly O'Hair wrote: Need reviewer. Adding the whitespace normalizer script as a con

Re: Need reviewer, 7150324: Stop using drop bundles in jaxp

It looks OK to me but I'm not an ant expert. -phil. On 3/2/2012 12:57 PM, Kelly O'Hair wrote: 7150324: Stop using drop bundles in jaxp http://cr.openjdk.java.net/~ohair/openjdk8/infra-jaxp/webrev/ I'm working on helping to get the jdk8 build-infra changes integrated, this is for jaxp. This i

Need reviewer, 7150324: Stop using drop bundles in jaxp

7150324: Stop using drop bundles in jaxp http://cr.openjdk.java.net/~ohair/openjdk8/infra-jaxp/webrev/ I'm working on helping to get the jdk8 build-infra changes integrated, this is for jaxp. This is just the changes to the build files to remove the use of the drop bundles and add a new Makefi

Re: Need reviewer on addition of whitespace normalizer script

ript brakes multiline constants if we use it for languages that >>> allow it. >> >> There were several places in the JDK sources that did have tabs in literal >> strings when we >> did the original normalization, in all cases they were mistakes in the java >>

Re: Need reviewer on addition of whitespace normalizer script

e > JDK (indent 4)? > > /Staffan > > On 1 mar 2012, at 22:32, Kelly O'Hair wrote: > >> >> Need reviewer. Adding the whitespace normalizer script as a convenience to >> the jdk developers. >> >> 6625113: Add the normalize and rmkw perl

Re: Need reviewer on addition of whitespace normalizer script

he discuss alias. -kto > > -Dmitry > >> >> David >> - >> >>> >>> -Dmitry >>> >>> On 2012-03-02 01:32, Kelly O'Hair wrote: >>>> >>>> Need reviewer. Adding the whitespace normalizer script as a >&

Re: Need reviewer on addition of whitespace normalizer script

unintentionally done by the original authors of that code. > There were no instances of anyone needing an actual TAB character in the > source files. > > -kto > >> >> -Dmitry >> >> On 2012-03-02 01:32, Kelly O'Hair wrote: >>> >>> Need revi

Re: Need reviewer on addition of whitespace normalizer script

so >> this script brakes multiline constants if we use it for languages that >> allow it. > > In what circumstances would a literal with an embedded tab be valid? AFAIK we > should always be using /t. My position also. -kto > > David > - > >> >&g

Re: Need reviewer on addition of whitespace normalizer script

actual TAB character in the source files. -kto > > -Dmitry > > On 2012-03-02 01:32, Kelly O'Hair wrote: >> >> Need reviewer. Adding the whitespace normalizer script as a convenience to >> the jdk developers. >> >> 6625113: Add the normalize and

Re: Need reviewer on addition of whitespace normalizer script

Does this handle the difference between indents in HotSpot (indent 2) vs the JDK (indent 4)? /Staffan On 1 mar 2012, at 22:32, Kelly O'Hair wrote: > > Need reviewer. Adding the whitespace normalizer script as a convenience to > the jdk developers. > > 6625113: Add th

Re: Need reviewer on addition of whitespace normalizer script

nd I see no reason to replace it forcibly. -Dmitry > > David > - > >> >> -Dmitry >> >> On 2012-03-02 01:32, Kelly O'Hair wrote: >>> >>> Need reviewer. Adding the whitespace normalizer script as a >>> convenience to the jdk develope

Re: Need reviewer on addition of whitespace normalizer script

s be using /t. David - -Dmitry On 2012-03-02 01:32, Kelly O'Hair wrote: Need reviewer. Adding the whitespace normalizer script as a convenience to the jdk developers. 6625113: Add the normalize and rmkw perl script to the openjdk repository or openjdk site? http://cr.openjdk.

Re: Need reviewer on addition of whitespace normalizer script

I.e. if we have string constant with tab inside script brake it. Also this script brakes multiline constants if we use it for languages that allow it. -Dmitry On 2012-03-02 01:32, Kelly O'Hair wrote: > > Need reviewer. Adding the whitespace normalizer script as a convenience to

Re: Need reviewer on addition of whitespace normalizer script

Looks fine Kelly; great to have this sort of script included with the JDK itself. -Joe On 3/1/2012 1:32 PM, Kelly O'Hair wrote: Need reviewer. Adding the whitespace normalizer script as a convenience to the jdk developers. 6625113: Add the normalize and rmkw perl script to the op

Need reviewer on addition of whitespace normalizer script

Need reviewer. Adding the whitespace normalizer script as a convenience to the jdk developers. 6625113: Add the normalize and rmkw perl script to the openjdk repository or openjdk site? http://cr.openjdk.java.net/~ohair/openjdk8/normalizer-script/webrev/ Probably a little history is warranted

Re: Need reviewer: fixes to prtconf for solaris zones and less execs

Change looks correct, follows what we discussed. Thanks Dave On 1/4/2012 3:50 PM, Kelly O'Hair wrote: Need reviewer: fixes to prtconf for solaris zones and less execs Basically this patch, will be made to openjdk6, 7u4, and jdk8: diff --git a/make/common/shared/Platform.gmk b

Need reviewer: fixes to prtconf for solaris zones and less execs

Need reviewer: fixes to prtconf for solaris zones and less execs Basically this patch, will be made to openjdk6, 7u4, and jdk8: diff --git a/make/common/shared/Platform.gmk b/make/common/shared/Platform.gmk --- a/make/common/shared/Platform.gmk +++ b/make/common/shared/Platform.gmk @@ -147,8

Re: Need reviewer

On Jul 22, 2011, at 5:09 PM, David Katleman wrote: > > > On 7/22/2011 4:57 PM, Kelly O'Hair wrote: >> >> Can one of you review these jprt changes, there is no impact to RE or manual >> developer building. >> >> These changes are needed to instruct our internal developer build system >> JPRT

Re: Need reviewer

Hi Kelly, Thank you for making this change!! I see that Dave has already approved it. I am not a JPRT expert, but fwiw, I also looked at the changes, they actually made sense to me :) Looks good. Thanks, Lana On 07/22/2011 04:57 PM, Kelly O'Hair wrote: Can one of you review these jprt chang

Re: Need reviewer

On 7/22/2011 4:57 PM, Kelly O'Hair wrote: Can one of you review these jprt changes, there is no impact to RE or manual developer building. These changes are needed to instruct our internal developer build system JPRT on how to build jdk8. 7069993: Adjust make/jprt.properties file for jdk8

Need reviewer

Can one of you review these jprt changes, there is no impact to RE or manual developer building. These changes are needed to instruct our internal developer build system JPRT on how to build jdk8. 7069993: Adjust make/jprt.properties file for jdk8 http://cr.openjdk.java.net/~ohair/openjdk8/jprt

Re: Need reviewer: Added test target and makefile cleanups

On May 11, 2011, at 7:54 AM, Omair Majid wrote: >> >> This will take a little looking. I'll file a separate CR (7043700) on this, >> but no promises. >> I don't want to backout the original changeset completely, maybe ifdef it >> for windows. >> > > I didnt mean that we should backout the ch

Re: Need reviewer: Added test target and makefile cleanups

On 05/10/2011 08:45 PM, Kelly O'Hair wrote: On May 5, 2011, at 4:14 PM, Omair Majid wrote: Hi Kelly, Kelly O'Hair writes: Need reviewer: Added test target and makefile cleanups 6960335: Add top level 'make test' rule that uses test/Makefile, runs all test batc

Re: Need reviewer: Added test target and makefile cleanups

On May 5, 2011, at 4:14 PM, Omair Majid wrote: > Hi Kelly, > > Kelly O'Hair writes: >> >> >> Need reviewer: Added test target and makefile cleanups >> >> 6960335: Add top level 'make test' rule that uses test/Makefile, runs >> a

Re: Need reviewer: Added test target and makefile cleanups

Hi Kelly, Kelly O'Hair writes: > > > Need reviewer: Added test target and makefile cleanups > > 6960335: Add top level 'make test' rule that uses test/Makefile, runs > all test batches > 6960853: Cleanup makefiles, remove unused vars etc. > > http:

Re: Need Reviewer: change MAX_VM_MEMORY to 512

om <mailto:suchen.ch...@oracle.com> > To:kelly.oh...@oracle.com <mailto:kelly.oh...@oracle.com> > Cc:build-dev@openjdk.java.net <mailto:build-dev@openjdk.java.net>,david.katle...@oracle.com <mailto:david.katle...@oracle.com> > Sent: Friday, April 15, 2011 9:17:15 AM GMT

Re: Need Reviewer: change MAX_VM_MEMORY to 512

d delete all the comments about subtracting. Any machine doing a build with less than 512Mb is very very questionable. -kto > On Apr 12, 2011, at 4:29 PM, suchen.ch...@oracle.com wrote: > Need Reviewer: change MAX_VM_MEMORY to 512 Windows systems may not be able to handle 896 ma

Re: Need reviewer: Correcting jar manifests

I'm certainly not qualified to have a voice on the review, but I looked anyway and it is ok. Cheers -- Julien Ponge http://julien.ponge.info/ On Friday, April 22, 2011 at 4:31 AM, Kelly O'Hair wrote: > Need reviewer for these jar manifest changes. > > Multiple iss

Re: Need reviewer: CC_VER checks on compiler options

I do not see anything obviously wrong in this change (did not validate that all used macros actually equivalent though). So, looks ok for push. -igor On 4/21/11 2:33 PM, Kelly O'Hair wrote: This started out as an annoyance around the use of -Wno-clobber on Linux when the gcc might not suppor

Re: Need reviewer: CC_VER checks on compiler options

On Apr 21, 2011, at 2:53 PM, Dr Andrew John Hughes wrote: > On 14:33 Thu 21 Apr , Kelly O'Hair wrote: >> >> This started out as an annoyance around the use of -Wno-clobber on Linux >> when the gcc might >> not support it. Turned into fixing several CC_VER checks in the makefiles: >> >> 703

Need Reviewer: change MAX_VM_MEMORY to 512

Need Reviewer: change MAX_VM_MEMORY to 512 Windows systems may not be able to handle 896 max memory on every java app started up. Depends on what the system is running, even on a 2Gb system. Recommend lowering the 896 to 640 or maybe even 512 if possible. 6903609: Max memory of 896 may be

Re: Need reviewer: Correcting jar manifests

On 4/21/11 7:31 PM, Kelly O'Hair wrote: Need reviewer for these jar manifest changes. Multiple issues here: * Bean manifest information should only be in rt.jar, not resources.jar, jsse.jar, * Added missing basic jdk manifest information into demo jar manifests * JCE jars man

Re: Need reviewer: CC_VER checks on compiler options

On Apr 22, 2011, at 12:12 AM, David Holmes wrote: > Hi Kelly, > > Kelly O'Hair said the following on 04/22/11 07:33: >> This started out as an annoyance around the use of -Wno-clobber on Linux >> when the gcc might >> not support it. Turned into fixing several CC_VER checks in the makefiles: >>

Re: Need reviewer: demo fixes from a long time ago ...

On Mar 15, 2011, at 3:50 PM, Mandy Chung wrote: > On 3/15/11 2:25 PM, Kelly O'Hair wrote: >> Need reviewer for these 2 demo fixes: >> >> 6685150: make/mkdemo/jpda/Makefile creates jpda.jar and src.zip instead of >> examples.jar >> 6710813: SwingSet2 sourc

Re: Need reviewer: Turn off warnings for mapfiles in fastdebug builds

gt; >>>> Strange... I need a reviewer on this small change not sure why my >>>> email never showed up. :^( >>>> Begin forwarded message: >>>> >>>>> *From: *Kelly O'Hair >>>> <mailto:kelly.oh...@oracle.com&

Re: Need reviewer: Copyright year updates

Correct. I ran this first, to make sure some of the last 2010 changesets pushed in were covered for 2010: sh ./make/scripts/update_copyright_year.sh 2010 Then I ran sh ./make/scripts/update_copyright_year.sh 2011 To catch all the 2011 changesets. So I would expect a few to be updates to 201

Need reviewer: Turn off warnings for mapfiles in fastdebug builds

Need reviewer: Turn off warnings for mapfiles in fastdebug builds The mapfiles are generally not used on fastdebug or debug builds, this just turns off the warning in these cases, making it just an informative piece of information. 7033960: Do not check for mapfiles when fastdebug building

Re: Need reviewer: CC_VER checks on compiler options

Kelly O'Hair said the following on 04/23/11 02:17: On Apr 22, 2011, at 12:12 AM, David Holmes wrote: We can now drop the cross-compile check in jpeg/Makefile if you are going to make this conditional on the compiler version. The only reason we added this was because our ppc compiler is only 4.

Re: Need reviewer: Correcting jar manifests

Hi Kelly, didn't see any issues with the makefile logic. Dave On 4/21/2011 7:31 PM, Kelly O'Hair wrote: Need reviewer for these jar manifest changes. Multiple issues here: * Bean manifest information should only be in rt.jar, not resources.jar, jsse.jar, * Added mis

Re: Need reviewer: Correcting jar manifests

Kelly O'Hair wrote: Need reviewer for these jar manifest changes. Multiple issues here: * Bean manifest information should only be in rt.jar, not resources.jar, jsse.jar, * Added missing basic jdk manifest information into demo jar manifests * JCE jars manifest missing company

Re: Need reviewer: CC_VER checks on compiler options

Hi Kelly, Kelly O'Hair said the following on 04/22/11 07:33: This started out as an annoyance around the use of -Wno-clobber on Linux when the gcc might not support it. Turned into fixing several CC_VER checks in the makefiles: 7038711: Fix CC_VER checks for compiler options, fix use of -Wno-c

Need reviewer: Correcting jar manifests

Need reviewer for these jar manifest changes. Multiple issues here: * Bean manifest information should only be in rt.jar, not resources.jar, jsse.jar, * Added missing basic jdk manifest information into demo jar manifests * JCE jars manifest missing company name change * Specification

Re: Need reviewer: CC_VER checks on compiler options

On 14:33 Thu 21 Apr , Kelly O'Hair wrote: > > This started out as an annoyance around the use of -Wno-clobber on Linux when > the gcc might > not support it. Turned into fixing several CC_VER checks in the makefiles: > > 7038711: Fix CC_VER checks for compiler options, fix use of -Wno-clobbe

Re: Need reviewer: CC_VER checks on compiler options

Thanks. I'll run it through JPRT and multiple builds before integrating. Did not intend to be fixing this at this time, but I can't leave it be. Must be the altar boy in me. ;^) -kto On Apr 21, 2011, at 2:47 PM, Igor Nekrestyanov wrote: > I do not see anything obviously wrong in this change (

Need reviewer: CC_VER checks on compiler options

This started out as an annoyance around the use of -Wno-clobber on Linux when the gcc might not support it. Turned into fixing several CC_VER checks in the makefiles: 7038711: Fix CC_VER checks for compiler options, fix use of -Wno-clobber http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-cc

Re: Need reviewer: Exceptions to mapfile rule on shared libraries

On 15:14 Fri 15 Apr , Phil Race wrote: > For jpeg its something we could consider for JDK 8 although I think its been > called libjpeg since JDK 1.0 without apparent problems. But you use an in-tree libjpeg (at least at present). Having the option of linking against a system libjpeg at compil

Re: Need reviewer: Exceptions to mapfile rule on shared libraries

For jpeg its something we could consider for JDK 8 although I think its been called libjpeg since JDK 1.0 without apparent problems. But this JDK libxinerama is only for Solaris (SPARC, specifically), and on Solaris Xinerama functionality has always lived in libXext.so, so there's no clash. Sola

Re: Need Reviewer: change MAX_VM_MEMORY to 512

5 AM GMT -08:00 US/Canada Pacific > Subject: Re: Need Reviewer: change MAX_VM_MEMORY to 512 > > > Hi Kelly, > Thanks for reviewing and providing the suggestion. I've tested with the suggested codes and updated the webrev. > Regards, Su-Chen > On Apr 12

Re: Need Reviewer: change MAX_VM_MEMORY to 512

estionable. -kto On Apr 12, 2011, at 4:29 PM, suchen.ch...@oracle.com wrote: Need Reviewer: change MAX_VM_MEMORY to 512 Windows systems may not be able to handle 896 max memory on every java app started up. Depends on what the system is running, even on a 2Gb system. Recommend lowering t

Re: Need reviewer: Exceptions to mapfile rule on shared libraries

On 16:18 Tue 12 Apr , Kelly O'Hair wrote: > > On Apr 12, 2011, at 3:58 PM, Dr Andrew John Hughes wrote: > > > On 13:46 Tue 12 Apr , Kelly O'Hair wrote: > >> > >> Some shared libraries do not have and will not have mapfiles, at least for > >> now, we > >> give these an exception to the m

Re: Need Reviewer: add LocaleNames_no_NO_NY.properties to jdk/make/java/util/FILES_properties.gmk

e sure he is ok with the change. -kto On Apr 11, 2011, at 4:05 PM, suchen.ch...@oracle.com <mailto:suchen.ch...@oracle.com> wrote: Need Reviewer: add LocaleNames_no_NO_NY.properties to jdk/make/java/util/FILES_properties.gmk LocaleNames_no_NO_NY.class is missing in rt.jar. File jdk/

  1   2   3   4   >