Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

2016-12-20 Thread Thomas Stüfe
Thanks Volker! On Tue, Dec 20, 2016 at 9:11 AM, Volker Simonis wrote: > Looks good! > > Volker > > > On Mon, Dec 19, 2016 at 2:33 PM, Thomas Stüfe > wrote: > > > > On Sun, Dec 18, 2016 at 1:13 PM, Thomas Stüfe > > wrote: > >> > >> HI all, > >> > >> after investigating I see a number of issues

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

2016-12-20 Thread Volker Simonis
Looks good! Volker On Mon, Dec 19, 2016 at 2:33 PM, Thomas Stüfe wrote: > > On Sun, Dec 18, 2016 at 1:13 PM, Thomas Stüfe > wrote: >> >> HI all, >> >> after investigating I see a number of issues preventing gtest from running >> on AIX, so I decided to get the fix for the wrong assert in the h

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

2016-12-19 Thread Thomas Stüfe
Thanks David! On Dec 19, 2016 21:43, "David Holmes" wrote: > > > On 18/12/2016 10:13 PM, Thomas Stüfe wrote: > >> HI all, >> >> after investigating I see a number of issues preventing gtest from >> running on AIX, so I decided to get the fix for the wrong assert in the >> hotspot out of the way

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

2016-12-19 Thread David Holmes
On 18/12/2016 10:13 PM, Thomas Stüfe wrote: HI all, after investigating I see a number of issues preventing gtest from running on AIX, so I decided to get the fix for the wrong assert in the hotspot out of the way and open follow up issues for the other problems. So, this is just the fixed as

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

2016-12-19 Thread Thomas Stüfe
On Sun, Dec 18, 2016 at 1:13 PM, Thomas Stüfe wrote: > HI all, > > after investigating I see a number of issues preventing gtest from running > on AIX, so I decided to get the fix for the wrong assert in the hotspot out > of the way and open follow up issues for the other problems. > > So, this i

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

2016-12-18 Thread Thomas Stüfe
Hi Volker, Thank you for reviewing. I'll do the TOC issue this in a follow up change. Kind Regards, Thomas On Thu, Dec 15, 2016 at 12:24 PM, Volker Simonis wrote: > Hi Thomas, > > can you please try to fix the TOC issues for the gtest build only. I > don't like that we have to build everything

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

2016-12-18 Thread Thomas Stüfe
HI all, after investigating I see a number of issues preventing gtest from running on AIX, so I decided to get the fix for the wrong assert in the hotspot out of the way and open follow up issues for the other problems. So, this is just the fixed assert, fixed in the fashion David suggested. All

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

2016-12-18 Thread Thomas Stüfe
Hi David, thanks for your review, your suggestion makes sense. Will incorporate it into the next webrev; but first I have to try and meet Volkers linker demands :) Thanks, Thomas On Thu, Dec 15, 2016 at 11:33 AM, David Holmes wrote: > Hi Thomas, > > On 15/12/2016 4:43 PM, Thomas Stüfe wrote: >

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

2016-12-15 Thread Volker Simonis
Hi Thomas, can you please try to fix the TOC issues for the gtest build only. I don't like that we have to build everything with '-qpic=large -bbigtoc' just because of gtest. Isn't it possible to just set these parameters in hotspot/make/lib/CompileGtest.gmk by using CFLAGS_aix/LDFALGS_aix? Than

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

2016-12-15 Thread David Holmes
Hi Thomas, On 15/12/2016 4:43 PM, Thomas Stüfe wrote: Hi all, please review this small change. It fixes the gtest build on AIX and enables it by default. Note that even though this is a fix for AIX, a cast needed to be added to shared test coding. This is because xlC struggles with certain tem

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

2016-12-15 Thread Erik Joelsson
Yes, naturally. /Erik On 2016-12-15 11:06, Thomas Stüfe wrote: Hi Erik, thank you! I would have needed a sponsor for the hotspot change in any case, would sponsor this too? Thomas On Thu, Dec 15, 2016 at 10:00 AM, Erik Joelsson mailto:erik.joels...@oracle.com>> wrote: Hello Thomas,

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

2016-12-15 Thread Thomas Stüfe
Hi Erik, thank you! I would have needed a sponsor for the hotspot change in any case, would sponsor this too? Thomas On Thu, Dec 15, 2016 at 10:00 AM, Erik Joelsson wrote: > Hello Thomas, > > Build changes look ok. Please note that the configure changes requires > synchronized changes in Oracl

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

2016-12-15 Thread Erik Joelsson
Hello Thomas, Build changes look ok. Please note that the configure changes requires synchronized changes in Oracle closed configure so will need an Oracle sponsor to push. I assume this is intended for jdk9/hs. I will be happy to push it for you once the change has been cleared to go in. /E

RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

2016-12-14 Thread Thomas Stüfe
Hi all, please review this small change. It fixes the gtest build on AIX and enables it by default. Note that even though this is a fix for AIX, a cast needed to be added to shared test coding. This is because xlC struggles with certain template expansions and I had to help it by providing an exp