RFR: [8u] Build failed on Ubuntu 18.04 due to deprecated-declarations warnings

2019-03-19 Thread Jie Fu
Hi all, To fix build failures caused by deprecated-declarations warnings, can we make this change to jdk8u? -- diff -r 6e2900603bc6 make/linux/makefiles/gcc.make --- a/make/linux/makefiles/gcc.make Mon Mar 18 08:33:53 2019 +0100 +++ b/make/linux/makef

Re: RFR: [8u] Build failed on Ubuntu 18.04 due to deprecated-declarations warnings

2019-03-19 Thread Andrew Haley
On 3/19/19 12:25 PM, Jie Fu wrote: > To fix build failures caused by deprecated-declarations warnings, can we > make this change to jdk8u? This is very GCC-version dependent. We really should probe at configure time for these options. -- Andrew Haley Java Platform Lead Engineer Red Hat UK Ltd.

Re: RFR: [8u] Build failed on Ubuntu 18.04 due to deprecated-declarations warnings

2019-03-19 Thread Martin Buchholz
Probably it's because glibc deprecated readdir, and we don't have --disable-warnings-as-errors by default? (I think warnings should not be errors except as opt-in by openjdk developers/maintainers) On Tue, Mar 19, 2019 at 7:47 AM Andrew Haley wrote: > On 3/19/19 12:25 PM, Jie Fu wrote: > > To f

Re: RFR: [8u] Build failed on Ubuntu 18.04 due to deprecated-declarations warnings

2019-03-19 Thread Brian Burkhalter
jdk8u-dev will build with this conf bash configure --with-extra-cflags=-Wno-error at least on Ubuntu 18.04. > On Mar 19, 2019, at 8:09 AM, Martin Buchholz wrote: > > Probably it's because glibc deprecated readdir, and we don't have > --disable-warnings-as-errors by default? > > (I think warni

Re: RFR: [8u] Build failed on Ubuntu 18.04 due to deprecated-declarations warnings

2019-03-19 Thread Andrew John Hughes
On 19/03/2019 15:09, Martin Buchholz wrote: > Probably it's because glibc deprecated readdir, and we don't have > --disable-warnings-as-errors by default? > > (I think warnings should not be errors except as opt-in by openjdk > developers/maintainers) > > On Tue, Mar 19, 2019 at 7:47 AM Andrew Ha

Re: RFR: [8u] Build failed on Ubuntu 18.04 due to deprecated-declarations warnings

2019-03-19 Thread Jie Fu
On 2019/3/19 下午11:09, Martin Buchholz wrote: Probably it's because glibc deprecated readdir, and we don't have --disable-warnings-as-errors by default? Yes. (I think warnings should not be errors except as opt-in by openjdk developers/maintainers) I agree, especially for deprecated-declar

Re: RFR: [8u] Build failed on Ubuntu 18.04 due to deprecated-declarations warnings

2019-03-19 Thread Jie Fu
Hi all, Unless a runtime failure is triggered, I think the simplest way to fix this issue is to change the build system since deprecated-declarations warnings are not errors at all. deprecated-declarations warnings seem to be treated as errors only for hotspot build. But why not for jdk bui

Re: RFR: [8u] Build failed on Ubuntu 18.04 due to deprecated-declarations warnings

2019-03-20 Thread Andrew John Hughes
On 19/03/2019 15:09, Martin Buchholz wrote: > Probably it's because glibc deprecated readdir, and we don't have > --disable-warnings-as-errors by default? > > (I think warnings should not be errors except as opt-in by openjdk > developers/maintainers) I agree, and we've implemented it that way do

Re: RFR: [8u] Build failed on Ubuntu 18.04 due to deprecated-declarations warnings

2019-03-20 Thread Jie Fu
Thanks Andrew. On 2019/3/20 下午11:53, Andrew John Hughes wrote: On 19/03/2019 15:09, Martin Buchholz wrote: Probably it's because glibc deprecated readdir, and we don't have --disable-warnings-as-errors by default? (I think warnings should not be errors except as opt-in by openjdk developers/ma

Re: RFR: [8u] Build failed on Ubuntu 18.04 due to deprecated-declarations warnings

2019-03-21 Thread Andrew Haley
On 3/20/19 3:53 PM, Andrew John Hughes wrote: > On 19/03/2019 15:09, Martin Buchholz wrote: >> Probably it's because glibc deprecated readdir, and we don't have >> --disable-warnings-as-errors by default? >> >> (I think warnings should not be errors except as opt-in by openjdk >> developers/maintai

Re: RFR: [8u] Build failed on Ubuntu 18.04 due to deprecated-declarations warnings

2019-04-25 Thread Jie Fu
Hi Andrew, Is it possible that this issue be fixed in 8u222? Or shall we just update the README to work around it like this: - diff -r c52bf8887eb0 README --- a/README    Tue Apr 16 21:59:20 2019 +0100 +++ b/README    Thu Apr 25 17:49:36 2019 +0800 @@ -