Re: RFR: 8042810: (s) hgforest: some shells run read in sub-shell and can't use fifo

2014-05-13 Thread Erik Joelsson
Looks good to me Mike. Nice work! /Erik On 2014-05-13 01:53, Mike Duigou wrote: Hello all; I have updated the webrev after additional testing and cleanup. I found a couple of additional minor problems and added a feature that had been requested. Some of the default behaviour can now be contr

Re: RFR: 8042810: (s) hgforest: some shells run read in sub-shell and can't use fifo

2014-05-12 Thread Mike Duigou
Hello all; I have updated the webrev after additional testing and cleanup. I found a couple of additional minor problems and added a feature that had been requested. Some of the default behaviour can now be controlled using environment variables. It had been pointed out that being able to run c

Re: RFR: 8042810: (s) hgforest: some shells run read in sub-shell and can't use fifo

2014-05-12 Thread Mike Duigou
On May 9 2014, at 01:54 , pointo1d wrote: > Hi Mike , > > On 09/05/14 08:25, Mike Duigou wrote: >> On May 8 2014, at 22:35 , Chris Hegarty wrote: >> >>> Looks fine to me Mike. >>> >>> Trivially while you are there (not related to your changes), or i can do it >>> separately, --sequentially

Re: RFR: 8042810: (s) hgforest: some shells run read in sub-shell and can't use fifo

2014-05-12 Thread Mike Duigou
On May 9 2014, at 03:54 , pointo1d wrote: > Hi Mike , > > On 09/05/14 03:19, Mike Duigou wrote: >> Hello all; >> >> This issue is a follow-on bug fix to JDK-8041151 (Improve hgforest.sh >> concurrency). That changeset introduced use of fifos for monitoring >> sub-shell completion and include

Re: RFR: 8042810: (s) hgforest: some shells run read in sub-shell and can't use fifo

2014-05-09 Thread pointo1d
Hi Mike , On 09/05/14 03:19, Mike Duigou wrote: Hello all; This issue is a follow-on bug fix to JDK-8041151 (Improve hgforest.sh concurrency). That changeset introduced use of fifos for monitoring sub-shell completion and included an alternative implementation for configurations which did not

Re: RFR: 8042810: (s) hgforest: some shells run read in sub-shell and can't use fifo

2014-05-09 Thread pointo1d
Hi Mike , On 09/05/14 08:25, Mike Duigou wrote: On May 8 2014, at 22:35 , Chris Hegarty wrote: Looks fine to me Mike. Trivially while you are there (not related to your changes), or i can do it separately, --sequentially now runs with up to two parallel commands. Ah sorry, I know why that

Re: RFR: 8042810: (s) hgforest: some shells run read in sub-shell and can't use fifo

2014-05-09 Thread Mike Duigou
On May 8 2014, at 22:35 , Chris Hegarty wrote: > Looks fine to me Mike. > > Trivially while you are there (not related to your changes), or i can do it > separately, --sequentially now runs with up to two parallel commands. Ah sorry, I know why that is. It is due to shell having less-than bu

Re: RFR: 8042810: (s) hgforest: some shells run read in sub-shell and can't use fifo

2014-05-08 Thread Chris Hegarty
Looks fine to me Mike. Trivially while you are there (not related to your changes), or i can do it separately, --sequentially now runs with up to two parallel commands. -Chris > On 9 May 2014, at 03:19, Mike Duigou wrote: > > Hello all; > > This issue is a follow-on bug fix to JDK-8041151 (

RFR: 8042810: (s) hgforest: some shells run read in sub-shell and can't use fifo

2014-05-08 Thread Mike Duigou
Hello all; This issue is a follow-on bug fix to JDK-8041151 (Improve hgforest.sh concurrency). That changeset introduced use of fifos for monitoring sub-shell completion and included an alternative implementation for configurations which did not properly support fifos. This changeset detects an