Looks ok to me.
/Erik
On 2017-06-13 07:21, Mandy Chung wrote:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182029/webrev.00/
JBS issue:
https://bugs.openjdk.java.net/browse/JDK-8182029
This patch replaces the top-level docs index.html to a HTML-level redirect to
the API overview page
On 13/06/2017 06:21, Mandy Chung wrote:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182029/webrev.00/
JBS issue:
https://bugs.openjdk.java.net/browse/JDK-8182029
This patch replaces the top-level docs index.html to a HTML-level redirect to
the API overview page. We can come back to th
On 2017-06-13 09:26, Alan Bateman wrote:
On 13/06/2017 06:21, Mandy Chung wrote:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182029/webrev.00/
JBS issue:
https://bugs.openjdk.java.net/browse/JDK-8182029
This patch replaces the top-level docs index.html to a HTML-level
redirect to th
Hi,
This looks good to me. Relying on header include order is never a good idea.
Thanks,
/Erik
On 2017-06-08 01:51, Kim Barrett wrote:
Please review this change to the build of hotspot to globally define
the __STDC_xxx_MACROS macros via the command line, rather than
via #defines scattered thro
> On Jun 13, 2017, at 8:49 AM, Erik Österlund wrote:
>
> Hi,
>
> This looks good to me. Relying on header include order is never a good idea.
Thanks.
>
> Thanks,
> /Erik
>
> On 2017-06-08 01:51, Kim Barrett wrote:
>> Please review this change to the build of hotspot to globally define
>> the
> On Jun 13, 2017, at 3:57 AM, Magnus Ihse Bursie
> wrote:
>
>
>
> On 2017-06-13 09:26, Alan Bateman wrote:
>> On 13/06/2017 06:21, Mandy Chung wrote:
>>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182029/webrev.00/
>>>
>>> JBS issue:
>>> https://bugs.openjdk.java.net/browse/JDK-8182
Hi,
Please review the fix for JDK-8176583
Bug: https://bugs.openjdk.java.net/browse/JDK-8176583
Webrev: http://cr.openjdk.java.net/~nishjain/8176583/webrev.02/
Fix: Relocated currency.data from java.base module
(/java.base/java/util/currency.data) to /lib directory
Review mail thread of JDK-
Looks good to me, although still hoping for more review from others.
+if (bytes != 0) {
Style: use NULL.
+static jstring newStringJava(JNIEnv *env, const char *str) {
I expected two versions, one that took a length and one that did not, as
you did with newString8859_1.
---
TIL that jbyte
On 2017-06-13 21:09, Martin Buchholz wrote:
Looks good to me, although still hoping for more review from others.
I expect Sherman to weigh in. :-)
+if (bytes != 0) {
Style: use NULL.
Done.
+static jstring newStringJava(JNIEnv *env, const char *str) {
I expected two versions, one
Hello Mandy,
Looks good to me.
/Erik
On 2017-06-13 07:35, Mandy Chung wrote:
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182032/webrev.00/
java.compiler is a standalone technology that allows to be running on older
JDK, in particular for IDE to support new language featu
10 matches
Mail list logo
