Re: Build portability: enable or disable warnings

2011-05-13 15:20, Andrew Haley skrev: > A recent patch (of mine, as it happens) broke builds on Debian and > Gentoo. It was caused by a scanf call: > > if (sscanf(chars, "%lx-%*lx", &x) == 1) > > which looks pretty innocuous, but it triggers a warning if -Wformat is > turned on: > There

Re: Building a Minimal, Self-Contained Bootstrap JDK

There is a configuration option that is called KERNEL, if you manage to enable this option, the result is supposed to be a minimally sized JVM with very few runtime options For the JDK itself, it is such a tingletangle of interdependencies that it is not really possible to compile just a part

Re: Improving source drops documentation

2011/10/12 Dr Andrew John Hughes : > FWIW, I recently did exactly that in IcedTea because I'm sick of all the > problems this drop solution causes. > This has cut things down from needing five tarballs (jaxp + jaxws > repositories + three drop zips) to two with > everything in.  Should someone re

Re: Confused about Windows build

2011/10/17 Ulf Zibis : > So do I really need to buy a VS 2003, or is there some "workaround" with the > Platform SDK on Windows XP? You might be interested in the build-infra/jdk7 forest. I just posted this to build-infra-dev It builds on WindowsXP, using Visual Studio 2010 Express (free edition

Re: Confused about Windows build

cept that it uses configure to setup all the variables for you. And that the build will eventually be much faster than before. //Fredrik > On 10/26/2011 9:34 AM, Fredrik Öhrström wrote: > > 2011/10/17 Ulf Zibis: > >> So do I really need to buy a VS 2003, or is there some "wor

Re: jdk/src/solaris - time to re-visit it?

2011-11-23 13:12, Alan Bateman skrev: > In the jdk repository then src/solaris has all the Solaris and Linux > code. Most of it is used for both platforms with a small number of files > specific to one or the other. I'm sure this has come up before (probably > many times) but I'd like to bring i

Re: jdk/src/solaris - time to re-visit it?

2011-11-24 11:11, Alan Bateman skrev: > The immediate benefit of renaming is that it would allow us to move the > Solaris and Linux specific source files out of the src/unix tree into > src/ directories. That would eliminate the need for some of > the filtering in the build and would also allow

Re: jdk/src/solaris - time to re-visit it?

2011-11-28 16:46, Ulf Zibis skrev: > I guess you meant: > --shared > --posix >|--SYSV >||--solaris >||--aix >| >|--gnu >||--linux >|| >|--BSD > |--darwin > |--freebsd > > --winapi > |--win32

Re: Need help in building openjdk in ubuntu 11.10

Please try cloning http://hg.openjdk.java.net/build-infra/jdk7 then do ./configure and follow the instructions to fetch the missing config.guess config.sub and pkg.m4 as well as any dev package. Then type make Then you can run ./build/linux/jdk/bin/java Then type make install And it will be ins

Re: Does OpenJDK statically link the C++ runtime?

2012-01-05 03:03, Dr Andrew John Hughes skrev: >Hence, it is in the provider's interest to make that blob compatible with >as many systems as possible. This is done by statically linking libraries >and is also the reason you'll find copies of system libraries >(libpng, libjpeg, zlib, lcms) in the

Patch for: 7132779: build-infra merge: Enable ccache to work for most developer builds.

Hello hotspot-runtime-dev and build-dev! This is a patch to enable ccache to work for all builds, not only builds where the build number has been explicitly set. Webrev is here: http://cr.openjdk.java.net/~ohrstrom/7132779/webrev.00/ Exported hg patch is here: http://cr.openjdk.java.net/~ohrst

Re: Patch for: 7132779: build-infra merge: Enable ccache to work for most developer builds.

2012-01-31 22:38, David Holmes skrev: > I don't understand the comment on the new method though. Since jre_release_version() has a similar use case as vm_release(), ie it is called from crash handlers and error reporting handlers, I copied the comment for vm_release() to jre_release_version(). Bu

Re: Review for 7141242: build-infra merge: Rename CPP->CXX and LINK->LD

2012-02-03 02:43, David Holmes skrev: > Hi Erik, > > I think this has gone as far as it needs for now. My visual inspection > of these changes looks okay. > > My lingering concern is the impact on external scripts etc that may set > some of the renamed flags. Even I have a build script that sets

Re: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable

- [email protected] skrev: > This reminded me that one of the things on my wishlist for the new > build > was that I can still override something in SPEC by setting it on the > command-line invocation of make. That should work, since a variable specified on the make command line, fo

Re: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable

Looks good! //Fredrik - [email protected] skrev: > New webrev: > http://cr.openjdk.java.net/~erikj/7141244/webrev.02/ > > 177 lines changed: 89 ins; 29 del; 59 mod; 3970 unchg > > Changes since last time: > > * Moved the , to

Re: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable

2012/2/10 Kelly O'Hair : > Looks good to me. > > I assume you will work with John or someone in the hotspot team to get this > integrated into > one of the hotspot integration areas? Yes, we are already working with David Holmes to get these patches committed into hotspot. //Fredrik

Re: Is anyone able to build on Win 7

2012-02-02 00:10, Kelly O'Hair skrev: > I don't know what the current state is. The CYGWIN community seemed pretty > adamant that they wanted > to stamp out all drive letter pathnames. As I understood it, it's not so much > the version of make.exe, but how > the make.exe was built. Some kind of '

Re: Is anyone able to build on Win 7

2012-02-14 12:29, Volker Simonis skrev: > To cut a long story short: > - disabling "on access" scanning of *.{java,c,cpp,h,hpp} seems to > resolve the file io problems (permission denied, access denied) > - disabling ASLR seems to resolve the "fork" problems Great work! Do you know if disabling AS

Question about BUILD_HEADLESS and HEADLESS

Is the use of HEADLESS in gcc.make (linux and bsd) an archaeological remnant and should be removed? (No source in the hotspot repo looks a the HEADLESS define.) Is there any reason to not build a headless version of awt? (ie modify BUILD_HEADLESS to not be defined.) It seeems like headless is not

Re: Question about BUILD_HEADLESS and HEADLESS

- [email protected] skrev: > I'm not sure what you are asking. BUILD_HEADLESS is a JDK build flag. > As you say it is set true in the linux and solaris Def-.gmk files, > and AFAICS it is only used in one place in make/sun/headless/Makefile > > Note: BUILD_HEADLESS_ONLY is an unrelated op

Re: Is anyone able to build on Win 7

- [email protected] skrev: > So I'm with you on the stat() theory, makes a great deal of sense. The stat theory is very interesting, but it is unclear to me if it explains all of the problem. I setup a quadruple boot x86_64 machine with 4GB of ram and 4 cores: Winxp 32bit Win7 64bit So

Re: building part of jdk 8

Den måndagen den 20:e februari 2012 skrev Pete > > > > > A fastdebug build is a combination of the variables VARIANT=DBG and > FASTDEBUG=true > > but it's been a long time since I looked at that. Proof is in the > pudding. Good Luck. > Thanks Kelly, That's true. Also, I hadn't realized that I n

Re: building part of jdk 8

Den måndagen den 20:e februari 2012 skrev Pete Brunet: > > Hi Fredrik, I can't find any files named configure. Is there further > documentation? -Pete > Ah, this is the work in progress, the build-infra project. Discussed a bit here and on build-infra-dev. hg clone http://hg.openjdk.java.net/b

RFR (XXS): 77150579: build-infra merge: Move ant dependency into separate package.

Hi, the dependency on ant for the langtools repo, encoded into the build tools CompilePropertiesTask and GenStubs, can be separated into a separate package. This enables build-infra makefiles to compile langtools without the ant.jar simply by avoiding the ant specific package. Ant can of course s

Re: Fwd: Need reviewer, 7150322: Stop using drop source bundles in jaxws

Looks fine to me too! //Fredrik 2012/3/6 Joe Darcy : > Looks fine, > > -Joe > > > On 3/6/2012 9:24 AM, Kelly O'Hair wrote: > > Still need a reviewer or 2 on this. > > -kto > > > Begin forwarded message: > > From: "Kelly O'Hair" > Subject: Need reviewer, 7150322: Stop using drop source bundles in

Re: javax.tools in jdk/make/javax/others

Since there is no javax/tools in the jdk, this seems indeed like a redundant line of makefile. //Fredrik 2012/3/5 Jonathan Gibbons : > jdk/make/javax/others lists the following: > > # > # Files to compile > # > AUTO_FILES_JAVA_DIRS =       \ >    javax/naming             \ >    com/sun/naming/int

Re: Need reviewer: corba changes for build infra

2012-03-13 06:30, Tim Bell skrev: > > Sorry, I meant to pick on these lines, and also mention that > args.length should be an even number at line 64... > > 107 infiles.add(args[i]); > 108 outfiles.add(args[i]); > > Otherwise, my remarks apply, FWIW. You are right,

Re: Need reviewer: corba changes for build infra

2012-03-13 10:24, Dmitry Samersoff skrev: > Frederik, > > Just a curious - why we need a Java program here? > Could sed do the same with less efforts? In the old build system, there are two StripProperties.java in corba and in the jdk with slightly different implementations and command line option

Re: Review Request: 7141246 build-infra merge: Introduce new JVM_VARIANT* to control which kind of jvm gets built

2012-03-13 00:26, David Holmes skrev: > > You seem to have included the MINIMAL VM changes in here. Those changes > have not been pushed to the mainline and are not yet to be pushed. If > you want to push these build-infra changes you will need to factor out > the MINIMAL VM stuff - else wait.

Re: Review Request: 7141246 build-infra merge: Introduce new JVM_VARIANT* to control which kind of jvm gets built

2012-03-13 12:00, David Holmes skrev: > That is not really what is happening. KERNEL is gone (going) and MINIMAL > is coming. There are few places where it looks like a rename but that's > a bit of an over-simplificifation. Oh, well, to make it easier for the embedded team, we can wait with the

Re: RFR: 7151898: Check for LANG in Mac OS X jdk build sanity check [macosx]

- [email protected] skrev: > I don't know, and I don't have the expertise in the build system to > know how other LANG settings would affect the build. Perhaps somebody else on > build-dev knows. Meanwhile, we're patching things up this way, even though it > makes things a bit messier.

Re: RFR: 7151898: Check for LANG in Mac OS X jdk build sanity check [macosx]

2012-03-15 21:56, Kelly O'Hair skrev: > It is very hard to know the complete impact of building the product in > different locales when > native code is involved. So as much as I would like to guarantee all > selections will work, I would > rather we narrow down the options here to avoid having t

Re: RFR: 7155585: Fix ifeq errors in makefiles [macosx]

2012-03-21 16:03, Michael McMahon skrev: > Could I get the following change reviewed please for jdk 8? > > It is to fix a number of minor build warnings caused by the macosx changes. > > http://cr.openjdk.java.net/~michaelm/7155585/webrev.1/ > > Thanks > Michael Looks good. //Fredrik

Re: Review Request: Build-infra M1

2012-03-21 16:43, Andrew Hughes skrev: > I haven't tried this out yet, but I'll try and give it a spin in build-infra. > > One thing that did stand out from the patch is that generated files such as > configure are being checked in. For updates to this, is there a plan to > mandate the use of a sp

Re: Review Request: Build-infra M1

- [email protected] skrev: > My major concern with the transition here is being able to take > existing knowledge of the build system and be able to figure out where in the > new system certain things are handled. How can I tell if a Makefile is > part of the old build or the new build?

Re: Review Request: Build-infra M1

- [email protected] skrev: > > I tried this today and got a javac error compiling a Java2D demo - as > report to the build-infra list. You are building a closed demo. The fix that written by Alan 2 weeks ago: "Java2Demo breaks build, incompatible method in the same class" has not been

Re: Review Request: Build-infra M1

- [email protected] skrev: > I couldn't access /home/ohrstrom either :( You can replace my home directory with yours. ;-) > I guess this needs to be taken up internally to see how this > build-deps > stuff is to be setup, configured, and maintained. Something for M2 > perhaps. Yes,

Re: Review Request: Build-infra M1

Until we have done the integration later today. Please just build the openjdk. Thanks! //Fredrik - [email protected] skrev: > On 22/03/2012 6:35 PM, Fredrik Öhrström wrote: > > > > - [email protected] skrev: > >> > >> I tried this today

Re: Fwd: java -version different on Win vs Cygwin

Interesting. Could it be the 64 bit windows file system virtualization that slow down cygwin so much on 64-bit windows? Are other 32 bit applications as slow? //Fredrik - [email protected] skrev: > I think I found the answer here: > http://www.curlybrace.com/words/2010/12/17/con

Re: Review Request: Build-infra M1

- [email protected] skrev: > What is this builddeps server? Is it something that's worth emulating > elsewhere? A builddeps server is simply an ftp server with tar.gz or zip archives. The builddeps autoconf macros are inspired by the pkg-config macros. Lets look at this extract from configu

Re: Review Request: Build-infra M1

Yes, of course, I just pushed a fix. Have you changed the class analyzer to output a text file with the mapping of the sources? e.g. java/lang/Object.java jdk.base/java/langObject.java //Fredrik - [email protected] skrev: > On 21/03/2012 14:07, Erik Joelsson wrote: : > > jdk,

Re: Review Request: Build-infra M1

2012-03-23 00:51, David Holmes skrev: > Not wanting to go too OT here but I see the build-deps server as > something to be used at most per machine rather than per developer. We > have build servers internally that can be used by dozens of developers > and we don't want multiple copies of toolsets

Successful cross-compile from 32bit-linux to 64bit-linux

With my latest small pushes to build-infra/jdk8-hotspot-jdk the build-infra forest can successfully cross compile from 32bit-linux to 64bit-linux and vice versa. Some of the final problems were to set HOSTCC,HOST_CC and NIO_CC to be the compiler that compiles code for the build platform. Strip aw

Re: Review Request: Build-infra M1

in increasing order of verbosity make VERBOSE= make VERBOSE=-d make VERBOSE="-d -p" Den fredagen den 23:e mars 2012 skrev Michael McMahon< [email protected]>: > Is it possible to get a more verbose style of echoing the complete compile/build commands > like the old build ? > > - Micha

Re: Review Request: Build-infra M1

- [email protected] skrev: > I know that's the current status quo. It seemed to be being > suggested that the closed rules be removed from the public Makefiles and kept > separately. Maybe I misunderstood. Well, I guess I would like the closed rules be so simple that the default add/overrid

Re: Review Request: Build-infra M1

2012-03-26 12:05, Michael McMahon skrev: > Thanks. It looks like the first of the three options above is most > similar to the verbosity > level of the old build. Is all of this documented anywhere? Well, I have so far really tried to comment in the makefiles. So the "make VERBOSE=" trick is the

Re: javadoc and API docs

2012-03-26 13:34, Jonathan Gibbons skrev: Right now, in the current build, we use a "hybrid" javadoc to build the API documentation, where "hybrid" means: latest sources, running on bootstrap JDK. Looking to the future, at least for Jigsaw, and now maybe for JSR 308, we may need to run javado

Re: Review Request: Build-infra M1

2012-03-26 18:13, Kelly O'Hair skrev: * The "@GenerateNativeHeader" additions seem like they deserve some kind of comment, maybe a short one on the same line, like "No native methods here, but the constants are needed in the supporting JNI code" or something like that? Good idea! * The top

Re: Review Request: Build-infra M1

2012-03-27 16:39, Michael McMahon skrev: A few more things I'd like to understand are: 1) In what circumstances exactly would the configure script have to be re-run? You run configure once to setup a particular build configuration. After it is run, you only need to run make for the build co

Re: Review Request: Build-infra M1

2012-03-27 17:21, Michael McMahon skrev: Right. Configure doesn't need to be re-run, but presumably there is some build meta-information linking sources to target libraries etc. Say a new native library libfoo were to be added with associated C (and Java) sources. Where would this get added t

Re: First build-infra push to jdk8 -- try out the new build system!

Have you a correct /tmp setup for cygwin? //Fredrik 2012/4/13 Weijun Wang : > Trying on Windows now. I'm using a VirtualBox VM and the repos are in a > read-only shared folder. So I create a directory in its C: and run configure > there. But when I run make, it shows > > $ make > > >

Sv: Request for review: Defs-util.gmk missing in new build system, preventing build

Please remove the reference. //Fredrik - [email protected] skrev: > Background: Building with the new build system fails with > ".../common/shared/Defs-utils.gmk: No such file or directory" in the > build forest, but not in the build-infra forest. > > It turned out that a file

Re: First build-infra push to jdk8 -- try out the new build system!

- [email protected] skrev: > Would it be too early to report ‘warning: -jN forced in submake: > disabling jobserver mode.’ results? Not at all, this is a side effect of calling the old makefiles, which do not support multiple jobs. When all the old makefiles are converted, this message

Re: location of -source / -target in new build infrastructure

Yes, a leftover exist in Setup.gmk thanks for spotting that David! the -source 7 -target 7 should be replaced with $(BOOT_JDK_SOURCETARGET) which is setup by configure and stored in the spec.gmk file. That flag is only be used for compiling code that has to be run by the boot jdk. The particular

Re: Request for Review: Execute the build logger with the help of a shell if the x permission is not set

Looks good! 2012/4/20 Magnus Ihse Bursie : > In the build-infra hg repo, we allowed execute permission to be set on > files, including common/bin/logger.sh, which is called by the Makefile. > > The official hg repos strip this bit, so when integrating to the build > forest, this was lost, causing

Re: First build-infra push to jdk8 -- try out the new build system!

For the new build you have to explicitly choose release,fastdebug or slowdebug. (--with-debug-level=release,fastdebug or slowdebug) So you do not need to turn off fastdebug, it defaults to release. As for the demos and samples. They compile so much faster that there is no point in turning them off

Re: First build-infra push to jdk8 -- try out the new build system!

; Martijn > > > On 21 April 2012 12:34, Henri Gomez wrote: >> >> New build system has been tested allready on OSX ? >> >> Le 21 avr. 2012 à 09:10, Fredrik Öhrström a écrit : >> >> > For the new build you have to explicitly choose release,fastdebu

Re: First build-infra push to jdk8 -- try out the new build system!

2012/4/21 Henri Gomez : > new build system is using autoconf ? Yes, please have a look here: http://openjdk.java.net/projects/build-infra/guide.html for detailed instructions. //Fredrik

Re: Review Request: Build-infra update

In configure.ac: Indententation looks odd where solaris optimizations settings for CC are calculated. Could someone enlighten this configure script with a comment about libCrun? In logger.sh: trap "rm -rf '$RCDIR'" EXIT The $RCDIR is not replaced with the contents of the variable RCDIR since it is

Re: Need reviewer - @GenerateNativeHeader

Looks good. Since the annotation is a compile time only annotation, it should not affect any future modularization efforts. Right Alan? //Fredrik 2012/5/23 Kelly O'Hair : > > 7170969: Add @GenerateNativeHeader to classes whose fields need to be > exported for JNI > http://cr.openjdk.java.net/~

Re: Need reviewer - @GenerateNativeHeader

There is no point holding off this push since GenerateNativeHeader annotation and uses of it were already pushed long time ago. These are just the finishing touches to cater for the conversion of the remaining makefiles. If you want another location for the annotation then we can easily search and

Re: Review Request: Build-infra update

Not by me anyway. In fact, I think that solution is the best one! //Fredrik 2012/5/23 Jonathan Gibbons : > I wanted to be able to declare fields as native, but that was deemed > unacceptable. > > -- Jon > > > On 05/23/2012 10:05 AM, Alan Bateman wrote: >> >> On 23/05/2012 17:50, Kelly O'Hair wrot

Re: Review Request: Build-infra update

- [email protected] skrev: > The rationale for not allowing it is that it has no meaning at either > > the JLS or JVMS level. It would simply be a hint for tools, and hints > > for tools are best done by annotations. > > -- Jon > > On 05/24/2012 12:02

Re: Review Request: Build-infra update

Nice! Just fix the spelling of "annotaion". //Fredrik 4 jun 2012 kl. 16:15 skrev Erik Joelsson: > I have created a (hopefully temporary) hack to run javah manually for these 5 > classes. This webrev is just against the build-infra repo. Unless anybody > objects to this temporary solution, I w

Re: jdk8 makefile changes

The configure script does set a few variables in the spec.gmk file that is used but the hotspot repo. (It does read the spec.gmk file) We did forget about STATIC_CXX though, it should be added to spec.gmk and set appropriately, then the hotspot makefile that looks at it should be adjusted, beca

First webrev for smart javac wrapper

The current build-infra/jdk8 forest can now be configured using --enable-sjavac This causes the build to do proper incremental builds of Java sources (all the other sources are already properly handled when building incrementally) i.e. only the java sources that need to be compiled are actually c

Re: Need reviewers: more predictable binaries

Looks good. Perhaps we can even remove the "#ifndef THIS_FILE" test in the source files? At some time in the future…. //Fredrik 6 sep 2012 kl. 06:08 skrev Kelly O'Hair: > > Need a reviewer for this change. > > http://cr.openjdk.java.net/~ohair/openjdk8/jdk8-this-file/webrev/ > > It does ch

Re: Is the "skip boot cycle" trick still needed?

You are right Jon, it is rather easy to do. I just pushed boot_cycle.sh into build-infra. You can do: sh common/bin/boot_cycle.sh and it will create boot_cycle_1 in build, and build the complete product there (including images) then it will create boot_cycle_2 and configure it to use boot_cycl

Re: Is the "skip boot cycle" trick still needed?

n to describe a set of assorted extra scripts. And, it would fit > more uniformly into the JPRT infrastructure. > > -- Jon > > On 09/10/2012 03:27 PM, Fredrik Öhrström wrote: >> You are right Jon, it is rather easy to do. I just pushed boot_cycle.sh into >> build-infr

Re: The future of partial builds

Den tisdagen den 11:e september 2012 skrev Alan Bateman: > > So far my experience is that touching native code and re-building is super > fast, it's on par to executing specific make files in the old build (while > wearing the appropriate amulet around one's neck of course). Touching java > classes

Re: The future of partial builds

11 sep 2012 kl. 21:59 skrev Alan Bateman: > With a sjavac config I touched one source file and the incremental build took > 36s so much better. In this case the one class caused 77 classes to be > re-compiled, 10 native files, and 2 shared libraries to be re-linked. On the > other hand, the old

Re: The future of partial builds

Oookay, long story, this was when we used jdk6 to build jdk7, same kind of problem could occur when using jdk7 to build jdk8: jdk7javac used new features and classes in jdk7, for example: java/util/Objects.java java/util/ConcurrentModificationException.java java/io/File.java java/nio/file/*

Re: Request for Review: Add hotspot support for building with mingw/msys on build-infra (the new build)

2012-10-26 17:02, Kelly O'Hair skrev: I tend to disagree, having multiple words in CC is unconventional, and if we do that, we need to consider the consequences of straying from the typical make convention. But I'd rather not get into what is theoretically wrong or right, it just needs to work,

RFR 8003161: Cannot build jdk8/build using the new build system after latest merge.

It seems that some changes (like introduction of cmshalf.c) did not update the new makefiles and caused the OpenJDK only build to fail. http://cr.openjdk.java.net/~ohrstrom/webrev-8003161-root/ http://cr.openjdk.java.net/~ohrstrom/webrev-8003161-jdk/ //Fredrik

Re: RFR 8003161: Cannot build jdk8/build using the new build system after latest merge.

2012-11-08 11:52, David Holmes skrev: I don't understand this: $$(shell $(MKDIR) -p $$($1_BIN) && $(RM) $$($1_BIN)/_the.$$($1_JARNAME)_include) If you have to create the directory there can't possibly be anything to rm. ??? Two things need to be established before ListPathsSafely is ex

Re: Review Request: 8003274: build-infra: Makefile changes needed for sjavac

12 nov 2012 kl. 17:45 skrev Kelly O'Hair: > Looks ok. > > xargs used to prune whitespace? That was a new one on me. ;^) After reading through this one: http://stackoverflow.com/questions/369758/how-to-trim-whitespace-from-bash-variable I can only say that it seemed like the easiest solution.

Re: Review Request: 8003274: build-infra: Makefile changes needed for sjavac

12 nov 2012 kl. 19:04 skrev Kelly O'Hair: > Or maybe >if [ "$(words $(shell cat file))" -ne 0 ] ; then > Well, this one is better. I'll switch to this one, eventually. //Fredrik

Re: Review Request: 8001941: build-infra: --disable-precompiled-headers does not seem to work

Looks good. //Fredrik 14 nov 2012 kl. 14:21 skrev Erik Joelsson: > This is a fix for configure parameter --disable-precompiled-headers. It has > now been verified to work. > > http://cr.openjdk.java.net/~erikj/8001941/webrev.root.01/ >

Re: Review Request: 8003327: build-infra: "/bin/sh: : cannot execute" on solaris

Looks good. //Fredrik 14 nov 2012 kl. 15:25 skrev Erik Joelsson: > This minimal patch fixes a problem with error messages from /bin/sh on > solaris. > > http://cr.openjdk.java.net/~erikj/8003327/webrev.root.01/ > > /Erik

Re: Review Request: 8001875: build-infra: We must be able to force static linking of stdc++

Looks good. //Fredrik 14 nov 2012 kl. 12:38 skrev Erik Joelsson: > http://cr.openjdk.java.net/~erikj/8001875/webrev.root.01/ > > > This patch changes the configure paramater --disable-static-link-stdc++ to > the following: > > --w

Re: Review Request: 8003317: build-infra: Configure fails when current dir is part of a symlink

Looks good. //Fredrik 14 nov 2012 kl. 15:04 skrev Erik Joelsson: > This is a fix for the logic that prevents configure from creating > configurations in undesired directories. If the path to the source root > contains a symlink, the check got fooled and refused to create a > configuration any

Re: Review Request: 8003482: build-infra: Use correct manifest in security jars

Looks ok. However the practice of using [email protected] is unnecessary if there is no reasonable risk of failure in the recipe. //Fredrik 2012/11/26 Erik Joelsson : > This patch converts 7197071 to the new build-system. > > http://cr.openjdk.java.net/~erikj/8003482/webrev.jdk.01/ > > /Erik

Re: Review Request: 8003477: build-infra: Remove explicit source file listings for libs when possible

Great! 2012/11/26 Erik Joelsson : > This is a bit of a cleanup in CompileNativeLibraries.gmk, removing explicit > listings of source files when they aren't necessary. For some libraries, it > still makes sense to list files to include rather than exclude and those > still have include lists. > > h

Re: Review Request: 8003844: build-infra: docs target isn't working properly

Looks good! 2012/11/26 Erik Joelsson : > I have fixed the docs target and added support for comparing the generated > docs with the old build. > > http://cr.openjdk.java.net/~erikj/8003844/webrev.01/ > > /Erik

Re: Review Request: 8003528: build-infra: Diffs in libjava and hotspot libs on solaris.

Looks good. 2012/11/26 Erik Joelsson : > This fixes a difference between old and new build in libjava.so. It also > adds more exceptions for unavoidable differences in libs from hotspot. > > This also fixes part of 8001460: build-infra: Linker warnings on macosx > > http://cr.openjdk.java.net/~eri

Re: Review Request: 8004045: build-infra: Error 12 from zip when updating src.zip

Looks good. 2012/11/27 Erik Joelsson : > Small fix for common annoyance when rebuilding images. The zip utility > returns 12 when it has nothing to do. This happens because we run it > multiple times, once for each source root, when updating src.zip, even if > only sources in one of the roots have

Re: Review Request: 8003945: build-infra: problems finding compiler when using --with-dev-kit

I am not really fond of --with-dev-kit, but now its there. However the --sysroot compiler lookup no longer works. Which causes the cross compiles started using --with-builddeps-server to fail.. //Fredrik 2012/11/27 Erik Joelsson : > This fix changes how configure looks for the compiler when -

Re: Review Request: 8003300: build-infra: fails on solaris when objcopy is not found

Looks good. 2012/11/19 Erik Joelsson : > This is a simple fix for when objcopy is missing. > > http://cr.openjdk.java.net/~erikj/8003300/webrev.root.01/ > > /Erik

Re: Review Request: 8003482: build-infra: Use correct manifest in security jars

. 12:05 skrev Erik Joelsson: > In this case it's rather to protect against unfortunately timed ctrl-c or > other external interruptions. > > /Erik > > On 2012-11-28 09:26, Fredrik Öhrström wrote: >> Looks ok. However the practice of using [email protected] is unnecessary if the

Re: Review Request: 8004104: build-infra: Minor cleanup

Looks good! 2012/11/28 Erik Joelsson : > Here is a bit of cleanup. > > * A bunch of unnecessary excludes of java-files, since they are in the > platform specific parts of the source anyway. > * An LDFLAGS that should be posix only and was causing a link warning on > windows. > > http://cr.openjdk.

Review Request: JDK-8004145: build-infra: hgforest.sh cannot be interrupted safely.

This patch makes sure that pressing ctrl-c when running "sh get_source.sh" actually sends a nice TERM signal to the background mercurial processes so that they can do a nice rollback, if they need to. Really useful, when that clone has stalled, because your network is down, and you want to stop

Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!)

The GensrcX11Wrapper.gmk makefile creates a new sizes.32 or sizes.64 by running a generated C program that performs many sizeof calculations on X11 structures. This is cross compileable. Fortunately the sizes.32 and sizes.64 offset files are very stable. Thus we can commit them to the source c

Re: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!)

2012-11-29 15:27, Fredrik Öhrström skrev: The GensrcX11Wrapper.gmk makefile creates a new sizes.32 or sizes.64 by running a generated C program that performs many sizeof calculations on X11 structures. This is cross compileable. That "not" was accidently dropped. Obviously this is

Re: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!)

2012-11-29 15:36, Erik Joelsson skrev: I just submitted a patch to build-infra for the dual generation on all platforms since it breaks comparisons between old and new build. In general, we can't change behavior in new build without also changing the old before the old is removed. Removing si

Re: Review Request: 8003819: build-infra: backslashes at end of LIB and INCLUDE in spec.gmk

Looks good. 2012/11/30 Erik Joelsson : > This fixes a problem where the LIB and INCLUDE variables end up with a \ at > the end in spec.gmk. These variables are set in vcvars.bat and configure > extracts them to spec.gmk. Normally they do not end with a backslash, but if > these variables are alrea

Re: Review Request: 8003414: build-infra: fails on on windows

Looks good. 2012/11/30 Erik Joelsson : > This patch adds an extra check for validating that the windows sdk found by > configure is actually valid. > > http://cr.openjdk.java.net/~erikj/8003414/webrev.01/ > > /Erik

Re: Review Request: JDK-8004145: build-infra: hgforest.sh cannot be interrupted safely.

the old classic, space in directories (/cygdrive/c/Program Files/TortoiseHG/hg.exe). /Erik On 2012-12-03 17:34, Kelly O'Hair wrote: Nicely done. Looks good. You do realize that the "you touched it last" rule may apply here in the future? ;^) -kto On Nov 29, 2012, at 5:17 AM, Fredri

Re: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!)

2012-11-29 15:54, Fredrik Öhrström skrev: 2012-11-29 15:36, Erik Joelsson skrev: I just submitted a patch to build-infra for the dual generation on all platforms since it breaks comparisons between old and new build. In general, we can't change behavior in new build without also changin

Re: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!)

2012-12-03 17:55, Kelly O'Hair skrev: I notice that some of the [email protected] stuff has been removed, along with the "$(RM) $@ [email protected]" commands. I know it's a pain to do this, but I have found it necessary, especially on Windows for some reason. What reason? Can you give an example where it fails on

Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

A few source files, coming from the generated swing BeanInfo files are generated and stored into the wrong source directory, where the path does not correspond to the expected package path. This is unfortunate and makes it impossible for the smart javac wrapper to predict which source files bel

  1   2   >