Re: code review request for initial JDK FDS support (7071907)

On 2012-04-10 14:53, Daniel D. Daugherty wrote: On 4/10/12 3:47 PM, Dmitry Samersoff wrote: 1. 239 # If Full Debug Symbols is enabled, then we want the same debug and 240 # optimization flags as used by FASTDEBUG. We also want all the 241 # debug info in one place (-xs). Sorry! I'm later

RFR (S): 8007639: Workaround for ccache in vm.make is incorrect

Please review the following change: Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8007639/webrev.00/webrev Bug: http://bugs.sun.com/view_bug.do?bug_id=8007639 This change corrects the workaround that was introduced in vm.make for enabling ccache for HotSpot builds. The change introduces a

Re: RFR (S): 8007639: Workaround for ccache in vm.make is incorrect

On 9/02/2013 4:30 AM, Mikael Vidstedt wrote: Please review the following change: Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8007639/webrev.00/webrev Bug: http://bugs.sun.com/view_bug.do?bug_id=8007639 This change corrects the workaround that was introduced in vm.make for enabling ccache

Re: RFR (S): 8007639: Workaround for ccache in vm.make is incorrect

Erik/David - Thanks for the reviews! Cheers, Mikael On 2/12/2013 6:35 PM, David Holmes wrote: Looks okay to me. David On 13/02/2013 12:32 PM, Mikael Vidstedt wrote: Good catch! There is no fundamental reason for switching to CFLAGS, and since the other defines are added to CXXFLAGS so

Re: RFR: JDK-8256810: Incremental rebuild broken on Macosx

On Sat, 21 Nov 2020 00:12:30 GMT, Erik Joelsson wrote: > After fixing JDK-8256751, I noticed that the fix-deps-file macro isn't > actually doing the right thing at all. It seems clang on Macosx is > inconsistent with outputting relative or absolute paths in the deps files, so > some files end

Re: RFR: JDK-8257633: Missing -mmacosx-version-min=X flag when linking libjvm

On Fri, 4 Dec 2020 14:44:49 GMT, Erik Joelsson wrote: > We have historically provided -mmacosx-version-min=10.9.0 flags when > compiling and linking all our native executables and libraries on Macosx. > That flag seems to have disappeared when linking libjvm. This is sometimes > causing our ma

Re: RFR: 8257450: Start of release updates for JDK 17

On Tue, 1 Dec 2020 06:22:51 GMT, Joe Darcy wrote: > Start of JDK 17 updates. Marked as reviewed by mikael (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1531

Re: RFR: JDK-8260669: Missing quotes in fixpath.sh

On Fri, 29 Jan 2021 19:54:12 GMT, Erik Joelsson wrote: > The build on Windows can fail if certain directory names are present in root > directory of the workspace. In particular I've observed that the single > letter 'p' is triggering this problem. This is caused by missing quotes > around [:u

Re: [jdk16] RFR: 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)

On Tue, 2 Feb 2021 18:17:55 GMT, Jesper Wilhelmsson wrote: > We have our (first) RC candidate build for JDK 16 on Feb 04, 2021. We need to > remove the EA from version string for this build (b35) and going forward. > > Pushing this for @pashh Marked as reviewed by mikael (Reviewer).

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

On Wed, 3 Feb 2021 20:05:29 GMT, Anton Kozlov wrote: >> Thank you all for your comments regarding W^X implementation. I've made a >> change that reduces the footprint of the implementation, also addressing >> most of the comments. I'll revisit them individually to make sure nothing is >> forgo

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

On Wed, 3 Feb 2021 20:08:28 GMT, Mikael Vidstedt wrote: >>> I wonder if this is the right choice >>> ... >>> ``` >>> OopStorageParIterPerf::~OopStorageParIterPerf() { >>> ... >>> ``` >>> >> >> The transition in OopSt

RFR: 8264224: Add macosx-aarch64 to Oracle build configurations

This adds the necessary macosx-aarch64 support to the build configurations at Oracle. - Commit messages: - 8264224: Add macosx-aarch64 to Oracle build configurations Changes: https://git.openjdk.java.net/jdk/pull/3258/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=325

Re: RFR: 8264224: Add macosx-aarch64 to Oracle build configurations [v2]

On Tue, 30 Mar 2021 12:31:25 GMT, Erik Joelsson wrote: >> I don't think we need to set SETFILE anymore. This used to be needed because >> the SetFile binary in older Xcode versions was 32 bit and Catalina no longer >> supports 32 bit apps. This should definitely not be a problem on aarch64. > >

Re: RFR: 8264224: Add macosx-aarch64 to Oracle build configurations [v2]

> This adds the necessary macosx-aarch64 support to the build configurations at > Oracle. Mikael Vidstedt has updated the pull request incrementally with one additional commit since the last revision: Remove SETFILE override - Changes: - all: https://git.openjdk.java.n

Re: RFR: 8264224: Add macosx-aarch64 to Oracle build configurations [v2]

On Tue, 30 Mar 2021 14:42:22 GMT, Kevin Rushforth wrote: >> To answer Magnus, on line 1133, we define a different dependency, called >> "lldb". That dependency is an older devkit which only purpose is to provide >> lldb for the failure handler when running tests. We need this because we are >>

Re: RFR: 8264224: Add macosx-aarch64 to Oracle build configurations [v3]

> This adds the necessary macosx-aarch64 support to the build configurations at > Oracle. Mikael Vidstedt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull r

RFR: 8264623: Change to Xcode 12.4 for building on Macos at Oracle

Switch to Xcode 12.4 for building macosx-x64 at Oracle. The new lldb dependency is needed to ensure that we can collect information when testing on older versions of macOS which do not support Xcode 12.4. - Commit messages: - 8264623: Change to Xcode 12.4 for building on Macos at O

Integrated: 8264623: Change to Xcode 12.4 for building on Macos at Oracle

On Wed, 7 Apr 2021 22:22:55 GMT, Mikael Vidstedt wrote: > Switch to Xcode 12.4 for building macosx-x64 at Oracle. The new lldb > dependency is needed to ensure that we can collect information when testing > on older versions of macOS which do not support Xcode 12.4. This pull reques

Re: RFR: 8264224: Add macosx-aarch64 to Oracle build configurations [v4]

> This adds the necessary macosx-aarch64 support to the build configurations at > Oracle. Mikael Vidstedt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge branch 'master' into 8264224-macosx-

Re: RFR: 8264224: Add macosx-aarch64 to Oracle build configurations [v3]

On Wed, 31 Mar 2021 19:02:46 GMT, Mikael Vidstedt wrote: >> This adds the necessary macosx-aarch64 support to the build configurations >> at Oracle. > > Mikael Vidstedt has updated the pull request with a new target base due to a > merge or a rebase. The pull request now c

Integrated: 8264224: Add macosx-aarch64 to Oracle build configurations

On Tue, 30 Mar 2021 06:25:21 GMT, Mikael Vidstedt wrote: > This adds the necessary macosx-aarch64 support to the build configurations at > Oracle. This pull request has now been integrated. Changeset: 008fc75a Author:Mikael Vidstedt URL: https://git.openjdk.java.net/jdk/

Re: RFR: JDK-8265371: Change to Visual Studio 2019 16.9.3 for building on Windows at Oracle

On Fri, 16 Apr 2021 18:58:27 GMT, Erik Joelsson wrote: > Oracle is updating the minor version of Visual Studio for building the JDK to > 16.9.3. Marked as reviewed by mikael (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3550

Re: RFR: JDK-8265373: Change to GCC 10.3 for building on Linux at Oracle

On Fri, 16 Apr 2021 19:21:11 GMT, Erik Joelsson wrote: > Oracle is updating the version of GCC for building the JDK to 10.3. > > In addition to the version bump, I'm also enabling cross compilation OOTB > using jib from a linux-aarch64 to linux-x64 binaries, which was the last > missing combin

Re: RFR: JDK-8265373: Change to GCC 10.3 for building on Linux at Oracle [v2]

On Fri, 16 Apr 2021 20:36:05 GMT, Erik Joelsson wrote: >> Oracle is updating the version of GCC for building the JDK to 10.3. >> >> In addition to the version bump, I'm also enabling cross compilation OOTB >> using jib from a linux-aarch64 to linux-x64 binaries, which was the last >> missing c

RFR: 8257459: Bump minimum boot jdk to JDK 16

With JDK 16 having gone GA about a month ago it's time to bump the minimum boot JDK version for mainline/JDK 17. Testing: tier1-5. - Commit messages: - Update GHA configuration - 8257459: Bump minimum boot jdk to JDK 16 Changes: https://git.openjdk.java.net/jdk/pull/3555/files W

Re: RFR: 8257459: Bump minimum boot jdk to JDK 16

On Sat, 17 Apr 2021 07:20:21 GMT, Mikael Vidstedt wrote: > With JDK 16 having gone GA about a month ago it's time to bump the minimum > boot JDK version for mainline/JDK 17. > > Testing: tier1-5. Joe, Iris, Erik - thank you for the reviews! - PR: https://git.ope

Integrated: 8257459: Bump minimum boot jdk to JDK 16

On Sat, 17 Apr 2021 07:20:21 GMT, Mikael Vidstedt wrote: > With JDK 16 having gone GA about a month ago it's time to bump the minimum > boot JDK version for mainline/JDK 17. > > Testing: tier1-5. This pull request has now been integrated. Changeset: 72c88fc4 Author: Mik

RFR: 8265782: Bump bootjdk to jdk-17+19 on macosx-aarch64 at Oracle

The bootjdk used for macosx-aarch64 at Oracle is a custom build of JDK 16 from early December, so does not include all the JDK 16 GA functionality. This leads to build issues after JDK-8263621 which uses a method not included in the custom version. Let's bump the bootjdk used for macosx-aarch64

Integrated: 8265782: Bump bootjdk to jdk-17+19 on macosx-aarch64 at Oracle

On Thu, 22 Apr 2021 18:15:58 GMT, Mikael Vidstedt wrote: > The bootjdk used for macosx-aarch64 at Oracle is a custom build of JDK 16 > from early December, so does not include all the JDK 16 GA functionality. > This leads to build issues after JDK-8263621 which uses a method not inclu

RFR: 8266318: Switch to macos prefix for macOS bundles

Apple rebranded the operating system as "macOS" back in 2016. The JDK bundles files are still use the legacy "osx" string. They should be modernized to use "macos" instead. - Commit messages: - 8266318: Switch to macos prefix for macOS bundles Changes: https://git.openjdk.java.net

Re: RFR: 8266318: Switch to macos prefix for macOS bundles [v2]

> Apple rebranded the operating system as "macOS" back in 2016. The JDK bundles > files are still use the legacy "osx" string. They should be modernized to use > "macos" instead. Mikael Vidstedt has updated the pull request incrementally with one add

Integrated: 8266318: Switch to macos prefix for macOS bundles

On Thu, 29 Apr 2021 19:15:52 GMT, Mikael Vidstedt wrote: > Apple rebranded the operating system as "macOS" back in 2016. The JDK bundles > files are still use the legacy "osx" string. They should be modernized to use > "macos" instead. This pull requ

Re: RFR: 8266318: Switch to macos prefix for macOS bundles [v2]

On Fri, 30 Apr 2021 03:51:18 GMT, Mikael Vidstedt wrote: >> Apple rebranded the operating system as "macOS" back in 2016. The JDK >> bundles files are still use the legacy "osx" string. They should be >> modernized to use "macos" instead.

RFR: 8268142: Switch to jdk-17+24 for macosx-aarch64 at Oracle

With promoted builds available it's a good time to switch the boot JDK etc. - Commit messages: - Merge branch 'master' into 8268142-macos-aarch64-jdk17 - 8268142: Switch to jdk-17+24 for macosx-aarch64 at Oracle Changes: https://git.openjdk.java.net/jdk/pull/4341/files Webrev: htt

Integrated: 8268142: Switch to jdk-17+24 for macosx-aarch64 at Oracle

On Thu, 3 Jun 2021 18:24:51 GMT, Mikael Vidstedt wrote: > With promoted builds available it's a good time to switch the boot JDK etc. This pull request has now been integrated. Changeset: 1b4378e5 Author: Mikael Vidstedt URL: https://git.openjdk.java.net/jd

RFR: 8268214: Use system zlib and disable dtrace when building linux-aarch64 at Oracle

Mimic what's being done on linux-x64 for consistency. - Commit messages: - 8268214: Use system zlib and disable dtrace when building linux-aarch64 at Oracle Changes: https://git.openjdk.java.net/jdk/pull/4347/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4347&range=0

Integrated: 8268214: Use system zlib and disable dtrace when building linux-aarch64 at Oracle

On Thu, 3 Jun 2021 21:24:21 GMT, Mikael Vidstedt wrote: > Mimic what's being done on linux-x64 for consistency. This pull request has now been integrated. Changeset: e2d5ff9d Author: Mikael Vidstedt URL: https://git.openjdk.java.net/jd

Re: [jdk17] RFR: 8268861: Disable Windows-Aarch64 build in GitHub Actions [v3]

On Wed, 16 Jun 2021 04:53:08 GMT, David Holmes wrote: >> This has been failing for a while so disabling it until it can be fixed. >> >> Thanks, >> David > > David Holmes has updated the pull request incrementally with one additional > commit since the last revision: > > Completely remove win

Re: [jdk17] RFR: 8270422: Test build/AbsPathsInImage.java fails after JDK-8259848

On Wed, 14 Jul 2021 07:34:58 GMT, Erik Joelsson wrote: > This patch extends the filter for marker files when creating jmods. Our > latest established marker file format is `_*.marker` and through > ExecuteWithLog, we regularly append additional suffixes to such file names. > Thus I propose we

Re: RFR: 8271148: static-libs-image target --with-native-debug-symbols=external doesn't produce debug info

On Thu, 22 Jul 2021 16:43:26 GMT, Severin Gehwolf wrote: > Hi! > > Please review this tiny patch which removes the special casing of > `--with-native-debug-symbols=external` for the static libs build. I don't see > why this is needed. If no debug symbols are wanted > `--with-native-debug-symb

Re: [jdk17] RFR: 8271150: Remove EA from JDK 17 version string starting with Initial RC promotion on Aug 5, 2021(B34)

On Fri, 30 Jul 2021 06:47:07 GMT, Saravana Kumar Vijayasekaran wrote: > 8271150: Remove EA from JDK 17 version string starting with Initial RC > promotion on Aug 5, 2021(B34) Marked as reviewed by mikael (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/297

Re: RFR: Merge jdk17 [v2]

On Mon, 2 Aug 2021 23:53:59 GMT, Jesper Wilhelmsson wrote: >> Forwardport JDK 17 -> JDK 18 > > Jesper Wilhelmsson has updated the pull request incrementally with one > additional commit since the last revision: > > Revert "8271150: Remove EA from JDK 17 version string starting with Initial

RFR: 8267636: Bump minimum boot jdk to JDK 17

With the JDK 17 GA out it's time to bump the minimum boot JDK version for mainline/JDK 18. Testing: tier1-5, GHA builds - Commit messages: - 8267636: Bump minimum boot jdk to JDK 17 Changes: https://git.openjdk.java.net/jdk/pull/5639/files Webrev: https://webrevs.openjdk.java.net

Integrated: 8267636: Bump minimum boot jdk to JDK 17

On Wed, 22 Sep 2021 20:03:55 GMT, Mikael Vidstedt wrote: > With the JDK 17 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 18. > > Testing: tier1-5, GHA builds This pull request has now been integrated. Changeset: 75404ea2 Author: Mik

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v2]

On Mon, 22 Nov 2021 04:30:38 GMT, Joe Darcy wrote: >> The time to get JDK 19 underway draws nigh, please review this usual set of >> start-of-release updates, including CSRs for the javac and javax.lang.model >> updates: >> >> JDK-8277512: Add SourceVersion.RELEASE_19 >> https://bugs.openjdk.j

RFR: 8266839: Enable pandoc on macosx-aarch64 at Oracle

Enabling pandoc on macosx-aarch64 at Oracle to produce man pages etc. Testing: * Passes tier1 * Verified that the product bundle includes man pages as expected * Sampling a few of the man pages they look as expected - Commit messages: - 8266839: Enable pandoc on macosx-aarch64 Cha

Re: RFR: 8266839: Enable pandoc on macosx-aarch64 at Oracle

On Wed, 1 Dec 2021 18:37:53 GMT, Mikael Vidstedt wrote: > Enabling pandoc on macosx-aarch64 at Oracle to produce man pages etc. > > Testing: > > * Passes tier1 > * Verified that the product bundle includes man pages as expected > * Sampling a few of the man pages they loo

Integrated: 8266839: Enable pandoc on macosx-aarch64 at Oracle

On Wed, 1 Dec 2021 18:37:53 GMT, Mikael Vidstedt wrote: > Enabling pandoc on macosx-aarch64 at Oracle to produce man pages etc. > > Testing: > > * Passes tier1 > * Verified that the product bundle includes man pages as expected > * Sampling a few of the man pages they l

RFR: 8279884: Use better file for cygwin source permission check

For sanity, configure tries to verify that source files have the right permissions by checking the LICENSE file in TOPDIR. That file may not always be available, and for builds where it isn't configure will generate a (harmless) error along the lines of: - Commit messages: - 82798

Integrated: 8279884: Use better file for cygwin source permission check

On Tue, 11 Jan 2022 21:07:17 GMT, Mikael Vidstedt wrote: > For sanity, configure tries to verify that source files have the right > permissions by checking the LICENSE file in TOPDIR. That file may not always > be available, and for builds where it isn't configure will generate

RFR: 8283062: Uninitialized warnings in libgtest with GCC 11.2

Background, from JBS: In file included from googletest-release-1.8.1/googletest/src/gtest-all.cc:42: googletest-release-1.8.1/googletest/src/gtest-death-test.cc: In function 'bool testing::internal::StackGrowsDown()': googletest-release-1.8.1/googletest/src/gtest-death-test.cc:1224:24: error:

Integrated: 8283062: Uninitialized warnings in libgtest with GCC 11.2

On Sat, 12 Mar 2022 03:26:29 GMT, Mikael Vidstedt wrote: > Background, from JBS: > > In file included from > googletest-release-1.8.1/googletest/src/gtest-all.cc:42: > googletest-release-1.8.1/googletest/src/gtest-death-test.cc: In function > 'bool testing::i

RFR: 8283057: Update GCC to version 11.2 for Oracle builds on Linux

Oracle is updating the version of GCC for building the JDK on Linux to 11.2. Testing: tier1-5 + additional significant testing. Re-running tier1,builds-tier{2,3,4,5} now for good luck. - Commit messages: - gcc11.2.0 Changes: https://git.openjdk.java.net/jdk/pull/7871/files Webre

Integrated: 8283057: Update GCC to version 11.2 for Oracle builds on Linux

On Fri, 18 Mar 2022 20:33:54 GMT, Mikael Vidstedt wrote: > Oracle is updating the version of GCC for building the JDK on Linux to 11.2. > > Testing: tier1-5 + additional significant testing. Re-running > tier1,builds-tier{2,3,4,5} now for good luck. This pull request has now bee

RFR: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows

Oracle is updating the version of Visual Studio for building the JDK on Windows to Visual Studio 2022 17.1.0. This change adds support for building devkits based on VS 2022. Instead of creating a new script file for that I decided to combine it with the logic in createWindowsDevkit2019.sh and r

Re: RFR: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows [v2]

On Mon, 28 Mar 2022 11:54:28 GMT, Magnus Ihse Bursie wrote: >> Mikael Vidstedt has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove PROGRAMFILES workaround > > make/devkit/createWindowsDevkit.sh line 7

Re: RFR: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows [v2]

th the logic in > createWindowsDevkit2019.sh and rename the resulting file. I decided to > dropped support for VS 2017 since that version is pretty old now, let me know > if you'd prefer to see it kept around. > > Testing: tier1-5 + additional testing. Mikael Vidstedt has updated the pull reques

Re: RFR: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows [v3]

th the logic in > createWindowsDevkit2019.sh and rename the resulting file. I decided to > dropped support for VS 2017 since that version is pretty old now, let me know > if you'd prefer to see it kept around. > > Testing: tier1-5 + additional testing. Mikael Vidstedt has updated the pull reques

Re: RFR: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows [v3]

On Mon, 28 Mar 2022 16:05:03 GMT, Mikael Vidstedt wrote: >> make/devkit/createWindowsDevkit.sh line 74: >> >>> 72: # Work around the insanely named ProgramFiles(x86) env variable >>> 73: PROGRAMFILES_X86="$($WINDOWS_PATH_TO_UNIX_PATH "$(cmd.exe /c set

Re: RFR: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows [v4]

th the logic in > createWindowsDevkit2019.sh and rename the resulting file. I decided to > dropped support for VS 2017 since that version is pretty old now, let me know > if you'd prefer to see it kept around. > > Testing: tier1-5 + additional testing. Mikael Vidstedt has updated the pull requ

Integrated: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows

On Sun, 27 Mar 2022 05:08:52 GMT, Mikael Vidstedt wrote: > Oracle is updating the version of Visual Studio for building the JDK on > Windows to Visual Studio 2022 17.1.0. > > This change adds support for building devkits based on VS 2022. Instead of > creating a new script

Re: RFR: 8277517: Bump minimum boot jdk to JDK 18

On Tue, 5 Apr 2022 03:19:06 GMT, Mikael Vidstedt wrote: > With the JDK 18 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 19. > > Testing: tier1-5, GHA builds Adding a random comment here in the hopes that it will generate an email and give ever

Re: RFR: 8277517: Bump minimum boot jdk to JDK 18 [v2]

> With the JDK 18 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 19. > > Testing: tier1-5, GHA builds Mikael Vidstedt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated chang

Integrated: 8277517: Bump minimum boot jdk to JDK 18

On Tue, 5 Apr 2022 03:19:06 GMT, Mikael Vidstedt wrote: > With the JDK 18 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 19. > > Testing: tier1-5, GHA builds This pull request has now been integrated. Changeset: 46ce2ef1 Author: Mikael Vidstedt

Re: RFR: 8285755: JDK-8285093 changed the default for --with-output-sync

On Wed, 27 Apr 2022 19:16:48 GMT, Erik Joelsson wrote: > The make option '--output-sync recurse' can be useful in certain situations, > especially when dealing with very verbose output from makefiles and you want > to parse them after the fact. However, when running make interactively on the >

RFR: JDK-8201263: Traling backslash in VS120COMNTOOLS leads to ugly error message when running tests

Please review this change which addresses a minor issue when running tests on some Windows machines. Bug: https://bugs.openjdk.java.net/browse/JDK-8201263 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8201263/webrev.00/open/

Re: RFR: JDK-8201263: Traling backslash in VS120COMNTOOLS leads to ugly error message when running tests

Joelsson wrote: > > Looks good. > > /Erik > > > On 2018-04-06 15:04, Mikael Vidstedt wrote: >> Please review this change which addresses a minor issue when running tests >> on some Windows machines. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK

RFR: JDK-8202052: Disable warnings when building libawt with VS2017

Please review the following change which disables some warnings in libawt which show up when building with VS2017: bug: https://bugs.openjdk.java.net/browse/JDK-8202052 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8202062/webrev.00/open/

Re: RFR (XS): 8209760 merge error: restore ea in make/conf/jib-profiles.js

Looks good, thanks for fixing and sorry for getting it wrong to start with. Cheers, Mikael > On Aug 20, 2018, at 4:11 PM, Tim Bell wrote: > > All- > > Please review this change to restore ea in make/conf/jib-profiles.js. > > This is a file we use to control some internal build and release

Re: Linux + Clang + execstack

> On Aug 20, 2018, at 5:03 PM, David Holmes wrote: > > On 21/08/2018 9:39 AM, Arthur Eubanks wrote: >> On Mon, Aug 20, 2018 at 4:18 PM David Holmes > > wrote: >>Hi Arthur, >>cc'ing build-dev as this is currently a build issue. >>On 21/08/2018 3:11 AM

Re: Linux + Clang + execstack

> On Sep 4, 2018, at 7:06 PM, Martin Buchholz wrote: > > Here's Arthur's patch: > > 8205457: gcc and clang should use the same ld flags > http://cr.openjdk.java.net/~martin/webrevs/jdk/noexecstack/ > https://bugs.openjdk.java.net/browse/JDK-8205457 > > This applies -Wl,-z,noexecstack uniform

Re: RFR: JDK-8210519: build/releaseFile/CheckSource.java failed additional sources found

Looks good, thanks for fixing. Arguably the ":((hg)|(git)):[a-z0-9]*\\+?” string could be a constant (re-)used in the two places it occurs, and the nested if statements inside checking the Oracle specific part could be turned around to check "if (isOpenJDK)” first to avoid the negation, but t

Re: RFR: JDK-8210519: build/releaseFile/CheckSource.java failed additional sources found

Beautiful, thanks for fixing! Cheers, Mikael > On Sep 11, 2018, at 11:39 AM, Erik Joelsson wrote: > > Hello, > > I do agree with your points. > > http://cr.openjdk.java.net/~erikj/8210519/webrev.02/ > > > On 2018-09-11 11:32, Mikael Vidstedt wrote: &g

RFR(S): 8211350: Remove jprt support

Please review this change which removes support for, and references to, the (Oracle internal) JPRT system. bug: https://bugs.openjdk.java.net/browse/JDK-8211350 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.00/open/webrev/ * Background (from the issue) The Oracle internal

Re: RFR(S): 8211350: Remove jprt support

hange. Cheers, Mikael > On Oct 2, 2018, at 8:40 AM, Mandy Chung wrote: > > > > On 10/2/18 12:21 AM, Mikael Vidstedt wrote: >> Please review this change which removes support for, and references to, the >> (Oracle internal) JPRT system. >> >> bug: http

Re: RFR: 8211296: Remove HotSpot deprecation warning suppression for Mac/clang

> On Oct 4, 2018, at 2:18 PM, Kim Barrett wrote: > >> On Oct 4, 2018, at 9:27 AM, Magnus Ihse Bursie >> wrote: >>> That all assumes that static build actually works at all; it doesn’t look >>> like we >>> test that configuration these days, so who knows what bit rot may have set >>> in. >>

Re: Building Portola JDK11 for AMR64 arch

It looks like the compiler doesn’t recognize the aarch64 instruction set, so configure probably picked up the wrong compiler. You’d have to double check what configure says it’s going to use. However, even if you address that it’s unlikely to work. As you probably know Alpine uses the musl C

Re: Building Portola JDK11 for AMR64 arch

> On Oct 26, 2018, at 1:00 AM, Mikael Vidstedt > wrote: > > > > It looks like the compiler doesn’t recognize the aarch64 instruction set, so > configure probably picked up the wrong compiler. You’d have to double check > what configure says it’s going to use. &

Re: Building Portola JDK11 for AMR64 arch

> On Oct 26, 2018, at 3:47 AM, Aleksey Shipilev wrote: > > On 10/26/2018 10:36 AM, Andrew Haley wrote: >> On 10/26/2018 09:00 AM, Mikael Vidstedt wrote: >>> ./configure --openjdk-target=aarch64-oe-linux >>> --with-boot-jdk=/work/jdk11/build/linux-x86_64-nor

Re: RFR: JDK-8210837: Add libXrandr-devel to the Linux devkits

Looks good. (We should drop the ‘E’ in OEL at some point, it’s just OL nowadays) Cheers, Mikael > On Oct 31, 2018, at 1:05 PM, Erik Joelsson wrote: > > Hello, > > Please review this small change to the devkit generator scripts for Linux, > adding libXrandr-devel to the sysroot. I'm also bu

RFR: 8213569: Bump minimum boot jdk to JDK 11

Please review this change which bumps the minimum boot jdk to JDK 11 (see [1] for Boot-JDK policy). bug: https://bugs.openjdk.java.net/browse/JDK-8213569 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8213569/webrev.00/open/webrev/

Re: RFR: JDK-8211727: Adjust default concurrency settings for running tests on Sparc

Looks good, thanks a lot for fixing this! Cheers, Mikael > On Nov 13, 2018, at 2:19 PM, Erik Joelsson wrote: > > I didn't know. Updated references to SPARC. > > http://cr.openjdk.java.net/~erikj/8211727/webrev.02/ > > /Erik > > On 2018-11-13 14:10, Tim Bell wrote: >> Erik: >> >> One nit:

Re: RFR: 8213569: Bump minimum boot jdk to JDK 11

Thanks for the reviews. Pushed. Cheers, Mikael > On Nov 13, 2018, at 9:07 AM, Erik Joelsson wrote: > > Looks good. > > /Erik > > On 2018-11-11 23:30, Mikael Vidstedt wrote: >> Please review this change which bumps the minimum boot jdk to JDK 11 (see >> [1]

Re: RFR: 8213569: Bump minimum boot jdk to JDK 11

JDK keep bumping with each new release? Or will it stay at > JDK 11 until the next LTS? > > Emmanuel Bourg > > > Le 14/11/2018 à 01:07, Mikael Vidstedt a écrit : >> >> Thanks for the reviews. Pushed. >> >> Cheers, >> Mikael >>

Re: RFR: JDK-8217032: Check pandoc capabilities in configure

Looks good. Cheers, Mikael > On Feb 14, 2019, at 3:26 PM, Erik Joelsson wrote: > > Please review this minor fix. The JDK build now has support for generating > man pages, and will try to do so if it finds pandoc on the system. > Unfortunately, not all versions of pandoc are valid, and if a

Re: RFR: JDK-8217032: Check pandoc capabilities in configure

How about having the variable be called something like PANDOC_MARKDOWN_FLAG, and have the value include “markdown”? Cheers, Mikael > On Feb 15, 2019, at 11:57 AM, Erik Joelsson wrote: > > Thanks for the input. Here is a new webrev that only tries to disable the > "smart" extension if it is

Re: RFR: JDK-8217032: Check pandoc capabilities in configure

+1 Cheers, Mikael > On Feb 15, 2019, at 2:28 PM, Erik Joelsson wrote: > > That would look better. Here is a new webrev: > http://cr.openjdk.java.net/~erikj/8217032/webrev.03/index.html > > /Erik > > On 2019-02-15 14:04, Mikael Vidstedt wrote: >> How about

RFR(XS): 8219675: Disable harfbuzz warnings with gcc 8

Please review this change which (temporarily) disables two gcc warnings which are triggered by the harfbuzz code. JBS: https://bugs.openjdk.java.net/browse/JDK-8219675 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8219675/webrev.00/open/

Re: RFR(XS): 8219675: Disable harfbuzz warnings with gcc 8

t; On Feb 25, 2019, at 2:16 PM, Erik Joelsson wrote: > > Looks good. > > /Erik > > On 2019-02-25 13:28, Mikael Vidstedt wrote: >> Please review this change which (temporarily) disables two gcc warnings >> which are triggered by the harfbuzz code. >> >

Re: RFR: JDK-8221414: Bump required boot jdk version to 12

Looks good. Cheers, Mikael > On Mar 25, 2019, at 3:44 PM, Erik Joelsson wrote: > > With the release of JDK 12 it is now time to update the required boot jdk > version for JDK 13 (to 12). This patch changes the configure requirements as > well as bumps the version used for Jib builds at Orac

Re: RFR: JDK-8222913: Add Jib support for VERSION_EXTRA*

Wow, so proactive of you. Ship it! Cheers, Mikael > On Apr 24, 2019, at 4:00 PM, Erik Joelsson wrote: > > JDK-8207849 added support for extra version numbers in the java version > string. Now we need to use at least one more at Oracle so need to add the > corresponding support to jib-profil

Re: JDK 14 RFR of JDK-8214546: Start of release updates for JDK 14

Looks good! Still a bunch of mechanical changes, but it’s far from obvious that spending more time automating this will save any significant time. Cheers, Mikael > On Jun 5, 2019, at 2:40 PM, Joseph D. Darcy wrote: > > Hello, > > Please have an early review the start-of-release builds updat

Re: RFR: JDK-8230715: Baseline compare build on Windows fails intermittently in file type for jvm.pdb

Looks good. Cheers, Mikael > On Sep 6, 2019, at 10:13 AM, Erik Joelsson wrote: > > The baseline compare builds on Windows fails intermittently. The output of > the file command for jvm.pdb is not entirely stable. I have now seen a > handful of failures over the last month looking like this:

RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

Please review this change which implements the changes for JEP 362: Deprecate the Solaris and SPARC Ports. JBS: https://bugs.openjdk.java.net/browse/JDK-8234370 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.00/open/webrev/ I’ve tested that the expected error message is pro

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

> > Looks good. > > /Erik > > On 2019-11-18 15:28, Mikael Vidstedt wrote: >> Please review this change which implements the changes for JEP 362: >> Deprecate the Solaris and SPARC Ports. >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8234370 >> Webrev

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

; Let me know if you think of other places where this should be reflected. Cheers, Mikael > On Nov 22, 2019, at 6:17 AM, Tim Bell wrote: > > Mikael: > > Looks good to me as well. > > Tim > > On 2019-11-22 06:10, Erik Joelsson wrote: >> Looks good. >>

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

tml#Expanded-Before-Required > /.../jdk/make/autoconf/platform.m4:545: > PLATFORM_SETUP_OPENJDK_BUILD_AND_TARGET is expanded from... > stdin:85: the top level > > Would you mind to check (and fix?) this? > Shall I create a bug? > > Thanks > Christoph > > >

RFR(XS): 8235789: AC_REQUIRE: `PLATFORM_EXTRACT_TARGET_AND_BUILD' was expanded before it was required

Please review this change which addresses the warning produced when running configure, introduced by JDK-8234370. Bug: https://bugs.openjdk.java.net/browse/JDK-8235789 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8235789/webrev.00/open/webrev/ Cheers, Mikael

RFR: 8235814: Add --enable-deprecated-ports=yes to all solaris and SPARC build profiles

Please review this change that adds the newly introduced --enable-deprecated-ports=yes argument to the relevant build profiles. Bug: https://bugs.openjdk.java.net/browse/JDK-8235814 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8235814/webrev.01/open/webrev/ Cheers, Mikael

Re: RFR: 8235960: Zero should not trigger the deprecation warning for ports

You need to group the OPENJDK_TARGET_CPU_ARCH and with_jvm_variants checks. The suggested change will incorrectly *not* produce a warning for solaris/*/zero. Something like this should do the trick: if test "x$OPENJDK_TARGET_OS" = xsolaris || (test "x$OPENJDK_TARGET_CPU_ARCH" = xsparc &&

  1   2   >