Re: RFR: 8291444: GHA builds/tests won't run manually if disabled from automatic running

2022-12-01 Thread Christoph Langer
On Fri, 25 Nov 2022 13:24:09 GMT, Christoph Langer wrote: > This is an attempt to fix the issue reported in JDK-8291444. > > The check for secrets.JDK_SUBMIT_FILTER should only be applied to the push > event but not on e.g. workflow_dispatch. > Currently setting JDK_SUBMIT_FILTER would lead to

Re: RFR: 8291444: GHA builds/tests won't run manually if disabled from automatic running [v2]

2022-12-01 Thread Christoph Langer
> This is an attempt to fix the issue reported in JDK-8291444. > > The check for secrets.JDK_SUBMIT_FILTER should only be applied to the push > event but not on e.g. workflow_dispatch. > Currently setting JDK_SUBMIT_FILTER would lead to setting every platform to > 'false', even when manually tri

Re: RFR: 8297984: Turn on warnings as errors for javadoc

2022-12-01 Thread Sergey Bylokhov
On Thu, 1 Dec 2022 22:20:00 GMT, Magnus Ihse Bursie wrote: > For some reason, we never turned on `-Werror` for javadoc. It is high time to > do so. > > This PR also fixes a recent issue with the javadoc in JFR that caused a > warning, and enables building of javadoc on GHA. (It takes about 3 m

Integrated: 8297455: Use the official ToolProvider API to call javac

2022-12-01 Thread Magnus Ihse Bursie
On Tue, 22 Nov 2022 20:50:04 GMT, Magnus Ihse Bursie wrote: > In JDK-8297041, the javacserver was moved out of the JDK itself, and lifted > out as a separate buildtool. Due to this, internal classes in jdk.compiler > were no longer available. Therefore, the closest way to calling javac as > be

Re: RFR: 8297455: Use the official ToolProvider API to call javac [v4]

2022-12-01 Thread Magnus Ihse Bursie
> In JDK-8297041, the javacserver was moved out of the JDK itself, and lifted > out as a separate buildtool. Due to this, internal classes in jdk.compiler > were no longer available. Therefore, the closest way to calling javac as > before were to use `com.sun.tools.javac.Main.compile()`. This me

Re: RFR: 8297455: Use the official ToolProvider API to call javac [v2]

2022-12-01 Thread Magnus Ihse Bursie
> In JDK-8297041, the javacserver was moved out of the JDK itself, and lifted > out as a separate buildtool. Due to this, internal classes in jdk.compiler > were no longer available. Therefore, the closest way to calling javac as > before were to use `com.sun.tools.javac.Main.compile()`. This me

Re: RFR: 8297455: Use the official ToolProvider API to call javac [v3]

2022-12-01 Thread Magnus Ihse Bursie
> In JDK-8297041, the javacserver was moved out of the JDK itself, and lifted > out as a separate buildtool. Due to this, internal classes in jdk.compiler > were no longer available. Therefore, the closest way to calling javac as > before were to use `com.sun.tools.javac.Main.compile()`. This me

Integrated: 8297444: Refactor the javacserver build tool

2022-12-01 Thread Magnus Ihse Bursie
On Tue, 22 Nov 2022 19:54:51 GMT, Magnus Ihse Bursie wrote: > Now that the javacserver no longer has any ambitions outside being a > buildtool customized for the JDK build process, a lot of abstractions and > generalizations can be removed. > > This will allow the actual behavior to be more cl

Re: RFR: 8297444: Refactor the javacserver build tool [v4]

2022-12-01 Thread Magnus Ihse Bursie
> Now that the javacserver no longer has any ambitions outside being a > buildtool customized for the JDK build process, a lot of abstractions and > generalizations can be removed. > > This will allow the actual behavior to be more clearly visible, and will help > debugging the issues we are st

Re: RFR: 8297455: Use the official ToolProvider API to call javac

2022-12-01 Thread Magnus Ihse Bursie
On Tue, 22 Nov 2022 20:50:04 GMT, Magnus Ihse Bursie wrote: > In JDK-8297041, the javacserver was moved out of the JDK itself, and lifted > out as a separate buildtool. Due to this, internal classes in jdk.compiler > were no longer available. Therefore, the closest way to calling javac as > be

RFR: 8297984: Turn on warnings as errors for javadoc

2022-12-01 Thread Magnus Ihse Bursie
For some reason, we never turned on `-Werror` for javadoc. It is high time to do so. This PR also fixes a recent issue with the javadoc in JFR that caused a warning, and enables building of javadoc on GHA. (It takes about 3 minutes, as a separate build job.) - Commit messages: -

Re: RFR: 8297444: Refactor the javacserver build tool [v3]

2022-12-01 Thread Magnus Ihse Bursie
On Thu, 24 Nov 2022 20:36:06 GMT, Magnus Ihse Bursie wrote: >> Now that the javacserver no longer has any ambitions outside being a >> buildtool customized for the JDK build process, a lot of abstractions and >> generalizations can be removed. >> >> This will allow the actual behavior to be mo

Re: RFR: JDK-8296149: Start of release updates for JDK 21 [v2]

2022-12-01 Thread Iris Clark
On Thu, 1 Dec 2022 18:53:38 GMT, Joe Darcy wrote: >> Usual start-of-release updates. Symbol updates in initial version reflect >> JDK 20 build 21. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated change

Re: RFR: JDK-8296149: Start of release updates for JDK 21 [v2]

2022-12-01 Thread Joe Darcy
> Usual start-of-release updates. Symbol updates in initial version reflect JDK > 20 build 21. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contain

Integrated: 8296710: Update to use jtreg 7.1

2022-12-01 Thread Christian Stein
On Tue, 29 Nov 2022 14:44:12 GMT, Christian Stein wrote: > Please review the change to update to using jtreg `7.1`. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the requiredVersi

RFR: 8297963: Partially fix string expansion issues in the autoconf UTIL macros

2022-12-01 Thread Julian Waters
The UTIL macros have several problematic flaws that may not seem apparent initially, the worst of which include parsing commas as actual argument separators to the underlying m4 macros, and completely, but very subtly wrecking shell constructs. I've done my best here to fix some of these issues

Re: RFR: 8291444: GHA builds/tests won't run manually if disabled from automatic running

2022-12-01 Thread Magnus Ihse Bursie
On Fri, 25 Nov 2022 13:24:09 GMT, Christoph Langer wrote: > This is an attempt to fix the issue reported in JDK-8291444. > > The check for secrets.JDK_SUBMIT_FILTER should only be applied to the push > event but not on e.g. workflow_dispatch. > Currently setting JDK_SUBMIT_FILTER would lead to

Re: RFR: 8291444: GHA builds/tests won't run manually if disabled from automatic running

2022-12-01 Thread Erik Joelsson
On Fri, 25 Nov 2022 13:24:09 GMT, Christoph Langer wrote: > This is an attempt to fix the issue reported in JDK-8291444. > > The check for secrets.JDK_SUBMIT_FILTER should only be applied to the push > event but not on e.g. workflow_dispatch. > Currently setting JDK_SUBMIT_FILTER would lead to

Re: RFR: 8291444: GHA builds/tests won't run manually if disabled from automatic running

2022-12-01 Thread Christoph Langer
On Fri, 25 Nov 2022 13:24:09 GMT, Christoph Langer wrote: > This is an attempt to fix the issue reported in JDK-8291444. > > The check for secrets.JDK_SUBMIT_FILTER should only be applied to the push > event but not on e.g. workflow_dispatch. > Currently setting JDK_SUBMIT_FILTER would lead to