Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-12 Thread David Holmes
On Mon, 12 Dec 2022 10:42:22 GMT, Justin King wrote: >> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >> behav

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v3]

2022-12-12 Thread Justin King
On Tue, 13 Dec 2022 00:37:42 GMT, David Holmes wrote: >> Primarily, but its not a requirement. We should also be able to invoke >> `java` as is. The environment variables should be used to force specific >> behavior for a single invocation. Otherwise, if one forgets to pass the >> environment

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v3]

2022-12-12 Thread David Holmes
On Mon, 12 Dec 2022 08:04:57 GMT, Justin King wrote: >> src/java.base/share/native/launcher/main.c line 41: >> >>> 39: // extremely early during library loading, before main is called. We >>> need to override the default >>> 40: // options because by default UBSan only prints a warning for each

RFR: Merge jdk20

2022-12-12 Thread Jesper Wilhelmsson
Forwardport JDK 20 -> JDK 21 - Commit messages: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8297288: Example code in Scanner class - 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows - 8298459: Fix msys2 linking and

Re: [jdk20] RFR: 8298527: Cygwin's uname -m returns different string than before [v2]

2022-12-12 Thread Erik Joelsson
On Mon, 12 Dec 2022 17:19:18 GMT, Christoph Langer wrote: > Hm, you mean like so? That works but results in the debug output of > > https://github.com/openjdk/jdk20/blob/cf93933e21d146fe296b1e4b8e2ef06b699175d6/make/autoconf/build-aux/autoconf-config.guess#L1510 > > to be always written... Do w

Integrated: 8298589: java/net/SctpSanity.java fail with NoClassDefFoundError: sun/nio/ch/sctp/UnsupportedUtil

2022-12-12 Thread Per Minborg
On Mon, 12 Dec 2022 16:56:22 GMT, Per Minborg wrote: > This PR fixes a typo This pull request has now been integrated. Changeset: 9ff85f65 Author:Per Minborg Committer: Daniel Fuchs URL: https://git.openjdk.org/jdk/commit/9ff85f65774c0a81ed10500d3591cd79b440aed0 Stats: 1 line i

Re: [jdk20] RFR: 8298527: Cygwin's uname -m returns different string than before [v2]

2022-12-12 Thread Christoph Langer
On Mon, 12 Dec 2022 13:33:54 GMT, Erik Joelsson wrote: > We don't change the autoconf-* files in build-aux directly. Instead we modify > the wrapper scripts. Hm, you mean like so? That works but results in the debug output of https://github.com/openjdk/jdk20/blob/cf93933e21d146fe296b1e4b8e2ef0

Re: [jdk20] RFR: 8298527: Cygwin's uname -m returns different string than before [v2]

2022-12-12 Thread Christoph Langer
> `uname -m` returns `.x86_64` after the latest upgread, instead of `x86_64`. > Not sure why. > > However, we can handle this in autoconf-config.guess, to unbreak the build. Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: Avoid

Re: RFR: 8298589: java/net/SocketPermission/BindTest.java fails with NoClassDefFoundError: sun/nio/ch/sctp/UnsupportedUtil

2022-12-12 Thread Alan Bateman
On Mon, 12 Dec 2022 16:56:22 GMT, Per Minborg wrote: > This PR fixes a typo Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11636

RFR: 8298589: java/net/SocketPermission/BindTest.java fails with NoClassDefFoundError: sun/nio/ch/sctp/UnsupportedUtil

2022-12-12 Thread Per Minborg
This PR fixes a typo - Commit messages: - Fix typo Changes: https://git.openjdk.org/jdk/pull/11636/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11636&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298589 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Pat

Re: [jdk20] RFR: 8298527: Cygwin's uname -m returns different string than before

2022-12-12 Thread Erik Joelsson
On Sun, 11 Dec 2022 14:13:14 GMT, Christoph Langer wrote: > `uname -m` returns `.x86_64` after the latest upgread, instead of `x86_64`. > Not sure why. > > However, we can handle this in autoconf-config.guess, to unbreak the build. We don't change the autoconf-* files in build-aux directly. In

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v3]

2022-12-12 Thread Justin King
On Mon, 12 Dec 2022 09:58:54 GMT, Justin King wrote: >> src/java.base/share/native/launcher/main.c line 49: >> >>> 47: #endif // UNDEFINED_BEHAVIOR_SANITIZER >>> 48: >>> 49: /* >> >> As I said we have more launcher than 'java', if you put this method here you >> must put it in all launchers.

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-12 Thread Justin King
> Allow building OpenJDK with UBSan. Currently the build fails when optimizing > the image due to lots of undefined behavior (it invokes the built JVM). > Follow up PRs will either replace the undefined behavior with well defined > behavior or suppress errors which are intentional. The goal is t

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v7]

2022-12-12 Thread Justin King
> Allow building OpenJDK with UBSan. Currently the build fails when optimizing > the image due to lots of undefined behavior (it invokes the built JVM). > Follow up PRs will either replace the undefined behavior with well defined > behavior or suppress errors which are intentional. The goal is t

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v6]

2022-12-12 Thread Justin King
On Mon, 12 Dec 2022 09:50:33 GMT, Justin King wrote: >> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >> behav

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v3]

2022-12-12 Thread Justin King
On Mon, 12 Dec 2022 08:14:51 GMT, Robbin Ehn wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add comment explaining __ubsan_default_options and UBSAN_OPTIONS >> >> Signed-off-by: Justin King > > src/java.base/

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v6]

2022-12-12 Thread Justin King
> Allow building OpenJDK with UBSan. Currently the build fails when optimizing > the image due to lots of undefined behavior (it invokes the built JVM). > Follow up PRs will either replace the undefined behavior with well defined > behavior or suppress errors which are intentional. The goal is t

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v5]

2022-12-12 Thread Justin King
> Allow building OpenJDK with UBSan. Currently the build fails when optimizing > the image due to lots of undefined behavior (it invokes the built JVM). > Follow up PRs will either replace the undefined behavior with well defined > behavior or suppress errors which are intentional. The goal is t

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v4]

2022-12-12 Thread Justin King
> Allow building OpenJDK with UBSan. Currently the build fails when optimizing > the image due to lots of undefined behavior (it invokes the built JVM). > Follow up PRs will either replace the undefined behavior with well defined > behavior or suppress errors which are intentional. The goal is t

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v3]

2022-12-12 Thread Robbin Ehn
On Mon, 12 Dec 2022 07:02:04 GMT, Justin King wrote: >> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >> behav

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v3]

2022-12-12 Thread Justin King
On Mon, 12 Dec 2022 07:26:21 GMT, David Holmes wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add comment explaining __ubsan_default_options and UBSAN_OPTIONS >> >> Signed-off-by: Justin King > > src/java.bas