[jdk20] Integrated: 8298527: Cygwin's uname -m returns different string than before

2022-12-13 Thread Christoph Langer
On Sun, 11 Dec 2022 14:13:14 GMT, Christoph Langer wrote: > `uname -m` returns `.x86_64` after the latest upgread, instead of `x86_64`. > Not sure why. > > However, we can handle this in autoconf-config.guess, to unbreak the build. This pull request has now been integrated. Changeset:

Re: [jdk20] RFR: 8298527: Cygwin's uname -m returns different string than before [v5]

2022-12-13 Thread Christoph Langer
On Tue, 13 Dec 2022 21:38:18 GMT, Christoph Langer wrote: >> `uname -m` returns `.x86_64` after the latest upgread, instead of `x86_64`. >> Not sure why. >> >> However, we can handle this in autoconf-config.guess, to unbreak the build. > > Christoph Langer has updated the pull request

Re: [jdk20] RFR: 8298050: Add links to graph output for javadoc [v2]

2022-12-13 Thread Per Minborg
> This PR proposes adding hyperlinks to the sealed graphic layout making > navigation much simpler via the image. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Use package for navigation - Changes: - all:

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-13 Thread Justin King
On Tue, 13 Dec 2022 16:55:09 GMT, Robbin Ehn wrote: > > I guess the advantage to putting this in the build machinery (as opposed to > > using `--with-extra-cflags=-fsanitize=undefined > > --with-extra-ldflags=-fsanitize=undefined`) is that we can turn some of > > these onn by default once

Re: [jdk20] RFR: 8298527: Cygwin's uname -m returns different string than before [v5]

2022-12-13 Thread Erik Joelsson
On Tue, 13 Dec 2022 21:38:18 GMT, Christoph Langer wrote: >> `uname -m` returns `.x86_64` after the latest upgread, instead of `x86_64`. >> Not sure why. >> >> However, we can handle this in autoconf-config.guess, to unbreak the build. > > Christoph Langer has updated the pull request

Re: [jdk20] RFR: 8298527: Cygwin's uname -m returns different string than before [v4]

2022-12-13 Thread Christoph Langer
On Tue, 13 Dec 2022 17:58:58 GMT, Erik Joelsson wrote: >> Christoph Langer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Undo changes to autoconf-config.guess > > make/autoconf/build-aux/config.guess line 35: > >> 33: OUT=`.

Re: [jdk20] RFR: 8298527: Cygwin's uname -m returns different string than before [v4]

2022-12-13 Thread Christoph Langer
On Tue, 13 Dec 2022 14:49:33 GMT, Christoph Langer wrote: >> `uname -m` returns `.x86_64` after the latest upgread, instead of `x86_64`. >> Not sure why. >> >> However, we can handle this in autoconf-config.guess, to unbreak the build. > > Christoph Langer has updated the pull request

Re: [jdk20] RFR: 8298527: Cygwin's uname -m returns different string than before [v5]

2022-12-13 Thread Christoph Langer
> `uname -m` returns `.x86_64` after the latest upgread, instead of `x86_64`. > Not sure why. > > However, we can handle this in autoconf-config.guess, to unbreak the build. Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:

Re: [jdk20] RFR: 8298527: Cygwin's uname -m returns different string than before [v4]

2022-12-13 Thread Erik Joelsson
On Tue, 13 Dec 2022 14:49:33 GMT, Christoph Langer wrote: >> `uname -m` returns `.x86_64` after the latest upgread, instead of `x86_64`. >> Not sure why. >> >> However, we can handle this in autoconf-config.guess, to unbreak the build. > > Christoph Langer has updated the pull request

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-13 Thread Erik Joelsson
On Tue, 13 Dec 2022 13:45:04 GMT, Justin King wrote: > Nope. Some targets end up passing C++ flags to the C compiler, causing a > failure. Ah right, we (mis)use CFLAGS (instead of CXXFLAGS) in some SetupNativeCompilation calls when all source files are C++. In that case, your suggested patch

Re: [jdk20] RFR: 8298050: Add links to graph output for javadoc

2022-12-13 Thread Joe Darcy
On Tue, 13 Dec 2022 14:27:37 GMT, Per Minborg wrote: > This PR proposes adding hyperlinks to the sealed graphic layout making > navigation much simpler via the image. Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.org/jdk20/pull/23

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-13 Thread Robbin Ehn
On Tue, 13 Dec 2022 16:29:59 GMT, Justin King wrote: > I guess the advantage to putting this in the build machinery (as opposed to > using `--with-extra-cflags=-fsanitize=undefined > --with-extra-ldflags=-fsanitize=undefined`) is that we can turn some of these > onn by default once we've

Integrated: Merge jdk20

2022-12-13 Thread Jesper Wilhelmsson
On Tue, 13 Dec 2022 13:55:12 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has now been integrated. Changeset: 23e18275 Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/23e18275ac2a7297ba806a1835fabb7141949967 Stats: 181 lines

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-13 Thread Justin King
On Mon, 12 Dec 2022 10:42:22 GMT, Justin King wrote: >> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >>

Re: [jdk20] RFR: 8298527: Cygwin's uname -m returns different string than before [v4]

2022-12-13 Thread Christoph Langer
On Mon, 12 Dec 2022 18:40:33 GMT, Erik Joelsson wrote: > We certainly don't want spurious output, so that means we need to get > creative. OK, I have tried to be creative then.  I refactored the script a bit. First, I collect stderr into a variable and then only print it if we didn't handle

Re: [jdk20] RFR: 8298527: Cygwin's uname -m returns different string than before [v4]

2022-12-13 Thread Christoph Langer
> `uname -m` returns `.x86_64` after the latest upgread, instead of `x86_64`. > Not sure why. > > However, we can handle this in autoconf-config.guess, to unbreak the build. Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: Undo

Re: [jdk20] RFR: 8298527: Cygwin's uname -m returns different string than before [v3]

2022-12-13 Thread Christoph Langer
> `uname -m` returns `.x86_64` after the latest upgread, instead of `x86_64`. > Not sure why. > > However, we can handle this in autoconf-config.guess, to unbreak the build. Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: Be

Re: RFR: 8298050: Add links to graph output for javadoc [v2]

2022-12-13 Thread Per Minborg
On Tue, 13 Dec 2022 13:17:00 GMT, Per Minborg wrote: >> This PR proposes adding hyperlinks to the sealed graphic layout making >> navigation much simpler via the image. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > >

[jdk20] RFR: 8298050: Add links to graph output for javadoc

2022-12-13 Thread Per Minborg
This PR proposes adding hyperlinks to the sealed graphic layout making navigation much simpler via the image. - Commit messages: - Add links to graph output for javadoc Changes: https://git.openjdk.org/jdk20/pull/23/files Webrev: https://webrevs.openjdk.org/?repo=jdk20=23=00

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-13 Thread Andrew Haley
On Mon, 12 Dec 2022 10:42:22 GMT, Justin King wrote: >> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >>

Withdrawn: 8298050: Add links to graph output for javadoc

2022-12-13 Thread Per Minborg
On Thu, 8 Dec 2022 09:19:54 GMT, Per Minborg wrote: > This PR proposes adding hyperlinks to the sealed graphic layout making > navigation much simpler via the image. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/11580

RFR: Merge jdk20

2022-12-13 Thread Jesper Wilhelmsson
Forwardport JDK 20 -> JDK 21 - Commit messages: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8298084: Memory leak in Method::build_profiling_method_data - 8296955: Kitchensink.java failed with "double free or corruption (!prev): " - 8298488: [macos13]

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-13 Thread Erik Joelsson
On Tue, 13 Dec 2022 08:17:09 GMT, Justin King wrote: > I tried to use a single file, but the build logic attempts to compile as > either C or C++ based on file extensions, and has logic based on it. So if I > use `.cpp` and the target is all `.c` odd things happen. The same for the > inverse.

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-13 Thread Justin King
On Mon, 12 Dec 2022 10:42:22 GMT, Justin King wrote: >> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >>

Withdrawn: Merge jdk20

2022-12-13 Thread Jesper Wilhelmsson
On Mon, 12 Dec 2022 18:49:49 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/11637

Re: RFR: [DRAFT] 8294982: Implementation of Classfile API [v4]

2022-12-13 Thread Adam Sotona
> **This pull request is not intended for immediate integration to JDK > mainline.** > > This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming

Re: RFR: 8298050: Add links to graph output for javadoc [v2]

2022-12-13 Thread Per Minborg
On Thu, 8 Dec 2022 16:12:29 GMT, Jonathan Gibbons wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove Yoda notation > > make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 209: > >> 207:

Re: RFR: 8298050: Add links to graph output for javadoc [v2]

2022-12-13 Thread Per Minborg
> This PR proposes adding hyperlinks to the sealed graphic layout making > navigation much simpler via the image. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Remove Yoda notation - Changes: - all:

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-13 Thread Justin King
On Mon, 12 Dec 2022 10:42:22 GMT, Justin King wrote: >> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >>