Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor

2023-01-05 Thread Alan Bateman
On Fri, 6 Jan 2023 02:20:53 GMT, Archie L. Cobbs wrote: > This PR adds a new lint warning category `this-escape`. > > It also adds `@SuppressWarnings` annotations as needed to the JDK itself to > allow the JDK to continue to compile with `-Xlint:all`. > > A 'this' escape warning is generated

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor

2023-01-05 Thread David Holmes
On Fri, 6 Jan 2023 02:20:53 GMT, Archie L. Cobbs wrote: > This PR adds a new lint warning category `this-escape`. > > It also adds `@SuppressWarnings` annotations as needed to the JDK itself to > allow the JDK to continue to compile with `-Xlint:all`. > > A 'this' escape warning is generated

RFR: 8015831: Add lint check for calling overridable methods from a constructor

2023-01-05 Thread Archie L . Cobbs
This PR adds a new lint warning category `this-escape`. It also adds `@SuppressWarnings` annotations as needed to the JDK itself to allow the JDK to continue to compile with `-Xlint:all`. A 'this' escape warning is generated for a constructor `A()` in a class `A` when the compiler detects that

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v2]

2023-01-05 Thread Matias Saavedra Silva
> This is an enhancement of the test case in > [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests > against an archive created by the "boot JDK", which is usually set as the > previous official JDK release when building the JDK repo. > > If it's able to acquire previous

Integrated: 8299693: Change to Xcode12.4+1.1 devkit for building on macOS at Oracle

2023-01-05 Thread Mikael Vidstedt
On Thu, 5 Jan 2023 20:17:52 GMT, Mikael Vidstedt wrote: > Bump the devkit version used when building on macOS at Oracle to work around > an issue when building on Ventura. This pull request has now been integrated. Changeset: 4b6809b9 Author:Mikael Vidstedt URL:

Re: RFR: 8299693: Change to Xcode12.4+1.1 devkit for building on macOS at Oracle

2023-01-05 Thread Erik Joelsson
On Thu, 5 Jan 2023 20:17:52 GMT, Mikael Vidstedt wrote: > Bump the devkit version used when building on macOS at Oracle to work around > an issue when building on Ventura. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11869

Re: RFR: 8299693: Change to Xcode12.4+1.1 devkit for building on macOS at Oracle

2023-01-05 Thread David Holmes
On Thu, 5 Jan 2023 20:17:52 GMT, Mikael Vidstedt wrote: > Bump the devkit version used when building on macOS at Oracle to work around > an issue when building on Ventura. Looks good and trivial. Thanks. - Marked as reviewed by dholmes (Reviewer). PR:

RFR: 8299693: Change to Xcode12.4+1.1 devkit for building on macOS at Oracle

2023-01-05 Thread Mikael Vidstedt
Bump the devkit version used when building on macOS at Oracle to work around an issue when building on Ventura. - Commit messages: - 8299693: Change to Xcode12.4+1.1 devkit for building on macOS at Oracle Changes: https://git.openjdk.org/jdk/pull/11869/files Webrev:

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions

2023-01-05 Thread Matias Saavedra Silva
On Thu, 5 Jan 2023 19:48:43 GMT, Erik Joelsson wrote: >> bin/jib.sh line 197: >> >>> 195: export REAL_CONFIGURE_COMMAND_EXEC_SHORT="$myname" >>> 196: >>> 197: ${installed_jib_script} "$@" >> >> Don't we need this? > > I just now noticed this file was deleted, that's not ok. Sorry about that,

Integrated: 8299254: Support dealing with standard assert macro

2023-01-05 Thread Kim Barrett
On Thu, 22 Dec 2022 23:05:03 GMT, Kim Barrett wrote: > Please review this change to provide and use mechanisms for dealing with uses > of the standard assert macro (from or ) in 3rd party code > that we use in HotSpot. > > We provide a pair of utility header files, to be included before and

Re: RFR: 8299254: Support dealing with standard assert macro [v2]

2023-01-05 Thread Kim Barrett
> Please review this change to provide and use mechanisms for dealing with uses > of the standard assert macro (from or ) in 3rd party code > that we use in HotSpot. > > We provide a pair of utility header files, to be included before and after a > header that may use (and so include) the

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions

2023-01-05 Thread Ioi Lam
On Thu, 5 Jan 2023 19:25:07 GMT, Coleen Phillimore wrote: >> This is an enhancement of the test case in >> [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests >> against an archive created by the "boot JDK", which is usually set as the >> previous official JDK release when

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions

2023-01-05 Thread Erik Joelsson
On Thu, 5 Jan 2023 19:28:13 GMT, Coleen Phillimore wrote: >> This is an enhancement of the test case in >> [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests >> against an archive created by the "boot JDK", which is usually set as the >> previous official JDK release when

Re: RFR: 8299254: Support dealing with standard assert macro

2023-01-05 Thread Kim Barrett
On Tue, 3 Jan 2023 03:11:32 GMT, Xue-Lei Andrew Fan wrote: >> Please review this change to provide and use mechanisms for dealing with uses >> of the standard assert macro (from or ) in 3rd party code >> that we use in HotSpot. >> >> We provide a pair of utility header files, to be included

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions

2023-01-05 Thread Coleen Phillimore
On Wed, 4 Jan 2023 20:07:48 GMT, Matias Saavedra Silva wrote: > This is an enhancement of the test case in > [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests > against an archive created by the "boot JDK", which is usually set as the > previous official JDK release

Re: RFR: JDK-8298908: Instrument Metaspace for ASan [v6]

2023-01-05 Thread Justin King
On Thu, 5 Jan 2023 16:29:13 GMT, Justin King wrote: >> This change instruments Metaspace for ASan. Metaspace allocates memory using >> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports >> applications [manually poisoning/unpoisoning >>

Re: RFR: JDK-8298908: Instrument Metaspace for ASan [v6]

2023-01-05 Thread Justin King
> This change instruments Metaspace for ASan. Metaspace allocates memory using > `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports > applications [manually poisoning/unpoisoning > memory](https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning). > ASan is

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v10]

2023-01-05 Thread Justin King
On Sat, 17 Dec 2022 06:39:48 GMT, Justin King wrote: >> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >>

Re: RFR: 8294403: [REDO] make test should report only on executed tests [v2]

2023-01-05 Thread Aleksey Shipilev
On Wed, 4 Jan 2023 09:15:18 GMT, Aleksey Shipilev wrote: >> This should help to speed up tests significantly. Currently, if we run "make >> test" with a subset of tests, JTReg would still read the entirety of test >> root to report on tests that were not run. Even with current suite of tests