On Tue, 7 Feb 2023 15:20:15 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent
On Wed, 8 Feb 2023 07:21:07 GMT, Adam Sotona wrote:
>>> Class `Signature` (aka `JavaTypeSignature`), all subclasses,
>>> `MethodSignature` and `ClassSignature` are designed according to [JVMS
>>> 4.7.9.1
>>>
On Wed, 8 Feb 2023 07:21:07 GMT, Adam Sotona wrote:
>>> Class `Signature` (aka `JavaTypeSignature`), all subclasses,
>>> `MethodSignature` and `ClassSignature` are designed according to [JVMS
>>> 4.7.9.1
>>>
On Tue, 7 Feb 2023 15:47:25 GMT, Maurizio Cimadamore
wrote:
>> Class `Signature` (aka `JavaTypeSignature`), all subclasses,
>> `MethodSignature` and `ClassSignature` are designed according to [JVMS
>> 4.7.9.1
>>
On Tue, 7 Feb 2023 15:40:34 GMT, Justin King wrote:
>> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been
>> used to identify multiple leaks so far. It can run most of the test suite
>> except those that also fail with ASan, which is being looked at separately.
>> It is
On Wed, 8 Feb 2023 03:11:32 GMT, Justin King wrote:
> > The bot can only check the required number of Reviewers (strictly 1 per
> > OpenJDK rules but changeable as here via `/reviewers` command) but it
> > doesn't know about the informal rules such as having reviewers from each
> > affected
On Wed, 8 Feb 2023 02:53:51 GMT, David Holmes wrote:
> The bot can only check the required number of Reviewers (strictly 1 per
> OpenJDK rules but changeable as here via `/reviewers` command) but it doesn't
> know about the informal rules such as having reviewers from each affected
> area
On Tue, 7 Feb 2023 15:40:34 GMT, Justin King wrote:
>> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been
>> used to identify multiple leaks so far. It can run most of the test suite
>> except those that also fail with ASan, which is being looked at separately.
>> It is
On Tue, 7 Feb 2023 15:40:34 GMT, Justin King wrote:
>> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been
>> used to identify multiple leaks so far. It can run most of the test suite
>> except those that also fail with ASan, which is being looked at separately.
>> It is
On Tue, 7 Feb 2023 15:34:50 GMT, Justin King wrote:
>> Justin King has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains ten commits:
>>
>> - Merge branch 'master' into lsan
>> - Fix grammatical error
>>
>>Signed-off-by:
Hi Yasumasa,
Please see:
https://mail.openjdk.org/pipermail/jdk-dev/2023-February/007342.html
Cheers,
David
On 7/02/2023 9:25 pm, Yasumasa Suenaga wrote:
Hi all,
We are discussing about source file encoding in PR #12436 [1]
I saw some C4819 warnings on Windows when I tried to build OpenJDK
On Tue, 7 Feb 2023 20:56:01 GMT, Leonid Mesnik wrote:
> The newline is added to be compatible with old make 3.81 which is still used
> on MacOSX.
> Fixed actually by dnsimon.
Marked as reviewed by dnsimon (Committer).
-
PR: https://git.openjdk.org/jdk/pull/12461
On Tue, 7 Feb 2023 20:56:01 GMT, Leonid Mesnik wrote:
> The newline is added to be compatible with old make 3.81 which is still used
> on MacOSX.
> Fixed actually by dnsimon.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12461
The newline is added to be compatible with old make 3.81 which is still used on
MacOSX.
Fixed actually by dnsimon.
-
Commit messages:
- 8301753: AppendFile needs to add a new line to be compatible with old make
Changes: https://git.openjdk.org/jdk/pull/12461/files
Webrev:
Hi build-team, updates-team,
We encountered a build issue since jdk 11.0.18, the root cause and possible
solutions are
documented in JDK-8302000[1]. I am willing to make the change as noted in the
bug.
Let me know if approach #2 or #3 is the best option, I would like
to get a consensus from
On Thu, 26 Jan 2023 17:33:28 GMT, Justin King wrote:
> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been
> used to identify multiple leaks so far. It can run most of the test suite
> except those that also fail with ASan, which is being looked at separately.
> It is
On Mon, 6 Feb 2023 13:29:10 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>>
On Tue, 7 Feb 2023 14:51:06 GMT, Adam Sotona wrote:
> Class `Signature` (aka `JavaTypeSignature`), all subclasses,
> `MethodSignature` and `ClassSignature` are designed according to [JVMS
> 4.7.9.1
> Signatures](https://docs.oracle.com/javase/specs/jvms/se19/html/jvms-4.html#jvms-4.7.9.1)
On Tue, 7 Feb 2023 15:32:11 GMT, Justin King wrote:
>> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been
>> used to identify multiple leaks so far. It can run most of the test suite
>> except those that also fail with ASan, which is being looked at separately.
>> It is
> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been
> used to identify multiple leaks so far. It can run most of the test suite
> except those that also fail with ASan, which is being looked at separately.
> It is especially useful when combined with ASan, as LSan can
> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been
> used to identify multiple leaks so far. It can run most of the test suite
> except those that also fail with ASan, which is being looked at separately.
> It is especially useful when combined with ASan, as LSan can
On Tue, 7 Feb 2023 13:49:55 GMT, Magnus Ihse Bursie wrote:
>> Justin King has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Fix grammatical error
>>
>>Signed-off-by: Justin King
>> - Update based on review and remove
> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been
> used to identify multiple leaks so far. It can run most of the test suite
> except those that also fail with ASan, which is being looked at separately.
> It is especially useful when combined with ASan, as LSan can
On Tue, 7 Feb 2023 12:10:43 GMT, Maurizio Cimadamore
wrote:
>> The confusion come from simplified name. Signature probably should be called
>> JavaTypeSignature according to the spec. ClassSignature and MethodSignature
>> could not extend it, as it would not respect the reality. Each of them
On Tue, 7 Feb 2023 14:14:50 GMT, Maurizio Cimadamore
wrote:
>> The relation is that each `Attribute` is applicable in N
>> `AttributedElements` and not vice versa.
>> For example `ClassModel::attributedElementKind` returns `CLASS` and for
>> example
>>
On Tue, 7 Feb 2023 12:59:32 GMT, Adam Sotona wrote:
>> Still, there seems to be a modelling issue here. The property of "where
>> could this attribute go" is a property of the attribute. Of course, for
>> usability reason, an AttributedElement might expose a predicate saying "I
>> only accept
On Thu, 2 Feb 2023 15:52:01 GMT, Justin King wrote:
>> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been
>> used to identify multiple leaks so far. It can run most of the test suite
>> except those that also fail with ASan, which is being looked at separately.
>> It is
On Thu, 2 Feb 2023 22:44:40 GMT, Erik Joelsson wrote:
> This patch removes some now obsolete jib profiles configurations.
Marked as reviewed by ihse (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12395
On Tue, 7 Feb 2023 12:34:50 GMT, Maurizio Cimadamore
wrote:
>> `AttributedElement::attributedElementKind` identifies the one kind of the
>> attributes holder.
>> The "places where an attribute can appear" is available through
>> `AttributeMapper::whereApplicable` and matched against
>>
On Tue, 7 Feb 2023 12:14:40 GMT, Maurizio Cimadamore
wrote:
>> On the contrary, it has been deduplicated. Opcode is referencing numeric
>> constants stored in Classfile.
>
> sure, but my question is - once you have a nice enum that is 1-1 with the
> opcodes - why would a client want to use
On Tue, 7 Feb 2023 12:23:05 GMT, Adam Sotona wrote:
>> Uhm - I can't see these usages... something seems to be off with my IDE
>> configuration. I did a grep and I now saw the uses. That said, having the
>> Kind/Location inside AttributedElement still looks weird to me. The "places
>> where
On Tue, 7 Feb 2023 11:48:28 GMT, Maurizio Cimadamore
wrote:
>> There are at least 72 usages of AttributedElement.Kind across the Classfile
>> API.
>> Do you suggest to rename it to something else (for example Location)?
>
> Uhm - I can't see these usages... something seems to be off with my
On Mon, 6 Feb 2023 14:35:43 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/Opcode.java line 39:
>>
>>> 37: */
>>> 38: public enum Opcode {
>>> 39: NOP(Classfile.NOP, 1, Kind.NOP),
>>
>> This also duplicates the constants in classfile...
>
> On the contrary,
On Mon, 6 Feb 2023 14:32:12 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/ClassSignature.java line
>> 34:
>>
>>> 32: * Models the generic signature of a class file, as defined by JVMS
>>> 4.7.9.
>>> 33: */
>>> 34: public sealed interface ClassSignature
>>
>>
On Mon, 6 Feb 2023 12:34:36 GMT, Yasumasa Suenaga wrote:
> This is subtask of https://github.com/openjdk/jdk/pull/12427 .
>
> I have seen C4819 warning in libfreetype files on Windows (CP932: Japanese
> locale)
>
>
>
On Mon, 6 Feb 2023 12:35:16 GMT, Yasumasa Suenaga wrote:
> This is subtask of https://github.com/openjdk/jdk/pull/12427 .
>
> I have seen C4819 warning in harfbuzz files on Windows (CP932: Japanese
> locale)
>
>
> d:\github-forked\jdk\src\java.desktop\share\native\libharfbuzz\hb.hh(1):
>
On Mon, 6 Feb 2023 12:34:36 GMT, Yasumasa Suenaga wrote:
> This is subtask of https://github.com/openjdk/jdk/pull/12427 .
>
> I have seen C4819 warning in libfreetype files on Windows (CP932: Japanese
> locale)
>
>
>
On Mon, 6 Feb 2023 14:09:08 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/BootstrapMethodEntry.java
>> line 41:
>>
>>> 39: * part of the constant pool.
>>> 40: */
>>> 41: public sealed interface BootstrapMethodEntry
>>
>> Usages of this seem all to fall into
On Mon, 6 Feb 2023 13:55:59 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/AttributedElement.java
>> line 94:
>>
>>> 92: * are permitted.
>>> 93: */
>>> 94: enum Kind {
>>
>> Not sure how to interpret this. This seems to refer to an attribute -
On Tue, 7 Feb 2023 01:12:06 GMT, Phil Race wrote:
> I grep'ed (with `-i`) in `doc` directory with `LANG`, `utf`, `locale`, but I
> could not find out them. I guess locale of build environment is not mentioned
> clearly. Is it correct?
Yes, it is unfortunately not documented. :-( There is an
On Mon, 6 Feb 2023 12:41:44 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/TypeAnnotation.java line
>> 75:
>>
>>> 73: * The kind of target on which the annotation appears.
>>> 74: */
>>> 75: public enum TargetType {
>>
>> My IDE says this enum is
Hi all,
We are discussing about source file encoding in PR #12436 [1]
I saw some C4819 warnings on Windows when I tried to build OpenJDK on Windows
with Japanese locale (CP932). C4819 means the source file contains characters
which cl.exe cannot be handled in the current code page (CP932 in
On Tue, 7 Feb 2023 07:55:58 GMT, Doug Simon wrote:
>For now, we will just add a check into Graal that UseBranchProtection is not
>set, exiting the VM if it is
that sounds a better solution to me instead of:
> disable JVMCI if _rop_protection is parsed as "true"
-
PR:
On Fri, 20 Jan 2023 12:01:06 GMT, Daniel Jeliński wrote:
>> Please review this patch that fixes and re-enables a few warnings in libawt
>> compilation.
>>
>> Verified that debug and release builds finish successfully on Win, Mac and
>> Linux. Also verified that client libs tests still pass.
>
On Tue, 7 Feb 2023 06:14:24 GMT, Hao Sun wrote:
>> The problem with `JVMCIGlobals::check_jvmci_supported_gc` is that it does
>> not give the compiler a chance to specify whether it supports a given GC.
>> Instead, we want a JVMCI upcall like
>>
45 matches
Mail list logo
