Integrated: JDK-8304171: Fix layout of JCov instrumented bundle on Mac OS

2023-03-14 Thread Alexandre Iline
On Tue, 14 Mar 2023 19:34:32 GMT, Alexandre Iline wrote: > Now on all platforms the JCov bundle would look the same. This pull request has now been integrated. Changeset: 065d3e0d Author:Alexandre Iline URL:

Re: RFR: 8303018: Unicode Emoji Properties [v2]

2023-03-14 Thread Roger Riggs
On Tue, 14 Mar 2023 15:49:56 GMT, Naoto Sato wrote: >> Proposing accessor methods to Emoji properties defined in [Unicode Technical >> Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character` >> class. This is per a request from the client group, as well as refining the >>

Integrated: JDK-8301998: Update HarfBuzz to 7.0.1

2023-03-14 Thread Harshitha Onkar
On Tue, 7 Mar 2023 23:31:16 GMT, Harshitha Onkar wrote: > HarfBuzz library updated from v4.4.1 to v7.0.1 > > - harfbuzz.md file updated > - Added -DHB_NO_VISIBILITY to HARFBUZZ_CFLAGS in Awt2DLibraries.gmk to avoid > build issues on linux and macos targets. > - GPOS.hh moved to Layout to

Re: RFR: JDK-8304171: Fix layout of JCov instrumented bundle on Mac OS

2023-03-14 Thread Erik Joelsson
On Tue, 14 Mar 2023 19:34:32 GMT, Alexandre Iline wrote: > Now on all platforms the JCov bundle would look the same. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.org/jdk/pull/13027

RFR: JDK-8304171: Fix layout of JCov instrumented bundle on Mac OS

2023-03-14 Thread Alexandre Iline
Now on all platforms the JCov bundle would look the same. - Commit messages: - JDK-8304171: Fix layout of JCov instrumented bundle on Mac OS Changes: https://git.openjdk.org/jdk/pull/13027/files Webrev: https://webrevs.openjdk.org/?repo=jdk=13027=00 Issue:

Re: RFR: 8303485: Replacing os.name for operating system customization [v3]

2023-03-14 Thread Eirik Bjorsnos
On Tue, 14 Mar 2023 18:15:46 GMT, Roger Riggs wrote: >> src/java.base/share/classes/jdk/internal/util/OperatingSystem.java line 29: >> >>> 27: >>> 28: /** >>> 29: * Enumeration of operating system types and testing for the current OS. >> >> Would it be more correct to say an enumerating of

Re: RFR: 8303485: Replacing os.name for operating system customization [v4]

2023-03-14 Thread Roger Riggs
> Improvements to support OS specific customization for JDK internal use: > - To select values and code; allowing elimination of unused code and values > - Optionally evaluated by build processes, compilation, or archiving (i.e. > CDS) > - Simple API to replace adhoc comparisons with `os.name`

Re: RFR: 8303485: Replacing os.name for operating system customization [v3]

2023-03-14 Thread Roger Riggs
On Tue, 14 Mar 2023 15:04:47 GMT, Alan Bateman wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix indentation and improve exception message > > src/java.base/share/classes/jdk/internal/util/OperatingSystem.java

Re: RFR: JDK-8301998: Update HarfBuzz to 7.0.1 [v2]

2023-03-14 Thread Phil Race
On Thu, 9 Mar 2023 06:12:26 GMT, Harshitha Onkar wrote: >> HarfBuzz library updated from v4.4.1 to v7.0.1 >> >> - harfbuzz.md file updated >> - Added -DHB_NO_VISIBILITY to HARFBUZZ_CFLAGS in Awt2DLibraries.gmk to avoid >> build issues on linux and macos targets. >> - GPOS.hh moved to Layout to

Re: RFR: 8303018: Unicode Emoji Properties [v2]

2023-03-14 Thread Eirik Bjorsnos
On Tue, 14 Mar 2023 15:49:56 GMT, Naoto Sato wrote: >> Proposing accessor methods to Emoji properties defined in [Unicode Technical >> Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character` >> class. This is per a request from the client group, as well as refining the >>

Integrated: 8295884: Implement IDE support for Eclipse

2023-03-14 Thread Julian Waters
On Tue, 25 Oct 2022 13:23:34 GMT, Julian Waters wrote: > Eclipse is a popular and very well-known IDE in the world of Java > development, utilized widely in many contexts, by beginners and experienced > teams alike. Although a relatively lightweight IDE, it features surprisingly > powerful

Re: RFR: 8295884: Implement IDE support for Eclipse [v43]

2023-03-14 Thread Julian Waters
On Mon, 13 Mar 2023 14:24:49 GMT, Julian Waters wrote: >> Eclipse is a popular and very well-known IDE in the world of Java >> development, utilized widely in many contexts, by beginners and experienced >> teams alike. Although a relatively lightweight IDE, it features surprisingly >>

Re: RFR: 8303018: Unicode Emoji Properties [v2]

2023-03-14 Thread Alan Bateman
On Tue, 14 Mar 2023 15:43:13 GMT, Naoto Sato wrote: > Fixed this one as well Spec update looks good. I suppose I have to use an emoji to react to that  - PR: https://git.openjdk.org/jdk/pull/13006

Re: RFR: 8303018: Unicode Emoji Properties [v2]

2023-03-14 Thread Eirik Bjorsnos
On Tue, 14 Mar 2023 15:49:56 GMT, Naoto Sato wrote: >> Proposing accessor methods to Emoji properties defined in [Unicode Technical >> Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character` >> class. This is per a request from the client group, as well as refining the >>

Re: RFR: 8303018: Unicode Emoji Properties [v2]

2023-03-14 Thread Naoto Sato
On Tue, 14 Mar 2023 08:13:11 GMT, Alan Bateman wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed method descriptions > > src/java.base/share/classes/java/lang/Character.java line 10803: > >> 10801: /** >>

Re: RFR: 8303018: Unicode Emoji Properties [v2]

2023-03-14 Thread Naoto Sato
> Proposing accessor methods to Emoji properties defined in [Unicode Technical > Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character` > class. This is per a request from the client group, as well as refining the > currently existing ad-hoc emoji implementation in regex. A

Re: RFR: 8302659: Modernize Windows native code for NetworkInterface [v5]

2023-03-14 Thread Alan Bateman
On Wed, 1 Mar 2023 18:55:05 GMT, Rich DiCroce wrote: >> Improves performance and correctness, as discussed on the net-dev mailing >> list. > > Rich DiCroce has updated the pull request incrementally with one additional > commit since the last revision: > > Revert flag change in

Re: Error while building jdk 11.0.18 for solaris sparcv Platform.

2023-03-14 Thread Rushal Bhalerao
++ David Whitlock From: Rushal Bhalerao Sent: Monday, March 13, 2023 2:48 PM To: build-dev@openjdk.org Subject: Error while building jdk 11.0.18 for solaris sparcv Platform. Hi Team, I tried to build jdk 11.0.18 version for solaris sparcv platform and while

Re: RFR: 8303485: Replacing os.name for operating system customization [v3]

2023-03-14 Thread Alan Bateman
On Tue, 14 Mar 2023 14:14:30 GMT, Roger Riggs wrote: >> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS)

Re: RFR: 8295884: Implement IDE support for Eclipse [v43]

2023-03-14 Thread Julian Waters
On Mon, 13 Mar 2023 14:24:49 GMT, Julian Waters wrote: >> Eclipse is a popular and very well-known IDE in the world of Java >> development, utilized widely in many contexts, by beginners and experienced >> teams alike. Although a relatively lightweight IDE, it features surprisingly >>

Re: RFR: 8303485: Replacing os.name for operating system customization [v3]

2023-03-14 Thread Roger Riggs
> Improvements to support OS specific customization for JDK internal use: > - To select values and code; allowing elimination of unused code and values > - Optionally evaluated by build processes, compilation, or archiving (i.e. > CDS) > - Simple API to replace adhoc comparisons with `os.name`

Re: RFR: 8304030: Configure call fails on AIX when using --with-gtest option.

2023-03-14 Thread Matthias Baesken
On Tue, 14 Mar 2023 08:08:12 GMT, Arno Zeller wrote: > When calling configure with the --with-gtest option on AIX it fails with the > following error: > ... > checking for X11/Intrinsic.h... yes > checking for gtest... > /sapmnt/sapjvm_work/openjdk/tools/gtest/googletest-1.13.0 Pre-submit

Re: RFR: 8304030: Configure call fails on AIX when using --with-gtest option.

2023-03-14 Thread Erik Joelsson
On Tue, 14 Mar 2023 08:08:12 GMT, Arno Zeller wrote: > When calling configure with the --with-gtest option on AIX it fails with the > following error: > ... > checking for X11/Intrinsic.h... yes > checking for gtest... > /sapmnt/sapjvm_work/openjdk/tools/gtest/googletest-1.13.0 Marked as

Re: RFR: 8303018: Unicode Emoji Properties

2023-03-14 Thread Erik Joelsson
On Mon, 13 Mar 2023 21:16:24 GMT, Naoto Sato wrote: > Proposing accessor methods to Emoji properties defined in [Unicode Technical > Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character` > class. This is per a request from the client group, as well as refining the >

Re: RFR: 8295884: Implement IDE support for Eclipse [v43]

2023-03-14 Thread Erik Joelsson
On Mon, 13 Mar 2023 14:24:49 GMT, Julian Waters wrote: >> Eclipse is a popular and very well-known IDE in the world of Java >> development, utilized widely in many contexts, by beginners and experienced >> teams alike. Although a relatively lightweight IDE, it features surprisingly >>

Re: RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

2023-03-14 Thread Rich DiCroce
On Tue, 14 Mar 2023 10:10:43 GMT, Daniel Jeliński wrote: >> I've updated the PR to address all of the various comments. >> >> @AlanBateman Regarding tools that return the new interface names, I'm not >> aware of any either. But it's not too hard to hack together a PowerShell >> script to call

Re: RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

2023-03-14 Thread Daniel Jeliński
On Wed, 1 Mar 2023 14:37:34 GMT, Rich DiCroce wrote: >> Rich DiCroce has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Forgot to add file >> - Resolve review comments > > I've updated the PR to address all of the various comments. > >

Re: RFR: 8294982: Implementation of Classfile API [v58]

2023-03-14 Thread Glavo
On Wed, 8 Mar 2023 08:50:24 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8304030: Configure call fails on AIX when using --with-gtest option.

2023-03-14 Thread Matthias Baesken
On Tue, 14 Mar 2023 08:08:12 GMT, Arno Zeller wrote: > When calling configure with the --with-gtest option on AIX it fails with the > following error: > ... > checking for X11/Intrinsic.h... yes > checking for gtest... > /sapmnt/sapjvm_work/openjdk/tools/gtest/googletest-1.13.0 LGTM

RFR: 8304030: Configure call fails on AIX when using --with-gtest option.

2023-03-14 Thread Arno Zeller
When calling configure with the --with-gtest option on AIX it fails with the following error: ... checking for X11/Intrinsic.h... yes checking for gtest... /sapmnt/sapjvm_work/openjdk/tools/gtest/googletest-1.13.0 - Commit messages: - JDK-8304030 Changes:

Re: RFR: 8303018: Unicode Emoji Properties

2023-03-14 Thread Alan Bateman
On Mon, 13 Mar 2023 21:16:24 GMT, Naoto Sato wrote: > Proposing accessor methods to Emoji properties defined in [Unicode Technical > Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character` > class. This is per a request from the client group, as well as refining the >