Re: RFR: 8303796: Optionally build fully statically linked JDK image

2023-04-27 Thread David Holmes
On Fri, 28 Apr 2023 01:03:28 GMT, Jiangli Zhou wrote: > Initial implementation for supporting building a fully statically linked > (with a desired set of JDK native libraries and libjvm) Java launcher > executable, which is named as 'javastatic'. > > In this PR, the support is only added for t

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v3]

2023-04-27 Thread David Holmes
On Thu, 27 Apr 2023 18:21:56 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 14 commits: > > - Merge branch 'maste

RFR: 8303796: Optionally build fully statically linked JDK image

2023-04-27 Thread Jiangli Zhou
Initial implementation for supporting building a fully statically linked (with a desired set of JDK native libraries and libjvm) Java launcher executable, which is named as 'javastatic'. In this PR, the support is only added for the linux platform. Both gcc and clang can be supported. For curre

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v3]

2023-04-27 Thread Erik Joelsson
On Thu, 27 Apr 2023 21:04:42 GMT, Erik Joelsson wrote: >> Antonios Printezis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> updated > > Marked as reviewed by erikj (Reviewer). > @erikj79 Thanks! I assume the integrate command will actu

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v3]

2023-04-27 Thread Antonios Printezis
On Thu, 27 Apr 2023 21:04:42 GMT, Erik Joelsson wrote: >> Antonios Printezis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> updated > > Marked as reviewed by erikj (Reviewer). @erikj79 Thanks! I assume the integrate command will actual

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v3]

2023-04-27 Thread Erik Joelsson
On Thu, 27 Apr 2023 20:53:25 GMT, Antonios Printezis wrote: >> Fix is to exclude hsdis when building the buildjdk. > > Antonios Printezis has updated the pull request incrementally with one > additional commit since the last revision: > > updated Marked as reviewed by erikj (Reviewer).

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v3]

2023-04-27 Thread Maurizio Cimadamore
On Thu, 27 Apr 2023 18:21:56 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 14 commits: > > - Merge branch 'maste

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v3]

2023-04-27 Thread Antonios Printezis
> Fix is to exclude hsdis when building the buildjdk. Antonios Printezis has updated the pull request incrementally with one additional commit since the last revision: updated - Changes: - all: https://git.openjdk.org/jdk/pull/13697/files - new: https://git.openjdk.org/jdk/pu

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

2023-04-27 Thread Antonios Printezis
On Thu, 27 Apr 2023 20:37:11 GMT, Erik Joelsson wrote: >> Antonios Printezis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changes based on Erik's feedback > > make/autoconf/buildjdk-spec.gmk.in line 109: > >> 107: # hsdis is not need

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

2023-04-27 Thread Erik Joelsson
On Thu, 27 Apr 2023 20:08:29 GMT, Antonios Printezis wrote: >> Fix is to exclude hsdis when building the buildjdk. > > Antonios Printezis has updated the pull request incrementally with one > additional commit since the last revision: > > changes based on Erik's feedback make/autoconf/buildj

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]

2023-04-27 Thread Maurizio Cimadamore
On Thu, 27 Apr 2023 18:28:41 GMT, Jim Laskey wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Enter.java line 432: >> >>> 430: >>> 431: // Restructure top level to be an top level anonymous class. >>> 432: public static void constructAnonymousMainClass(JCCompilationUnit

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

2023-04-27 Thread Antonios Printezis
> Fix is to exclude hsdis when building the buildjdk. Antonios Printezis has updated the pull request incrementally with one additional commit since the last revision: changes based on Erik's feedback - Changes: - all: https://git.openjdk.org/jdk/pull/13697/files - new: https

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

2023-04-27 Thread Antonios Printezis
On Thu, 27 Apr 2023 18:19:49 GMT, Erik Joelsson wrote: >> Antonios Printezis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changes based on Erik's feedback > > This looks like it should work, but I would like to avoid sprinkling any mo

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]

2023-04-27 Thread Jim Laskey
On Thu, 27 Apr 2023 14:53:21 GMT, Maurizio Cimadamore wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PreviewFeatures.isEnabled() > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Enter.java line 432: > >

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails

2023-04-27 Thread Antonios Printezis
On Thu, 27 Apr 2023 18:19:49 GMT, Erik Joelsson wrote: > This looks like it should work, but I would like to avoid sprinkling any more > CREATING_BUILDJDK conditionals throughout the build than absolutely > necessary. I think it would be better to just override `HSDIS_BACKEND` and > `ENABLE_HS

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails

2023-04-27 Thread Erik Joelsson
On Thu, 27 Apr 2023 17:57:05 GMT, Antonios Printezis wrote: > Fix is to exclude hsdis when building the buildjdk. This looks like it should work, but I would like to avoid sprinkling any more CREATING_BUILDJDK conditionals throughout the build than absolutely necessary. I think it would be bet

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]

2023-04-27 Thread Jim Laskey
On Thu, 27 Apr 2023 13:39:37 GMT, Alan Bateman wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PreviewFeatures.isEnabled() > > src/java.base/share/classes/sun/launcher/LauncherHelper.java line 45: > >> 43: import ja

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]

2023-04-27 Thread Jim Laskey
On Thu, 27 Apr 2023 14:55:01 GMT, Maurizio Cimadamore wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PreviewFeatures.isEnabled() > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java line > 2433

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v3]

2023-04-27 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: - Merge branch 'master' into 8306112 - PreviewFeatures.isEnabled() - Clean up isPre

RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails

2023-04-27 Thread Antonios Printezis
Fix is to exclude hsdis when building the buildjdk. - Commit messages: - JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails Changes: https://git.openjdk.org/jdk/pull/13697/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13697&range=00 Issue: ht

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]

2023-04-27 Thread Joe Darcy
On Thu, 27 Apr 2023 13:17:58 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > PreviewFeatures.isEnabled() I assume future it

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]

2023-04-27 Thread Maurizio Cimadamore
On Thu, 27 Apr 2023 13:17:58 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > PreviewFeatures.isEnabled() src/jdk.compiler/s

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]

2023-04-27 Thread Alan Bateman
On Thu, 27 Apr 2023 13:17:58 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > PreviewFeatures.isEnabled() src/java.base/shar

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]

2023-04-27 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: PreviewFeatures.isEnabled() - Changes: - all: https://git.openjdk.org/jdk/pull/13689/files -

RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview)

2023-04-27 Thread Jim Laskey
Add flexible main methods and anonymous main classes to the Java language. - Commit messages: - Clean up isPreview - Missing exception - Corrections - Update VM.java - Clean up testing - Update TestJavacTaskScanner.java - Merge branch 'master' into 8306112 - Clean up - remnan

Integrated: 8306976: UTIL_REQUIRE_SPECIAL warning on grep

2023-04-27 Thread xpbob
On Thu, 27 Apr 2023 07:00:05 GMT, xpbob wrote: > hi > > bash configure > > There is an warning message > > The following warnings were produced. Repeated here for convenience: > WARNING: Ignoring value of GREP from the environment. Use command line > variables instead. This pull request has

Integrated: 8304265: Implementation of Foreign Function and Memory API (Third Preview)

2023-04-27 Thread Per Minborg
On Fri, 17 Mar 2023 15:42:56 GMT, Per Minborg wrote: > API changes for the FFM API (third preview) > > ### Specdiff > https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html > > ### Javadoc > https://cr.openjdk.org/~pminborg/panama/21/v2/javadoc/api/java.base/java/lang/fore

Re: RFR: 8306976: UTIL_REQUIRE_SPECIAL warning on grep

2023-04-27 Thread xpbob
On Thu, 27 Apr 2023 08:50:01 GMT, Christoph Langer wrote: >> hi >> >> bash configure >> >> There is an warning message >> >> The following warnings were produced. Repeated here for convenience: >> WARNING: Ignoring value of GREP from the environment. Use command line >> variables instead. > >

Re: RFR: 8306976: UTIL_REQUIRE_SPECIAL warning on grep

2023-04-27 Thread Matthias Baesken
On Thu, 27 Apr 2023 07:00:05 GMT, xpbob wrote: > hi > > bash configure > > There is an warning message > > The following warnings were produced. Repeated here for convenience: > WARNING: Ignoring value of GREP from the environment. Use command line > variables instead. Marked as reviewed by

Re: RFR: 8306976: UTIL_REQUIRE_SPECIAL warning on grep

2023-04-27 Thread Christoph Langer
On Thu, 27 Apr 2023 07:00:05 GMT, xpbob wrote: > hi > > bash configure > > There is an warning message > > The following warnings were produced. Repeated here for convenience: > WARNING: Ignoring value of GREP from the environment. Use command line > variables instead. Ah, yes, I must have o

RFR: 8306976: UTIL_REQUIRE_SPECIAL warning on grep

2023-04-27 Thread xpbob
hi bash configure There is an warning message The following warnings were produced. Repeated here for convenience: WARNING: Ignoring value of GREP from the environment. Use command line variables instead. - Commit messages: - 8306976: UTIL_REQUIRE_SPECIAL warning on grep Changes