Re: RFR: 8307194: Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v9]

2023-05-09 Thread Jiangli Zhou
On Tue, 9 May 2023 22:14:04 GMT, Erik Joelsson wrote: > I think you also need to make a change to `GraalBuilderImage.gmk` and the > target in `Main.gmk` that calls it. Good catch! Fixed `GraalBuilderImage.gmk`, thanks! For the `graal-builder-image` target that uses `GraalBuilderImage.gmk`,

Re: RFR: 8307194: Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v10]

2023-05-09 Thread Jiangli Zhou
> This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/hotspot static libraries: > > - Introduce new make target(s) for creating image/bundle containing hotspot > libjvm.a and JDK static libraries > >

Re: RFR: 8307194: Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v9]

2023-05-09 Thread Erik Joelsson
On Tue, 9 May 2023 21:46:42 GMT, Jiangli Zhou wrote: >> This PR is branched from the makefile changes for >> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for >> handling the JDK/hotspot static libraries: >> >> - Introduce new make target(s) for creating image/bundle

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-09 Thread Alexander Zvegintsev
On Tue, 9 May 2023 20:43:13 GMT, Phil Race wrote: > I want to work through the scenarios and how much of it is specific to the > behaviours of the API you are using and so forth. Since you use the > Preferences API for saving the token, if you keyed it off the Robot class > rather than the

Re: RFR: 8307194: Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v7]

2023-05-09 Thread Jiangli Zhou
On Mon, 8 May 2023 19:45:18 GMT, Jiangli Zhou wrote: > > > All of that said, I think we can get away with a smaller subset of > > > targets and deliverables. AFAIK, graal needs the combined > > > `graal-builder-image` as input to their build anyway, so they should not > > > have any

Re: RFR: 8307194: Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v9]

2023-05-09 Thread Jiangli Zhou
> This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/hotspot static libraries: > > - Introduce new make target(s) for creating image/bundle containing hotspot > libjvm.a and JDK static libraries > >

Re: RFR: 8307194: Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v8]

2023-05-09 Thread Jiangli Zhou
> This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/hotspot static libraries: > > - Introduce new make target(s) for creating image/bundle containing hotspot > libjvm.a and JDK static libraries > >

Re: RFR: JDK-8306983: Do not invoke external programs when switch terminal to raw mode on selected platforms [v2]

2023-05-09 Thread Brian Burkhalter
On Fri, 5 May 2023 12:34:29 GMT, Jan Lahoda wrote: >> To support JShell and other usecases, the JDK uses JLine, which provides >> line-editing functionality inside a terminal. >> >> JLine has several ways to work with the terminal, based on various >> additional libraries and tools. Most of

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-09 Thread Phil Race
On Fri, 5 May 2023 14:35:46 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL [v2]

2023-05-09 Thread Chen Liang
On Mon, 8 May 2023 20:05:50 GMT, Chen Liang wrote: >> This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. >> The root cause might be that JMH requires passing VM args to benchmarks in >> quotes, which might have triggered incorrect detections in `FIXPATH` (as in >>

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL [v2]

2023-05-09 Thread Roger Riggs
On Mon, 8 May 2023 20:05:50 GMT, Chen Liang wrote: >> This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. >> The root cause might be that JMH requires passing VM args to benchmarks in >> quotes, which might have triggered incorrect detections in `FIXPATH` (as in >>

Re: RFR: 8300204: Sealed-class hierarchy graph missing nodes

2023-05-09 Thread Jonathan Gibbons
On Tue, 9 May 2023 03:11:10 GMT, Chen Liang wrote: > Please review this simple patch that fixes the package determination for > nested classes in the `@sealedGraph` taglet. > > Current JDK 21: >

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL [v2]

2023-05-09 Thread Erik Joelsson
On Mon, 8 May 2023 20:05:50 GMT, Chen Liang wrote: >> This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. >> The root cause might be that JMH requires passing VM args to benchmarks in >> quotes, which might have triggered incorrect detections in `FIXPATH` (as in >>

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL [v2]

2023-05-09 Thread Chen Liang
On Mon, 8 May 2023 20:05:50 GMT, Chen Liang wrote: >> This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. >> The root cause might be that JMH requires passing VM args to benchmarks in >> quotes, which might have triggered incorrect detections in `FIXPATH` (as in >>

Re: RFR: 8307058: Implementation of Generational ZGC [v12]

2023-05-09 Thread Stefan Karlsson
On Tue, 9 May 2023 12:55:42 GMT, Stefan Karlsson wrote: >> Hi all, >> >> Please review the implementation of Generational ZGC, which can be turned on >> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational >> ZGC is a major rewrite of the non-generational ZGC version

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots

2023-05-09 Thread Alexander Zvegintsev
On Mon, 8 May 2023 18:41:56 GMT, Sergey Bylokhov wrote: > > It seems that the current robot API is not suitable for this. > > Can we just reset the token when we create a new instance of Robot? This will be a big problem for automated testing, as each test with the robot will require user

Re: RFR: 8307732: build-test-lib is broken

2023-05-09 Thread Daniel Jeliński
On Tue, 9 May 2023 10:38:54 GMT, Johannes Bechberger wrote: > Fixes the issue by adding `--add-exports` for the required modules and making > the `HttpHeaderParser` final (fixing an issue with calling overridable > methods in a constructor). Marked as reviewed by djelinski (Reviewer).

Re: RFR: 8307058: Implementation of Generational ZGC [v12]

2023-05-09 Thread Stefan Karlsson
> Hi all, > > Please review the implementation of Generational ZGC, which can be turned on > by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational > ZGC is a major rewrite of the non-generational ZGC version that exists in the > openjdk/jdk repository. It splits the heap

Re: RFR: 8307732: build-test-lib is broken

2023-05-09 Thread Erik Joelsson
On Tue, 9 May 2023 10:38:54 GMT, Johannes Bechberger wrote: > Fixes the issue by adding `--add-exports` for the required modules and making > the `HttpHeaderParser` final (fixing an issue with calling overridable > methods in a constructor). Marked as reviewed by erikj (Reviewer).

Re: RFR: 8307058: Implementation of Generational ZGC [v11]

2023-05-09 Thread Stefan Karlsson
> Hi all, > > Please review the implementation of Generational ZGC, which can be turned on > by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational > ZGC is a major rewrite of the non-generational ZGC version that exists in the > openjdk/jdk repository. It splits the heap

Re: RFR: 8307732: build-test-lib is broken

2023-05-09 Thread Johannes Bechberger
On Tue, 9 May 2023 10:38:54 GMT, Johannes Bechberger wrote: > Fixes the issue by adding `--add-exports` for the required modules and making > the `HttpHeaderParser` final (fixing an issue with calling overridable > methods in a constructor). Well, I wanted to use the WhiteBox testing API for

Re: RFR: 8307732: build-test-lib is broken

2023-05-09 Thread Daniel Jeliński
On Tue, 9 May 2023 10:38:54 GMT, Johannes Bechberger wrote: > Fixes the issue by adding `--add-exports` for the required modules and making > the `HttpHeaderParser` final (fixing an issue with calling overridable > methods in a constructor). That's interesting. How did you find this? Is the

RFR: 8307732: build-test-lib is broken

2023-05-09 Thread Johannes Bechberger
Fixes the issue by adding `--add-exports` for the required modules and making the `HttpHeaderParser` final (fixing an issue with calling overridable methods in a constructor). - Commit messages: - Fix make build-test-lib Changes: https://git.openjdk.org/jdk/pull/13885/files

Re: RFR: 8307058: Implementation of Generational ZGC [v10]

2023-05-09 Thread Erik Österlund
On Tue, 9 May 2023 07:27:46 GMT, Kim Barrett wrote: >> Stefan Karlsson has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Workaround failed reservation in ZForwardingTest > > src/hotspot/share/code/relocInfo.hpp line 1105: > >> 1103:

Re: RFR: 8307058: Implementation of Generational ZGC [v10]

2023-05-09 Thread Kim Barrett
On Tue, 9 May 2023 06:06:11 GMT, Stefan Karlsson wrote: >> Hi all, >> >> Please review the implementation of Generational ZGC, which can be turned on >> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational >> ZGC is a major rewrite of the non-generational ZGC version

Re: RFR: 8300204: Sealed-class hierarchy graph missing nodes

2023-05-09 Thread Per Minborg
On Tue, 9 May 2023 03:11:10 GMT, Chen Liang wrote: > Please review this simple patch that fixes the package determination for > nested classes in the `@sealedGraph` taglet. > > Current JDK 21: >

Re: RFR: 8307058: Implementation of Generational ZGC [v6]

2023-05-09 Thread Stefan Karlsson
On Tue, 9 May 2023 00:50:56 GMT, Fei Yang wrote: >> That's unfortunate. Could you try this patch, which probes the address range >> to see if it can reserve the memory somewhere else within >> `[ZAddressHeapBase, ZAddressHeapBase+ZAddressOffsetMax)`: >>

Re: RFR: 8307058: Implementation of Generational ZGC [v10]

2023-05-09 Thread Stefan Karlsson
> Hi all, > > Please review the implementation of Generational ZGC, which can be turned on > by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational > ZGC is a major rewrite of the non-generational ZGC version that exists in the > openjdk/jdk repository. It splits the heap