Re: RFR: 8307573: Implementation of JEP 449: Deprecate the Windows 32-bit x86 Port for Removal [v5]

2023-05-22 Thread David Holmes
On Mon, 22 May 2023 08:51:13 GMT, George Adams wrote: >> Deprecate the Windows x86-32 port, with the intent to remove it in a future >> release. > > George Adams has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v5]

2023-05-22 Thread Alexander Zvegintsev
> Modern Linux systems often come with > [Wayland](https://wayland.freedesktop.org/) by default. > This comes with some difficulties, and one of them is the inability to get > screenshots from the system. > This is because we now use the [X Window System >

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v4]

2023-05-22 Thread Jiangli Zhou
> Original description for JDK-8307194 change: > - > This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/hotspot static libraries: > > - Build hotspot libjvm.a and JDK static libraries for >

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v2]

2023-05-22 Thread Jiangli Zhou
On Mon, 22 May 2023 19:52:42 GMT, Erik Joelsson wrote: >> Jiangli Zhou has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 12 commits: >> >> - Merge branch 'master' into JDK-8307858 >> - Merge branch 'master' into JDK-8307858 >> -

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v2]

2023-05-22 Thread Jiangli Zhou
On Mon, 22 May 2023 19:54:59 GMT, Erik Joelsson wrote: >> Jiangli Zhou has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 12 commits: >> >> - Merge branch 'master' into JDK-8307858 >> - Merge branch 'master' into JDK-8307858 >> -

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v3]

2023-05-22 Thread Jiangli Zhou
> Original description for JDK-8307194 change: > - > This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/hotspot static libraries: > > - Build hotspot libjvm.a and JDK static libraries for >

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v2]

2023-05-22 Thread Erik Joelsson
On Mon, 22 May 2023 19:40:00 GMT, Jiangli Zhou wrote: >> Original description for JDK-8307194 change: >> - >> This PR is branched from the makefile changes for >> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for >> handling the JDK/hotspot static libraries: >> >>

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v2]

2023-05-22 Thread Erik Joelsson
On Mon, 22 May 2023 19:21:52 GMT, Jiangli Zhou wrote: >> Thanks @erikj79. Could you please help provide some more info on the build >> failure: >> >> Which macOs version ran into the build issue? My mac is on Ventura 13.3.1 >> (a). It builds successfully for the `static-libs-image` target. >>

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v2]

2023-05-22 Thread Jiangli Zhou
> Original description for JDK-8307194 change: > - > This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/hotspot static libraries: > > - Build hotspot libjvm.a and JDK static libraries for >

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries

2023-05-22 Thread Jiangli Zhou
On Mon, 22 May 2023 19:10:57 GMT, Jiangli Zhou wrote: > Thanks @erikj79. Could you please help provide some more info on the build > failure: > > Which macOs version ran into the build issue? My mac is on Ventura 13.3.1 > (a). It builds successfully for the `static-libs-image` target. > >

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries

2023-05-22 Thread Jiangli Zhou
On Fri, 19 May 2023 22:45:16 GMT, Erik Joelsson wrote: >> make/common/NativeCompilation.gmk line 1208: >> >>> 1206: $$(call ExecuteWithLog, >>> $$($1_OBJECT_DIR)/$$($1_SAFE_NAME)_partial_link, \ >>> 1207:$$($1_LD) $(LDFLAGS_CXX_PARTIAL_LINKING) >>>

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v4]

2023-05-22 Thread Alexander Zvegintsev
> Modern Linux systems often come with > [Wayland](https://wayland.freedesktop.org/) by default. > This comes with some difficulties, and one of them is the inability to get > screenshots from the system. > This is because we now use the [X Window System >

Re: RFR: 8308093: Disable language preview features use in JDK

2023-05-22 Thread Joe Darcy
On Mon, 22 May 2023 10:01:55 GMT, Adam Sotona wrote: > This patch disables temporary use of language preview features in JDK. > Temporary enabled language preview features (to allow Pattern Matching for > switch use in the Classfile API library) are no more necessary. > All redundant use of

Integrated: 8307573: Implementation of JEP 449: Deprecate the Windows 32-bit x86 Port for Removal

2023-05-22 Thread George Adams
On Sat, 6 May 2023 09:39:17 GMT, George Adams wrote: > Deprecate the Windows x86-32 port, with the intent to remove it in a future > release. This pull request has now been integrated. Changeset: 29b8d3d9 Author:George Adams Committer: Jesper Wilhelmsson URL:

Re: RFR: 8308093: Disable language preview features use in JDK

2023-05-22 Thread Alan Bateman
On Mon, 22 May 2023 10:01:55 GMT, Adam Sotona wrote: > This patch disables temporary use of language preview features in JDK. > Temporary enabled language preview features (to allow Pattern Matching for > switch use in the Classfile API library) are no more necessary. > All redundant use of

Re: RFR: 8308093: Disable language preview features use in JDK

2023-05-22 Thread Erik Joelsson
On Mon, 22 May 2023 10:01:55 GMT, Adam Sotona wrote: > This patch disables temporary use of language preview features in JDK. > Temporary enabled language preview features (to allow Pattern Matching for > switch use in the Classfile API library) are no more necessary. > All redundant use of

Re: RFR: 8308093: Disable language preview features use in JDK

2023-05-22 Thread Chen Liang
On Mon, 22 May 2023 10:01:55 GMT, Adam Sotona wrote: > This patch disables temporary use of language preview features in JDK. > Temporary enabled language preview features (to allow Pattern Matching for > switch use in the Classfile API library) are no more necessary. > All redundant use of

Integrated: JDK-8306983: Do not invoke external programs when switch terminal to raw mode on selected platforms

2023-05-22 Thread Jan Lahoda
On Thu, 27 Apr 2023 11:21:04 GMT, Jan Lahoda wrote: > To support JShell and other usecases, the JDK uses JLine, which provides > line-editing functionality inside a terminal. > > JLine has several ways to work with the terminal, based on various additional > libraries and tools. Most of them

RFR: 8308093: Disable language preview features use in JDK

2023-05-22 Thread Adam Sotona
This patch disables temporary use of language preview features in JDK. Temporary enabled language preview features (to allow Pattern Matching for switch use in the Classfile API library) are no more necessary. All redundant use of --enable-preview in the Classfile API tests are also removed.

Re: RFR: 8307573: Implementation of JEP 449: Deprecate the Windows 32-bit x86 Port for Removal [v5]

2023-05-22 Thread George Adams
> Deprecate the Windows x86-32 port, with the intent to remove it in a future > release. George Adams has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains

Re: RFR: 8307573: Implementation of JEP 449: Deprecate the Windows 32-bit x86 Port for Removal [v3]

2023-05-22 Thread George Adams
On Fri, 19 May 2023 14:49:54 GMT, George Adams wrote: >> George Adams has updated the pull request incrementally with one additional >> commit since the last revision: >> >> typo fix > > This JEP has now been moved from "Proposed to target" to "Targeted" which > means I think we can merge

Re: RFR: 8307573: Implementation of JEP 449: Deprecate the Windows 32-bit x86 Port for Removal [v4]

2023-05-22 Thread George Adams
> Deprecate the Windows x86-32 port, with the intent to remove it in a future > release. George Adams has updated the pull request incrementally with two additional commits since the last revision: - fixup - update wording from review - Changes: - all:

Re: RFR: 8307573: Implementation of JEP 449: Deprecate the Windows 32-bit x86 Port for Removal [v3]

2023-05-22 Thread David Holmes
On Fri, 19 May 2023 14:49:54 GMT, George Adams wrote: >> George Adams has updated the pull request incrementally with one additional >> commit since the last revision: >> >> typo fix > > This JEP has now been moved from "Proposed to target" to "Targeted" which > means I think we can merge

Re: RFR: 8307652: sealed class hierarchy graph doesn't distinguish non-sealed classes [v2]

2023-05-22 Thread Per Minborg
On Tue, 16 May 2023 17:16:57 GMT, Chen Liang wrote: >> `@sealedGraph` had a mechanism to render non-sealed classes differently, but >> it's useless because the graph nodes are not bordered. This patch converts >> the non-sealed classes to be rendered in italics instead. >> >> An example of

Re: RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code [v2]

2023-05-22 Thread JoKern65
On Thu, 18 May 2023 15:20:22 GMT, Kim Barrett wrote: >> Use >> >> struct shmid_ds shm_buf{}; >> >> to _value-initialize_. Calls the default constructor if there is one. >> Otherwise, performs _zero-initialization_, >> which is what we want here. > > The final suggested change (to