Re: RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code [v2]

2023-05-23 Thread Kim Barrett
On Mon, 22 May 2023 07:09:30 GMT, JoKern65 wrote: >> The final suggested change (to direct-value-initialize the object) seems to >> have *not* been made. >> >> However, I think it doesn't matter. The mentioned restriction against being >> non-empty until C23 is not relevant. >> This is C++, n

Re: RFR: 8307652: sealed class hierarchy graph doesn't distinguish non-sealed classes [v2]

2023-05-23 Thread -
Hi, Jonathan Gibbons, would you mind taking a look at this and approve if this looks good? I wish to get this into JDK 21 before RDP 1 starts. On Mon, May 22, 2023 at 2:25 AM Per Minborg wrote: > > On Tue, 16 May 2023 17:16:57 GMT, Chen Liang wrote: > > >> `@sealedGraph` had a mechanism to rend

Re: RFR: JDK-8306584: Start of release updates for JDK 22

2023-05-23 Thread Iris Clark
On Thu, 20 Apr 2023 20:28:18 GMT, Joe Darcy wrote: > Time to get JDK 22 underway... Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13567#pullrequestreview-1440582657

Re: RFR: JDK-8306584: Start of release updates for JDK 22

2023-05-23 Thread Joe Darcy
On Tue, 23 May 2023 20:38:34 GMT, Jonathan Gibbons wrote: >> Time to get JDK 22 underway... > > test/langtools/tools/javac/versions/Versions.java line 93: > >> 91: TWENTY(false,"64.0", "20", Versions::checksrc20), >> 92: TWENTY_ONE(false,"65.0", "21", Versions::checksrc20), >

Re: RFR: JDK-8306584: Start of release updates for JDK 22

2023-05-23 Thread Jonathan Gibbons
On Thu, 20 Apr 2023 20:28:18 GMT, Joe Darcy wrote: > Time to get JDK 22 underway... test/langtools/tools/javac/versions/Versions.java line 26: > 24: /* > 25: * @test > 26: * @bug 4981566 5028634 5094412 6304984 7025786 7025789 8001112 8028545 > 8000961 8030610 8028546 8188870 8173382 8173382

Re: RFR: JDK-8306584: Start of release updates for JDK 22

2023-05-23 Thread Erik Joelsson
On Thu, 20 Apr 2023 20:28:18 GMT, Joe Darcy wrote: > Time to get JDK 22 underway... Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13567#pullrequestreview-1440532444

Re: RFR: JDK-8306584: Start of release updates for JDK 22

2023-05-23 Thread Joe Darcy
On Thu, 20 Apr 2023 20:28:18 GMT, Joe Darcy wrote: > Time to get JDK 22 underway... Typical start-of-JDK-next changes. As usual, the bulk of the PR is the symbol file information to support "javac --release 21". - PR Comment: https://git.openjdk.org/jdk/pull/13567#issuecomment-156

RFR: JDK-8306584: Start of release updates for JDK 22

2023-05-23 Thread Joe Darcy
Time to get JDK 22 underway... - Commit messages: - Merge branch 'master' into JDK-8306584 - Merge branch 'master' into JDK-8306584 - Minor test fixes. - Merge branch 'master' into JDK-8306584 - Update symbol files to JDK 21 b23. - Merge branch 'JDK-8306584' of https://github.co

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v17]

2023-05-23 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 33 commits: - Fix missing constructor error messages and handle inner class launching - Merge br

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v16]

2023-05-23 Thread Jim Laskey
On Tue, 23 May 2023 18:02:16 GMT, Alan Bateman wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Give subclass priority > > src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 129: > >> 127:

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v16]

2023-05-23 Thread Alan Bateman
On Thu, 18 May 2023 19:06:28 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > Give subclass priority src/java.base/share/cla

RFR: 8306703: JFR: Summary views

2023-05-23 Thread Erik Gahlin
Could I have a review of an enhancement that adds a view command to jfr. Testing: tier1, tier2 + jdk/jdk/jfr For the change to work properly when streaming, fix of JDK-8306703 needs to be applied. To simplify the review, changes not relevant to the feature, but that can use classes in jdk.jfr.

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v5]

2023-05-23 Thread Alexander Zvegintsev
On Mon, 22 May 2023 22:34:17 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v6]

2023-05-23 Thread Alexander Zvegintsev
> Modern Linux systems often come with > [Wayland](https://wayland.freedesktop.org/) by default. > This comes with some difficulties, and one of them is the inability to get > screenshots from the system. > This is because we now use the [X Window System > API](https://en.wikipedia.org/wiki/X_Wi

Integrated: 8308093: Disable language preview features use in JDK

2023-05-23 Thread Adam Sotona
On Mon, 22 May 2023 10:01:55 GMT, Adam Sotona wrote: > This patch disables temporary use of language preview features in JDK. > Temporary enabled language preview features (to allow Pattern Matching for > switch use in the Classfile API library) are no more necessary. > All redundant use of --en