Re: RFR: 8308286 Fix clang warnings in linux code [v6]

2023-06-22 Thread Daniel Jeliński
On Thu, 22 Jun 2023 09:58:19 GMT, Daniel Jeliński wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 241: > >> 239: DISABLED_WARNINGS_

Re: RFR: 8308286 Fix clang warnings in linux code [v6]

2023-06-22 Thread Artem Semenov
On Thu, 22 Jun 2023 09:58:49 GMT, Daniel Jeliński wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 260: > >> 258: DISABLED_WARNINGS_clang_ai

Re: RFR: 8308286 Fix clang warnings in linux code [v7]

2023-06-22 Thread Artem Semenov
> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: update - Changes: - all:

Re: RFR: JDK-8310550: Adjust references to rt.jar

2023-06-22 Thread Alan Bateman
On Wed, 21 Jun 2023 15:18:19 GMT, Matthias Baesken wrote: > There are a few references to rt.jar in comments and in the codebase itself. > Some of them might be removed or adjusted. src/java.sql/share/classes/java/sql/DriverManager.java line 658: > 656: * (which is invoking this class

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events

2023-06-22 Thread Erik Gahlin
On Thu, 22 Jun 2023 11:53:59 GMT, Daniel Fuchs wrote: > The new code seems to accurately correspond to what the various > `*Instrumentor` classes were doing, so that is good. I agree with Alan that > potential exception that may arise when generating the event are an issue > (e.g. call to getR

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events

2023-06-22 Thread Daniel Fuchs
On Tue, 6 Jun 2023 19:39:31 GMT, Tim Prinzing wrote: > The socket read/write JFR events currently use instrumentation of java.base > code using templates in the jdk.jfr modules. This results in some java.base > code residing in the jdk.jfr module which is undesirable. > > JDK19 added static su

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events

2023-06-22 Thread Alan Bateman
On Wed, 21 Jun 2023 15:48:30 GMT, Alan Bateman wrote: >> The socket read/write JFR events currently use instrumentation of java.base >> code using templates in the jdk.jfr modules. This results in some java.base >> code residing in the jdk.jfr module which is undesirable. >> >> JDK19 added sta

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events

2023-06-22 Thread Alan Bateman
On Tue, 6 Jun 2023 19:39:31 GMT, Tim Prinzing wrote: > The socket read/write JFR events currently use instrumentation of java.base > code using templates in the jdk.jfr modules. This results in some java.base > code residing in the jdk.jfr module which is undesirable. > > JDK19 added static su

Re: RFR: 8308286 Fix clang warnings in linux code [v6]

2023-06-22 Thread Daniel Jeliński
On Thu, 22 Jun 2023 09:13:21 GMT, Artem Semenov wrote: >> When using the clang compiler to build OpenJDk on Linux, we encounter >> various "warnings as errors". >> They can be fixed with small changes. > > Artem Semenov has updated the pull request incrementally with one additional > commit sin

Re: RFR: JDK-8310550: Adjust references to rt.jar

2023-06-22 Thread Matthias Baesken
On Wed, 21 Jun 2023 21:46:03 GMT, David Holmes wrote: >> There are a few references to rt.jar in comments and in the codebase itself. >> Some of them might be removed or adjusted. > > src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java > line 196: > >> 194: >> 195:

Re: RFR: 8308286 Fix clang warnings in linux code [v6]

2023-06-22 Thread Artem Semenov
> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: update - Changes: - all:

Re: RFR: 8308286 Fix clang warnings in linux code [v5]

2023-06-22 Thread Artem Semenov
On Wed, 21 Jun 2023 07:35:16 GMT, Daniel Jeliński wrote: >> Artem Semenov has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains five commits: >> >> - update >> - update >> - update >> - update >> - 8308286 Fix clang warnings in lin

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events

2023-06-22 Thread Erik Gahlin
On Tue, 6 Jun 2023 19:39:31 GMT, Tim Prinzing wrote: > The socket read/write JFR events currently use instrumentation of java.base > code using templates in the jdk.jfr modules. This results in some java.base > code residing in the jdk.jfr module which is undesirable. > > JDK19 added static su