Re: Inconsistent revision control

2023-06-26 Thread Alan Snyder
Thanks for the information. That indeed was the problem. Carbon Copy Cloner squirrels some files away to allow undo, a feature that I don’t usually pay attention to. Removing the extra CCC directory did the trick. Alan > On Jun 26, 2023, at 6:24 PM, Sriram Narayanan wrote: > > > > On

Re: Inconsistent revision control

2023-06-26 Thread Sriram Narayanan
On Tue, 27 Jun 2023 at 8:34 AM, Alan Snyder wrote: > Can we start over? > > I am trying to do a JDK build using make. > > It reports an error like this: Inconsistent revision control: 17-24-55/ is > missing .git directory > > at which point the build is aborted. > > I’d like to know what this mes

Re: Inconsistent revision control

2023-06-26 Thread Joseph D. Darcy
Thread archived at https://mail.openjdk.org/pipermail/build-dev/2023-June/039957.html -Joe On 6/26/2023 6:03 PM, Alan Snyder wrote: I’m deducing the existence of a message from Erik that I did not receive. Perhaps someone can repost it?

Re: Inconsistent revision control

2023-06-26 Thread Alan Snyder
Can we start over? I am trying to do a JDK build using make. It reports an error like this: Inconsistent revision control: 17-24-55/ is missing .git directory at which point the build is aborted. I’d like to know what this message means, so that I can fix the problem or avoid it in the future

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base [v2]

2023-06-26 Thread Anthony Scarpino
> Hi, > > I need a code review for moving the contents of the jdk.crypto.ec module into > java.base. This moves the SunEC JCE Provider (Elliptic Curve) into > java.base. EC has always been separate from the base module/pkg because of > its dependence on a native library. That library was rem

Re: Inconsistent revision control

2023-06-26 Thread Joseph D. Darcy
And anyone is free to use the standard set of tools, which is know to work and used daily by dozens to hundreds of developers. -Joe On 6/26/2023 3:24 PM, David Holmes wrote: On 27/06/2023 8:04 am, Alan Snyder wrote: An incremental clone is a sync, like an incremental backup. Erik responded t

Re: Inconsistent revision control

2023-06-26 Thread David Holmes
On 27/06/2023 8:04 am, Alan Snyder wrote: An incremental clone is a sync, like an incremental backup. Erik responded to a different question. I’ve gotten no closer to figuring out this problem. Erik responded to exactly your question. Feel free to be helpful, if you can. I don’t think it i

Re: Inconsistent revision control

2023-06-26 Thread Alan Snyder
An incremental clone is a sync, like an incremental backup. Erik responded to a different question. I’ve gotten no closer to figuring out this problem. Feel free to be helpful, if you can. I don’t think it is helpful to nitpick my words. > On Jun 26, 2023, at 2:46 PM, David Holmes wrote: >

Re: Inconsistent revision control

2023-06-26 Thread David Holmes
On 27/06/2023 7:40 am, Alan Snyder wrote: No, I meant incremental clone. What is an incremental clone? After updating the directory, I tried to do an incremental build and got the strange message. So you did mean "incremental build". After that, I tried doing a full build, reconfiguring,

Re: Inconsistent revision control

2023-06-26 Thread Alan Snyder
No, I meant incremental clone. After updating the directory, I tried to do an incremental build and got the strange message. After that, I tried doing a full build, reconfiguring, etc., but nothing helped. Now that you know that a build tool is involved, can you help me figure out what the pro

Re: Inconsistent revision control

2023-06-26 Thread David Holmes
On 26/06/2023 10:55 pm, Alan Snyder wrote: It would be very unlikely for CCC to fail to correctly clone the directory. It would be helpful to know what the build tool is complaining about with that message. Wasn't apparent any build tool was involved. You stated: > After an incremental clone

Re: RFR: 8310890: Normalize identifier names

2023-06-26 Thread Pavel Rappo
On Mon, 26 Jun 2023 18:44:42 GMT, Pavel Rappo wrote: >> make/data/charsetmapping/charsets line 149: >> >>> 147: package sun.nio.cs >>> 148: typesbcs >>> 149: histname ISO8859_2 >> >> Should this column be re-aligned with the longer name? > > I thought about it before publishing

Re: RFR: 8310890: Normalize identifier names

2023-06-26 Thread Pavel Rappo
On Mon, 26 Jun 2023 18:31:06 GMT, Jens Lidestrom wrote: >> Please review this cleanup PR to normalize names of identifiers which are >> Java variables/fields or tokens in text files. Those names either contain a >> pronoun that is very rarely used in code, or seem like they contain such a >> p

Re: RFR: 8310890: Normalize identifier names

2023-06-26 Thread Pavel Rappo
On Mon, 26 Jun 2023 18:21:07 GMT, Roger Riggs wrote: >> Please review this cleanup PR to normalize names of identifiers which are >> Java variables/fields or tokens in text files. Those names either contain a >> pronoun that is very rarely used in code, or seem like they contain such a >> pron

Re: RFR: 8310890: Normalize identifier names

2023-06-26 Thread Jens Lidestrom
On Mon, 26 Jun 2023 14:07:03 GMT, Pavel Rappo wrote: > Please review this cleanup PR to normalize names of identifiers which are > Java variables/fields or tokens in text files. Those names either contain a > pronoun that is very rarely used in code, or seem like they contain such a > pronoun,

Re: RFR: 8310890: Normalize identifier names

2023-06-26 Thread Roger Riggs
On Mon, 26 Jun 2023 14:07:03 GMT, Pavel Rappo wrote: > Please review this cleanup PR to normalize names of identifiers which are > Java variables/fields or tokens in text files. Those names either contain a > pronoun that is very rarely used in code, or seem like they contain such a > pronoun,

Re: RFR: 8310890: Normalize identifier names

2023-06-26 Thread Naoto Sato
On Mon, 26 Jun 2023 14:07:03 GMT, Pavel Rappo wrote: > Please review this cleanup PR to normalize names of identifiers which are > Java variables/fields or tokens in text files. Those names either contain a > pronoun that is very rarely used in code, or seem like they contain such a > pronoun,

RFR: 8310890: Normalize identifier names

2023-06-26 Thread Pavel Rappo
Please review this cleanup PR to normalize names of identifiers which are Java variables/fields or tokens in text files. Those names either contain a pronoun that is very rarely used in code, or seem like they contain such a pronoun, which, in fact, they don't. Either way, the goal is to improve

Re: Inconsistent revision control

2023-06-26 Thread erik . joelsson
The makefile is trying to locate your local repositories and record the state of the workspace. It will only do so if it finds what looks like .git repositories and a git executable to run. If not, it will just skip this. You aren't giving us much to work on here, but the error message looks to

Re: Inconsistent revision control

2023-06-26 Thread Alan Snyder
That much is obvious :-) As the script appears to run git status, I am going to take a guess that it is complaining because I have modified or untracked files in the repo. Can someone confirm that? On the other hand, I don’t see why modified or untracked files should prevent building during dev

Re: RFR: 8310728: Enable Zc:inline flag in Visual Studio build

2023-06-26 Thread Erik Joelsson
On Mon, 26 Jun 2023 12:36:38 GMT, Daniel Jeliński wrote: > Enabling `Zc:inline` flag improves C++11 standard compliance, reduces the > size of obj files produced by the build by 200+MB, and might also improve > build speed. > > 2 files failed to compile with the flag added; see JBS for details

Re: Inconsistent revision control

2023-06-26 Thread Pavel Rappo
It appears that the error is coming from make/SourceRevision.gmk > On 26 Jun 2023, at 13:55, Alan Snyder wrote: > > It would be very unlikely for CCC to fail to correctly clone the directory. > > It would be helpful to know what the build tool is complaining about with > that message. > >> On

Re: Inconsistent revision control

2023-06-26 Thread Alan Snyder
It would be very unlikely for CCC to fail to correctly clone the directory. It would be helpful to know what the build tool is complaining about with that message. > On Jun 25, 2023, at 10:04 PM, David Holmes wrote: > > On 24/06/2023 12:28 pm, Alan Snyder wrote: >> I have been trying to use Ca

RFR: 8310728: Enable Zc:inline flag in Visual Studio build

2023-06-26 Thread Daniel Jeliński
Enabling `Zc:inline` flag improves C++11 standard compliance, reduces the size of obj files produced by the build by 200+MB, and might also improve build speed. 2 files failed to compile with the flag added; see JBS for details if you're interested. This PR fixes the compilation issues. Tier1-

Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files [v2]

2023-06-26 Thread Erik Joelsson
On Sat, 24 Jun 2023 06:47:48 GMT, Vladimir Sitnikov wrote: > I've posted the suggetion to add .editorconfig on ide-support-dev, however, > the list does not seem to be active: > https://mail.openjdk.org/pipermail/ide-support-dev/2023-June/000281.html I think that sounds like a reasonable idea

Re: xattr: Permission denied: build/macosx-aarch64-server-release/jdk/conf/management/jmxremote.password.template

2023-06-26 Thread Vitaly Provodin
Erik, thanks a lot! Terminal did not have the Developer Tools permission - adding it resolves this issue. Vitaly > On 26. Jun 2023, at 16:20, erik.joels...@oracle.com wrote: > > Hello Vitaly, > This could be a permissions problem with the terminal application you are > using. This seems like

Re: path arguments to make

2023-06-26 Thread erik . joelsson
The problem lists are expected to be either relative to the test root (test/jdk in this case) or an absolute path. The command using them happens to be launched with CWD in the make dir, so you were able to resolve a file relative to that dir. That isn't intentional. /Erik On 6/24/23 04:31, A

Re: xattr: Permission denied: build/macosx-aarch64-server-release/jdk/conf/management/jmxremote.password.template

2023-06-26 Thread erik . joelsson
Hello Vitaly, This could be a permissions problem with the terminal application you are using. This seems like a common issue if you use something other than the default Terminal application. If so you need to give that application permissions to run "developer tools". It could also be some a

Re: RFR: 8294982: Implementation of Classfile API [v58]

2023-06-26 Thread Adam Sotona
On Fri, 23 Jun 2023 09:05:21 GMT, Andrey Turbanov wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed obsolete javadoc from implementation classes > > src/java.base/share/classes/jdk/internal/classfile/instructi