Result: New Build Group Member: Julian Waters

2023-11-10 Thread Magnus Ihse Bursie
The vote for Julian Waters [1] is now closed. Yes: 2 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. /Magnus [1] https://mail.openjdk.org/pipermail/build-dev/2023-September/040966.html On 2023-09-20 12:21, Magnus Ihse Bu

Re: RFR: 8319818: Address GCC 13.2.0 warnings (stringop-overflow and dangling-pointer) [v2]

2023-11-10 Thread Mikael Vidstedt
On Fri, 10 Nov 2023 01:25:32 GMT, Hao Sun wrote: >> Mikael Vidstedt has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add comment for stringop-overflow warning >> >> Co-authored-by: Hao Sun > > make/hotspot/lib/CompileJvm.gmk line 93

Re: RFR: 8319818: Address GCC 13.2.0 warnings (stringop-overflow and dangling-pointer) [v2]

2023-11-10 Thread Mikael Vidstedt
> This PR is splitting out the GCC 13.2.0 warning related changes from #16550, > excluding the Oracle/devkit parts, for clarity and to make potential > backports more straightforward. > > GCC 13.2.0 generates two new warnings: > > * linux-aarch64-debug > > src/hotspot/os_cpu/linux_aarch64/atom

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-10 Thread Magnus Ihse Bursie
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote: > 1. Adding required compiler flags. > 2. Adding required symbols. > > JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) Not even using `nm` on the libraries in question? The file seem to be consumed by the compiler,

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-10 Thread suchismith1993
On Fri, 10 Nov 2023 15:48:59 GMT, Magnus Ihse Bursie wrote: > > Which directory do you suggest to put the exports list in ? Do we create a > > new directory or use any existing directory. > > My initial thinking is like Erik's, that this list should be dynamically > generated at build-time. I

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-10 Thread Magnus Ihse Bursie
On Fri, 10 Nov 2023 07:54:40 GMT, suchismith1993 wrote: > Which directory do you suggest to put the exports list in ? Do we create a > new directory or use any existing directory. My initial thinking is like Erik's, that this list should be dynamically generated at build-time. I am pretty sure

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-10 Thread suchismith1993
On Wed, 8 Nov 2023 21:11:32 GMT, Magnus Ihse Bursie wrote: > First and foremost, the `make/data/hotspot-symbols` directory is, as the name > says, for hotspot symbols. These are not hotspot symbols. If you really do > need the file, then it needs to reside in a proper location. > > Secondly: d

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-10 Thread suchismith1993
On Thu, 9 Nov 2023 17:46:20 GMT, Erik Joelsson wrote: > For some context: `java.lang.foreign.Linker.nativeLinker().defaultLookup()` > returns a `SymbolLookup` that can be used to find symbols from the standard > library. > > We use a shim library that re-exports symbols from the standard libra