Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v2]

2023-11-17 Thread Srinivas Vamsi Parasa
> The goal is to develop faster sort routines for x86_64 CPUs by taking > advantage of AVX2 instructions. This enhancement provides an order of > magnitude speedup for Arrays.sort() using int, long, float and double arrays. > > For serial sort on random data, this PR shows upto ~7.5x

Integrated: 8320258: Refresh building.md

2023-11-17 Thread Magnus Ihse Bursie
On Thu, 16 Nov 2023 17:40:36 GMT, Magnus Ihse Bursie wrote: > The contents of the build README has been poorly kept up to date in places. > With the move to Github, the need to have markdown syntax that looks good on > Github has become apparent. The entire document has been in need for a

Integrated: 8320212: Disable GCC stringop-overflow warning for affected files

2023-11-17 Thread Mikael Vidstedt
On Fri, 17 Nov 2023 00:31:36 GMT, Mikael Vidstedt wrote: > In JDK-8319818 the stringop-overflow warnings were disabled for linux-aarch64 > (fastdebug). With the changes in JDK-8319883 additional stringop-overflow > warnings are produced with GCC 13.2.0, this time for linux-x64-zero >

Re: RFR: 8320212: Disable GCC stringop-overflow warning for affected files

2023-11-17 Thread Mikael Vidstedt
On Fri, 17 Nov 2023 00:31:36 GMT, Mikael Vidstedt wrote: > In JDK-8319818 the stringop-overflow warnings were disabled for linux-aarch64 > (fastdebug). With the changes in JDK-8319883 additional stringop-overflow > warnings are produced with GCC 13.2.0, this time for linux-x64-zero >

RFR: 8306055: Add a built-in Catalog to JDK XML module

2023-11-17 Thread Joe Wang
Implement the built-in Catalog. - Commit messages: - fix whitespace error - 8306055: Add a built-in Catalog to JDK XML module Changes: https://git.openjdk.org/jdk/pull/16719/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16719=00 Issue:

Re: RFR: 8320212: Disable GCC stringop-overflow warning for affected files

2023-11-17 Thread Daniel D . Daugherty
On Fri, 17 Nov 2023 00:31:36 GMT, Mikael Vidstedt wrote: > In JDK-8319818 the stringop-overflow warnings were disabled for linux-aarch64 > (fastdebug). With the changes in JDK-8319883 additional stringop-overflow > warnings are produced with GCC 13.2.0, this time for linux-x64-zero >

Re: RFR: 8320258: Refresh building.md [v5]

2023-11-17 Thread Erik Joelsson
On Fri, 17 Nov 2023 16:33:44 GMT, Magnus Ihse Bursie wrote: >> The contents of the build README has been poorly kept up to date in places. >> With the move to Github, the need to have markdown syntax that looks good on >> Github has become apparent. The entire document has been in need for a

Re: RFR: 8264425: Update building.md on non-English locales on Windows [v2]

2023-11-17 Thread Naoto Sato
On Fri, 17 Nov 2023 13:01:38 GMT, Magnus Ihse Bursie wrote: >> doc/building.html line 404: >> >>> 402: locale for a specific process like this in Windows. The only way is to >>> 403: change the user locale setting to US English, which >>> 404: will affect all applications run by the user. >>

Integrated: 8320334: Reflow markdown in testing.md

2023-11-17 Thread Magnus Ihse Bursie
On Fri, 17 Nov 2023 16:39:54 GMT, Magnus Ihse Bursie wrote: > In preparation for textual updates, the markdown in testing.md is reflowed so > line lengths of 80 is respected, wherever possible. > > Note that is is correct that the testing.html file is unchanged (and indeed > a sign that

Re: RFR: 8320334: Reflow markdown in testing.md

2023-11-17 Thread Iris Clark
On Fri, 17 Nov 2023 16:39:54 GMT, Magnus Ihse Bursie wrote: > In preparation for textual updates, the markdown in testing.md is reflowed so > line lengths of 80 is respected, wherever possible. > > Note that is is correct that the testing.html file is unchanged (and indeed > a sign that

Re: RFR: 8320212: Disable GCC stringop-overflow warning for affected files

2023-11-17 Thread Mikael Vidstedt
On Fri, 17 Nov 2023 15:36:29 GMT, Magnus Ihse Bursie wrote: > Looks okay from a build perspective. In the end, I guess some hotspot > developers need to weigh in if this is acceptable. > > I presume you have tried to analyze what makes the Thread:current access > different in these files, so

RFR: 8320334: Reflow markdown in testing.md

2023-11-17 Thread Magnus Ihse Bursie
In preparation for textual updates, the markdown in testing.md is reflowed so line lengths of 80 is respected, wherever possible. Note that is is correct that the testing.html file is unchanged (and indeed a sign that only markdown line breaks have been modified). - Commit

Re: RFR: 8320258: Refresh building.md [v4]

2023-11-17 Thread Magnus Ihse Bursie
On Fri, 17 Nov 2023 15:50:46 GMT, Magnus Ihse Bursie wrote: >> The contents of the build README has been poorly kept up to date in places. >> With the move to Github, the need to have markdown syntax that looks good on >> Github has become apparent. The entire document has been in need for a

Re: RFR: 8320258: Refresh building.md [v5]

2023-11-17 Thread Magnus Ihse Bursie
> The contents of the build README has been poorly kept up to date in places. > With the move to Github, the need to have markdown syntax that looks good on > Github has become apparent. The entire document has been in need for a while > of a comprehensive oversight to be made more consistent

Re: RFR: 8320258: Refresh building.md [v4]

2023-11-17 Thread Magnus Ihse Bursie
On Thu, 16 Nov 2023 19:08:49 GMT, Erik Joelsson wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> FIx remaining review comments > > doc/building.md line 1339: > >> 1337: ### Considerations for specific

Re: RFR: 8320258: Refresh building.md [v3]

2023-11-17 Thread Magnus Ihse Bursie
On Fri, 17 Nov 2023 15:27:31 GMT, Christoph Langer wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> FIx some review comments > > doc/building.md line 5: > >> 3: ## TL;DR (Instructions for the Impatient) >>

Re: RFR: 8320258: Refresh building.md [v4]

2023-11-17 Thread Magnus Ihse Bursie
> The contents of the build README has been poorly kept up to date in places. > With the move to Github, the need to have markdown syntax that looks good on > Github has become apparent. The entire document has been in need for a while > of a comprehensive oversight to be made more consistent

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-17 Thread Magnus Ihse Bursie
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote: > The math library in AIX specifically, is a static archive. Doing a -lm wont > suffice, because when the symbols are looked up using dlsym or accessing > native code through Java, it will lead to failures. > Hence we had to come up with

Re: RFR: 8320212: Disable GCC stringop-overflow warning for affected files

2023-11-17 Thread Magnus Ihse Bursie
On Fri, 17 Nov 2023 00:31:36 GMT, Mikael Vidstedt wrote: > In JDK-8319818 the stringop-overflow warnings were disabled for linux-aarch64 > (fastdebug). With the changes in JDK-8319883 additional stringop-overflow > warnings are produced with GCC 13.2.0, this time for linux-x64-zero >

Re: RFR: 8320258: Refresh building.md [v3]

2023-11-17 Thread Christoph Langer
On Fri, 17 Nov 2023 13:24:56 GMT, Magnus Ihse Bursie wrote: >> The contents of the build README has been poorly kept up to date in places. >> With the move to Github, the need to have markdown syntax that looks good on >> Github has become apparent. The entire document has been in need for a

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-17 Thread suchismith1993
On Fri, 17 Nov 2023 13:02:22 GMT, Martin Doerr wrote: > > And I still don't understand if this is the list of symbols that are > > required by our tests, or the complete list of symbols that FFI > > `defaultLookup` returns to user applications. If it is the latter, then > > this is sort-of

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-17 Thread Jorn Vernee
On Fri, 17 Nov 2023 13:02:22 GMT, Martin Doerr wrote: > My understanding is that a lot of symbols can be found out of the box because > they are in dynamically linked libraries. Only some libraries are special on > AIX which don't support dynamic linking and we need this workaround for them.

Re: RFR: 8320258: Refresh building.md [v3]

2023-11-17 Thread Magnus Ihse Bursie
> The contents of the build README has been poorly kept up to date in places. > With the move to Github, the need to have markdown syntax that looks good on > Github has become apparent. The entire document has been in need for a while > of a comprehensive oversight to be made more consistent

Re: RFR: 8320258: Refresh building.md [v3]

2023-11-17 Thread Magnus Ihse Bursie
On Thu, 16 Nov 2023 18:40:24 GMT, Erik Joelsson wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> FIx some review comments > > doc/building.md line 273: > >> 271: the hood. WSL1 runs the binaries natively by

Re: RFR: 8320258: Refresh building.md [v2]

2023-11-17 Thread Magnus Ihse Bursie
> The contents of the build README has been poorly kept up to date in places. > With the move to Github, the need to have markdown syntax that looks good on > Github has become apparent. The entire document has been in need for a while > of a comprehensive oversight to be made more consistent

Re: RFR: 8264425: Update building.md on non-English locales on Windows [v2]

2023-11-17 Thread Magnus Ihse Bursie
> Update the build documentation to reflect the fact that non-English locales > are only supported on a "best effort" principle, and add instructions how to > install the necessary language pack to Visual Studio. Magnus Ihse Bursie has updated the pull request with a new target base due to a

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-17 Thread Martin Doerr
On Fri, 17 Nov 2023 12:45:32 GMT, suchismith1993 wrote: > And I still don't understand if this is the list of symbols that are required > by our tests, or the complete list of symbols that FFI `defaultLookup` > returns to user applications. If it is the latter, then this is sort-of okay > as

Re: RFR: 8264425: Update building.md on non-English locales on Windows [v2]

2023-11-17 Thread Magnus Ihse Bursie
On Thu, 16 Nov 2023 17:25:58 GMT, Naoto Sato wrote: >> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains three >> additional

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-17 Thread suchismith1993
On Fri, 17 Nov 2023 12:06:48 GMT, Martin Doerr wrote: >>> > There is not generic way of generating this. It needs a manual >>> > intervention and symbols are to be added on a need basis in future. Looks >>> > like a list to be maintained. I had tried adding comments to explain the >>> > list,

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-17 Thread Magnus Ihse Bursie
On Fri, 17 Nov 2023 12:06:48 GMT, Martin Doerr wrote: >>> > There is not generic way of generating this. It needs a manual >>> > intervention and symbols are to be added on a need basis in future. Looks >>> > like a list to be maintained. I had tried adding comments to explain the >>> > list,

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-17 Thread Magnus Ihse Bursie
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote: > 1. Adding required compiler flags. > 2. Adding required symbols. > > JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) make/data/hotspot-symbols/symbols-aix-foreign line 1: > 1: Maybe delete the two leading empty

Integrated: 8317357: Update links in building.md to use https rather than http

2023-11-17 Thread Magnus Ihse Bursie
On Thu, 16 Nov 2023 17:09:25 GMT, Magnus Ihse Bursie wrote: > From the bug report: Building.md file contains a number of HTTP links that > would need to be converted to HTTPS in order for clicking on the links on the > OpenJDK web site at https://openjdk.org/groups/build/doc/building.html to

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-17 Thread Martin Doerr
On Mon, 13 Nov 2023 11:47:52 GMT, suchismith1993 wrote: >>> There is not generic way of generating this. It needs a manual intervention >>> and symbols are to be added on a need basis in future. Looks like a list to >>> be maintained. I had tried adding comments to explain the list, but that

Re: RFR: 8317357: Update links in building.md to use https rather than http

2023-11-17 Thread Julian Waters
On Thu, 16 Nov 2023 17:09:25 GMT, Magnus Ihse Bursie wrote: > From the bug report: Building.md file contains a number of HTTP links that > would need to be converted to HTTPS in order for clicking on the links on the > OpenJDK web site at https://openjdk.org/groups/build/doc/building.html to