Re: RFR: 8333685: Make update-copyright-year script more useful [v2]

2024-06-11 Thread Thomas Stuefe
On Tue, 11 Jun 2024 13:34:24 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685). >> >> I have added the following enhancements: >> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E` >> respectively. >>

Integrated: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'

2024-06-11 Thread Matthias Baesken
On Mon, 10 Jun 2024 12:30:59 GMT, Matthias Baesken wrote: > When running hs :tier1 tests or jdk/jfr tests, with ubsan enabled (configure > flag --enable-ubsan), in a lot of jfr related tests like > compiler/intrinsics/klass/CastNullCheckDroppingsTest.jtr > serviceability/jvmti/RedefineClasses/Re

Re: RFR: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'

2024-06-11 Thread Matthias Baesken
On Mon, 10 Jun 2024 12:30:59 GMT, Matthias Baesken wrote: > When running hs :tier1 tests or jdk/jfr tests, with ubsan enabled (configure > flag --enable-ubsan), in a lot of jfr related tests like > compiler/intrinsics/klass/CastNullCheckDroppingsTest.jtr > serviceability/jvmti/RedefineClasses/Re

Re: RFR: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'

2024-06-11 Thread Thomas Stuefe
On Mon, 10 Jun 2024 12:30:59 GMT, Matthias Baesken wrote: > When running hs :tier1 tests or jdk/jfr tests, with ubsan enabled (configure > flag --enable-ubsan), in a lot of jfr related tests like > compiler/intrinsics/klass/CastNullCheckDroppingsTest.jtr > serviceability/jvmti/RedefineClasses/Re

Integrated: 8334036: Update JCov for class file version 68

2024-06-11 Thread Alexandre Iline
On Tue, 11 Jun 2024 19:02:29 GMT, Alexandre Iline wrote: > Update JCov for class file version 68 This pull request has now been integrated. Changeset: bbd3b1d8 Author:Alexandre Iline URL: https://git.openjdk.org/jdk/commit/bbd3b1d812da997347fca4c06e22794285ab00d3 Stats: 1 line

Re: RFR: 8334036: Update JCov for class file version 68

2024-06-11 Thread Erik Joelsson
On Tue, 11 Jun 2024 19:02:29 GMT, Alexandre Iline wrote: > Update JCov for class file version 68 Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19665#pullrequestreview-2111324522

Re: RFR: 8334036: Update JCov for class file version 68

2024-06-11 Thread Alan Bateman
On Tue, 11 Jun 2024 19:02:29 GMT, Alexandre Iline wrote: > Update JCov for class file version 68 Marked as reviewed by alanb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19665#pullrequestreview-2111285609

RFR: 8334036: Update JCov for class file version 68

2024-06-11 Thread Alexandre Iline
Update JCov for class file version 68 - Commit messages: - JDK-8334036: Update JCov for class file version 68 Changes: https://git.openjdk.org/jdk/pull/19665/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19665&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334036

Re: RFR: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'

2024-06-11 Thread Erik Gahlin
On Tue, 11 Jun 2024 16:55:39 GMT, Thomas Stuefe wrote: > About your fix, do you know why MetadataEvent and CheckPointEvent would not > count toward the number of events? In other words, why NUMBER_OF_EVENTS is > 162 if we have 164 events? Maybe the number of events is wrong? > > @egahlin ? Th

Re: RFR: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'

2024-06-11 Thread Thomas Stuefe
On Mon, 10 Jun 2024 12:30:59 GMT, Matthias Baesken wrote: > When running hs :tier1 tests or jdk/jfr tests, with ubsan enabled (configure > flag --enable-ubsan), in a lot of jfr related tests like > compiler/intrinsics/klass/CastNullCheckDroppingsTest.jtr > serviceability/jvmti/RedefineClasses/Re

Re: RFR: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'

2024-06-11 Thread Thomas Stuefe
On Tue, 11 Jun 2024 14:46:10 GMT, Matthias Baesken wrote: > My maximum JfrEventId is 163 , see the generated > hotspot/variant-server/gensrc/jfrfiles/jfrEventIds.hpp > > ``` > > enum JfrEventId { > JfrMetadataEvent = 0, > JfrCheckpointEvent = 1, > JfrDurationEvent = 2, > JfrInstantEven

Re: RFR: 8333685: Make update-copyright-year script more useful [v2]

2024-06-11 Thread Erik Joelsson
On Tue, 11 Jun 2024 13:34:24 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685). >> >> I have added the following enhancements: >> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E` >> respectively. >>

Re: RFR: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'

2024-06-11 Thread Matthias Baesken
On Mon, 10 Jun 2024 12:30:59 GMT, Matthias Baesken wrote: > When running hs :tier1 tests or jdk/jfr tests, with ubsan enabled (configure > flag --enable-ubsan), in a lot of jfr related tests like > compiler/intrinsics/klass/CastNullCheckDroppingsTest.jtr > serviceability/jvmti/RedefineClasses/Re

Re: RFR: 8333685: Make update-copyright-year script more useful

2024-06-11 Thread Sonia Zaldana Calles
On Tue, 11 Jun 2024 13:19:48 GMT, Thomas Stuefe wrote: >> Opinion: while it's good to see improvements to the existent script, since >> JEP 330, we can now conveniently implement a similar script in Java. That'll >> also automatically take care of OS specifics. > >> Opinion: while it's good to

Re: RFR: 8333685: Make update-copyright-year script more useful [v2]

2024-06-11 Thread Sonia Zaldana Calles
> Hi all, > > This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685). > > I have added the following enhancements: > - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E` > respectively. > - Altered default behaviour to limit the processed changesets to those i

Re: RFR: 8333685: Make update-copyright-year script more useful

2024-06-11 Thread Thomas Stuefe
On Tue, 11 Jun 2024 13:12:48 GMT, Pavel Rappo wrote: > Opinion: while it's good to see improvements to the existent script, since > JEP 330, we can now conveniently implement a similar script in Java. That'll > also automatically take care of OS specifics. Sure, but the script is here, it work

Re: RFR: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'

2024-06-11 Thread Thomas Stuefe
On Mon, 10 Jun 2024 12:30:59 GMT, Matthias Baesken wrote: > When running hs :tier1 tests or jdk/jfr tests, with ubsan enabled (configure > flag --enable-ubsan), in a lot of jfr related tests like > compiler/intrinsics/klass/CastNullCheckDroppingsTest.jtr > serviceability/jvmti/RedefineClasses/Re

Re: RFR: 8333685: Make update-copyright-year script more useful

2024-06-11 Thread Pavel Rappo
On Fri, 7 Jun 2024 19:01:45 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685). > > I have added the following enhancements: > - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E` > respectively. > - Altere

Re: RFR: 8333685: Make update-copyright-year script more useful

2024-06-11 Thread Erik Joelsson
On Tue, 11 Jun 2024 12:32:59 GMT, Thomas Stuefe wrote: > Tested on Linux, there it works. > > Note, IIRC, the original unpatched version also worked on MacOS. So, I think > the original sed expressions were probably ok. Something about > `(${copyright_symbol} )?` perhabs. Mac has bsd sed by d

Re: RFR: 8333685: Make update-copyright-year script more useful

2024-06-11 Thread Thomas Stuefe
On Fri, 7 Jun 2024 19:01:45 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685). > > I have added the following enhancements: > - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E` > respectively. > - Altere

Re: RFR: 8333685: Make update-copyright-year script more useful

2024-06-11 Thread Thomas Stuefe
On Fri, 7 Jun 2024 19:01:45 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685). > > I have added the following enhancements: > - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E` > respectively. > - Altere