On Thu, 25 Apr 2024 09:47:11 GMT, SendaoYan wrote:
> The script make/devkit/createJMHBundle.sh use fixed maven repo server:
> https://repo.maven.apache.org/maven2. It's maybe useful to make the maven
> repo mirror configurable.
>
> Only change devkit shell script, no risk.
Looks reasonable.
On Mon, 5 Feb 2024 10:38:26 GMT, Magnus Ihse Bursie wrote:
>> We're currently setting LC_ALL=C. Not all tools will default to utf-8 as
>> their encoding of choice when they see this locale, but use an arbitrarily
>> encoding, which might not properly handle all UTF-8 characters. Since in
>> pr
On Mon, 5 Feb 2024 10:38:26 GMT, Magnus Ihse Bursie wrote:
>> We're currently setting LC_ALL=C. Not all tools will default to utf-8 as
>> their encoding of choice when they see this locale, but use an arbitrarily
>> encoding, which might not properly handle all UTF-8 characters. Since in
>> pr
On Wed, 17 Jan 2024 13:35:23 GMT, Claes Redestad wrote:
> Incrementally building the OpenJDK microbenchmarks emit a "Note: Benchmark
> entries for already exists, overwriting" for each microbenchmark
> class. This is generated by the JMH BenchmarkProcessor annotation process
On Wed, 17 Jan 2024 13:35:23 GMT, Claes Redestad wrote:
> Incrementally building the OpenJDK microbenchmarks emit a "Note: Benchmark
> entries for already exists, overwriting" for each microbenchmark
> class. This is generated by the JMH BenchmarkProcessor annotation process
Incrementally building the OpenJDK microbenchmarks emit a "Note: Benchmark
entries for already exists, overwriting" for each microbenchmark class.
This is generated by the JMH BenchmarkProcessor annotation processor via the
javac messager framework.
To carefully disable this informative message
On Wed, 10 Jan 2024 15:10:58 GMT, Claes Redestad wrote:
> JMH microbenchmarks may have dependencies on artifacts in the test image
> outside of the benchmarks.jar. This includes native libraries (built into
> `$TEST_IMAGE/micro/native`) and may soon include other test libraries like
On Thu, 11 Jan 2024 17:49:42 GMT, Erik Joelsson wrote:
> Fair enough. This isn't worse than the current CWD. The test image dir and
> the support output dir have no guaranteed relationship relative to each
> other, so we can't rely any relative path between them.
Thanks! Perhaps we can improve
On Thu, 11 Jan 2024 14:17:39 GMT, Erik Joelsson wrote:
>> In principle, I think tests should be executed from their corresponding
>> test-support directory. (I think there is some JBS issue for this that's
>> been around for some while.) The rationale is that this is a good directory
>> for an
JMH microbenchmarks may have dependencies on artifacts in the test image
outside of the benchmarks.jar. This includes native libraries (built into
`$TEST_IMAGE/micro/native`) and may soon include other test libraries like
wb.jar (built into `$TEST_IMAGE/lib-test/`)
By moving execution to the te
On Mon, 11 Dec 2023 13:47:26 GMT, Magnus Ihse Bursie wrote:
>> The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has
>> recently arisen.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Revert change
On Fri, 8 Dec 2023 16:12:27 GMT, Magnus Ihse Bursie wrote:
>> The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has
>> recently arisen.
>
> make/RunTests.gmk line 598:
>
>> 596: endif
>> 597:
>> 598: # Set paths for dependencies
>
> @cl4es So basically this is the line yo
On Wed, 6 Dec 2023 15:32:14 GMT, Magnus Ihse Bursie wrote:
> The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has
> recently arisen.
Adding wb.jar to the test image is great. Maybe that could be done separately?
I think we need a different solution here that does not pollute
On Thu, 26 Oct 2023 22:17:45 GMT, Claes Redestad wrote:
> The binutils build of libiberty is put in `$BINUTILS_INSTALL_DIR/lib64` on
> some Linux distributions (e.g. Fedora, Oracle Linux),
> `$BINUTILS_INSTALL_DIR/lib` on others (e.g. Ubuntu).
>
> This PR suggest simply addin
On Thu, 26 Oct 2023 22:17:45 GMT, Claes Redestad wrote:
> The binutils build of libiberty is put in `$BINUTILS_INSTALL_DIR/lib64` on
> some Linux distributions (e.g. Fedora, Oracle Linux),
> `$BINUTILS_INSTALL_DIR/lib` on others (e.g. Ubuntu).
>
> This PR suggest simply addin
The binutils build of libiberty is put in `$BINUTILS_INSTALL_DIR/lib64` on some
Linux distributions (e.g. Fedora, Oracle Linux), `$BINUTILS_INSTALL_DIR/lib` on
others (e.g. Ubuntu).
This PR suggest simply adding logic to look for `libiberty.a` in either place,
favoring `.../lib` like now. Alte
On Tue, 19 Sep 2023 17:59:05 GMT, Erik Joelsson wrote:
> After [JDK-8253620](https://bugs.openjdk.org/browse/JDK-8253620),
> BuildMicrobenchmark.gmk has started printing warnings about overriding
> targets on macos. This is caused by a CopyFiles using the `FLATTEN` option in
> combination with
On Wed, 16 Aug 2023 15:52:09 GMT, Claes Redestad wrote:
> Use most recent devkit when using jib.
>
> Test: staged, configured from scratch and verified micros locally
This pull request has now been integrated.
Changeset: c634bdf9
Author: Claes Redestad
URL:
https://git.op
On Wed, 16 Aug 2023 15:52:09 GMT, Claes Redestad wrote:
> Use most recent devkit when using jib.
>
> Test: staged, configured from scratch and verified micros locally
Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/15313#issuecomment-1682152453
Use most recent devkit when using jib.
Test: staged, configured from scratch and verified micros locally
-
Commit messages:
- Update jib-profiles.js to use JMH 1.37
Changes: https://git.openjdk.org/jdk/pull/15313/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15313&range=0
On Thu, 10 Aug 2023 14:28:14 GMT, Aleksey Shipilev wrote:
> Time to update JMH devkit to latest version. This time, the dependency
> version of Commons Math 3 also changed.
> https://github.com/openjdk/jmh/blob/362d6579e007f0241f05c1305f0b269fcc2cc27a/pom.xml#L284
>
> Additional testing:
> -
t;>
>> I assume “iff” should “if”?
>
> Here and elsewhere in this file "iff" might mean [if and only
> if](https://en.wikipedia.org/wiki/If_and_only_if), which would make sense.
> (FWIW, there are a few hundred occurrences of the word "iff" in src.)
>
>
On Thu, 23 Feb 2023 08:32:29 GMT, Claes Redestad wrote:
>> `Charset` class is initialized *before* system properties are set up, in
>> order to check the JNU encoding (used for file path name) is a supported
>> charset or not. In some OS environments, GB18030 is the native
On Wed, 22 Feb 2023 17:52:01 GMT, Naoto Sato wrote:
>>> curious - what scenario triggers this call at initLevel < 1 ?
>>
>> It's not supported, but it is possible that someone might run with
>> -Dfile.encoding=GB18030, in which case the default charset is used before
>> the system properties a
On Wed, 21 Sep 2022 21:47:48 GMT, Claes Redestad wrote:
> JMH 1.34 changed to use jopt-simple 5.0.4. Running 1.34 or later with
> jopt-simple 4.6 works for all of our CI usage, so this issue went undetected
> for a while. It breaks on things like `java -jar benchmarks.jar -h
JMH 1.34 changed to use jopt-simple 5.0.4. Running 1.34 or later a jopt-simple
4.6 works for most/all of our CI use cases, but breaks on things like `java
-jar benchmarks.jar -h`, `-prof async:output=flamegraph` and many others.
Also updated jib-profiles.js to pick up the JMH 1.35 and tested our
26 matches
Mail list logo
