Re: RFR: 8292559: Add test for -XX:+CheckJNICalls showing changed signal handlers [v2]

On Thu, 18 Aug 2022 12:59:49 GMT, Thomas Stuefe wrote: >> Harold Seigel has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove ifdef _cplusplus etc. > > test/hotspot/jtreg/runtime/posixSig/libTestPs

Re: RFR: 8292559: Add test for -XX:+CheckJNICalls showing changed signal handlers [v2]

E and SIGILL signals. > > The test was tested using Mach5 to run it on Linux, Mac OS, and Windows. > > Thanks, Harold Harold Seigel has updated the pull request incrementally with one additional commit since the last revision: remove ifdef _cplusplus etc. -

Re: RFR: 8292559: Add test for -XX:+CheckJNICalls showing changed signal handlers

On Thu, 18 Aug 2022 12:48:30 GMT, Harold Seigel wrote: > Please review this small change to add a test that option -XX:+CheckJNICalls > shows changed signal handlers. This new test is a copy of the recently > deleted TestPosixSig.java with small changes. This version of the

RFR: 8292559: Add test for -XX:+CheckJNICalls showing changed signal handlers

Please review this small change to add a test that option -XX:+CheckJNICalls shows changed signal handlers. This new test is a copy of the recently deleted TestPosixSig.java with small changes. This version of the test only checks that handlers were changed for SIGFPE and SIGILL signals. The

Integrated: 8291360: Create entry points to expose low-level class file information

On Fri, 29 Jul 2022 18:02:46 GMT, Harold Seigel wrote: > Please review this change to fix JDK-8291360. This fix adds entry points > getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. > The new entry points return the current class's class file version

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

On Thu, 4 Aug 2022 12:51:33 GMT, Harold Seigel wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's cla

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

On Thu, 4 Aug 2022 12:28:51 GMT, David Holmes wrote: >> I think it seems more natural to display the major version first, but I can >> change it if you prefer. > > I think it should match the underlying representation else it may cause > someone trying to debug a failure to look at the wrong pa

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, > and Mach5 tiers 1-3 on Linux x64. Additionally, the JCK lang, vm, and api > tests and new regression tests were run locally on Linux x64. > > Thanks, Harold Harold Seigel has updated the pull request incrementally wi

Re: RFR: 8291360: Create entry points to expose low-level class file information [v3]

On Tue, 2 Aug 2022 06:36:54 GMT, David Holmes wrote: >> No particular reason for choosing 59 other than it's different and less than >> 64. Test case Version64_65535 has a non-zero minor version. > > I think we should be testing for other real classfile versions that may be > encountered, such

Re: RFR: 8291360: Create entry points to expose low-level class file information [v2]

On Tue, 2 Aug 2022 06:24:10 GMT, David Holmes wrote: >> Harold Seigel has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improved tests, added mulit-dimensional array tests, simplified new >> java.lang.Class

Re: RFR: 8291360: Create entry points to expose low-level class file information [v3]

tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, > and Mach5 tiers 1-3 on Linux x64. Additionally, the JCK lang, vm, and api > tests and new regression tests were run locally on Linux x64. > > Thanks, Harold Harold Seigel has updated the pull request incrementally wi

Re: RFR: 8291360: Create entry points to expose low-level class file information [v2]

On Tue, 2 Aug 2022 06:51:46 GMT, David Holmes wrote: >> Changed to display as major:minor version. > > Seems odd to display as major:minor when it is stored as minor:major I think it seems more natural to display the major version first, but I can change it if you prefer. - PR: ht

Re: RFR: 8291360: Create entry points to expose low-level class file information [v2]

On Fri, 29 Jul 2022 21:08:43 GMT, Roger Riggs wrote: >> Harold Seigel has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improved tests, added mulit-dimensional array tests, simplified new >> java.lang.Clas

Re: RFR: 8291360: Create entry points to expose low-level class file information [v2]

On Sun, 31 Jul 2022 22:02:11 GMT, David Holmes wrote: >> Harold Seigel has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improved tests, added mulit-dimensional array tests, simplified new >> java.lang.Cla

Re: RFR: 8291360: Create entry points to expose low-level class file information [v2]

On Mon, 1 Aug 2022 18:51:10 GMT, Harold Seigel wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's cla

Re: RFR: 8291360: Create entry points to expose low-level class file information [v2]

tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, > and Mach5 tiers 1-3 on Linux x64. Additionally, the JCK lang, vm, and api > tests and new regression tests were run locally on Linux x64. > > Thanks, Harold Harold Seigel has updated the pull request incrementally wi

Re: RFR: 8291360: Create entry points to expose low-level class file information

On Mon, 1 Aug 2022 14:04:22 GMT, Roger Riggs wrote: >> Though in this case the Java code has defined behaviour for array types so >> it is correct for the VM to assume this is not an array type and to assert >> if it is. > > My companion question was whether the native code can for efficiently

Re: RFR: 8291360: Create entry points to expose low-level class file information

On Fri, 29 Jul 2022 21:21:43 GMT, Roger Riggs wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's class file version and its >> ra

Re: RFR: 8291360: Create entry points to expose low-level class file information

On Sun, 31 Jul 2022 22:22:24 GMT, David Holmes wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's class file version and its >> r

Re: RFR: 8291360: Create entry points to expose low-level class file information

On Sun, 31 Jul 2022 22:05:15 GMT, David Holmes wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's class file version and its >> r

Re: RFR: 8291360: Create entry points to expose low-level class file information

On Fri, 29 Jul 2022 18:12:22 GMT, Joe Darcy wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's class file version and its >> raw

RFR: 8291360: Create entry points to expose low-level class file information

Please review this change to fix JDK-8291360. This fix adds entry points getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. The new entry points return the current class's class file version and its raw access flags. The fix was tested by running Mach5 tiers 1-2 on L

Re: RFR: 8285792: Posix signal handler modification checking issues. [v4]

On Tue, 26 Jul 2022 19:53:10 GMT, Harold Seigel wrote: >> Please review this fix for JDK-8285792. The fix removes print statements >> from check_signal_handler() so that it doesn't print all the handlers every >> time it finds one that is modified. Instead, it retu

Integrated: 8285792: Posix signal handler modification checking issues.

On Mon, 25 Jul 2022 17:21:27 GMT, Harold Seigel wrote: > Please review this fix for JDK-8285792. The fix removes print statements > from check_signal_handler() so that it doesn't print all the handlers every > time it finds one that is modified. Instead, it returns true if the

Re: RFR: 8285792: Posix signal handler modification checking issues. [v4]

he fix was tested with Mach5 tiers 1-2 on Linux and Mac OS and Mach 5 tiers > 3-5 on Linux x64. The regression test is excluded on Windows. > > Thanks, Harold Harold Seigel has updated the pull request incrementally with one additional commit since the last revision: fix whitespac

Re: RFR: 8285792: Posix signal handler modification checking issues. [v3]

On Mon, 25 Jul 2022 21:45:30 GMT, David Holmes wrote: >> Harold Seigel has updated the pull request incrementally with one additional >> commit since the last revision: >> >> SIGFPE change > > src/hotspot/os/posix/signals_posix.cpp line 843: > >> 841:

Re: RFR: 8285792: Posix signal handler modification checking issues. [v3]

he fix was tested with Mach5 tiers 1-2 on Linux and Mac OS and Mach 5 tiers > 3-5 on Linux x64. The regression test is excluded on Windows. > > Thanks, Harold Harold Seigel has updated the pull request incrementally with one additional commit since the last revision: SIGFPE

Re: RFR: 8285792: Posix signal handler modification checking issues.

On Mon, 25 Jul 2022 21:52:26 GMT, David Holmes wrote: >> Please review this fix for JDK-8285792. The fix removes print statements >> from check_signal_handler() so that it doesn't print all the handlers every >> time it finds one that is modified. Instead, it returns true if the handler >> i

Re: RFR: 8285792: Posix signal handler modification checking issues. [v2]

On Mon, 25 Jul 2022 21:58:00 GMT, David Holmes wrote: >> Harold Seigel has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Consolidate java test files, change tested signals > > test/hotspot/jtreg/runtime/

Re: RFR: 8285792: Posix signal handler modification checking issues. [v2]

he fix was tested with Mach5 tiers 1-2 on Linux and Mac OS and Mach 5 tiers > 3-5 on Linux x64. The regression test is excluded on Windows. > > Thanks, Harold Harold Seigel has updated the pull request incrementally with one additional commit since the last revision: Con

Re: RFR: 8285792: Posix signal handler modification checking issues.

On Mon, 25 Jul 2022 20:50:07 GMT, Phil Race wrote: >> So the VM warnings are something of a mild annoyance that we've worked >> around in this test but it never made sense to me what this has to do with >> JNI ? At some point it was decided that checkJNI should check for certain user defined

Re: RFR: 8285792: Posix signal handler modification checking issues.

On Mon, 25 Jul 2022 17:21:27 GMT, Harold Seigel wrote: > Please review this fix for JDK-8285792. The fix removes print statements > from check_signal_handler() so that it doesn't print all the handlers every > time it finds one that is modified. Instead, it returns true if the

RFR: 8285792: Posix signal handler modification checking issues.

Please review this fix for JDK-8285792. The fix removes print statements from check_signal_handler() so that it doesn't print all the handlers every time it finds one that is modified. Instead, it returns true if the handler is modified, false otherwise. Its caller, user_handler(), then print